| JayF | What review "bar" should be applied to something like https://review.opendev.org/c/openstack/diskimage-builder/+/1006200 | 15:36 |
|---|---|---|
| JayF | is checking to make sure the sources all point to a correct place, and that it looks plausible good enough? | 15:37 |
| JayF | I don't want these folks to wait, but I'm unwilling to invest a "test the change" amount of time in an oracle linux related thing. | 15:37 |
| clarkb | JayF: yes I think general shape is probably sufficient there. Maybe we should insist on a note in the element README that the oracle linux element is untested and the dib maintainers are unsure of its functionality | 15:39 |
| clarkb | basically make sure the element isn't doing anything malicious and that it follows the basic shape of building an rpm based distro image. Then warn people it is untested? | 15:40 |
| clarkb | but also we don't have to accept it either | 15:40 |
| JayF | I assume the submitters have tested it; so asking themselves to put a "untested" in the readme feels a little silly? | 15:40 |
| clarkb | I disagree. They are not the ones who will be complained to when it stops working or if it doesn't work to begin with | 15:41 |
| clarkb | the change has to be written from the perspective of the end result not the proposal | 15:41 |
| clarkb | if that makes sense | 15:41 |
| JayF | "There are no active DIB maintainers who use oracle linux. Can we add a note here that DIB doesn't run CI or actively test this element, but if bugs are found patches are accepted?" | 15:42 |
| clarkb | yup I think that sounds great | 15:43 |
| JayF | https://review.opendev.org/c/openstack/diskimage-builder/+/1006200/10#message-94f3b69d061e3b2e42936572bbbc677680ff1ab8 | 15:47 |
| JayF | they have two bugfixes in there which might be generally useful, I asked em to split it | 15:47 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!