*** matsuhashi has joined #openstack-dns | 00:18 | |
*** krow has joined #openstack-dns | 00:29 | |
*** adrian_otto has quit IRC | 01:06 | |
*** nosnos has joined #openstack-dns | 01:13 | |
*** nosnos has quit IRC | 01:13 | |
*** nosnos has joined #openstack-dns | 01:14 | |
*** krow has quit IRC | 01:38 | |
*** nosnos_ has joined #openstack-dns | 02:27 | |
*** nosnos has quit IRC | 02:30 | |
*** CaptTofu has quit IRC | 03:01 | |
*** CaptTofu has joined #openstack-dns | 03:02 | |
*** matsuhashi has quit IRC | 03:02 | |
*** matsuhashi has joined #openstack-dns | 03:03 | |
*** matsuhashi has quit IRC | 03:03 | |
*** matsuhashi has joined #openstack-dns | 03:13 | |
*** tsimmons has joined #openstack-dns | 03:30 | |
*** tsimmons has left #openstack-dns | 03:30 | |
*** krow has joined #openstack-dns | 03:33 | |
*** krow has quit IRC | 03:37 | |
*** matsuhashi has quit IRC | 03:45 | |
*** matsuhashi has joined #openstack-dns | 03:46 | |
*** matsuhas_ has joined #openstack-dns | 03:49 | |
*** matsuhashi has quit IRC | 03:50 | |
*** krow has joined #openstack-dns | 04:00 | |
*** vipul is now known as vipul-away | 04:07 | |
*** nosnos_ has quit IRC | 04:44 | |
*** nosnos has joined #openstack-dns | 04:44 | |
*** krow has quit IRC | 04:54 | |
*** adrian_otto has joined #openstack-dns | 05:17 | |
*** vipul-away is now known as vipul | 05:19 | |
*** adrian_otto has quit IRC | 05:37 | |
*** matsuhas_ has quit IRC | 05:58 | |
*** matsuhashi has joined #openstack-dns | 06:00 | |
*** matsuhashi has quit IRC | 06:01 | |
*** matsuhashi has joined #openstack-dns | 06:02 | |
*** krow has joined #openstack-dns | 06:02 | |
*** ctracey has quit IRC | 06:05 | |
*** krow has quit IRC | 06:14 | |
*** adrian_otto has joined #openstack-dns | 06:39 | |
*** matsuhashi has quit IRC | 06:53 | |
*** matsuhashi has joined #openstack-dns | 06:53 | |
*** matsuhashi has quit IRC | 06:57 | |
*** matsuhashi has joined #openstack-dns | 07:06 | |
*** nosnos_ has joined #openstack-dns | 07:11 | |
*** nosnos has quit IRC | 07:14 | |
*** vipul is now known as vipul-away | 07:27 | |
*** adrian_otto has quit IRC | 07:30 | |
*** nosnos_ has quit IRC | 07:31 | |
*** nosnos has joined #openstack-dns | 07:32 | |
*** vipul-away is now known as vipul | 07:55 | |
*** Krast has joined #openstack-dns | 08:20 | |
*** Krast has left #openstack-dns | 08:25 | |
*** pasquier-s has joined #openstack-dns | 08:32 | |
*** Krast has joined #openstack-dns | 08:32 | |
*** matsuhashi has quit IRC | 08:36 | |
*** matsuhashi has joined #openstack-dns | 08:37 | |
*** krow has joined #openstack-dns | 09:00 | |
*** matsuhashi has quit IRC | 09:08 | |
*** matsuhashi has joined #openstack-dns | 09:11 | |
*** nosnos_ has joined #openstack-dns | 09:33 | |
*** nosnos has quit IRC | 09:37 | |
*** krow has quit IRC | 09:39 | |
*** matsuhashi has quit IRC | 09:45 | |
*** matsuhashi has joined #openstack-dns | 09:46 | |
*** matsuhashi has quit IRC | 09:51 | |
*** matsuhashi has joined #openstack-dns | 09:51 | |
*** Krast has quit IRC | 10:07 | |
*** Krast has joined #openstack-dns | 10:07 | |
*** Krast has quit IRC | 10:07 | |
*** matsuhashi has quit IRC | 10:36 | |
*** matsuhashi has joined #openstack-dns | 10:36 | |
*** matsuhashi has quit IRC | 10:41 | |
*** ctracey has joined #openstack-dns | 10:43 | |
*** matsuhashi has joined #openstack-dns | 10:49 | |
*** matsuhashi has quit IRC | 10:56 | |
*** matsuhashi has joined #openstack-dns | 10:57 | |
*** cflmarques has joined #openstack-dns | 11:00 | |
*** matsuhas_ has joined #openstack-dns | 11:00 | |
*** matsuhashi has quit IRC | 11:00 | |
kiall | Heya | 11:02 |
---|---|---|
ekarlso | kiall: yo | 11:15 |
kiall | yep | 11:15 |
kiall | whats up? :) | 11:15 |
ekarlso | nothing much, trying to get billingstack going again | 11:15 |
ekarlso | apparantly someone at *hp* cares about it .. | 11:15 |
kiall | lol .. someone? | 11:16 |
ekarlso | myeh | 11:17 |
ekarlso | wants to get a PoC going | 11:17 |
*** nosnos_ has quit IRC | 11:52 | |
*** nosnos has joined #openstack-dns | 11:53 | |
*** nosnos has quit IRC | 11:53 | |
*** nosnos has joined #openstack-dns | 11:54 | |
*** matsuhas_ has quit IRC | 11:58 | |
*** nosnos has quit IRC | 11:58 | |
*** matsuhashi has joined #openstack-dns | 11:59 | |
*** nosnos has joined #openstack-dns | 11:59 | |
*** matsuhashi has quit IRC | 12:03 | |
*** nosnos has quit IRC | 12:04 | |
*** CaptTofu has quit IRC | 12:18 | |
*** CaptTofu has joined #openstack-dns | 12:18 | |
*** CaptTofu has quit IRC | 13:28 | |
*** CaptTofu has joined #openstack-dns | 13:29 | |
*** mwoodson has quit IRC | 14:01 | |
*** vinod1 has joined #openstack-dns | 14:11 | |
*** eankutse has joined #openstack-dns | 14:13 | |
*** eankutse has quit IRC | 14:13 | |
*** eankutse has joined #openstack-dns | 14:13 | |
*** vinod1 has quit IRC | 14:17 | |
*** ppenjoy has joined #openstack-dns | 14:54 | |
*** eankutse has quit IRC | 14:55 | |
*** eankutse has joined #openstack-dns | 14:55 | |
*** CaptTofu has quit IRC | 14:57 | |
*** CaptTofu has joined #openstack-dns | 14:57 | |
*** vinod1 has joined #openstack-dns | 14:57 | |
vinod1 | kiall: I had a question on your "hyphens rather than underscores" comment | 15:06 |
kiall | heya | 15:07 |
kiall | Specifcally, you have cfg.StrOpt('accepted-tlds', ...) and cfg.StrOpt('effective_tlds', ...) i.e. one using a hyphen and the other with an underscore | 15:07 |
vinod1 | For "backend-driver" for .e.g central_init__.py has it as "backend-driver" but designate.conf has it as | 15:08 |
vinod1 | backend_driver | 15:08 |
kiall | So, It's a tad confusing all right.. (oslo-cfg is a bit odd) | 15:09 |
kiall | We consistently use hypens (or try to .. when we remember) in the option declaration, since the options can be exposed to the CLI, where `designate-api --option-name` makes more sense than `designate-api --option_name` | 15:09 |
kiall | But, the config file is always underscores | 15:10 |
vinod1 | So does oslo-cfg do the conversion from underscores to hypens? | 15:11 |
kiall | Yep - they go "as defined" onto the CLI, and are converted to underscores for the config file, and are converted to underscores use in the code itself | 15:12 |
kiall | It's that first "as defined" that causes us to use the hyphen convention :) | 15:13 |
vinod1 | wow that is pretty confusing :-( | 15:14 |
kiall | Yep - I *think* it's due to oslo-cfg wanting to maintain compatibility with some of the older CLI's that for whatever reason used underscores in CLI arguments | 15:15 |
kiall | Either way, We wouldd have gong with underscores otherwise.. Makes more sense that way! | 15:15 |
vinod1 | Okay I will try to make that change and hopefully get it right | 15:17 |
kiall | Tis easy enough to follow: Use underscores everywhere BUT where the config option is defined .. (But, yea, Doing that makes no sense if you don't know the history) | 15:19 |
vinod1 | On your other comment about regarding the following | 15:29 |
vinod1 | In order to merge this to the stable branch, we'll need to maintain backwards compatibility.. i.e. not having an effective TLDs file should be acceptable. | 15:29 |
vinod1 | At that point, we should probably do the same for the IANA list too, keeping things consistent. | 15:29 |
vinod1 | — So do you mean that not having acceptable list file too should be okay? | 15:29 |
*** shakayumi has joined #openstack-dns | 15:38 | |
kiall | vinod1: brb - on a call | 15:40 |
vinod1 | same here | 15:40 |
*** betsy has quit IRC | 15:40 | |
vinod1 | Also one other thing - the reason I moved the following check and the one label check to effectivetld.pyjavascript:void(0) | 15:42 |
vinod1 | if domain_tld not in self._accepted_tld_list: | 15:42 |
vinod1 | javascript:void(0) | 15:42 |
vinod1 | raise exceptions.InvalidTLD('Unknown or invalid TLD') | 15:42 |
vinod1 | It seemed to make sense to have all the tld related validations in one place | 15:42 |
vinod1 | for both the accepted_tlds and effective_tlds | 15:42 |
*** vinod1 has quit IRC | 15:44 | |
kiall | vinod1: I was actually thing the same thing a few minutes ago .. I think the public suffix and IANA list parsing etc belongs isolated from everything else, exposing 1 method "is_effective_tld", which returns True/False.. | 15:48 |
kiall | Then the remainder of the checks are in the central/service.py file, to later be abstracted away along with the record_name etc checks | 15:49 |
kiall | ah .. he left! | 15:49 |
* artom feels like he's copy-pasting tests too much... | 15:54 | |
* kiall actually typed `rm -rf designate/tests` at one point | 15:55 | |
artom | There's a story behind that I'm sure... | 15:55 |
kiall | artom: it's a simple story really.. | 15:57 |
kiall | there's too much copy and pasting necessary ;) | 15:57 |
artom | Hah. | 15:57 |
artom | I suppose I could use reflection, since it's testing the same thing but with different method names. | 15:57 |
artom | Not sure if it would make the code easier to read/maintain... | 15:58 |
kiall | I've been continuing the copy and paste, saving the test refactor for another day. At least if everything is similar, the refactor is easy-ish :( | 15:58 |
*** shakayumi has quit IRC | 16:07 | |
*** betsy has joined #openstack-dns | 16:26 | |
*** adrian_otto has joined #openstack-dns | 16:33 | |
openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Multi-backend https://review.openstack.org/55887 | 16:34 |
openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Multi-backend https://review.openstack.org/55887 | 16:47 |
*** shakayumi has joined #openstack-dns | 16:56 | |
*** vinod1 has joined #openstack-dns | 16:58 | |
kiall | IRC meet starting over in #openstack-meeting-alt | 17:00 |
*** jmcbride has joined #openstack-dns | 17:15 | |
*** zane has joined #openstack-dns | 17:25 | |
*** shakayumi has quit IRC | 17:31 | |
*** jmcbride1 has joined #openstack-dns | 17:35 | |
*** jmcbride has quit IRC | 17:36 | |
*** jmcbride1 has quit IRC | 17:46 | |
*** jmcbride has joined #openstack-dns | 17:46 | |
*** zane has quit IRC | 17:54 | |
*** tsimmons has joined #openstack-dns | 18:00 | |
* artom just noticed the find_* methods in Central's API. | 18:03 | |
artom | I guess this is what kiall had in mind for the recreates in multi-backend's delete error handling... | 18:04 |
artom | We need to find all the records in the domain, save them, save the domain, and re-add all of that on the slave if the delete on the master fails... | 18:05 |
*** tsimmons has left #openstack-dns | 18:06 | |
*** ppenjoy has quit IRC | 18:06 | |
*** vinod1 has quit IRC | 18:07 | |
*** cflmarques has quit IRC | 18:14 | |
artom | But that's actually quite backwards. | 18:14 |
artom | You're going through Central to save a domain in the backend. | 18:14 |
artom | Surely it should be the backend's responsibility to do that. | 18:15 |
*** jmcbride has quit IRC | 18:15 | |
*** eankutse has quit IRC | 18:31 | |
*** krow has joined #openstack-dns | 18:46 | |
*** zane has joined #openstack-dns | 18:47 | |
*** krow has quit IRC | 18:59 | |
*** krow has joined #openstack-dns | 19:00 | |
*** ctracey has left #openstack-dns | 19:01 | |
*** eankutse has joined #openstack-dns | 19:02 | |
*** eankutse1 has joined #openstack-dns | 19:02 | |
*** vinod1 has joined #openstack-dns | 19:04 | |
*** vinod1 has quit IRC | 19:05 | |
*** vinod1 has joined #openstack-dns | 19:05 | |
*** eankutse has quit IRC | 19:07 | |
*** eankutse1 has quit IRC | 19:07 | |
*** jmcbride has joined #openstack-dns | 19:07 | |
*** eankutse has joined #openstack-dns | 19:07 | |
*** krow has quit IRC | 19:11 | |
*** krow has joined #openstack-dns | 19:13 | |
*** krow has quit IRC | 19:24 | |
*** jmcbride1 has joined #openstack-dns | 19:26 | |
*** jmcbride has quit IRC | 19:26 | |
betsy | artom: I agree with you re it should be the backend's responsibility. It will vary a lot depending on the backend | 19:27 |
*** krow has joined #openstack-dns | 19:32 | |
*** jmcbride1 has quit IRC | 19:38 | |
*** krow has quit IRC | 19:42 | |
*** tsimmons has joined #openstack-dns | 19:49 | |
*** vinod1 has quit IRC | 19:56 | |
*** jmcbride has joined #openstack-dns | 20:03 | |
*** jmcbride has quit IRC | 20:09 | |
*** vinod1 has joined #openstack-dns | 20:13 | |
*** vinod1 has quit IRC | 20:33 | |
*** vinod1 has joined #openstack-dns | 20:47 | |
*** zane has quit IRC | 21:01 | |
*** zane has joined #openstack-dns | 21:09 | |
openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: Add SLDs that act like TLDs https://review.openstack.org/55871 | 21:50 |
*** vinod1 has quit IRC | 22:06 | |
*** vinod1 has joined #openstack-dns | 22:25 | |
*** vinod2 has joined #openstack-dns | 22:25 | |
*** vinod2 has joined #openstack-dns | 22:26 | |
*** vinod1 has quit IRC | 22:29 | |
*** eankutse has quit IRC | 22:30 | |
*** tsimmons has left #openstack-dns | 22:34 | |
*** zane has quit IRC | 22:34 | |
*** krow has joined #openstack-dns | 22:35 | |
*** betsy has quit IRC | 22:36 | |
*** CaptTofu has quit IRC | 22:45 | |
*** CaptTofu has joined #openstack-dns | 22:46 | |
*** zane has joined #openstack-dns | 22:49 | |
*** vinod2 has quit IRC | 22:50 | |
*** zane1 has joined #openstack-dns | 22:57 | |
*** zane1 has quit IRC | 22:57 | |
*** zane has quit IRC | 22:59 | |
*** zane has joined #openstack-dns | 23:02 | |
*** zane has quit IRC | 23:23 | |
*** adrian_otto has quit IRC | 23:33 | |
*** adrian_otto has joined #openstack-dns | 23:34 | |
*** eankutse has joined #openstack-dns | 23:47 | |
*** eankutse has quit IRC | 23:48 | |
*** eankutse has joined #openstack-dns | 23:48 | |
*** krow has quit IRC | 23:56 | |
*** matsuhashi has joined #openstack-dns | 23:57 | |
*** eankutse has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!