| *** kukanova has joined #openstack-dns | 00:45 | |
| *** kukanova has quit IRC | 00:45 | |
| *** jmcbride has joined #openstack-dns | 00:59 | |
| *** jmcbride has quit IRC | 00:59 | |
| *** nosnos has joined #openstack-dns | 01:05 | |
| *** jmcbride has joined #openstack-dns | 02:08 | |
| *** jmcbride has quit IRC | 02:14 | |
| *** jmcbride has joined #openstack-dns | 02:19 | |
| *** jmcbride has quit IRC | 02:30 | |
| *** jmcbride has joined #openstack-dns | 02:31 | |
| *** jmcbride has quit IRC | 02:45 | |
| *** jmcbride has joined #openstack-dns | 03:14 | |
| *** jmcbride has quit IRC | 03:16 | |
| *** jmcbride has joined #openstack-dns | 03:17 | |
| *** jmcbride has quit IRC | 03:26 | |
| *** CaptTofu has joined #openstack-dns | 03:34 | |
| *** CaptTofu has quit IRC | 03:37 | |
| *** CaptTofu has joined #openstack-dns | 03:37 | |
| *** jmcbride has joined #openstack-dns | 03:57 | |
| *** CaptTofu has quit IRC | 04:01 | |
| *** CaptTofu has joined #openstack-dns | 04:04 | |
| *** CaptTofu has quit IRC | 04:05 | |
| *** jmcbride has quit IRC | 05:31 | |
| *** nosnos_ has joined #openstack-dns | 05:34 | |
| *** nosnos_ has quit IRC | 05:35 | |
| *** nosnos_ has joined #openstack-dns | 05:36 | |
| *** nosnos has quit IRC | 05:37 | |
| *** Adri2000 has quit IRC | 05:47 | |
| *** nosnos has joined #openstack-dns | 06:59 | |
| *** nosnos_ has quit IRC | 06:59 | |
| *** HenryG_ has joined #openstack-dns | 09:37 | |
| *** HenryG has quit IRC | 09:40 | |
| *** briancline has quit IRC | 09:52 | |
| *** briancline has joined #openstack-dns | 09:54 | |
| *** Adri2000 has joined #openstack-dns | 11:58 | |
| *** HenryG_ has quit IRC | 12:24 | |
| *** HenryG has joined #openstack-dns | 12:35 | |
| *** HenryG has quit IRC | 12:40 | |
| *** nosnos has quit IRC | 12:47 | |
| *** HenryG has joined #openstack-dns | 13:32 | |
| *** zigo has quit IRC | 13:55 | |
| *** zigo has joined #openstack-dns | 14:00 | |
| *** jmcbride has joined #openstack-dns | 14:04 | |
| *** betsy has joined #openstack-dns | 14:14 | |
| *** jmcbride1 has joined #openstack-dns | 14:16 | |
| *** jmcbride has quit IRC | 14:16 | |
| *** komandir has joined #openstack-dns | 14:20 | |
| *** eankutse has joined #openstack-dns | 14:21 | |
| *** HenryG has quit IRC | 14:23 | |
| *** pasquier-s has quit IRC | 14:23 | |
| *** sentimo has joined #openstack-dns | 14:26 | |
| *** komandir has quit IRC | 14:28 | |
| *** sentimo has quit IRC | 14:30 | |
| *** pasquier-s has joined #openstack-dns | 14:30 | |
| *** eankutse has quit IRC | 14:31 | |
| *** eankutse has joined #openstack-dns | 14:31 | |
| *** openstackgerrit has quit IRC | 14:31 | |
| *** openstackgerrit has joined #openstack-dns | 14:31 | |
| *** ChanServ sets mode: +v openstackgerrit | 14:31 | |
| *** artom has joined #openstack-dns | 14:34 | |
| *** jmcbride1 has quit IRC | 14:40 | |
| *** jmcbride has joined #openstack-dns | 14:41 | |
| openstackgerrit | Dirk Mueller proposed a change to stackforge/python-designateclient: Fix and enable gating on H306 https://review.openstack.org/62379 | 14:42 |
|---|---|---|
| *** cflmarques has joined #openstack-dns | 14:43 | |
| *** HenryG has joined #openstack-dns | 15:08 | |
| *** vipul has quit IRC | 15:27 | |
| *** vipul has joined #openstack-dns | 15:28 | |
| *** 1JTABG80R has joined #openstack-dns | 15:29 | |
| *** jmcbride1 has joined #openstack-dns | 15:30 | |
| *** jmcbride has quit IRC | 15:31 | |
| *** 1JTABG80R has quit IRC | 15:37 | |
| *** eankutse has quit IRC | 15:39 | |
| *** zigo has quit IRC | 15:39 | |
| *** Adri2000 has quit IRC | 15:39 | |
| *** briancline has quit IRC | 15:39 | |
| *** eankutse has joined #openstack-dns | 15:44 | |
| *** zigo has joined #openstack-dns | 15:44 | |
| *** Adri2000 has joined #openstack-dns | 15:44 | |
| *** briancline has joined #openstack-dns | 15:44 | |
| *** ctracey|` has joined #openstack-dns | 15:51 | |
| *** tsimmons has joined #openstack-dns | 15:51 | |
| *** jdbarry_ has joined #openstack-dns | 15:51 | |
| *** jdbarry has quit IRC | 15:54 | |
| *** ctracey|away has quit IRC | 15:54 | |
| *** jdbarry_ is now known as jdbarry | 15:55 | |
| *** pasquier-s has quit IRC | 15:56 | |
| *** pasquier-s has joined #openstack-dns | 15:59 | |
| *** msisk has joined #openstack-dns | 16:00 | |
| *** jmcbride1 has quit IRC | 16:02 | |
| *** ctracey|away has joined #openstack-dns | 16:14 | |
| *** spiffxp_ has joined #openstack-dns | 16:14 | |
| *** CaptTofu has joined #openstack-dns | 16:15 | |
| *** ctracey|` has quit IRC | 16:18 | |
| *** spiffxp has quit IRC | 16:18 | |
| *** eankutse has quit IRC | 16:18 | |
| *** zigo has quit IRC | 16:18 | |
| *** Adri2000 has quit IRC | 16:18 | |
| *** briancline has quit IRC | 16:18 | |
| *** kiall has quit IRC | 16:18 | |
| *** msisk has quit IRC | 16:18 | |
| *** tsimmons has quit IRC | 16:18 | |
| *** betsy has quit IRC | 16:18 | |
| *** jmcbride1 has joined #openstack-dns | 16:19 | |
| *** msisk has joined #openstack-dns | 16:21 | |
| *** tsimmons has joined #openstack-dns | 16:21 | |
| *** briancline has joined #openstack-dns | 16:21 | |
| *** Adri2000 has joined #openstack-dns | 16:21 | |
| *** zigo has joined #openstack-dns | 16:21 | |
| *** eankutse has joined #openstack-dns | 16:21 | |
| *** betsy has joined #openstack-dns | 16:21 | |
| *** kiall has joined #openstack-dns | 16:21 | |
| *** jmcbride1 has quit IRC | 16:27 | |
| *** CaptTofu has quit IRC | 16:27 | |
| *** jmcbride has joined #openstack-dns | 16:27 | |
| *** CaptTofu has joined #openstack-dns | 16:30 | |
| *** jmcbride has quit IRC | 16:33 | |
| *** eankutse has quit IRC | 16:34 | |
| *** ctracey|away is now known as ctracey | 16:37 | |
| *** jmcbride1 has joined #openstack-dns | 16:42 | |
| *** eankutse has joined #openstack-dns | 16:43 | |
| *** CaptTofu has quit IRC | 16:50 | |
| *** skafandr has joined #openstack-dns | 17:17 | |
| *** skafandr has quit IRC | 17:19 | |
| *** stereodom has joined #openstack-dns | 17:21 | |
| *** stereodom has quit IRC | 17:26 | |
| *** rjrjr has joined #openstack-dns | 17:29 | |
| *** jmcbride1 has quit IRC | 17:34 | |
| *** tsimmons has left #openstack-dns | 17:38 | |
| *** msisk has quit IRC | 18:05 | |
| *** msisk has joined #openstack-dns | 18:07 | |
| *** jmcbride has joined #openstack-dns | 18:07 | |
| *** maralia has joined #openstack-dns | 18:25 | |
| *** maralia has quit IRC | 18:30 | |
| *** milarus has joined #openstack-dns | 18:32 | |
| *** milarus has quit IRC | 18:33 | |
| *** cflmarques has quit IRC | 18:41 | |
| *** lunarlight has joined #openstack-dns | 18:47 | |
| *** lunarlight has quit IRC | 18:49 | |
| *** unmoral has joined #openstack-dns | 18:53 | |
| *** unmoral has quit IRC | 19:02 | |
| *** jmcbride has quit IRC | 19:04 | |
| *** jmcbride has joined #openstack-dns | 19:08 | |
| *** jorgem has joined #openstack-dns | 19:38 | |
| *** jmcbride has quit IRC | 19:41 | |
| *** jmcbride has joined #openstack-dns | 19:44 | |
| *** sinstenes has joined #openstack-dns | 19:45 | |
| *** CaptTofu has joined #openstack-dns | 19:52 | |
| *** jmcbride has quit IRC | 19:58 | |
| *** jmcbride has joined #openstack-dns | 20:01 | |
| *** jmcbride has quit IRC | 20:05 | |
| *** jmcbride has joined #openstack-dns | 20:09 | |
| *** jmcbride1 has joined #openstack-dns | 20:16 | |
| *** jmcbride has quit IRC | 20:18 | |
| openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Apply db migrations for all sqlalchemy tests https://review.openstack.org/62079 | 20:27 |
| *** tmc3inphilly has joined #openstack-dns | 20:31 | |
| *** ctracey is now known as ctracey|away | 20:37 | |
| *** ctracey|away is now known as ctracey | 21:07 | |
| *** openstackgerrit has quit IRC | 21:08 | |
| *** openstackgerrit has joined #openstack-dns | 21:08 | |
| *** ChanServ sets mode: +v openstackgerrit | 21:08 | |
| kiall | artom: ^ nice :) One thing I would suggest is using the fixtures stuff in place of "DatabaseManager" | 21:13 |
| kiall | Some examples, https://github.com/stackforge/designate/blob/master/designate/tests/__init__.py#L50-91 and https://github.com/stackforge/designate/tree/master/designate/openstack/common/fixture | 21:13 |
| artom | Yeah, I wanted to get ekarlso to review and suggest improvements, as I feel I unintentionally ignored a lot of best practices. | 21:14 |
| kiall | I looked at the first patchset, but was on a bus and gerrit doesn't work right on mobiles ;) | 21:15 |
| kiall | Then promptly forgot about it | 21:15 |
| kiall | But, in general is looks good! | 21:15 |
| artom | Cool :) But my initial plan of merging it with your rrsets patchset to make sure it replicates the error I got "live" hit a snag. | 21:16 |
| kiall | I would take that DBManager class, and turn it into a fixture that, on first instantiation, creates the DB file, then uses the cleanup to restore the "golden" db after re-uses.. | 21:16 |
| kiall | s/after re-uses..// | 21:16 |
| kiall | Yea - let me push up some changes to that patchset that fix the migrations -_- | 21:17 |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: WIP: RRSets https://review.openstack.org/59409 | 21:17 |
| kiall | Still more issues in ^ patchset, managed to get a whole morning on it until other duties kicked in! | 21:18 |
| artom | kiall, sounds good for the fixture thing. | 21:19 |
| kiall | https://review.openstack.org/#/c/59409/13/designate/storage/impl_sqlalchemy/migrate_repo/versions/033_add_record_tenant_id.py <-- actually needs to be merged ASAP, it's likely the issue your seeing | 21:19 |
| kiall | I'll pull that into its own PS and merge this evening.. | 21:19 |
| artom | Hrmm, can it be used to validate that my ps does what it's supposed ot? | 21:20 |
| artom | Ie, somehow run my ps's tests on your ps without/with that migration to make sure it respectively doesn't work/works. | 21:21 |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Correct migration 33 https://review.openstack.org/62477 | 21:21 |
| artom | ... I hope that sentence made sense. | 21:21 |
| kiall | If your PS works over master right now, then we have a hole in our tests somewhere :) | 21:22 |
| artom | It *does* work over master... | 21:22 |
| kiall | Great -_- | 21:22 |
| kiall | Oh | 21:22 |
| kiall | Ah.. Humm It would work over master | 21:22 |
| kiall | Since the dodgy piece in migration 33 only affects existing data | 21:23 |
| kiall | Of which there would be none | 21:23 |
| artom | So... yey? | 21:24 |
| artom | Or should we have a pre-populated db for tests? | 21:25 |
| kiall | Other projects have been trying to get upgrade testing for quite some time, it's been *really* hard for them | 21:25 |
| kiall | (https://wiki.openstack.org/wiki/Grenade | 21:26 |
| kiall | https://wiki.openstack.org/wiki/Grenade * | 21:26 |
| artom | Well this really only tests that operations work after an empty DB has been upgraded... | 21:27 |
| kiall | Yea, it tests that the migration produces the correct schema, rather than that the migration updates data correctly.. | 21:27 |
| kiall | Which is hugely valuable on it's own - So lets get that merged :) | 21:27 |
| kiall | Upgrade testing is probably something we should probably look into how/if we can tie into Grenate | 21:28 |
| kiall | Grenade* | 21:28 |
| kiall | Anyway - 9:30 pm.. Time to get out of the office! | 21:31 |
| artom | 'night | 21:31 |
| openstackgerrit | A change was merged to stackforge/designate: Correct migration 33 https://review.openstack.org/62477 | 21:33 |
| *** shawni has joined #openstack-dns | 21:59 | |
| *** msisk has quit IRC | 22:02 | |
| *** sinstenes has quit IRC | 22:02 | |
| *** jmcbride1 has quit IRC | 22:03 | |
| *** msisk has joined #openstack-dns | 22:05 | |
| *** msisk has quit IRC | 22:06 | |
| *** shawni has quit IRC | 22:18 | |
| *** rjrjr has quit IRC | 22:23 | |
| *** tmc3inphilly has quit IRC | 22:51 | |
| *** jmcbride has joined #openstack-dns | 23:10 | |
| *** jmcbride has quit IRC | 23:31 | |
| *** eankutse has quit IRC | 23:38 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!