| *** HenryG has quit IRC | 00:05 | |
| *** krow has quit IRC | 00:13 | |
| *** vipul is now known as vipul-away | 00:14 | |
| *** krow has joined #openstack-dns | 00:18 | |
| *** rossk_ has joined #openstack-dns | 00:41 | |
| *** rossk has quit IRC | 00:44 | |
| *** CaptTofu has quit IRC | 00:56 | |
| *** CaptTofu has joined #openstack-dns | 00:56 | |
| *** tsimmons has joined #openstack-dns | 01:07 | |
| *** tsimmons has quit IRC | 01:12 | |
| *** krow1 has joined #openstack-dns | 01:31 | |
| *** krow has quit IRC | 01:32 | |
| *** nosnos has joined #openstack-dns | 01:38 | |
| *** krow has joined #openstack-dns | 02:16 | |
| *** krow1 has quit IRC | 02:17 | |
| *** zane has joined #openstack-dns | 02:23 | |
| *** rossk_ has quit IRC | 02:27 | |
| *** nosnos_ has joined #openstack-dns | 02:30 | |
| *** rossk has joined #openstack-dns | 02:30 | |
| *** nosnos has quit IRC | 02:33 | |
| *** krow has quit IRC | 02:35 | |
| *** krow has joined #openstack-dns | 02:42 | |
| *** krow has quit IRC | 03:04 | |
| *** krow has joined #openstack-dns | 03:22 | |
| *** zane has quit IRC | 03:25 | |
| *** CaptTofu has quit IRC | 03:40 | |
| *** krow has quit IRC | 03:40 | |
| *** CaptTofu has joined #openstack-dns | 03:45 | |
| *** ctracey|away is now known as ctracey | 03:48 | |
| *** vipul-away is now known as vipul | 04:01 | |
| *** vipul has joined #openstack-dns | 04:02 | |
| *** rossk has quit IRC | 04:05 | |
| *** krow has joined #openstack-dns | 04:14 | |
| *** betsy has joined #openstack-dns | 04:15 | |
| *** krow has quit IRC | 04:16 | |
| *** rossk has joined #openstack-dns | 04:34 | |
| *** krow has joined #openstack-dns | 04:41 | |
| *** rossk has quit IRC | 04:42 | |
| *** zane has joined #openstack-dns | 04:52 | |
| *** CaptTofu has quit IRC | 04:56 | |
| *** ctracey is now known as ctracey|away | 05:01 | |
| *** nosnos_ has quit IRC | 05:06 | |
| *** nosnos has joined #openstack-dns | 05:07 | |
| *** CaptTofu has joined #openstack-dns | 05:16 | |
| *** CaptTofu has quit IRC | 06:36 | |
| *** CaptTofu has joined #openstack-dns | 06:37 | |
| *** krow has quit IRC | 06:54 | |
| *** zane has quit IRC | 07:27 | |
| *** vipul is now known as vipul-away | 07:34 | |
| *** krow has joined #openstack-dns | 08:05 | |
| *** krow has quit IRC | 08:09 | |
| *** krow has joined #openstack-dns | 08:13 | |
| *** krow has quit IRC | 08:22 | |
| *** krow has joined #openstack-dns | 08:32 | |
| *** krow has quit IRC | 08:48 | |
| *** krow has joined #openstack-dns | 08:54 | |
| *** krow has quit IRC | 09:39 | |
| *** krow has joined #openstack-dns | 10:50 | |
| *** nosnos has quit IRC | 11:00 | |
| *** krow has quit IRC | 11:45 | |
| *** krow has joined #openstack-dns | 11:48 | |
| *** CaptTofu has quit IRC | 12:01 | |
| *** CaptTofu has joined #openstack-dns | 12:01 | |
| *** krow has quit IRC | 12:16 | |
| *** krow has joined #openstack-dns | 12:18 | |
| *** krow has quit IRC | 12:18 | |
| *** CaptTofu has quit IRC | 12:37 | |
| *** CaptTofu has joined #openstack-dns | 12:37 | |
| *** CaptTofu has quit IRC | 12:41 | |
| *** HenryG has joined #openstack-dns | 13:00 | |
| *** eankutse has joined #openstack-dns | 13:07 | |
| *** eankutse has quit IRC | 13:07 | |
| *** eankutse has joined #openstack-dns | 13:08 | |
| *** zux has joined #openstack-dns | 13:48 | |
| *** zux has left #openstack-dns | 13:49 | |
| *** zane has joined #openstack-dns | 14:39 | |
| *** openstack has joined #openstack-dns | 14:49 | |
| *** ChanServ sets mode: +v openstack | 14:49 | |
| betsy | kiall or mugsie around? I've got a question on testing the Blacklist API | 14:50 |
|---|---|---|
| kiall | betsy: heya | 14:56 |
| betsy | hey. So I've got the new db created and a get blacklist correctly returns an empty list. I can see in the logs where it's hitting the db | 14:56 |
| kiall | artom: get any further on 62079 (testing against a DB created with the actual migrations)? I have a feeling it might identify an issue ;) | 14:57 |
| artom | kiall, slowly... | 14:57 |
| kiall | artom: :) | 14:58 |
| betsy | But, I can't get the create blacklist to work. It gets passed the policy check, but there's never any db calls in the logs. It goes on to send it over rpc after all the db stuff where it gets a circular reference error | 14:58 |
| artom | Had other stuff for the last couple of days. | 14:58 |
| artom | Hey, are there tests that depend on the record(set)/domain/server fixtures *not* having UUIDs? | 14:59 |
| betsy | I looked at the json and can't see anything obviously wrong | 14:59 |
| kiall | betsy: Humm, when you say it's get passed the policy check, are you sending the list of blacklisted zones to policy.check(), that doesn't seem right.. I think | 14:59 |
| *** tsimmons has joined #openstack-dns | 15:00 | |
| betsy | No. The policy check just sees if I have the authority to make the call | 15:00 |
| kiall | artom: Humm, I think so.. the fixtures are used to create / update things.. so having a UUID in them would break that | 15:00 |
| artom | Hrmm, maybe I'm doing my tests wrong. | 15:00 |
| kiall | betsy: ah .. Well, then I don't understand the issue! Maybe pastebin the code? | 15:00 |
| artom | There are CRUD methods in tests/__init__ | 15:01 |
| artom | Should I use those to test the backend? | 15:01 |
| artom | Doing it manually is... painful. | 15:01 |
| kiall | I would have thought this method would be extended to check the DB blacklist, in addition to the config blacklist https://github.com/stackforge/designate/blob/master/designate/central/service.py#L168-178 | 15:01 |
| betsy | The problem is I can't get the create blacklist to work. Is there some trick or some place something has to be added that I'm not aware of? | 15:01 |
| kiall | OMG. I can't believe I merged with all the commented out code -_- | 15:02 |
| betsy | kiall: Right. It will, but that's not the problem I'm having now. Something much more basic. I can't get the Post Blacklist to add the blacklisted domain to the db | 15:02 |
| kiall | Oh .. Humm | 15:03 |
| kiall | betsy: I think I'd need to see to code to properly understand the issue | 15:03 |
| betsy | ok. How do I check it in where only you can see it? | 15:04 |
| kiall | commit, then `git-review --draft` | 15:04 |
| kiall | then open the web UI and add me (and anyone else..) as a reviewer | 15:04 |
| betsy | ok | 15:04 |
| kiall | betsy: BTW - Joe in yet? | 15:07 |
| betsy | idk -- I'm working from home, but he's usually in early (our time) so he should be there | 15:08 |
| kiall | If you have an internal IM, can you ask him to ping me when he gets a chance? :) | 15:08 |
| tsimmons | kiall: He's not online, but I texted him. | 15:10 |
| kiall | tsimmons: hah.. wasn't that urgent, but thanks :) | 15:11 |
| tsimmons | kiall: np. | 15:12 |
| *** CaptTofu has joined #openstack-dns | 15:50 | |
| *** CaptTofu has quit IRC | 15:52 | |
| *** CaptTofu has joined #openstack-dns | 15:53 | |
| *** jmcbride has joined #openstack-dns | 15:53 | |
| *** CaptTofu has quit IRC | 15:57 | |
| artom | In the basic TestCase, at which point is self.central_service instanciated? | 16:00 |
| artom | All the create_ methods call it, but at no point can I see it being created. | 16:01 |
| kiall | It somewhat backwards, the test cases that use them create it in their setUp | 16:04 |
| kiall | All that stuff should be switched to "proper" fixtures | 16:05 |
| artom | Urgh. | 16:05 |
| kiall | Yea - It's some of the code I've most wanted to kill in the entire thing!" | 16:07 |
| kiall | (Oh a call if I stop answering..) | 16:07 |
| kiall | On* | 16:07 |
| artom | I think you're still on a call even if you continue answering ;) | 16:07 |
| kiall | ;) | 16:08 |
| *** jorgem has joined #openstack-dns | 16:10 | |
| eankutse | hi | 16:11 |
| *** jmcbride1 has joined #openstack-dns | 16:16 | |
| kiall | heya | 16:17 |
| *** jmcbride has quit IRC | 16:19 | |
| eankutse | kiall: sorry that was wrong IRC :-) | 16:22 |
| kiall | ;) | 16:22 |
| *** vipul-away is now known as vipul | 16:26 | |
| *** jmcbride1 has quit IRC | 16:30 | |
| *** HenryG_ has joined #openstack-dns | 16:38 | |
| *** jmcbride has joined #openstack-dns | 16:39 | |
| *** HenryG has quit IRC | 16:41 | |
| *** jmcbride has quit IRC | 16:42 | |
| *** jmcbride has joined #openstack-dns | 16:43 | |
| *** jmcbride has quit IRC | 16:43 | |
| *** jmcbride has joined #openstack-dns | 16:47 | |
| *** zane has quit IRC | 16:49 | |
| *** zane has joined #openstack-dns | 16:49 | |
| *** tsimmons has quit IRC | 16:57 | |
| *** tsimmons has joined #openstack-dns | 17:05 | |
| *** jmcbride has quit IRC | 17:07 | |
| *** zane1 has joined #openstack-dns | 17:15 | |
| *** eankutse has quit IRC | 17:16 | |
| *** zane has quit IRC | 17:18 | |
| *** baffle has quit IRC | 17:35 | |
| *** baffle has joined #openstack-dns | 17:36 | |
| *** eankutse has joined #openstack-dns | 17:47 | |
| *** zane1 has quit IRC | 17:53 | |
| *** rjrjr has quit IRC | 17:55 | |
| *** eankutse has quit IRC | 17:57 | |
| *** jmcbride has joined #openstack-dns | 18:12 | |
| artom | Well, looks like I got my tests working... | 18:24 |
| artom | And it's giving me similar errors to what I was experiencing when I was trying to test kiall's rrset code... | 18:26 |
| artom | Back then the error was: Column count doesn't match value count at row 1 | 18:26 |
| artom | Now it's OperationalError: (OperationalError) table records has 13 columns but 12 values were supplied | 18:26 |
| *** eankutse has joined #openstack-dns | 18:33 | |
| *** CaptTofu has joined #openstack-dns | 18:33 | |
| *** jmcbride has quit IRC | 18:34 | |
| *** tsimmons has quit IRC | 18:35 | |
| *** krow has joined #openstack-dns | 18:35 | |
| *** jorgem has quit IRC | 18:37 | |
| *** eankutse has quit IRC | 18:38 | |
| *** eankutse has joined #openstack-dns | 18:38 | |
| *** krow has quit IRC | 18:40 | |
| *** krow has joined #openstack-dns | 18:42 | |
| *** jdbarry has quit IRC | 18:42 | |
| *** jmcbride has joined #openstack-dns | 18:56 | |
| artom | I get the feeling it's https://github.com/stackforge/designate/blob/master/designate/backend/impl_powerdns/__init__.py#L429-L441 | 19:00 |
| artom | Compare with https://github.com/stackforge/designate/blob/master/designate/backend/impl_powerdns/__init__.py#L429-L441 | 19:01 |
| artom | Looks like designate_recordset_id is missing in the former. | 19:01 |
| *** ctracey|away is now known as ctracey | 19:10 | |
| artom | If my diagnosis is correct, I can file a bug. | 19:14 |
| artom | I'm kinda hoping someone more familiar with that corner of the code can do what's for them a quick fix. | 19:15 |
| artom | I would need to dig around quite a bit. | 19:15 |
| *** rossk has joined #openstack-dns | 19:23 | |
| *** CaptTofu has quit IRC | 19:29 | |
| *** tsimmons has joined #openstack-dns | 19:40 | |
| *** HenryG_ has quit IRC | 19:49 | |
| *** krow has quit IRC | 19:52 | |
| *** betsy has quit IRC | 20:02 | |
| artom | Can I just null() it...? | 20:11 |
| *** CaptTofu has joined #openstack-dns | 20:18 | |
| openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Fix PowerDNS not using recordset_id https://review.openstack.org/63208 | 20:36 |
| *** zane1 has joined #openstack-dns | 20:41 | |
| *** jmcbride has quit IRC | 20:48 | |
| *** zane1 has quit IRC | 20:49 | |
| *** zane has joined #openstack-dns | 20:50 | |
| *** jmcbride has joined #openstack-dns | 20:50 | |
| *** CaptTofu has quit IRC | 21:05 | |
| *** jmcbride has quit IRC | 21:13 | |
| *** vipul is now known as vipul-away | 21:16 | |
| *** eankutse has quit IRC | 21:17 | |
| *** vipul-away is now known as vipul | 21:21 | |
| openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Do not try to update records if there are none https://review.openstack.org/63216 | 21:21 |
| *** HenryG has joined #openstack-dns | 22:07 | |
| openstackgerrit | Artom Lifshitz proposed a change to stackforge/designate: Test database migration schema https://review.openstack.org/62079 | 22:29 |
| *** zane has quit IRC | 22:34 | |
| *** betsy has joined #openstack-dns | 22:35 | |
| *** rossk has quit IRC | 22:39 | |
| *** artom has quit IRC | 22:39 | |
| *** zane has joined #openstack-dns | 22:41 | |
| *** artom has joined #openstack-dns | 22:42 | |
| *** krow has joined #openstack-dns | 22:46 | |
| *** vipul is now known as vipul-away | 22:56 | |
| *** ctracey is now known as ctracey|away | 22:58 | |
| *** tsimmons has quit IRC | 23:14 | |
| *** rossk has joined #openstack-dns | 23:24 | |
| *** CaptTofu has joined #openstack-dns | 23:52 | |
| *** CaptTofu has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!