| *** sn6i23a has quit IRC | 00:16 | |
| *** jorgem has quit IRC | 00:17 | |
| *** CaptTofu has joined #openstack-dns | 00:23 | |
| *** matsuhashi has joined #openstack-dns | 00:31 | |
| *** matsuhas_ has joined #openstack-dns | 00:48 | |
| *** matsuhashi has quit IRC | 00:55 | |
| *** openstackgerrit has quit IRC | 01:18 | |
| *** openstackgerrit has joined #openstack-dns | 01:18 | |
| *** ChanServ sets mode: +v openstackgerrit | 01:18 | |
| *** nosnos has joined #openstack-dns | 01:34 | |
| *** shakayumi has quit IRC | 01:53 | |
| *** rossk has quit IRC | 01:59 | |
| *** jmcbride has joined #openstack-dns | 02:09 | |
| *** elemecca1 has quit IRC | 02:12 | |
| *** jmcbride has quit IRC | 02:21 | |
| *** matsuhas_ has quit IRC | 02:34 | |
| *** matsuhas_ has joined #openstack-dns | 02:36 | |
| *** elemecca has joined #openstack-dns | 02:43 | |
| *** elemecca has quit IRC | 02:48 | |
| *** vinod has joined #openstack-dns | 02:54 | |
| *** matsuhas_ has quit IRC | 03:03 | |
| *** matsuhas_ has joined #openstack-dns | 03:06 | |
| *** vinod has quit IRC | 03:25 | |
| *** matsuhas_ has quit IRC | 03:29 | |
| *** richm has quit IRC | 03:43 | |
| *** CaptTofu has quit IRC | 04:02 | |
| *** furlongm has quit IRC | 04:04 | |
| *** msisk has joined #openstack-dns | 04:23 | |
| *** matsuhashi has joined #openstack-dns | 04:25 | |
| *** msisk has quit IRC | 04:38 | |
| *** jorgem has joined #openstack-dns | 04:52 | |
| *** jorgem has quit IRC | 04:53 | |
| *** jorgem has joined #openstack-dns | 04:53 | |
| *** matsuhashi has quit IRC | 05:23 | |
| *** jmcbride has joined #openstack-dns | 05:29 | |
| *** matsuhashi has joined #openstack-dns | 05:33 | |
| *** jmcbride has quit IRC | 05:34 | |
| *** CaptTofu has joined #openstack-dns | 06:03 | |
| *** CaptTofu has quit IRC | 06:08 | |
| *** jorgem1 has joined #openstack-dns | 06:47 | |
| *** jorgem has quit IRC | 06:48 | |
| *** jorgem1 has quit IRC | 06:48 | |
| *** jorgem has joined #openstack-dns | 06:48 | |
| *** jorgem1 has joined #openstack-dns | 07:03 | |
| *** jorgem has quit IRC | 07:05 | |
| *** jorgem has joined #openstack-dns | 07:09 | |
| *** jorgem1 has quit IRC | 07:13 | |
| *** CaptTofu has joined #openstack-dns | 08:04 | |
| *** CaptTofu has quit IRC | 08:09 | |
| *** jorgem has quit IRC | 08:23 | |
| *** jorgem has joined #openstack-dns | 08:23 | |
| *** CaptTofu has joined #openstack-dns | 10:05 | |
| *** CaptTofu has quit IRC | 10:09 | |
| *** CaptTofu has joined #openstack-dns | 10:57 | |
| *** nosnos has quit IRC | 10:58 | |
| *** matsuhashi has quit IRC | 11:02 | |
| *** jmcbride has joined #openstack-dns | 11:29 | |
| *** jmcbride has quit IRC | 11:36 | |
| *** mwagner_lap has joined #openstack-dns | 13:11 | |
| *** CaptTofu has quit IRC | 13:19 | |
| *** mwagner_lap has quit IRC | 13:38 | |
| *** jmcbride has joined #openstack-dns | 13:44 | |
| *** nkinder has quit IRC | 14:13 | |
| *** eankutse has joined #openstack-dns | 14:24 | |
| *** rektide_ is now known as rektide | 14:41 | |
| *** CaptTofu has joined #openstack-dns | 14:50 | |
| *** vinod has joined #openstack-dns | 14:59 | |
| vinod | kiall: are you around? | 15:05 |
|---|---|---|
| *** richm has joined #openstack-dns | 15:06 | |
| *** nkinder has joined #openstack-dns | 15:06 | |
| kiall | vinod: Heya | 15:36 |
| vinod | Wanted to talk about the comments that you had regarding specific exceptions - https://review.openstack.org/#/c/75143 | 15:38 |
| vinod | To throw specific exceptions, I will need to duplicate the sort_dir check in storage | 15:38 |
| kiall | vinod: so, my thinking was, if a user gets a "value error", that's really confusing | 15:39 |
| vinod | # Limits are checked at the API layer. If however central or | 15:39 |
| vinod | # storage is called directly, invalid limits show up as | 15:39 |
| vinod | # ValueError | 15:39 |
| vinod | At the API layer I can throw InvalidLimit | 15:39 |
| kiall | https://review.openstack.org/#/c/75143/2/designate/api/v2/controllers/rest.py | 15:39 |
| kiall | L63 - could be switched to raise exceptions.InvalidLimit() | 15:40 |
| vinod | Yes I will be doing that | 15:40 |
| kiall | L65 to exceptions.InvalidSort() | 15:40 |
| kiall | Would that not cover it? | 15:40 |
| vinod | L65 should also be exceptions.InvalidLimit | 15:41 |
| vinod | Here we are checking only for invalid limit | 15:41 |
| vinod | sort_dir, marker and sort_key are checked here - https://review.openstack.org/#/c/75143/2/designate/storage/impl_sqlalchemy/__init__.py | 15:41 |
| vinod | Ideally I would like all the checks to be in storage at https://review.openstack.org/#/c/75143/2/designate/storage/impl_sqlalchemy/__init__.py | 15:42 |
| vinod | But all invalid limits are not caught there - and especially the rpc limit cannot be | 15:42 |
| vinod | so i moved just the limit checks to https://review.openstack.org/#/c/75143/2/designate/api/v2/controllers/rest.py | 15:42 |
| *** msisk has joined #openstack-dns | 15:42 | |
| vinod | http://pastebin.com/E3DZHXhD | 15:44 |
| kiall | Ah .. Humm .. Well, sort_dir and sort_key could be checked in the API | 15:47 |
| kiall | sort_dir is easy enough .. it's always asc or desc | 15:47 |
| kiall | sort_key could be checked against a per-controller list of valid sort keys | 15:48 |
| kiall | which gives a added bonus of allowing us to decide which keys can be used to sort against | 15:48 |
| kiall | (e.g. we probably don't want people sorting records by there value.. that's a sql blob after all) | 15:48 |
| vinod | having the checks in controller, implies, if you call central then the same checks are not done | 15:51 |
| *** artom has joined #openstack-dns | 15:51 | |
| kiall | Well - Most of our validation is already done like that (I think theres a BP or Bug re moving it around a bit) | 15:51 |
| kiall | I'm generally a fan of validating at the edges, and not letting crummy values get past the outermost layer. | 15:53 |
| kiall | The downside to that is.. When the validation isn't abstracted, you're stuck duplicating in in places.. Which sucks. | 15:53 |
| kiall | brb | 15:53 |
| artom | kiall, could validation moved into its own component/module? | 15:57 |
| kiall | So - I've been thinking about the pluggable record type stuff, which kinda merges into the structured rdata format stuff | 16:02 |
| kiall | I had a review up (it's expired..) that added classes for each of the record types | 16:02 |
| kiall | If we extended that to all our core objects.. Zones, RecordSets etc | 16:02 |
| kiall | then validations for everything have a neat home that can be used by all the layers | 16:02 |
| vinod | i will look at your review again - but from an initial glance it is a good idea | 16:11 |
| vinod | for now i will do the validations that i can in the api layer | 16:11 |
| *** jmcbride has quit IRC | 16:12 | |
| *** msisk_ has joined #openstack-dns | 16:14 | |
| *** msisk has quit IRC | 16:16 | |
| *** CaptTofu has quit IRC | 16:16 | |
| *** jmcbride has joined #openstack-dns | 16:17 | |
| kiall | vinod: yea, I think it's the right way to fix it, we only really thought of making the switch for everything a day or two ago.. So haven't had time to actually see how much effort it would be | 16:19 |
| kiall | I suspect not much .. Since we can make our Objects behave just like the dicts and lists our Storage layer returns today... Hopefully meaning virtually no changes outside the storage layer for the initial switch | 16:20 |
| *** vinod has quit IRC | 16:26 | |
| *** jmcbride has quit IRC | 16:27 | |
| *** CaptTofu has joined #openstack-dns | 16:30 | |
| *** vinod has joined #openstack-dns | 16:32 | |
| *** jmcbride has joined #openstack-dns | 16:34 | |
| ekarlso | kiall: yo | 16:35 |
| ekarlso | you guys around ? | 16:36 |
| kiall | Yep | 16:36 |
| ekarlso | what's the paging fuzz about ? | 16:37 |
| kiall | You missed a few things ;) | 16:37 |
| kiall | (And we missed them in testing) | 16:38 |
| kiall | Read the commit, you'll see | 16:38 |
| ekarlso | kk | 16:39 |
| ekarlso | a q though | 16:40 |
| ekarlso | since we have a storage layer | 16:40 |
| ekarlso | why don't we have a model layer since we're supposed to have "pluggable" storage? | 16:40 |
| kiall | lol .. scroll up about 10 lines | 16:41 |
| ekarlso | oh ok | 16:41 |
| ekarlso | you working on thaet ? | 16:41 |
| kiall | Nobody is working on it .. Because we haven't decided A) if it's a good idea (Okay, it probably is) and B) if the change should be rushed into icehouse (It probably shouldn't be) | 16:44 |
| vinod | #agree on doing this after icehouse | 16:46 |
| ekarlso | yeah, do we semi-know what approach we wanna have ? | 16:47 |
| ekarlso | as in just models or the nova objects thing | 16:47 |
| kiall | ekarlso: please don't go starting it ;) | 16:47 |
| ekarlso | kiall: no, I won't, just wondering to make a "initial bp" for juno | 16:47 |
| ekarlso | then at least it's noted down somewher | 16:48 |
| kiall | No approach has been thought through .. other than 15:52 <kiall> I had a review up (it's expired..) that added classes for each of the record types | 16:48 |
| ekarlso | ok : ) | 16:48 |
| kiall | But - It didn't really aim to be this, it just triggered the idea | 16:48 |
| ekarlso | Ok if I add a BP though in draft so we have it noted down somewhere? | 16:49 |
| kiall | No, not right now | 16:49 |
| ekarlso | ok ! :) | 16:50 |
| kiall | I'll write up a BP once the idea's actually been thought through a little more than "Gee, this might just solve some problems for us" ;) | 16:50 |
| ekarlso | :) | 16:50 |
| kiall | You get anywhere with bug | 16:51 |
| kiall | #1282672 today? | 16:51 |
| ekarlso | yeah | 16:51 |
| ekarlso | gonna push in an our : ) | 16:51 |
| ekarlso | just adding tests also tio it : p | 16:51 |
| *** jmcbride has quit IRC | 16:52 | |
| *** jmcbride has joined #openstack-dns | 16:52 | |
| vinod | ekarlso: is 1282672 different from 1282682? | 16:52 |
| vinod | Is this for checking the UUIDs in the actual URL as opposed to marker? | 16:53 |
| ekarlso | vinod: yes | 16:53 |
| *** betsy has joined #openstack-dns | 16:55 | |
| *** nkinder has quit IRC | 17:04 | |
| *** jmcbride has quit IRC | 17:18 | |
| *** nkinder has joined #openstack-dns | 17:20 | |
| *** jorgem has joined #openstack-dns | 17:24 | |
| *** elemecca has joined #openstack-dns | 17:36 | |
| *** jmcbride has joined #openstack-dns | 18:04 | |
| vinod | kiall: In the api tests, is there a way to assert that I need to get an InvalidLimit exception (from the api and not central), rather than just a 400? | 18:14 |
| vinod | with testtools.ExpectedException() fails | 18:15 |
| vinod | AssertionError: InvalidLimit not raised. | 18:15 |
| kiall | You can check the type filed in the response == 'invalid_limit' | 18:24 |
| kiall | But, the API catches the exceptions and converts them.. so assertRaises and ExpectedException won't work | 18:25 |
| kiall | field* | 18:25 |
| *** tsimmons has joined #openstack-dns | 18:25 | |
| tsimmons | kiall: How would you go about writing out the bind configs in the devstack script? | 18:27 |
| *** msisk_ has quit IRC | 18:27 | |
| kiall | tsimmons: heya | 18:28 |
| kiall | It depends really, if the files are going to be 99% the same on Ubuntu 12, Ubuntu 14, Fedora 18, Fedora 19 etc etc, then a bash HEREDOC with some variables for path differences etc should work | 18:30 |
| kiall | If there really different, then a if is_ubuntu; then render HEREDOC; else; EXPLODE; fi would be better, as it will at least shout at people that their OS needs to be implemented | 18:31 |
| tsimmons | Right, I've never tried to install bind on anything other than Ubuntu/Debian. Not sure how it differs. | 18:31 |
| kiall | Ah .. Then go with the "blow up if it's not ubuntu" pattern, and the current stuff (or rendering the entire config) should do the trick ;) | 18:33 |
| tsimmons | Alright, will do :) i don't think it's much different, I could look into it, but I'll fix that up. Thank you :) | 18:33 |
| kiall | Gotta run.. Cyas later | 18:34 |
| tsimmons | See ya, thanks again. | 18:34 |
| *** jmcbride has quit IRC | 18:34 | |
| *** jmcbride has joined #openstack-dns | 18:35 | |
| openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: Handle invalid pagination parameters https://review.openstack.org/75143 | 18:48 |
| *** tsimmons has quit IRC | 19:00 | |
| *** jorgem1 has joined #openstack-dns | 19:05 | |
| *** jorgem has quit IRC | 19:08 | |
| *** msisk has joined #openstack-dns | 19:22 | |
| *** msisk has quit IRC | 19:23 | |
| *** msisk has joined #openstack-dns | 19:33 | |
| *** msisk has quit IRC | 19:34 | |
| *** jmcbride has quit IRC | 19:42 | |
| *** sn6i23a has joined #openstack-dns | 19:47 | |
| *** vinod has quit IRC | 20:12 | |
| *** jmcbride has joined #openstack-dns | 20:13 | |
| *** msisk has joined #openstack-dns | 20:13 | |
| *** msisk has quit IRC | 20:14 | |
| *** msisk has joined #openstack-dns | 20:14 | |
| *** tsimmons has joined #openstack-dns | 20:20 | |
| *** jorgem1 has quit IRC | 20:28 | |
| openstackgerrit | Tim Simmons proposed a change to stackforge/designate: Add Bind9 Support to the DevStack Plugin https://review.openstack.org/75222 | 20:39 |
| *** jorgem has joined #openstack-dns | 20:40 | |
| *** vinod has joined #openstack-dns | 20:42 | |
| openstackgerrit | Tim Simmons proposed a change to stackforge/designate: Add Bind9 Support to the DevStack Plugin https://review.openstack.org/75222 | 20:48 |
| *** ekarlso has quit IRC | 20:50 | |
| *** ekarlso has joined #openstack-dns | 20:50 | |
| *** eankutse has quit IRC | 21:06 | |
| *** tsimmons has quit IRC | 21:11 | |
| *** tsimmons has joined #openstack-dns | 21:25 | |
| *** jmcbride1 has joined #openstack-dns | 21:27 | |
| *** jmcbride has quit IRC | 21:27 | |
| *** tsimmons has left #openstack-dns | 21:30 | |
| *** vinod1 has joined #openstack-dns | 21:36 | |
| *** vinod has quit IRC | 21:36 | |
| *** vinod has joined #openstack-dns | 21:38 | |
| *** vinod1 has quit IRC | 21:41 | |
| *** CaptTofu has quit IRC | 22:10 | |
| *** msisk has quit IRC | 22:12 | |
| *** CaptTofu has joined #openstack-dns | 22:12 | |
| *** msisk has joined #openstack-dns | 22:13 | |
| *** jorgem has quit IRC | 22:39 | |
| *** jorgem has joined #openstack-dns | 22:41 | |
| *** vinod has quit IRC | 22:42 | |
| *** betsy has quit IRC | 22:44 | |
| *** jmcbride1 has quit IRC | 22:47 | |
| *** CaptTofu has quit IRC | 22:54 | |
| *** jmcbride has joined #openstack-dns | 23:03 | |
| *** jorgem1 has joined #openstack-dns | 23:07 | |
| *** jorgem1 has quit IRC | 23:08 | |
| *** jorgem has quit IRC | 23:09 | |
| *** artom has quit IRC | 23:11 | |
| *** richm has quit IRC | 23:25 | |
| *** nkinder has quit IRC | 23:38 | |
| *** richm has joined #openstack-dns | 23:39 | |
| *** msisk has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!