| *** vinod has joined #openstack-dns | 00:01 | |
| *** jorgem1 has quit IRC | 00:15 | |
| *** rossk has quit IRC | 00:23 | |
| *** nkinder_ has joined #openstack-dns | 00:24 | |
| *** matsuhashi has joined #openstack-dns | 00:26 | |
| *** HenryG_ has quit IRC | 00:32 | |
| *** richm has quit IRC | 00:41 | |
| *** CaptTofu has joined #openstack-dns | 00:51 | |
| *** rmoe has quit IRC | 00:52 | |
| *** ytwu has quit IRC | 00:56 | |
| *** puck has quit IRC | 00:56 | |
| *** mugsie has quit IRC | 00:57 | |
| *** rektide has quit IRC | 00:57 | |
| *** kiall has quit IRC | 00:57 | |
| *** zigo has quit IRC | 00:58 | |
| *** ytwu1 has joined #openstack-dns | 00:58 | |
| *** puck` has joined #openstack-dns | 00:58 | |
| *** mugsie_ has joined #openstack-dns | 00:58 | |
| *** CaptTofu has quit IRC | 00:58 | |
| *** vinod has quit IRC | 00:58 | |
| *** openstack has joined #openstack-dns | 01:04 | |
| *** ChanServ sets mode: +v openstack | 01:04 | |
| *** rmoe has joined #openstack-dns | 01:07 | |
| *** zigo has quit IRC | 01:27 | |
| *** zigo has joined #openstack-dns | 01:33 | |
| *** nosnos has joined #openstack-dns | 01:39 | |
| *** matsuhashi has quit IRC | 01:58 | |
| *** HenryG has joined #openstack-dns | 02:12 | |
| *** matsuhashi has joined #openstack-dns | 02:17 | |
| *** zigo has quit IRC | 02:19 | |
| *** zigo has joined #openstack-dns | 02:23 | |
| *** vinod has joined #openstack-dns | 02:30 | |
| *** ctracey has quit IRC | 02:51 | |
| *** ctracey has joined #openstack-dns | 02:51 | |
| *** CaptTofu has joined #openstack-dns | 02:52 | |
| *** eankutse has joined #openstack-dns | 02:54 | |
| *** CaptTofu has quit IRC | 02:57 | |
| *** eankutse has quit IRC | 03:03 | |
| *** CaptTofu has joined #openstack-dns | 03:23 | |
| *** matsuhashi has quit IRC | 03:23 | |
| *** vinod has quit IRC | 03:36 | |
| *** CaptTofu has quit IRC | 04:24 | |
| *** matsuhashi has joined #openstack-dns | 04:25 | |
| *** timfreund has quit IRC | 04:52 | |
| *** eankutse has joined #openstack-dns | 05:06 | |
| *** timfreund has joined #openstack-dns | 05:21 | |
| *** pravka has joined #openstack-dns | 05:26 | |
| *** eankutse has quit IRC | 05:28 | |
| *** eankutse has joined #openstack-dns | 05:28 | |
| *** eankutse has quit IRC | 05:34 | |
| *** CaptTofu has joined #openstack-dns | 06:00 | |
| *** pravka has quit IRC | 06:07 | |
| *** zoresvit1 has joined #openstack-dns | 06:17 | |
| *** CaptTofu has quit IRC | 07:35 | |
| *** zoresvit1 has quit IRC | 07:53 | |
| *** matsuhashi has quit IRC | 08:21 | |
| *** ekarlso has quit IRC | 08:47 | |
| *** ekarlso has joined #openstack-dns | 08:47 | |
| *** puck` is now known as puck | 09:19 | |
| *** CaptTofu has joined #openstack-dns | 09:32 | |
| *** CaptTofu has quit IRC | 09:37 | |
| *** vinod has joined #openstack-dns | 10:20 | |
| *** mugsie_ has quit IRC | 10:36 | |
| *** JensOfSweden has joined #openstack-dns | 10:53 | |
| *** mugsie has joined #openstack-dns | 11:07 | |
| *** vinod has quit IRC | 11:15 | |
| *** CaptTofu has joined #openstack-dns | 11:24 | |
| *** ChanServ changes topic to "test/gate jobs are queuing now in preparation for gerrit maintenance at 12:00 utc (eta to resume is 12:30 utc)" | 11:27 | |
| *** CaptTofu has quit IRC | 11:28 | |
| *** CaptTofu has joined #openstack-dns | 11:38 | |
| *** mwagner_lap has quit IRC | 11:59 | |
| openstackstatus | NOTICE: gerrit on review.openstack.org is down for maintenance (eta to resume is 12:30 utc) | 12:06 |
|---|---|---|
| openstackstatus | NOTICE: gerrit on review.openstack.org is down for maintenance (revised eta to resume is 13:00 utc) | 12:24 |
| *** ChanServ changes topic to "gerrit on review.openstack.org is down for maintenance (revised eta to resume is 13:00 utc)" | 12:24 | |
| *** artom has joined #openstack-dns | 12:45 | |
| *** ChanServ changes topic to "Openstack DNS / Designate - https://wiki.openstack.org/wiki/Designate/Blueprints/Meetings/12-2013 | Weekly meet on Wednesdays @ 1700 UTC https://launchpad.net/designate - https://github.com/stackforge/designate - https://designate.readthedocs.org/ - This room is logged (http://eavesdrop.openstack.org/irclogs/)" | 12:45 | |
| openstackgerrit | A change was merged to stackforge/designate: Support more record types https://review.openstack.org/79588 | 12:47 |
| *** CaptTofu has quit IRC | 12:47 | |
| *** CaptTofu has joined #openstack-dns | 12:47 | |
| *** CaptTofu has quit IRC | 12:52 | |
| *** openstackgerrit has quit IRC | 12:54 | |
| *** openstackgerrit has joined #openstack-dns | 12:54 | |
| *** ChanServ sets mode: +v openstackgerrit | 12:54 | |
| *** openstackgerrit has quit IRC | 13:08 | |
| *** openstackgerrit has joined #openstack-dns | 13:08 | |
| *** ChanServ sets mode: +v openstackgerrit | 13:08 | |
| *** eankutse has joined #openstack-dns | 13:32 | |
| *** eankutse has quit IRC | 13:33 | |
| *** eankutse has joined #openstack-dns | 13:33 | |
| *** CaptTofu has joined #openstack-dns | 13:34 | |
| *** nosnos has quit IRC | 13:43 | |
| openstackgerrit | A change was merged to stackforge/designate: create_server fails if server is not unique https://review.openstack.org/79455 | 13:46 |
| *** matsuhashi has joined #openstack-dns | 13:50 | |
| *** matsuhashi has quit IRC | 13:56 | |
| *** fungi has joined #openstack-dns | 13:59 | |
| *** fungi has left #openstack-dns | 13:59 | |
| *** matsuhashi has joined #openstack-dns | 14:00 | |
| *** mwagner_lap has joined #openstack-dns | 14:01 | |
| *** openstack has joined #openstack-dns | 14:04 | |
| *** ChanServ sets mode: +v openstack | 14:04 | |
| *** ttrumm has joined #openstack-dns | 14:12 | |
| *** jmcbride has joined #openstack-dns | 14:21 | |
| *** matsuhashi has quit IRC | 14:23 | |
| *** matsuhashi has joined #openstack-dns | 14:30 | |
| *** jmcbride has quit IRC | 14:32 | |
| *** tsimmons has joined #openstack-dns | 14:32 | |
| *** msisk has joined #openstack-dns | 14:33 | |
| *** jmcbride has joined #openstack-dns | 14:39 | |
| *** jmcbride has joined #openstack-dns | 14:39 | |
| *** richm has joined #openstack-dns | 15:08 | |
| richm | question about backends - is create_tsigkey/update_tsigkey supposed to do anything other than create/update a TSIG RR? | 15:09 |
| *** jmcbride has quit IRC | 15:15 | |
| *** jmcbride has joined #openstack-dns | 15:18 | |
| *** matsuhashi has quit IRC | 15:18 | |
| *** jmcbride has quit IRC | 15:30 | |
| *** jmcbride has joined #openstack-dns | 15:35 | |
| *** eankutse has quit IRC | 15:37 | |
| *** vinod has joined #openstack-dns | 15:55 | |
| tsimmons | Is it cool if I blow away last meetings agenda and start a new one for today? | 15:56 |
| richm | does the wiki keep track of page history? | 15:59 |
| *** jmcbride has quit IRC | 15:59 | |
| *** CaptTofu has quit IRC | 16:00 | |
| *** CaptTofu has joined #openstack-dns | 16:01 | |
| mugsie | richm: yup | 16:02 |
| mugsie | tsimmons: go for it | 16:02 |
| tsimmons | mugsie: cool | 16:03 |
| *** rmoe has quit IRC | 16:04 | |
| *** CaptTofu has quit IRC | 16:05 | |
| *** betsy has joined #openstack-dns | 16:06 | |
| *** pravka has joined #openstack-dns | 16:09 | |
| *** ttrumm has quit IRC | 16:10 | |
| *** vinod has quit IRC | 16:20 | |
| *** rossk has joined #openstack-dns | 16:26 | |
| *** vinod has joined #openstack-dns | 16:27 | |
| *** rmoe has joined #openstack-dns | 16:29 | |
| *** CaptTofu has joined #openstack-dns | 16:30 | |
| *** eankutse has joined #openstack-dns | 16:41 | |
| *** eankutse has quit IRC | 16:42 | |
| *** eankutse has joined #openstack-dns | 16:42 | |
| *** rjrjr__ has joined #openstack-dns | 16:57 | |
| *** sballe has joined #openstack-dns | 17:03 | |
| *** msisk has quit IRC | 17:05 | |
| *** sballe has quit IRC | 17:10 | |
| *** artom has quit IRC | 17:13 | |
| *** jmcbride has joined #openstack-dns | 17:16 | |
| *** artom has joined #openstack-dns | 17:24 | |
| *** msisk has joined #openstack-dns | 17:24 | |
| *** pravka has quit IRC | 17:30 | |
| *** openstackstatus has quit IRC | 17:38 | |
| *** openstackstatus has joined #openstack-dns | 17:38 | |
| *** rmoe_ has joined #openstack-dns | 17:50 | |
| *** rmoe has quit IRC | 17:51 | |
| *** crc32 has joined #openstack-dns | 18:04 | |
| vinod | kiall: Let me know when you have some time to talk about bug 1291518 | 18:06 |
| vinod | For v2, at least, I think the issue is in the load function where we allow id in the list of fields | 18:06 |
| kiall | vinod: graham is verifying it right now, seems to exist in pre-v2 too | 18:06 |
| vinod | Yes it is present in v1 too as I mentioned in the bug | 18:07 |
| kiall | I mean, it was present in v1 since before any of the v2 stuff was merged | 18:08 |
| vinod | ok | 18:08 |
| kiall | vinod: for V2, I think you're correct. Removing those items from load looks like it will do what we need | 18:09 |
| kiall | I'm just looking into how that will affect V2 updates | 18:10 |
| kiall | We currently: | 18:11 |
| kiall | 1) Fetch the existing zone | 18:11 |
| kiall | 2) Convert it to the V2 structure | 18:11 |
| kiall | 3) Merge the supplied body and converted structure | 18:11 |
| kiall | 4) Convert back to Central's format (i.e. V1) | 18:12 |
| kiall | 5) Issue the update | 18:12 |
| kiall | #4 is where load get's called | 18:13 |
| kiall | I believe all that will continue to work when load discards the fields we don't want people editing | 18:13 |
| vinod | so we need not specify id at step 4? | 18:14 |
| kiall | No, I think if 4 discards the id/created/updated fields.. We're still good. Those aren't necessary as part of the update call to central | 18:15 |
| kiall | in V1, We'll need to add something similar - since it doesn't discard anything today. | 18:16 |
| kiall | I'm going to tackle V1 in the next hour or so, if you want to fixup V2? We need to push a fix for this pretty quick ;) | 18:17 |
| kiall | (even if it doesn't look like it can be abused, now that it's known, people better at breaking things than I will aim at us) | 18:18 |
| vinod | sure i will fix v2 | 18:19 |
| vinod | i am also planning to raise a BadRequest if you specify fields like id, created_at etc fields in the POST body | 18:20 |
| kiall | Actually - Thinking about how to fix this in v1.. lol. snap | 18:21 |
| kiall | We've always had these kinda things in the schemas - But they've always just been informative hints rather than anything enforced: | 18:22 |
| kiall | https://github.com/stackforge/designate/blob/master/designate/resources/schemas/v2/recordset.json | 18:22 |
| kiall | L23 and L29 | 18:22 |
| kiall | I'm wondering if we can/should find a way to use that data to handle the enforcement | 18:22 |
| vinod | you mean if the json field is readOnly then do not allow create/modify in v1 api | 18:23 |
| kiall | Yea, so.. If it's readOnly and present in a create - 400. If it's readOnly or immutable and present in an update, 400 if the supplied value differs from it's current value | 18:25 |
| kiall | (That conversation we had amount model objects to represent domains etc would be the ideal place for this kinda logic ;)) | 18:25 |
| vinod | yeah - agreed what you suggest currently looks like the cleanest way to validate the fields | 18:27 |
| *** msisk has quit IRC | 18:29 | |
| kiall | https://github.com/stackforge/designate/blob/master/designate/schema/__init__.py#L59 | 18:29 |
| kiall | That could be extended to take an existing object, for the immutable / readOnly on update change thing | 18:30 |
| kiall | And if no existing object is supplied, then the presence of a readOnly field would be a failure | 18:30 |
| kiall | And - They possibly could be implement as (kinda) part of the jsonschema lib itself.. e.g. heres what happens with "minimum": 100 in a schema; | 18:32 |
| kiall | https://github.com/Julian/jsonschema/blob/v2.3.0/jsonschema/_validators.py#L93 | 18:32 |
| *** jmcbride1 has joined #openstack-dns | 18:32 | |
| *** eankutse has quit IRC | 18:32 | |
| kiall | we already implement some custom (well - backported) ones in Designate: https://github.com/stackforge/designate/blob/master/designate/schema/_validators.py | 18:32 |
| kiall | The trick would be figuring out how to pass some context (to existing object) in there | 18:34 |
| *** jmcbride has quit IRC | 18:34 | |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Remove JSONSchema 1.3 compatibility code https://review.openstack.org/80048 | 18:42 |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Remove JSONSchema 1.3 compatibility code https://review.openstack.org/80048 | 18:42 |
| *** eankutse has joined #openstack-dns | 18:44 | |
| kiall | Okay - Scratch that, we can't pass the necessary context through jsonschema. | 18:58 |
| kiall | I might see if I can set ekarlso on working with upstream jsonshema to get that added in a future version... | 18:58 |
| *** jorgem has joined #openstack-dns | 19:21 | |
| *** artom has joined #openstack-dns | 19:23 | |
| *** jmcbride1 has quit IRC | 19:43 | |
| *** tsimmons has left #openstack-dns | 19:43 | |
| *** vinod has quit IRC | 20:00 | |
| *** vinod has joined #openstack-dns | 20:20 | |
| *** bauruine has quit IRC | 20:23 | |
| *** bauruine has joined #openstack-dns | 20:23 | |
| *** nkinder_ has quit IRC | 20:41 | |
| openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: Ensure that request body contains valid fields https://review.openstack.org/80076 | 20:44 |
| vinod | I separated out v1 and v2 issues to separate bugs to handle them differently. This is for v2 | 20:44 |
| openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: Ensure that request body in v2 contains valid fields https://review.openstack.org/80076 | 20:45 |
| *** jmcbride has joined #openstack-dns | 20:54 | |
| *** nkinder has joined #openstack-dns | 21:01 | |
| *** vinod has quit IRC | 21:06 | |
| *** jmcbride has quit IRC | 21:16 | |
| *** eankutse has quit IRC | 21:17 | |
| *** jmcbride has joined #openstack-dns | 21:18 | |
| *** vinod has joined #openstack-dns | 21:24 | |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Remove JSONSchema 1.3 compatibility code https://review.openstack.org/80048 | 21:30 |
| *** eankutse has joined #openstack-dns | 21:36 | |
| *** eankutse has quit IRC | 21:36 | |
| *** eankutse has joined #openstack-dns | 21:37 | |
| *** CaptTofu has quit IRC | 21:44 | |
| *** pravka has joined #openstack-dns | 21:45 | |
| vinod | kiall: Is code change https://review.openstack.org/#/c/80048/ still helpful? | 21:45 |
| *** jmcbride has quit IRC | 21:50 | |
| *** mwagner_lap has quit IRC | 22:04 | |
| *** timfreund has quit IRC | 22:08 | |
| openstackgerrit | Vinod Mangalpally proposed a change to stackforge/designate: Ensure that request body in v2 contains valid fields https://review.openstack.org/80076 | 22:12 |
| ekarlso | kiall: what's up ? | 22:14 |
| *** artom has quit IRC | 22:19 | |
| *** eankutse has quit IRC | 22:23 | |
| *** vinod has quit IRC | 22:23 | |
| *** eankutse has joined #openstack-dns | 22:31 | |
| *** crc32 has quit IRC | 22:36 | |
| *** nkinder has quit IRC | 22:40 | |
| *** timfreund has joined #openstack-dns | 22:42 | |
| *** nkinder has joined #openstack-dns | 22:47 | |
| *** crc32 has joined #openstack-dns | 22:50 | |
| *** jorgem has quit IRC | 23:13 | |
| *** nkinder has quit IRC | 23:13 | |
| *** nkinder has joined #openstack-dns | 23:28 | |
| *** betsy has quit IRC | 23:35 | |
| *** CaptTofu has joined #openstack-dns | 23:46 | |
| *** eankutse has quit IRC | 23:46 | |
| *** CaptTofu has quit IRC | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!