*** sbfox has quit IRC | 00:08 | |
*** jmcbride has joined #openstack-dns | 00:11 | |
*** jmcbride has quit IRC | 00:16 | |
*** rmoe has quit IRC | 00:29 | |
*** CaptTofu has joined #openstack-dns | 00:40 | |
*** rmoe has joined #openstack-dns | 00:53 | |
*** CaptTofu has quit IRC | 00:59 | |
*** eankutse has joined #openstack-dns | 01:10 | |
*** jmcbride has joined #openstack-dns | 01:11 | |
*** crc32 has quit IRC | 01:13 | |
*** jmcbride has quit IRC | 01:15 | |
*** nosnos has joined #openstack-dns | 01:33 | |
*** eankutse has quit IRC | 01:40 | |
*** sbfox has joined #openstack-dns | 02:03 | |
*** sbfox has quit IRC | 02:07 | |
*** amarao has quit IRC | 02:32 | |
*** vinod1 has joined #openstack-dns | 02:40 | |
*** eankutse has joined #openstack-dns | 02:50 | |
*** eankutse has quit IRC | 02:50 | |
*** eankutse has joined #openstack-dns | 02:50 | |
*** matsuhas_ has joined #openstack-dns | 02:53 | |
*** matsuhashi has quit IRC | 02:53 | |
*** matsuhas_ has quit IRC | 02:54 | |
*** eankutse1 has joined #openstack-dns | 02:56 | |
*** matsuhashi has joined #openstack-dns | 02:56 | |
*** eankutse has quit IRC | 02:56 | |
*** eankutse1 has quit IRC | 03:00 | |
*** matsuhashi has quit IRC | 03:02 | |
*** matsuhashi has joined #openstack-dns | 03:04 | |
*** vinod1 has quit IRC | 03:08 | |
*** scrull has joined #openstack-dns | 03:11 | |
*** msisk has joined #openstack-dns | 03:12 | |
*** nosnos has quit IRC | 03:17 | |
*** matsuhashi has quit IRC | 04:01 | |
*** scrull has quit IRC | 04:03 | |
*** matsuhashi has joined #openstack-dns | 04:05 | |
*** shinshila has joined #openstack-dns | 04:10 | |
*** sbfox has joined #openstack-dns | 04:19 | |
*** nosnos has joined #openstack-dns | 04:20 | |
*** CaptTofu has joined #openstack-dns | 05:29 | |
*** CaptTofu has quit IRC | 05:56 | |
*** ttrumm has joined #openstack-dns | 06:12 | |
*** shinshila has quit IRC | 06:57 | |
*** matsuhashi has quit IRC | 07:07 | |
*** matsuhashi has joined #openstack-dns | 08:04 | |
*** ttrumm has quit IRC | 08:06 | |
*** ttrumm has joined #openstack-dns | 08:07 | |
ekarlso | for those who want | 08:21 |
---|---|---|
ekarlso | https://review.openstack.org/#/c/85175/ | 08:21 |
ekarlso | oslo.messaging change | 08:21 |
*** matsuhashi has quit IRC | 08:35 | |
*** matsuhashi has joined #openstack-dns | 08:53 | |
*** matsuhashi has quit IRC | 09:47 | |
*** matsuhashi has joined #openstack-dns | 09:47 | |
*** matsuhashi has quit IRC | 10:23 | |
*** matsuhashi has joined #openstack-dns | 10:30 | |
*** nosnos has quit IRC | 10:33 | |
*** matsuhashi has quit IRC | 10:38 | |
*** nosnos has joined #openstack-dns | 10:39 | |
*** matsuhas_ has joined #openstack-dns | 10:41 | |
*** matsuhas_ has quit IRC | 10:52 | |
*** matsuhashi has joined #openstack-dns | 10:52 | |
*** matsuhashi has quit IRC | 10:57 | |
*** jmcbride has joined #openstack-dns | 11:15 | |
*** mwagner_lap has quit IRC | 11:22 | |
*** nosnos has quit IRC | 11:30 | |
*** eankutse has joined #openstack-dns | 11:35 | |
openstackgerrit | A change was merged to stackforge/designate: WIP - Implement Capture the Notification Context in Designate Sink https://review.openstack.org/82667 | 11:50 |
*** jmcbride has quit IRC | 11:57 | |
*** mwagner_lap has joined #openstack-dns | 12:03 | |
*** eankutse has quit IRC | 12:03 | |
ekarlso | happy reviewing the oslo change ;p | 12:11 |
*** jmcbride has joined #openstack-dns | 12:18 | |
*** jmcbride has quit IRC | 12:22 | |
ekarlso | mugsie: thansk for the fast comments : p | 12:26 |
*** jmcbride has joined #openstack-dns | 12:27 | |
*** vinod1 has joined #openstack-dns | 12:31 | |
mugsie | ekarlso: np ;) | 12:31 |
*** jmcbride has quit IRC | 12:32 | |
mugsie | just a quick look though, I will run full testing over the weekend | 12:32 |
*** eankutse has joined #openstack-dns | 12:35 | |
ekarlso | :P | 12:38 |
ekarlso | big change :/ | 12:38 |
*** eankutse has quit IRC | 12:38 | |
*** eankutse has joined #openstack-dns | 12:39 | |
*** eankutse has quit IRC | 12:42 | |
mugsie | yup | 12:44 |
*** sballe has quit IRC | 12:46 | |
*** sballe has joined #openstack-dns | 12:47 | |
*** CaptTofu has joined #openstack-dns | 12:52 | |
*** vinod1 has quit IRC | 12:52 | |
*** jmcbride has joined #openstack-dns | 12:53 | |
*** CaptTofu has quit IRC | 13:07 | |
*** CaptTofu has joined #openstack-dns | 13:17 | |
*** sballe has quit IRC | 13:18 | |
*** sballe has joined #openstack-dns | 13:18 | |
*** vinod has joined #openstack-dns | 13:26 | |
*** eankutse has joined #openstack-dns | 13:29 | |
vinod | kiall: Did you get a chance to look at https://review.openstack.org/#/c/84247/? | 13:30 |
*** eankutse has quit IRC | 13:30 | |
*** eankutse has joined #openstack-dns | 13:31 | |
vinod | I wanted to make sure that this would meet our needs before proceeding further with other objects | 13:31 |
Kiall | vinod: heya | 13:36 |
Kiall | I did - Looks good, | 13:36 |
Kiall | It should give us the base to add more functionality to the objects in the rest of the BPs :) | 13:37 |
Kiall | Also - You note in the commit message that the API still sees dicts - since it's a designate class now, rather than sqlalchemy's, oslo.rpc will pass the object over... | 13:37 |
Kiall | rjrjr: I see you upset the review gods :D | 13:37 |
vinod | kiall let me verify that api gets the object and not a dict | 13:39 |
vinod | In nova code there seems to be a bunch of code to let rpc handle objects | 13:39 |
vinod | I am not sure if we need something similar | 13:39 |
vinod | Also any suggestions in getting this to be more elegant without provoking flake8 - https://review.openstack.org/#/c/84247/3/designate/objects/__init__.py | 13:40 |
Kiall | You can import normally, then add "# noqa" to the end of the line to tell flake8 to ignore.. While that's better, it still feels wrong :) | 13:45 |
*** richm has joined #openstack-dns | 13:54 | |
*** ttrumm has quit IRC | 13:55 | |
*** vinod has quit IRC | 14:07 | |
*** jmcbride has quit IRC | 14:08 | |
*** jmcbride has joined #openstack-dns | 14:14 | |
*** vinod has joined #openstack-dns | 14:16 | |
*** msisk has quit IRC | 14:30 | |
*** msisk has joined #openstack-dns | 14:33 | |
*** vinod has quit IRC | 14:33 | |
*** vinod has joined #openstack-dns | 14:33 | |
*** vinod has quit IRC | 14:55 | |
*** jmcbride has quit IRC | 15:01 | |
*** jmcbride has joined #openstack-dns | 15:02 | |
*** CaptTofu has quit IRC | 15:04 | |
*** rmoe has quit IRC | 15:04 | |
*** jmcbride has quit IRC | 15:24 | |
*** jmcbride has joined #openstack-dns | 15:24 | |
*** vinod has joined #openstack-dns | 15:36 | |
*** eankutse has quit IRC | 15:38 | |
*** sbfox1 has joined #openstack-dns | 15:42 | |
*** sbfox has quit IRC | 15:43 | |
*** jmcbride has quit IRC | 15:54 | |
*** rmoe has joined #openstack-dns | 15:58 | |
*** vinod has quit IRC | 15:58 | |
*** jmcbride has joined #openstack-dns | 16:01 | |
*** vinod has joined #openstack-dns | 16:08 | |
*** sbfox1 has quit IRC | 16:16 | |
*** vinod has quit IRC | 16:16 | |
*** vinod has joined #openstack-dns | 16:17 | |
*** eankutse has joined #openstack-dns | 16:17 | |
*** jmcbride has quit IRC | 16:23 | |
*** crc32 has joined #openstack-dns | 16:50 | |
*** vinod has quit IRC | 16:53 | |
*** jmcbride has joined #openstack-dns | 16:53 | |
*** jmcbride has quit IRC | 16:55 | |
*** jmcbride1 has joined #openstack-dns | 16:55 | |
*** vinod has joined #openstack-dns | 16:58 | |
*** vinod has quit IRC | 17:25 | |
*** eankutse has quit IRC | 17:27 | |
*** eankutse has joined #openstack-dns | 17:27 | |
*** eankutse has quit IRC | 17:31 | |
*** eankutse has joined #openstack-dns | 17:31 | |
*** vinod has joined #openstack-dns | 17:33 | |
*** CaptTofu has joined #openstack-dns | 17:36 | |
*** vinod has quit IRC | 17:41 | |
*** CaptTofu has quit IRC | 17:42 | |
*** CaptTofu has joined #openstack-dns | 17:42 | |
*** CaptTofu has quit IRC | 17:47 | |
*** eankutse has quit IRC | 17:51 | |
*** eankutse has joined #openstack-dns | 17:52 | |
*** jmcbride1 has quit IRC | 18:01 | |
*** openstackgerrit has quit IRC | 18:01 | |
*** openstackgerrit has joined #openstack-dns | 18:02 | |
*** ChanServ sets mode: +v openstackgerrit | 18:02 | |
*** jmcbride has joined #openstack-dns | 18:29 | |
*** jmcbride has quit IRC | 18:32 | |
*** jmcbride has joined #openstack-dns | 18:34 | |
*** jmcbride has quit IRC | 18:59 | |
*** jmcbride has joined #openstack-dns | 19:18 | |
*** CaptTofu has joined #openstack-dns | 19:35 | |
*** CaptTofu has quit IRC | 19:36 | |
*** CaptTofu has joined #openstack-dns | 19:37 | |
*** CaptTofu has quit IRC | 19:41 | |
*** CaptTofu has joined #openstack-dns | 19:45 | |
*** sballe has quit IRC | 19:57 | |
*** sballe has joined #openstack-dns | 19:57 | |
*** vinod has joined #openstack-dns | 20:10 | |
*** vinod has quit IRC | 20:14 | |
*** CaptTofu has quit IRC | 20:16 | |
*** CaptTofu has joined #openstack-dns | 20:16 | |
*** vinod has joined #openstack-dns | 20:16 | |
*** vinod has joined #openstack-dns | 20:17 | |
*** CaptTofu has quit IRC | 20:20 | |
*** CaptTofu has joined #openstack-dns | 20:21 | |
*** CaptTofu has quit IRC | 20:24 | |
*** vinod has quit IRC | 20:43 | |
*** vinod has joined #openstack-dns | 20:46 | |
vinod | kiall: I verified that with the latest change (https://review.openstack.org/#/c/84247/), oslo.rpc returns dict. So api has a dict and not the object | 21:03 |
*** vinod has quit IRC | 21:11 | |
*** jmcbride has quit IRC | 21:14 | |
*** mwagner_lap has quit IRC | 21:38 | |
*** vinod has joined #openstack-dns | 21:56 | |
*** CaptTofu has joined #openstack-dns | 22:03 | |
*** CaptTofu has quit IRC | 22:08 | |
*** rossk has quit IRC | 22:10 | |
*** jmcbride has joined #openstack-dns | 22:14 | |
*** msisk has quit IRC | 22:17 | |
*** msisk has joined #openstack-dns | 22:18 | |
*** jmcbride has quit IRC | 22:19 | |
*** vinod has quit IRC | 22:30 | |
*** xmltok- has joined #openstack-dns | 22:37 | |
*** vinod has joined #openstack-dns | 22:52 | |
*** msisk has quit IRC | 22:54 | |
*** vinod has quit IRC | 22:56 | |
*** eankutse has quit IRC | 23:01 | |
*** vinod has joined #openstack-dns | 23:01 | |
*** vinod has quit IRC | 23:02 | |
*** vinod has joined #openstack-dns | 23:06 | |
*** vinod has joined #openstack-dns | 23:09 | |
*** jmcbride has joined #openstack-dns | 23:14 | |
*** jmcbride has quit IRC | 23:19 | |
*** rmoe has quit IRC | 23:36 | |
*** rmoe has joined #openstack-dns | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!