*** rmoe has quit IRC | 00:07 | |
*** richm has left #openstack-dns | 00:08 | |
*** matsuhashi has joined #openstack-dns | 00:20 | |
*** rmoe has joined #openstack-dns | 00:25 | |
*** betsy has quit IRC | 00:36 | |
*** CaptTofu_ has quit IRC | 00:36 | |
*** CaptTofu_ has joined #openstack-dns | 00:37 | |
*** CaptTofu_ has quit IRC | 00:41 | |
*** nosnos has joined #openstack-dns | 00:43 | |
*** msisk has joined #openstack-dns | 00:47 | |
*** vinod1 has joined #openstack-dns | 00:49 | |
*** m1crofarmer has quit IRC | 01:00 | |
*** msisk has quit IRC | 01:01 | |
*** rossk has quit IRC | 01:02 | |
*** msisk has joined #openstack-dns | 01:03 | |
*** yidclare has quit IRC | 01:05 | |
*** CaptTofu_ has joined #openstack-dns | 01:08 | |
*** vinod1 has quit IRC | 01:23 | |
*** dtx00ff__ has quit IRC | 01:30 | |
*** dtx00ff has joined #openstack-dns | 01:36 | |
*** JensOfSweden has joined #openstack-dns | 01:44 | |
*** msisk has quit IRC | 01:49 | |
*** CaptTofu_ has quit IRC | 01:50 | |
*** CaptTofu_ has joined #openstack-dns | 01:50 | |
*** vinod1 has joined #openstack-dns | 01:52 | |
*** CaptTofu_ has quit IRC | 01:55 | |
*** matsuhashi has quit IRC | 02:07 | |
*** matsuhashi has joined #openstack-dns | 02:08 | |
*** matsuhashi has quit IRC | 02:08 | |
*** matsuhashi has joined #openstack-dns | 02:08 | |
*** ytwu has quit IRC | 02:14 | |
*** ytwu has joined #openstack-dns | 02:15 | |
*** CaptTofu_ has joined #openstack-dns | 02:29 | |
*** ytwu has quit IRC | 02:31 | |
*** ytwu has joined #openstack-dns | 02:32 | |
*** vinod1 has quit IRC | 02:51 | |
*** eankutse1 has quit IRC | 02:53 | |
*** nkinder_ has quit IRC | 02:58 | |
*** nkinder_ has joined #openstack-dns | 02:59 | |
*** CaptTofu_ has quit IRC | 03:28 | |
*** CaptTofu_ has joined #openstack-dns | 03:29 | |
*** CaptTofu_ has quit IRC | 03:33 | |
*** matsuhashi has quit IRC | 03:38 | |
*** matsuhashi has joined #openstack-dns | 03:39 | |
*** yidclare has joined #openstack-dns | 03:41 | |
*** matsuhashi has quit IRC | 03:45 | |
*** matsuhashi has joined #openstack-dns | 03:45 | |
*** matsuhashi has quit IRC | 03:46 | |
*** yidclare has quit IRC | 03:52 | |
*** dtx00ff has quit IRC | 03:54 | |
*** serverascode has quit IRC | 03:59 | |
*** simonmcc has quit IRC | 04:00 | |
*** simonmcc has joined #openstack-dns | 04:01 | |
*** serverascode has joined #openstack-dns | 04:02 | |
*** nosnos has quit IRC | 04:02 | |
*** matsuhashi has joined #openstack-dns | 04:37 | |
*** nosnos has joined #openstack-dns | 04:43 | |
*** matsuhashi has quit IRC | 04:56 | |
*** matsuhashi has joined #openstack-dns | 04:57 | |
*** dtx00ff has joined #openstack-dns | 05:03 | |
*** CaptTofu_ has joined #openstack-dns | 05:17 | |
*** CaptTofu_ has quit IRC | 05:21 | |
*** m1crofarmer has joined #openstack-dns | 06:17 | |
*** rjrjr has quit IRC | 06:25 | |
*** seventy3 has quit IRC | 06:37 | |
*** dtx00ff has quit IRC | 06:38 | |
*** seventy3_away has joined #openstack-dns | 06:40 | |
*** seventy3_away is now known as seventy3 | 06:40 | |
*** m1crofarmer has quit IRC | 06:44 | |
*** CaptTofu_ has joined #openstack-dns | 07:05 | |
*** CaptTofu_ has quit IRC | 07:10 | |
*** ajc_ has joined #openstack-dns | 07:18 | |
*** baffle_ has joined #openstack-dns | 07:24 | |
*** JoeHazzers has quit IRC | 07:27 | |
*** baffle has quit IRC | 07:27 | |
*** JoeHazzers has joined #openstack-dns | 07:28 | |
*** dtx00ff has joined #openstack-dns | 07:28 | |
*** nosnos has quit IRC | 08:44 | |
*** nosnos has joined #openstack-dns | 08:46 | |
*** dtx00ff has quit IRC | 08:48 | |
*** dtx00ff has joined #openstack-dns | 08:51 | |
*** dtx00ff has quit IRC | 08:52 | |
*** CaptTofu_ has joined #openstack-dns | 08:53 | |
*** CaptTofu_ has quit IRC | 08:58 | |
*** openstackgerrit has quit IRC | 09:14 | |
*** nosnos has quit IRC | 09:40 | |
*** matsuhashi has quit IRC | 09:44 | |
*** matsuhashi has joined #openstack-dns | 09:44 | |
*** matsuhashi has quit IRC | 09:46 | |
*** matsuhashi has joined #openstack-dns | 09:47 | |
*** amarao has joined #openstack-dns | 10:33 | |
*** CaptTofu_ has joined #openstack-dns | 10:36 | |
*** matsuhashi has quit IRC | 11:00 | |
*** matsuhashi has joined #openstack-dns | 11:01 | |
*** matsuhashi has quit IRC | 11:05 | |
*** matsuhashi has joined #openstack-dns | 11:16 | |
*** CaptTofu_ has quit IRC | 11:22 | |
*** CaptTofu_ has joined #openstack-dns | 11:23 | |
*** CaptTofu_ has quit IRC | 11:27 | |
*** dtx00ff has joined #openstack-dns | 11:39 | |
*** dtx00ff has quit IRC | 11:43 | |
*** ajc_ has quit IRC | 11:50 | |
*** ajc_ has joined #openstack-dns | 11:50 | |
*** ajc_ has quit IRC | 11:55 | |
*** mwagner_lap has quit IRC | 12:10 | |
*** matsuhashi has quit IRC | 12:13 | |
*** matsuhashi has joined #openstack-dns | 12:14 | |
*** matsuhas_ has joined #openstack-dns | 12:18 | |
*** matsuhashi has quit IRC | 12:18 | |
*** CaptTofu_ has joined #openstack-dns | 12:29 | |
*** CaptTofu_ has quit IRC | 12:33 | |
*** seventy3 has quit IRC | 12:40 | |
*** seventy3_away has joined #openstack-dns | 12:43 | |
*** seventy3_away is now known as seventy3 | 12:44 | |
*** CaptTofu_ has joined #openstack-dns | 12:53 | |
*** jaycaz has joined #openstack-dns | 13:02 | |
*** vinod1 has joined #openstack-dns | 13:04 | |
*** vinod1 has quit IRC | 13:15 | |
*** richm has joined #openstack-dns | 13:20 | |
*** tsimmons has joined #openstack-dns | 13:32 | |
*** msisk has joined #openstack-dns | 13:37 | |
*** amarao has quit IRC | 13:44 | |
*** sballe has joined #openstack-dns | 13:47 | |
tsimmons | Kiall: about? | 14:00 |
---|---|---|
ekarlso | tsimmons: anything I can help with ? | 14:02 |
ekarlso | offload the poor dude a bit ;) | 14:02 |
tsimmons | ekarlso: Sure! | 14:02 |
tsimmons | Looking at https://review.openstack.org/#/c/100361/2/designate/api/v2/controllers/root.py | 14:03 |
tsimmons | I'm trying to figure out how to "walk that path and attach the controller to the right place" generically given the right path from a static method in the extension controllers. I'm not 100% sure but it seems that the API path is determined by the variable names in the root controller, so how can we make that up no the fly for a bunch of different extensions? | 14:05 |
ekarlso | tsimmons: good q really, I think i'll let you talk to him instead ;) | 14:08 |
tsimmons | hah. I did actually have a question for you yesterday. | 14:08 |
ekarlso | fire away :) | 14:09 |
tsimmons | For the oslo.db change. https://review.openstack.org/#/c/98122/ Is it just a style thing changing databse_connection to connection, or is it a convention for oslo.db? | 14:09 |
ekarlso | it's what other projects are moving to I think and what o.db has :) | 14:10 |
ekarlso | I don't think there was projects besides us using database_connection but rather connection / sql_connection | 14:10 |
tsimmons | Alright, that's cool, might as well keep it consistent. | 14:13 |
ekarlso | :) | 14:14 |
*** vinod1 has joined #openstack-dns | 14:17 | |
*** matsuhas_ has quit IRC | 14:17 | |
*** vinod1 has quit IRC | 14:18 | |
*** vinod1 has joined #openstack-dns | 14:18 | |
*** mwagner_lap has joined #openstack-dns | 14:19 | |
*** matsuhashi has joined #openstack-dns | 14:23 | |
*** yidclare has joined #openstack-dns | 14:23 | |
*** ytwu has quit IRC | 14:25 | |
*** ytwu has joined #openstack-dns | 14:25 | |
*** yidclare has quit IRC | 14:26 | |
*** crc32 has joined #openstack-dns | 14:30 | |
*** matsuhashi has quit IRC | 14:33 | |
*** matsuhashi has joined #openstack-dns | 14:33 | |
*** jmcbride has joined #openstack-dns | 14:35 | |
*** crc32 has quit IRC | 14:36 | |
*** jmcbride has quit IRC | 14:36 | |
*** jmcbride has joined #openstack-dns | 14:37 | |
*** crc32 has joined #openstack-dns | 14:37 | |
*** matsuhashi has quit IRC | 14:38 | |
*** matsuhashi has joined #openstack-dns | 14:40 | |
Kiall | tsimmons: sorry, been meaning to reply to your Q all day.. Distractions keep coming my way ;) | 14:48 |
tsimmons | Kiall: Whenever it's convenient for you, I understand you're busy :) | 14:49 |
Kiall | Basically, I think if we add a __init__ method (possibly __new__, if __init__ is too late), we can iterate the list of plugins, calling a static method for each which would return a "path" like "zones.bla" | 14:50 |
Kiall | Then, you you split the path on "." | 14:50 |
Kiall | Then - take the 0 -> N-1 items, lets say they are ["zones", "recordsets", "bla"] | 14:52 |
*** eankutse has joined #openstack-dns | 14:52 | |
Kiall | you would do a controller = getattr(getattr(self, "zones"), "recordsets") | 14:52 |
Kiall | controller.bla = BlaController() | 14:53 |
Kiall | that way - the plugins can be attached almost anywhere in the API tree etc | 14:53 |
Kiall | Not sure if that's really much clearer TBH ;) | 14:53 |
tsimmons | I'm getting there. I was experimenting a little bit. I did zones.blacklists = blacklists.BlacklistsController. I could interact with /zones/blacklists but not /zones/id/blacklists. | 14:54 |
Kiall | That's due to the structure of the blacklists controller, rather than the way it was attached :) | 14:54 |
tsimmons | Ah, ok. | 14:55 |
Kiall | https://github.com/stackforge/designate/blob/master/designate/api/v2/controllers/blacklists.py#L38 | 14:55 |
Kiall | if that line was changed to .. | 14:55 |
Kiall | def get_one(self, zone_id, blacklist_id): | 14:55 |
Kiall | then /zones/<id>/blacklists would work | 14:55 |
tsimmons | Derp. ok that mkaes sense. | 14:55 |
Kiall | Pecan infers a chunk of stuff based on how the objects are attached, what the methods are called, and what the methods arguments are called | 14:56 |
Kiall | actually.. for that URL, it's the method on L49 | 14:56 |
Kiall | It'd need to be changed to | 14:56 |
Kiall | def get_all(self, zone_id, **params): | 14:56 |
Kiall | e.g. here's the recordsets controller: https://github.com/stackforge/designate/blob/master/designate/api/v2/controllers/recordsets.py#L53 | 14:56 |
tsimmons | Yeah that makes sense. | 14:57 |
tsimmons | So for this bit "controller = getattr(getattr(self, "zones"), "recordsets") " how would you do this generically? So some might be ["zones", "recordsets", "bla"] but others might just be ["bla"]. How can you do controller.bla when "bla" could be anything? | 14:58 |
*** jaycaz has quit IRC | 15:00 | |
*** vinod1 has quit IRC | 15:01 | |
*** jmcbride has quit IRC | 15:02 | |
Kiall | tsimmons: So, if there's only 1 path element, the controller = self (considering this in the RootController's __init__ method) | 15:03 |
*** vinod1 has joined #openstack-dns | 15:03 | |
tsimmons | Right, that makes sense. I guess would that be done manually in each extension controller's __init__ or __new__? | 15:04 |
Kiall | controller = self | 15:04 |
Kiall | for p in path.split('.')[:-1]: | 15:04 |
Kiall | controller = getattr(controller, p) | 15:04 |
Kiall | setattr(controller, 'bla', BlaController()) | 15:04 |
Kiall | (that'll blow up in a few different ways, like when a path segment doesn't exist) | 15:05 |
Kiall | But the idea should be there | 15:05 |
*** matsuhashi has quit IRC | 15:07 | |
tsimmons | Ok, so we'll do that for each enabled extension in the root controller. I think I'm there. | 15:07 |
*** matsuhashi has joined #openstack-dns | 15:07 | |
tsimmons | Thanks Kiall :) | 15:09 |
Kiall | No problem :) | 15:09 |
*** matsuhashi has quit IRC | 15:11 | |
*** crc32 has quit IRC | 15:12 | |
*** vinod1 has quit IRC | 15:17 | |
*** vinod1 has joined #openstack-dns | 15:17 | |
*** jaycaz has joined #openstack-dns | 15:18 | |
*** betsy has joined #openstack-dns | 15:21 | |
*** jmcbride has joined #openstack-dns | 15:30 | |
*** jmcbride1 has joined #openstack-dns | 15:32 | |
*** jmcbride has quit IRC | 15:34 | |
*** jmcbride1 has quit IRC | 16:01 | |
*** jmcbride has joined #openstack-dns | 16:11 | |
*** vinod2 has joined #openstack-dns | 16:12 | |
*** vinod1 has quit IRC | 16:13 | |
*** rmoe has quit IRC | 16:23 | |
*** rmoe has joined #openstack-dns | 16:40 | |
*** jmcbride has quit IRC | 16:40 | |
*** jmcbride has joined #openstack-dns | 16:43 | |
Kiall | jmcbride / vinod / betsy / richm / rjrjr: Okay - Looks like we can get space in Seattle for a mid-cycle | 17:06 |
Kiall | comes down to logistics now :) | 17:07 |
betsy | Cool. Now hopefully we get approved for the trip. :) | 17:07 |
ekarlso | Kiall: could the extensions add in at different places also ? | 17:14 |
ekarlso | aka a extension could be at /zones/<id>/blahext | 17:14 |
ekarlso | vs /zones/<id>/records/<id>/fooext ? | 17:14 |
*** richm has quit IRC | 17:15 | |
*** crc32 has joined #openstack-dns | 17:15 | |
Kiall | Yep - ekarlso they can be (or will be, once tsimmons is finished with the changes I suggested) :) | 17:16 |
*** richm has joined #openstack-dns | 17:32 | |
*** yidclare has joined #openstack-dns | 17:34 | |
*** richm has quit IRC | 17:36 | |
*** richm has joined #openstack-dns | 17:38 | |
*** jmcbride has quit IRC | 17:39 | |
*** crc32 has quit IRC | 18:08 | |
*** ytwu has quit IRC | 18:08 | |
*** sballe has quit IRC | 18:08 | |
*** yidclare has quit IRC | 18:08 | |
*** vinod2 has quit IRC | 18:08 | |
*** seventy3 has quit IRC | 18:08 | |
*** retr0h has quit IRC | 18:08 | |
*** briancline has quit IRC | 18:08 | |
*** betsy has quit IRC | 18:08 | |
*** simonmcc has quit IRC | 18:08 | |
*** mgagne has quit IRC | 18:08 | |
*** fouxm has quit IRC | 18:08 | |
*** zigo has quit IRC | 18:08 | |
*** shufflebot has quit IRC | 18:08 | |
*** yidclare has joined #openstack-dns | 18:10 | |
*** crc32 has joined #openstack-dns | 18:10 | |
*** vinod2 has joined #openstack-dns | 18:10 | |
*** betsy has joined #openstack-dns | 18:10 | |
*** ytwu has joined #openstack-dns | 18:10 | |
*** sballe has joined #openstack-dns | 18:10 | |
*** seventy3 has joined #openstack-dns | 18:10 | |
*** simonmcc has joined #openstack-dns | 18:10 | |
*** retr0h has joined #openstack-dns | 18:10 | |
*** mgagne has joined #openstack-dns | 18:10 | |
*** briancline has joined #openstack-dns | 18:10 | |
*** zigo has joined #openstack-dns | 18:10 | |
*** fouxm has joined #openstack-dns | 18:10 | |
*** shufflebot has joined #openstack-dns | 18:10 | |
*** jmcbride has joined #openstack-dns | 18:14 | |
*** crc32 has quit IRC | 18:14 | |
*** ytwu has quit IRC | 18:14 | |
*** sballe has quit IRC | 18:14 | |
*** yidclare has quit IRC | 18:14 | |
*** vinod2 has quit IRC | 18:14 | |
*** seventy3 has quit IRC | 18:14 | |
*** retr0h has quit IRC | 18:14 | |
*** briancline has quit IRC | 18:14 | |
*** betsy has quit IRC | 18:14 | |
*** simonmcc has quit IRC | 18:14 | |
*** mgagne has quit IRC | 18:14 | |
*** fouxm has quit IRC | 18:14 | |
*** zigo has quit IRC | 18:14 | |
*** shufflebot has quit IRC | 18:14 | |
*** yidclare has joined #openstack-dns | 18:16 | |
*** crc32 has joined #openstack-dns | 18:16 | |
*** vinod2 has joined #openstack-dns | 18:16 | |
*** betsy has joined #openstack-dns | 18:16 | |
*** ytwu has joined #openstack-dns | 18:16 | |
*** sballe has joined #openstack-dns | 18:16 | |
*** seventy3 has joined #openstack-dns | 18:16 | |
*** simonmcc has joined #openstack-dns | 18:16 | |
*** retr0h has joined #openstack-dns | 18:16 | |
*** mgagne has joined #openstack-dns | 18:16 | |
*** briancline has joined #openstack-dns | 18:16 | |
*** zigo has joined #openstack-dns | 18:16 | |
*** fouxm has joined #openstack-dns | 18:16 | |
*** shufflebot has joined #openstack-dns | 18:16 | |
tsimmons | Kiall: The only piece I'm missing is how to get at BlaController() in our example. Do you access that via entry points? | 18:20 |
Kiall | tsimmons: In https://review.openstack.org/#/c/100361/2/designate/api/v2/controllers/extension.py | 18:24 |
Kiall | e.obj should be the instantiated class | 18:25 |
Kiall | (with invoke_on_load=False, it would be the class, and you would need to e.obj() to get an instance) | 18:25 |
*** rjrjr has joined #openstack-dns | 18:29 | |
*** sballe has quit IRC | 18:33 | |
tsimmons | Everything should work....but I still get a 404 at v2/quotas | 18:36 |
*** yidclare has quit IRC | 18:50 | |
*** vinod2 has quit IRC | 18:50 | |
tsimmons | ....well that's because there isn't a get_all in the thing that I wrote. Dumbbbb. Ok we're good. | 18:52 |
Kiall | lol | 18:52 |
Kiall | :) | 18:52 |
tsimmons | Should have just stepped away for a second and I would have realized that. | 18:53 |
*** dtx00ff has joined #openstack-dns | 18:56 | |
*** ekarlso has quit IRC | 19:01 | |
*** ekarlso has joined #openstack-dns | 19:04 | |
*** vinod1 has joined #openstack-dns | 19:29 | |
*** jmcbride has quit IRC | 19:31 | |
*** jmcbride has joined #openstack-dns | 19:32 | |
*** jmcbride has quit IRC | 19:34 | |
*** jmcbride has joined #openstack-dns | 19:34 | |
*** jaycaz has quit IRC | 19:46 | |
*** dtx00ff has quit IRC | 20:10 | |
*** CaptTofu_ has quit IRC | 20:13 | |
*** dtx00ff has joined #openstack-dns | 20:17 | |
*** CaptTofu_ has joined #openstack-dns | 20:21 | |
*** yidclare has joined #openstack-dns | 20:36 | |
*** jmcbride has quit IRC | 20:37 | |
*** jmcbride has joined #openstack-dns | 20:55 | |
*** jmcbride has quit IRC | 20:55 | |
*** jmcbride has joined #openstack-dns | 20:55 | |
*** crc32 has quit IRC | 21:00 | |
*** jmcbride1 has joined #openstack-dns | 21:18 | |
*** mwagner_lap has quit IRC | 21:20 | |
*** jmcbride has quit IRC | 21:20 | |
*** vinod1 has quit IRC | 21:23 | |
*** jmcbride1 has quit IRC | 21:30 | |
*** eankutse has quit IRC | 21:31 | |
*** eankutse has joined #openstack-dns | 21:31 | |
*** eankutse has quit IRC | 21:31 | |
*** openstackgerrit has joined #openstack-dns | 21:34 | |
*** ChanServ sets mode: +v openstackgerrit | 21:34 | |
*** dtx00ff has quit IRC | 21:35 | |
*** dtx00ff has joined #openstack-dns | 21:42 | |
*** vinod1 has joined #openstack-dns | 21:51 | |
*** crc32 has joined #openstack-dns | 21:58 | |
*** tsimmons has quit IRC | 22:00 | |
openstackgerrit | Endre Karlson proposed a change to stackforge/designate: Switch to oslo.db and fix cmd.manage https://review.openstack.org/98122 | 22:01 |
*** CaptTofu_ has quit IRC | 22:06 | |
*** CaptTofu_ has joined #openstack-dns | 22:07 | |
*** yidclare has quit IRC | 22:07 | |
*** msisk has quit IRC | 22:08 | |
*** CaptTofu_ has quit IRC | 22:11 | |
*** vinod1 has quit IRC | 22:19 | |
*** CaptTofu_ has joined #openstack-dns | 22:20 | |
*** iraw_ has joined #openstack-dns | 22:23 | |
*** iraw_ has quit IRC | 22:31 | |
*** openstackgerrit has quit IRC | 22:34 | |
*** 20WAAHXAJ has joined #openstack-dns | 22:35 | |
*** yidclare has joined #openstack-dns | 22:45 | |
*** openstack has joined #openstack-dns | 22:50 | |
*** ChanServ sets mode: +v openstack | 22:50 | |
*** CaptTofu_ has quit IRC | 22:55 | |
*** CaptTofu_ has joined #openstack-dns | 22:55 | |
*** CaptTofu_ has quit IRC | 23:00 | |
*** CaptTofu_ has joined #openstack-dns | 23:05 | |
*** crc32 has quit IRC | 23:21 | |
*** 20WAAHXAJ has quit IRC | 23:29 | |
*** betsy has quit IRC | 23:30 | |
*** openstackgerrit has joined #openstack-dns | 23:30 | |
*** ChanServ sets mode: +v openstackgerrit | 23:30 | |
*** yidclare has quit IRC | 23:36 | |
*** msisk has joined #openstack-dns | 23:37 | |
*** msisk has quit IRC | 23:38 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!