| *** ytwu has quit IRC | 00:05 | |
| *** ytwu1 has joined #openstack-dns | 00:05 | |
| *** matsuhashi has joined #openstack-dns | 00:31 | |
| *** puck has quit IRC | 01:02 | |
| *** puck has joined #openstack-dns | 01:03 | |
| *** seventy3 has quit IRC | 01:23 | |
| *** seventy3_away has joined #openstack-dns | 01:24 | |
| *** seventy3_away is now known as seventy3 | 01:24 | |
| *** puck has quit IRC | 01:32 | |
| *** puck has joined #openstack-dns | 01:34 | |
| *** puck has quit IRC | 01:38 | |
| *** nosnos has joined #openstack-dns | 01:39 | |
| *** puck has joined #openstack-dns | 01:40 | |
| *** puck has quit IRC | 01:46 | |
| *** puck has joined #openstack-dns | 01:48 | |
| *** puck has quit IRC | 01:52 | |
| *** puck has joined #openstack-dns | 01:53 | |
| *** puck has quit IRC | 01:57 | |
| *** puck has joined #openstack-dns | 01:59 | |
| *** puck has quit IRC | 02:07 | |
| *** puck has joined #openstack-dns | 02:07 | |
| *** ytwu1 has quit IRC | 02:19 | |
| *** ytwu has joined #openstack-dns | 02:24 | |
| *** ytwu has quit IRC | 03:04 | |
| *** matsuhashi has quit IRC | 03:39 | |
| *** nosnos has quit IRC | 03:54 | |
| *** shakamunyi has quit IRC | 04:30 | |
| *** shakamunyi has joined #openstack-dns | 04:31 | |
| *** matsuhashi has joined #openstack-dns | 04:39 | |
| *** shakamunyi has quit IRC | 04:41 | |
| *** nosnos has joined #openstack-dns | 04:41 | |
| *** shakamunyi has joined #openstack-dns | 04:42 | |
| *** nosnos has quit IRC | 04:46 | |
| *** shakamunyi has quit IRC | 04:47 | |
| *** nosnos has joined #openstack-dns | 04:47 | |
| *** ajc_ has joined #openstack-dns | 05:29 | |
| *** nosnos has quit IRC | 05:35 | |
| *** nosnos has joined #openstack-dns | 05:37 | |
| *** shakamunyi has joined #openstack-dns | 06:05 | |
| *** matsuhashi has quit IRC | 06:05 | |
| *** matsuhashi has joined #openstack-dns | 06:06 | |
| *** matsuhashi has quit IRC | 06:11 | |
| *** matsuhashi has joined #openstack-dns | 06:13 | |
| *** matsuhashi has quit IRC | 06:19 | |
| *** matsuhashi has joined #openstack-dns | 06:19 | |
| *** openstackstatus has quit IRC | 06:27 | |
| *** matsuhashi has quit IRC | 06:55 | |
| *** matsuhashi has joined #openstack-dns | 06:56 | |
| *** amarao has joined #openstack-dns | 07:48 | |
| *** cflmarques has joined #openstack-dns | 09:06 | |
| *** cflmarques has quit IRC | 09:46 | |
| *** eankutse has joined #openstack-dns | 12:01 | |
| *** eankutse has quit IRC | 12:02 | |
| *** eankutse has joined #openstack-dns | 12:02 | |
| *** matsuhashi has quit IRC | 12:23 | |
| *** matsuhashi has joined #openstack-dns | 12:23 | |
| *** matsuhashi has quit IRC | 12:28 | |
| *** matsuhashi has joined #openstack-dns | 12:28 | |
| *** matsuhashi has quit IRC | 12:35 | |
| *** matsuhashi has joined #openstack-dns | 12:35 | |
| *** matsuhas_ has joined #openstack-dns | 12:38 | |
| *** shakamunyi has quit IRC | 12:38 | |
| *** matsuhashi has quit IRC | 12:39 | |
| *** vinod1 has joined #openstack-dns | 12:40 | |
| *** ajc_ has quit IRC | 12:40 | |
| *** matsuhas_ has quit IRC | 13:03 | |
| *** matsuhashi has joined #openstack-dns | 13:03 | |
| *** matsuhashi has quit IRC | 13:08 | |
| *** matsuhashi has joined #openstack-dns | 13:08 | |
| *** mugsie has joined #openstack-dns | 13:12 | |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Unify Storage vs Rest of World fixture creation https://review.openstack.org/101700 | 13:12 |
|---|---|---|
| *** nkinder_ has quit IRC | 13:13 | |
| *** matsuhashi has quit IRC | 13:13 | |
| openstackgerrit | A change was merged to stackforge/designate: Switch to oslo.db and fix cmd.manage https://review.openstack.org/98122 | 13:14 |
| *** matsuhashi has joined #openstack-dns | 13:14 | |
| *** vinod1 has quit IRC | 13:17 | |
| *** matsuhashi has quit IRC | 13:18 | |
| openstackgerrit | Kiall Mac Innes proposed a change to stackforge/designate: Unify Storage vs Rest of World fixture creation https://review.openstack.org/101700 | 13:25 |
| *** richm has joined #openstack-dns | 13:26 | |
| *** nosnos has quit IRC | 13:29 | |
| *** vinod1 has joined #openstack-dns | 13:34 | |
| *** eankutse has quit IRC | 13:39 | |
| *** vinod1 has quit IRC | 13:43 | |
| *** vinod1 has joined #openstack-dns | 14:00 | |
| *** vinod1 has quit IRC | 14:00 | |
| *** vinod1 has joined #openstack-dns | 14:01 | |
| *** nkinder_ has joined #openstack-dns | 14:08 | |
| *** betsy has quit IRC | 14:08 | |
| *** tsimmons has joined #openstack-dns | 14:23 | |
| *** vinod1 has quit IRC | 14:30 | |
| openstackgerrit | A change was merged to stackforge/designate: Unify Storage vs Rest of World fixture creation https://review.openstack.org/101700 | 14:31 |
| *** vinod1 has joined #openstack-dns | 14:32 | |
| *** msisk has joined #openstack-dns | 14:33 | |
| *** vinod1 has joined #openstack-dns | 14:34 | |
| *** jmcbride has joined #openstack-dns | 14:36 | |
| *** vinod1 has quit IRC | 14:38 | |
| openstackgerrit | Jordan Cazamias proposed a change to stackforge/designate: Change log string format to '%' for consistency https://review.openstack.org/101047 | 14:40 |
| *** vinod1 has joined #openstack-dns | 14:42 | |
| tsimmons | mugsie: You around? | 14:43 |
| *** msisk has quit IRC | 14:45 | |
| *** vinod1 has joined #openstack-dns | 14:46 | |
| *** shakamunyi has joined #openstack-dns | 14:54 | |
| *** vinod1 has quit IRC | 14:56 | |
| *** vinod1 has joined #openstack-dns | 14:57 | |
| *** betsy has joined #openstack-dns | 14:58 | |
| mugsie | tsimmons, yup | 14:59 |
| *** jmcbride has quit IRC | 15:05 | |
| *** eankutse has joined #openstack-dns | 15:13 | |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Fixes default content type on /v2/zones endpoint https://review.openstack.org/101929 | 15:14 |
| *** shakamunyi has quit IRC | 15:14 | |
| tsimmons | mugsie: Regarding your comments here: https://review.openstack.org/#/c/100361/4/designate/api/v2/views/extensions/quotas.py | 15:17 |
| mugsie | yup | 15:17 |
| tsimmons | You want it so that the API user sees zones/zones_blah blah and can enter them that way as well right? So I'll just transform the names "zones"->"domains" on PATCHs as well as transform them on GETS? | 15:18 |
| mugsie | yup | 15:18 |
| tsimmons | Alright cool. | 15:19 |
| mugsie | we will at some point in the future have to do one massive refactor to get zones in the code base, but until then we just need to do the transforms in the views | 15:19 |
| tsimmons | Yep. Alright, thanks! | 15:19 |
| mugsie | np | 15:22 |
| *** jorgem has joined #openstack-dns | 15:22 | |
| *** shakamunyi has joined #openstack-dns | 15:25 | |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Added all fields to limits endpoint, and corrected casing https://review.openstack.org/101935 | 15:26 |
| *** msisk has joined #openstack-dns | 15:29 | |
| *** shakamunyi has quit IRC | 15:37 | |
| *** shakamunyi has joined #openstack-dns | 15:38 | |
| *** shakamunyi has quit IRC | 15:39 | |
| *** shakamunyi has joined #openstack-dns | 15:39 | |
| *** shakamunyi has quit IRC | 15:47 | |
| *** shakamunyi has joined #openstack-dns | 15:48 | |
| *** jmcbride has joined #openstack-dns | 15:53 | |
| *** jmcbride has quit IRC | 15:53 | |
| *** jmcbride has joined #openstack-dns | 15:53 | |
| *** shakamunyi has quit IRC | 15:55 | |
| *** shakamunyi has joined #openstack-dns | 15:55 | |
| *** shakamunyi has quit IRC | 15:56 | |
| *** shakamunyi has joined #openstack-dns | 15:57 | |
| *** shakamunyi has quit IRC | 16:00 | |
| *** jorgem has quit IRC | 16:01 | |
| *** shakamunyi has joined #openstack-dns | 16:01 | |
| *** jorgem has joined #openstack-dns | 16:03 | |
| *** amarao has quit IRC | 16:07 | |
| *** shakamunyi has quit IRC | 16:13 | |
| *** shakamunyi has joined #openstack-dns | 16:15 | |
| *** rmoe has quit IRC | 16:20 | |
| *** shakamunyi has quit IRC | 16:22 | |
| *** shakamunyi has joined #openstack-dns | 16:22 | |
| *** bandarji has joined #openstack-dns | 16:23 | |
| *** shakamunyi has quit IRC | 16:30 | |
| *** shakamunyi has joined #openstack-dns | 16:31 | |
| *** shakamunyi has quit IRC | 16:31 | |
| *** shakamunyi has joined #openstack-dns | 16:32 | |
| *** shakamunyi has quit IRC | 16:34 | |
| *** shakamunyi has joined #openstack-dns | 16:45 | |
| *** shakamunyi has quit IRC | 16:45 | |
| *** shakamunyi has joined #openstack-dns | 16:46 | |
| *** rmoe has joined #openstack-dns | 16:49 | |
| *** yidclare has joined #openstack-dns | 16:51 | |
| *** jmcbride has quit IRC | 16:55 | |
| *** shakamunyi has quit IRC | 16:57 | |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON https://review.openstack.org/101954 | 16:58 |
| *** jmcbride has joined #openstack-dns | 17:06 | |
| *** jmcbride has quit IRC | 17:12 | |
| *** jorgem has quit IRC | 17:32 | |
| *** richm has quit IRC | 17:34 | |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON https://review.openstack.org/101954 | 17:35 |
| *** jorgem has joined #openstack-dns | 17:36 | |
| tsimmons | Just a general question to anyone who has written unit tests. Do you have any idea how I might enable extensions in the unit tests? I'm trying to enable the extensions via the config option, but I get an error: "NoSuchOptError: no such option in group service:api: enabled_extensions_v2". Without importing it I just get a 404 at a route in the test that works fine for me. | 17:48 |
| *** richm has joined #openstack-dns | 17:48 | |
| *** vinod1 has quit IRC | 17:59 | |
| openstackgerrit | Tim Simmons proposed a change to stackforge/designate: Add Extensions to the v2 API https://review.openstack.org/100361 | 18:02 |
| tsimmons | Unit test is broken^ but at least we'll be able to see it | 18:02 |
| mugsie | tsimmons, looks good | 18:07 |
| mugsie | might have a look how we did for the v1 api | 18:07 |
| mugsie | but my gut feeling is we didnt | 18:07 |
| tsimmons | Yeah I didn't see any :/ | 18:08 |
| *** jmcbride has joined #openstack-dns | 18:09 | |
| *** jmcbride has quit IRC | 18:10 | |
| *** jmcbride has joined #openstack-dns | 18:11 | |
| mugsie | tsimmons, yup, my gut was right | 18:12 |
| mugsie | we just didnt test them | 18:12 |
| tsimmons | Yeah, I mean we should. It's just a matter of getting it enabled in the testing framework. Surely it can be done... | 18:13 |
| *** bandarji has quit IRC | 18:13 | |
| mugsie | Yeah, but ekarlso would have a better idea about the testing framework than me | 18:15 |
| mugsie | ekarlso, any ideas? | 18:15 |
| *** jmcbride has quit IRC | 18:16 | |
| *** jmcbride has joined #openstack-dns | 18:20 | |
| *** vinod1 has joined #openstack-dns | 18:25 | |
| *** vinod1 has quit IRC | 18:25 | |
| *** vinod1 has joined #openstack-dns | 18:25 | |
| *** yidclare has quit IRC | 18:59 | |
| *** jmcbride has quit IRC | 18:59 | |
| *** vinod1 has quit IRC | 19:00 | |
| *** crc32 has joined #openstack-dns | 19:08 | |
| *** vipul has quit IRC | 19:10 | |
| tsimmons | Maybe it's something to do with the way I'm registering the configuration value? When I try that line and similar other places I get that there is no such config option. | 19:12 |
| *** tsimmons has quit IRC | 19:19 | |
| *** tsimmons has joined #openstack-dns | 19:20 | |
| *** vipul has joined #openstack-dns | 19:23 | |
| *** bandarji has joined #openstack-dns | 19:29 | |
| *** jorgem has left #openstack-dns | 19:31 | |
| Kiall | tsimmons: having a look now... | 19:36 |
| tsimmons | Kiall: I appreciate you taking the time. | 19:36 |
| Kiall | and - yea - we didn't test the V1 extensions. | 19:36 |
| Kiall | Hence waning to get started on the right foot in V2 ;) | 19:37 |
| Kiall | super(ApiV2QuotasTest, self).setUp()23 | 19:37 |
| Kiall | self.config(enabled_extensions_v2='quotas', group='service:api') | 19:37 |
| Kiall | I'm betting if you reverse the order of these two lines, it'll work | 19:37 |
| Kiall | (Which is something we should fix if it works, but I don't think the fix belongs in your review..) | 19:38 |
| Kiall | And - If that complains about the option not existing, adding a cfg.CONF.import_opt('enabled_extensions_v2', 'designate.api.v2', group='service:api') after the imports at the top should get it | 19:39 |
| tsimmons | It did complain about a missing option (very omniscient of you) but that unfortunately did not fix it. Still get the same "No Such Opt" Error. | 19:42 |
| tsimmons | http://paste.openstack.org/show/84725/ | 19:43 |
| Kiall | Where did you add the import_opt line? after the imports, but before the class started | 19:45 |
| Kiall | ? | 19:45 |
| tsimmons | Yup http://paste.openstack.org/show/84726 | 19:46 |
| tsimmons | (In that one I tried to change the option to a list, but I tried it both ways) | 19:47 |
| Kiall | It's definitely a list, but the error suggests it can't find it rather than your setting the wrong type :) | 19:47 |
| tsimmons | Yeah I'm just kind of throwing stuff at the wall :P | 19:47 |
| Kiall | ^ paste should work :/ | 19:47 |
| Kiall | L7 should either succeed or blow up with an NoSuchOpt before the tests even run | 19:48 |
| Kiall | Oh - it is blowing up that early.. | 19:48 |
| tsimmons | When I run that test only it just get a giant blob that looks like "Non-zero exit code (2) from test listing. stdout='\xb3)\x01@M@Bdesignate.tests.test_agent.test_service.AgentServiceTest.test_stopz\x9" | 19:49 |
| Kiall | AHH | 19:49 |
| Kiall | I see | 19:49 |
| Kiall | you're defining the config option in designate/api/v2/controllers/root.py rather than designate/api/v2/__init__.py | 19:49 |
| Kiall | if you move the definition to there, it should work | 19:49 |
| tsimmons | Yup. Alright then | 19:49 |
| Kiall | "designate/api/v2/__init__.py" would fit the pattern for where all our other services define their options | 19:50 |
| Kiall | but.. if you wanted to it work with the current placement, you would need cfg.CONF.import_opt('enabled_extensions_v2', 'designate.api.v2.controllers.root', group='service:api') | 19:50 |
| Kiall | import_opt('option-name', 'module-path-where-option-is-defined', group='group-name') | 19:51 |
| tsimmons | Sweet, now I just got a 403 Forbidden. I can work with that. | 19:52 |
| Kiall | Out of curiosity - does it work with the self.config() line after the super() line? | 19:52 |
| Kiall | (If not, that's fine.. That's a separate thing to figure out + fix ;)) | 19:53 |
| tsimmons | Nope, the extension doesn't get loaded. | 19:53 |
| Kiall | Okay.. I thought as much | 19:54 |
| Kiall | super() triggers the API service to be started, which loads the ext's on startup, and the config option hasn't been set yet.. | 19:54 |
| tsimmons | That makes sense. | 19:54 |
| tsimmons | Awesome, well thanks man I really appreciate it! | 19:55 |
| Kiall | I'm not sure there's much we can really do about that, but, maybe there is.. I'll poke at it tomorrow | 19:55 |
| *** yidclare has joined #openstack-dns | 20:02 | |
| *** nkinder has joined #openstack-dns | 20:28 | |
| *** nkinder_ has quit IRC | 20:32 | |
| *** CaptTofu_ has quit IRC | 20:34 | |
| *** vinod1 has joined #openstack-dns | 20:36 | |
| *** vinod1 has quit IRC | 20:37 | |
| *** vinod1 has joined #openstack-dns | 20:37 | |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Fixes default content type on /v2/zones endpoint https://review.openstack.org/101929 | 21:01 |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Ensure that 404's are returned as JSON https://review.openstack.org/101954 | 21:02 |
| openstackgerrit | Graham Hayes proposed a change to stackforge/designate: Added all fields to limits endpoint, and corrected casing https://review.openstack.org/101935 | 21:09 |
| *** eankutse has quit IRC | 21:12 | |
| *** tsimmons has quit IRC | 21:20 | |
| *** jaycaz has joined #openstack-dns | 21:28 | |
| *** msisk has quit IRC | 21:31 | |
| *** eankutse has joined #openstack-dns | 21:43 | |
| *** betsy has quit IRC | 21:43 | |
| *** nkinder has quit IRC | 21:45 | |
| *** eankutse has quit IRC | 21:49 | |
| *** CaptTofu_ has joined #openstack-dns | 22:01 | |
| *** CaptTofu_ has quit IRC | 22:06 | |
| *** CaptTofu_ has joined #openstack-dns | 22:09 | |
| *** seventy3 has quit IRC | 22:11 | |
| *** zane1 has joined #openstack-dns | 22:12 | |
| *** seventy3 has joined #openstack-dns | 22:14 | |
| *** jaycaz has left #openstack-dns | 22:21 | |
| *** vinod1 has quit IRC | 22:23 | |
| *** zane1 has quit IRC | 22:41 | |
| *** zane1 has joined #openstack-dns | 22:41 | |
| *** yidclare has quit IRC | 22:45 | |
| *** zane1 has quit IRC | 22:46 | |
| *** vinod1 has joined #openstack-dns | 22:55 | |
| *** bandarji has quit IRC | 23:07 | |
| *** eankutse has joined #openstack-dns | 23:43 | |
| *** eankutse has quit IRC | 23:44 | |
| *** msisk has joined #openstack-dns | 23:45 | |
| *** eankutse has joined #openstack-dns | 23:59 | |
| *** eankutse has quit IRC | 23:59 | |
| *** eankutse has joined #openstack-dns | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!