| *** yidclare has quit IRC | 00:09 | |
| *** vinod1 has joined #openstack-dns | 00:12 | |
| *** richm has left #openstack-dns | 00:22 | |
| *** msisk has joined #openstack-dns | 01:05 | |
| *** m1crofarmer has joined #openstack-dns | 01:40 | |
| *** nosnos has joined #openstack-dns | 01:44 | |
| *** m1crofarmer has quit IRC | 01:55 | |
| *** vinod1 has quit IRC | 02:34 | |
| *** m1crofarmer has joined #openstack-dns | 03:06 | |
| *** vinod1 has joined #openstack-dns | 03:08 | |
| *** msisk has quit IRC | 03:13 | |
| *** vinod1 has quit IRC | 03:20 | |
| *** nosnos has quit IRC | 03:20 | |
| *** m1crofarmer has quit IRC | 04:09 | |
| *** m1crofarmer has joined #openstack-dns | 04:09 | |
| *** nosnos has joined #openstack-dns | 04:13 | |
| *** nosnos has quit IRC | 04:24 | |
| *** m1crofarmer has left #openstack-dns | 06:42 | |
| *** Amresh has joined #openstack-dns | 07:58 | |
| *** Amresh has quit IRC | 08:25 | |
| *** mwagner_lap has joined #openstack-dns | 12:36 | |
| *** vinod1 has joined #openstack-dns | 12:41 | |
| *** richm has joined #openstack-dns | 12:59 | |
| *** sballe has joined #openstack-dns | 13:01 | |
| *** vinod1 has quit IRC | 13:09 | |
| *** timsim has joined #openstack-dns | 13:18 | |
| *** rickerc_ has joined #openstack-dns | 13:40 | |
| *** jaycaz has joined #openstack-dns | 13:41 | |
| *** retr0h_ has joined #openstack-dns | 13:43 | |
| *** rektide_ has joined #openstack-dns | 13:44 | |
| *** rickerc has quit IRC | 13:48 | |
| *** uvirtbot has quit IRC | 13:48 | |
| *** rektide has quit IRC | 13:48 | |
| *** retr0h has quit IRC | 13:48 | |
| *** rickerc_ is now known as rickerc | 13:48 | |
| *** eankutse has joined #openstack-dns | 13:53 | |
| *** uvirtbot has joined #openstack-dns | 13:57 | |
| *** vinod1 has joined #openstack-dns | 13:59 | |
| *** vinod1 has quit IRC | 14:11 | |
| *** betsy has joined #openstack-dns | 14:20 | |
| *** msisk has joined #openstack-dns | 14:20 | |
| *** vinod1 has joined #openstack-dns | 14:48 | |
| *** msisk_ has joined #openstack-dns | 14:56 | |
| *** msisk has quit IRC | 14:59 | |
| *** jaycaz has quit IRC | 15:01 | |
| *** sballe has quit IRC | 15:21 | |
| *** jaycaz has joined #openstack-dns | 15:34 | |
| *** yidclare has joined #openstack-dns | 16:24 | |
| *** retr0h_ is now known as retr0h | 16:25 | |
| *** retr0h has quit IRC | 16:26 | |
| *** retr0h has joined #openstack-dns | 16:26 | |
| *** richm has quit IRC | 16:27 | |
| *** shakamunyi has joined #openstack-dns | 16:33 | |
| *** shakamunyi has quit IRC | 16:33 | |
| *** shakamunyi has joined #openstack-dns | 16:34 | |
| *** bandarji has joined #openstack-dns | 16:34 | |
| *** yidclare has quit IRC | 16:36 | |
| *** richm has joined #openstack-dns | 16:40 | |
| Kiall | @mordred - I still don't believe you ;) | 16:46 |
|---|---|---|
| Kiall | oops - this ain't HipChat | 16:46 |
| timsim | At least it wasn't your password. | 16:46 |
| Kiall | timsim: I've never done that before, I swear .. <insert smiley face with fingers crossed here> | 16:47 |
| *** richm has quit IRC | 16:53 | |
| *** yidclare has joined #openstack-dns | 16:54 | |
| Kiall | meet in 5 | 16:55 |
| *** dtx00ff has joined #openstack-dns | 16:58 | |
| *** rjrjr has joined #openstack-dns | 16:59 | |
| *** crc32 has joined #openstack-dns | 17:03 | |
| *** richm has joined #openstack-dns | 17:07 | |
| *** mwagner_lap has quit IRC | 17:08 | |
| *** dtx00ff has quit IRC | 17:22 | |
| *** dtx00ff has joined #openstack-dns | 17:22 | |
| *** dtx00ff has quit IRC | 17:27 | |
| *** mwagner_lap has joined #openstack-dns | 17:36 | |
| Kiall | Heya | 18:05 |
| Kiall | jaycaz: about? | 18:05 |
| jaycaz | hey | 18:05 |
| jaycaz | so, in regards to the count feature | 18:06 |
| jaycaz | https://blueprints.launchpad.net/designate/+spec/zone-and-record-totalcount | 18:06 |
| Kiall | So .. One of the things I was thinking about when I first suggested the "Objects" stuff, was for providing a place to hold all this "extra" stuff we have and want to keep when handling our data. | 18:06 |
| Kiall | The old "everything is a dict or a list" stuff didn't give us anywhere to hold things like "What was the original value of domain.name before the end user changed it?" or "How may results do we have in total for this paged query" | 18:07 |
| jaycaz | Right. That sounds like it would be a valuable addition for a lot of different applications | 18:07 |
| Kiall | While, with the objects stuff, we actually have somewhere for that kind of info. | 18:07 |
| Kiall | https://review.openstack.org/#/c/105021 Was my first pass on getting a "ListObject" type in place, which I was doing in hopes of making the rebase of betsy's stuff easier.. The timing just happens to work for this too :) | 18:08 |
| jaycaz | haha yeah, the timing looks like it'll work out pretty well! | 18:09 |
| Kiall | With ^ review, we no longer return plain python lists from the storage layer.. we return our own Object, which can have "advanced functionality" attached to it | 18:09 |
| Kiall | https://review.openstack.org/#/c/105021/7/designate/objects/base.py | 18:09 |
| Kiall | the "class ListObjectMixin(object):" at L252 | 18:09 |
| Kiall | everything that's implemented on it today is standard "list" stuff.. | 18:09 |
| jaycaz | so, from the looks of it, the list should have the count that this feature needs | 18:10 |
| Kiall | But, we could easily expand that to include fields for things like "total_results" | 18:10 |
| jaycaz | would this count be for the list of resources before or after filtering/ | 18:10 |
| Kiall | With that, you would then be able to do things like this: | 18:10 |
| Kiall | records = RecordList(....) | 18:11 |
| Kiall | for record in records: | 18:11 |
| Kiall | print record.name | 18:11 |
| Kiall | print records.total_results | 18:11 |
| Kiall | and the storage layer can populate the "total_results" field | 18:11 |
| jaycaz | ah, that makes sense | 18:12 |
| Kiall | I think that could be implemented quite easily, with something like: .. 1 sec while 1 type it :) | 18:13 |
| Kiall | http://paste.openstack.org/show/85814/ | 18:16 |
| Kiall | Where most of ^ is implemented in #105021 | 18:17 |
| Kiall | just not the paging specific stuff | 18:17 |
| jaycaz | all right then, that seems simple enough | 18:17 |
| jaycaz | so do you think it should be implemented then? | 18:18 |
| jaycaz | at least, after your change is merged in? | 18:18 |
| Kiall | Well - I marked that change as -2 thinking that it didn't help massively with rebasing betsy's stuff, but now that there is an immediate use for it, why not merge it. | 18:19 |
| rjrjr | does Designate allow for delegation of subdomains today? | 18:19 |
| Kiall | rjrjr: graham is working on that right now, it's a feature we're on the hook for delivering real soon now at HP | 18:20 |
| Kiall | mugsie: BP link handy? | 18:20 |
| *** yidclare has quit IRC | 18:21 | |
| mugsie | eh - its aproved | 18:22 |
| jaycaz | Kiall: all right then, I'll work on it if you decide to merge it and whenever it's merged! | 18:22 |
| mugsie | you set rtd dodnt you? | 18:22 |
| Kiall | i have no idea what that means mugsie ;) | 18:22 |
| mugsie | read the docs | 18:23 |
| Kiall | jaycaz: you don't actually have to way for it to merge.. | 18:23 |
| mugsie | http://designate-specs.readthedocs.org/en/latest/specs/juno/zone-migration-between-tenants.html <- rjrjr | 18:23 |
| Kiall | you can download that change with `git review -d 105021` then, `git checkout -b expose-paging` and work away as if it was merged | 18:23 |
| jaycaz | Kiall: ah, good point. I'll do that then | 18:23 |
| Kiall | mugsie: .. Read The Docs | 18:23 |
| Kiall | rtd :) | 18:23 |
| mugsie | ? | 18:24 |
| *** dtx00ff has joined #openstack-dns | 18:25 | |
| ekarlso | betsy: u landed your v2 patch yet ? :p | 18:25 |
| Kiall | ekarlso: nope, I'm working on rebasing it now | 18:26 |
| betsy | Yeah. It’s all in Kiall’s capable hands to merge in | 18:26 |
| Kiall | betsy: capable? lol | 18:26 |
| Kiall | ;) | 18:26 |
| betsy | Definitely! :) | 18:26 |
| *** dtx00ff has quit IRC | 18:26 | |
| betsy | better you than me. :D | 18:27 |
| *** msisk_ has quit IRC | 18:27 | |
| *** msisk has joined #openstack-dns | 18:28 | |
| Kiall | Anyway - I'm going to grab a beer and re-review if https://review.openstack.org/#/c/105038/ will help or not | 18:29 |
| eankutse | Kiall: :-) | 18:32 |
| *** yidclare has joined #openstack-dns | 18:34 | |
| *** timsim has quit IRC | 18:36 | |
| *** dtx00ff has joined #openstack-dns | 18:43 | |
| *** yidclare has quit IRC | 18:45 | |
| Kiall | Okay - beer'd. ;) | 18:45 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 18:52 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 18:52 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105038 | 18:52 |
| Kiall | ^ simple rebase of my current patches.. | 18:52 |
| mugsie | Kiall: https://review.openstack.org/#/c/105843/ | 19:00 |
| *** eankutse has quit IRC | 19:03 | |
| Kiall | Is it not going to fail the requirements test again mugsie? | 19:04 |
| *** vinod2 has joined #openstack-dns | 19:04 | |
| Kiall | OHH | 19:05 |
| Kiall | Awesome | 19:05 |
| Kiall | OHH | 19:05 |
| Kiall | did you talk to doug about that? | 19:05 |
| *** vinod1 has quit IRC | 19:05 | |
| Kiall | Will it be appected? It's an alpha afterall | 19:05 |
| *** timsim has joined #openstack-dns | 19:06 | |
| *** eankutse has joined #openstack-dns | 19:07 | |
| *** jaycaz has quit IRC | 19:08 | |
| Kiall | Sometimes, I hate pep8 | 19:09 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 19:10 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105038 | 19:10 |
| Kiall | s/Sometimes/Whenever it bites me/ | 19:10 |
| *** jaycaz has joined #openstack-dns | 19:15 | |
| richm | Kiall: I find that beer helps with pep8 bites | 19:20 |
| *** shakamunyi has quit IRC | 19:20 | |
| richm | well, red wine anyway - I think the tannins help with bites | 19:21 |
| Kiall | I'm hoping the overloaded with chili pizza I'm cooking will help ;) | 19:23 |
| openstackgerrit | Vinod Mangalpally proposed a change to openstack/designate: Answer dns record queries https://review.openstack.org/105845 | 19:25 |
| Kiall | vinod2: when you said "nearly done".. i didn't think you were that close ;) | 19:26 |
| vinod2 | kiall: i had some question as TODO in the code - if you know the answers that would be helpful | 19:29 |
| timsim | Kiall/mugsie: Is the ability to have multiple pool managers sending notifies to a single pool in the plan? Say I had 10 nameservers in five different datacenters that were going to be identical. Could I have pool managers in every datacenter that all got the same message when a zone was added? | 19:31 |
| *** dtx00ff has quit IRC | 19:32 | |
| *** dtx00ff has joined #openstack-dns | 19:32 | |
| Kiall | having some dinner, will have a look in a few vinod2 | 19:33 |
| Kiall | timsim: I think the plan was each pool has 1 active and N standby mangers.. can't remember offhand | 19:33 |
| timsim | What would standby managers do? | 19:34 |
| Kiall | wait for an active to fail and takeover.. I can't remember the reasoning for active/standby offhand anymore, I'm sure mugsie does though | 19:34 |
| Kiall | I think it might have been a "small steps" thing... active/passive first.. then active/active | 19:35 |
| timsim | Right, that's what I thought, eventually there would be the ability to have multiple active pool manager for a pool. | 19:36 |
| *** yidclare has joined #openstack-dns | 19:41 | |
| Kiall | timsim: Thinking about it some more, the difficulty with multiple active pool managers was ensuring changes are applied serially. I'm not sure that's an issue with mDNS anymore, but baby steps is likely still the right way :) | 19:42 |
| timsim | Yeah, just thinking about having a really big DNS deployment where you want to have all of them serve the same data, you don't want one pool manager sending notifies to all those servers in different DCs. | 19:43 |
| *** dtx00ff has quit IRC | 19:48 | |
| *** shakamunyi has joined #openstack-dns | 19:49 | |
| Kiall | vinod2: left some comments inline, looks too simple to be true ;) | 19:49 |
| *** shakamunyi has quit IRC | 19:49 | |
| Kiall | and some more coming.. spotted 1 other thing | 19:50 |
| vinod2 | I will check what bind does with invalid packets later today | 19:52 |
| *** yidclare has quit IRC | 19:53 | |
| Kiall | published the other comments, again, looks great, I can't believe how simple it ended up :) | 19:53 |
| *** eankutse has quit IRC | 19:57 | |
| *** eankutse has joined #openstack-dns | 19:57 | |
| *** rektide_ is now known as rektide | 19:57 | |
| vinod2 | i know - once i started working on it - that was my question too - which is why i want you to validate that i have not overlooked something major | 20:02 |
| Kiall | ;) | 20:02 |
| *** msisk has quit IRC | 20:02 | |
| Kiall | There are definitely improvements to be made, things like reducing the # of text -> DNS conversions etc, but those are dependant on other changes and have to come later | 20:03 |
| Kiall | Looking at the code, I'm also thinking we "adapt" the idea of WSGI middlewares to DNS.. | 20:04 |
| *** bandarji has quit IRC | 20:04 | |
| *** bandarji has joined #openstack-dns | 20:04 | |
| Kiall | Packet comes in, First middleware decodes, second strips+validates TSIG, third does source IP filtering, finally the "app" answers | 20:05 |
| *** bandarji has quit IRC | 20:05 | |
| Kiall | But that's just me thinking out load and a few steps ahead | 20:05 |
| *** msisk has joined #openstack-dns | 20:05 | |
| Kiall | vinod2 / betsy so.. Q.. When someone does a find/get/update_recordset .. should we always include the records on the object returned? | 20:07 |
| Kiall | all the records* | 20:07 |
| Kiall | It looks like betsy's patch does that, and it looks like it'll be the same with the objects approach.. (Just thinking out loud and trying to figure out how to make the 2 play nice) | 20:09 |
| betsy | I think so, yes | 20:09 |
| vinod2 | since we do not expose the records individually or allow them to be accessed, i think so too | 20:09 |
| betsy | A recordset should always have all the records | 20:09 |
| Kiall | Okay - That's the answer I wanted to hear :) | 20:09 |
| betsy | The only other option to updating all the records would be to implement the json patch instead of using put for the updates | 20:11 |
| *** dtx00ff has joined #openstack-dns | 20:11 | |
| betsy | If we had that, it would solve a lot of the update problems | 20:11 |
| Kiall | Even then, the patch should probably apply to the RecordSet object, with the records attached | 20:11 |
| betsy | Yes, definitely | 20:12 |
| betsy | The RecordSet could have a json patch option instead of the PUT, then it’s clear which items, including which record, needs to be updated | 20:13 |
| betsy | But we haven’t implimented json patch | 20:13 |
| *** shakamunyi has joined #openstack-dns | 20:15 | |
| *** shakamunyi has quit IRC | 20:15 | |
| Kiall | Okay.. So, I'm starting to become convinced that in order to merge our patches.. I need to circle back to https://review.openstack.org/#/c/103587/ and rework it a little | 20:15 |
| Kiall | Specifically, it needs to share the same code as get/find etc do (from_sqla), and that code needs to handle SQLA relations correctly. | 20:16 |
| *** bandarji has joined #openstack-dns | 20:16 | |
| jaycaz | Kiall: so, for the zones/records count, you want to avoid two calls to central. Is it also possible to avoid two queries in the database? (one for find, one for count all) | 20:17 |
| Kiall | Sadly.. SQL sucks and 2 calls are necessary | 20:17 |
| Kiall | but ideally, 2 calls to central would be avoided, and the 2 sql queries happen in the one SQL transaction | 20:18 |
| *** vinod2 has quit IRC | 20:18 | |
| jaycaz | okay, now it's starting to all make sense! | 20:18 |
| jaycaz | thanks Kiall! | 20:18 |
| Kiall | e.g. one call to the storage driver executes both queries, and returns 1 object | 20:19 |
| *** vinod1 has joined #openstack-dns | 20:23 | |
| *** shakamunyi has joined #openstack-dns | 20:24 | |
| *** bandarji has quit IRC | 20:28 | |
| *** timsim has quit IRC | 20:32 | |
| *** yidclare has joined #openstack-dns | 20:41 | |
| *** yidclare has quit IRC | 20:41 | |
| jaycaz | Kiall: do I also need to add a field in the schema (e.g. "zones.json")? | 20:42 |
| Kiall | Yea, but that depends what we want the API to look like | 20:46 |
| Kiall | Maybe the API would be along the lines of {"domains": [], "links": {}, "meta": {"total_domains": 1.5million}} or something? | 20:47 |
| Kiall | (Total off the top of my head) | 20:47 |
| jaycaz | well, I think I have another prototype working for zones | 20:49 |
| jaycaz | it looks different from what you're saying | 20:49 |
| jaycaz | but the view can always be changed, right? | 20:49 |
| Kiall | Yep - easily enough | 20:50 |
| Kiall | As I said, off the top of my head.. We should probably put some proper thought into what the API might look at | 20:50 |
| Kiall | like* | 20:50 |
| Kiall | and compare to other APIs if they have something similar etc | 20:51 |
| Kiall | e.g. even if it's only a very small BP, it would be worth filing one to the specs repo to decide on the API | 20:52 |
| * Kiall has just broke everything.. NOOOO | 20:53 | |
| Kiall | :( | 20:53 |
| jaycaz | hmm, all right then, I'll look into that | 20:55 |
| *** jaycaz has quit IRC | 20:55 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 20:58 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Iterator methods should be on DictObjectMixin https://review.openstack.org/105020 | 20:58 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 20:58 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Update's should use objects https://review.openstack.org/103587 | 20:58 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Provide a standard method for populating an object from a model https://review.openstack.org/105874 | 20:58 |
| *** bandarji has joined #openstack-dns | 20:59 | |
| *** jaycaz has joined #openstack-dns | 21:00 | |
| *** shakamunyi has quit IRC | 21:08 | |
| *** shakamunyi has joined #openstack-dns | 21:09 | |
| *** shakamunyi has quit IRC | 21:09 | |
| *** shakamunyi has joined #openstack-dns | 21:10 | |
| Kiall | Nothing like that moment you run the tests thinking "Let's see what breaks" and you're greeted with: | 21:16 |
| Kiall | py27: commands succeeded | 21:16 |
| Kiall | congratulations :) | 21:17 |
| *** eankutse has quit IRC | 21:17 | |
| *** eankutse has joined #openstack-dns | 21:17 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105887 | 21:31 |
| vinod1 | kiall: do we have an agenda on what we want to talk about at the midsummit meetup? | 21:33 |
| Kiall | vinod1: I'm hoping it's pools pools pools ;) | 21:34 |
| Kiall | Since we're actually at the point where we can implement | 21:34 |
| Kiall | vinod1: https://review.openstack.org/#/c/105887 is my take #2 attempt at merging the records attached to recordsets and objects stuffs... Thoughts? | 21:35 |
| Kiall | It only implements the read methods so far | 21:35 |
| vinod1 | looking through it now | 21:35 |
| *** yidclare has joined #openstack-dns | 21:37 | |
| *** sballe has joined #openstack-dns | 21:42 | |
| *** jaycaz1 has joined #openstack-dns | 21:47 | |
| *** jaycaz has quit IRC | 21:49 | |
| vinod1 | kiall: regarding your change - from a quick look at this - it does look good | 21:49 |
| Kiall | Cool - I'm hoping it resolves the differences between the objects changes and betsy's change.. Hopefully :( | 21:50 |
| *** shakamunyi has quit IRC | 21:53 | |
| *** shakamunyi has joined #openstack-dns | 21:54 | |
| *** shakamunyi has quit IRC | 21:54 | |
| *** vinod1 has quit IRC | 21:55 | |
| betsy | looks good to me, but won’t my code have to change, too? In order to match? | 21:59 |
| Kiall | That's the plan, right now the code has to change anyway to match the "objects way" - I'm pretty sure the biggest disconnect between the two patches is how we handle the records on a dict vs on objects | 22:01 |
| Kiall | So, knocking that out and rebasing will hopefully fix everything :) | 22:01 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105887 | 22:01 |
| Kiall | Only update left.. the hard one.. | 22:02 |
| betsy | definitely the hardest one! | 22:02 |
| *** jaycaz1 has quit IRC | 22:02 | |
| Kiall | # TODO: Fek | 22:05 |
| Kiall | ^ what I've got so far ;) | 22:05 |
| *** msisk has quit IRC | 22:16 | |
| *** bandarji has quit IRC | 22:23 | |
| *** vinod1 has joined #openstack-dns | 22:34 | |
| *** eankutse has quit IRC | 22:51 | |
| *** vinod1 has quit IRC | 22:54 | |
| *** vinod1 has joined #openstack-dns | 22:55 | |
| *** dtx00ff has quit IRC | 22:58 | |
| *** vinod1 has quit IRC | 23:07 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: WIP: Attach records to RecordSet objects https://review.openstack.org/105887 | 23:21 |
| Kiall | betsy: Update in ^ .. Rebase time! | 23:22 |
| betsy | So what exactly do I need to do? | 23:22 |
| Kiall | Ah, I'll still do it :) I'm just sure ^ will make it easier for me :D | 23:23 |
| Kiall | now the records are exposed in an "Objects compatible" way, so there shouldn't be too much pain :) | 23:23 |
| betsy | Okay. So you’re gonna merge my stuff in, too? | 23:24 |
| Kiall | Yea, I'll try pull your stuff on top again now | 23:24 |
| Kiall | Skipping a few bits which ^ change does differently.. i.e. the storage bits | 23:25 |
| *** msisk has joined #openstack-dns | 23:25 | |
| betsy | Yeah. I saw that | 23:25 |
| Kiall | Only a few conflicts ;) http://paste.openstack.org/show/85846/ | 23:26 |
| betsy | So close! | 23:27 |
| Kiall | conflicts could still mean it's all merged horribly ;) | 23:28 |
| *** dtx00ff has joined #openstack-dns | 23:28 | |
| betsy | hopefully not :( | 23:29 |
| betsy | It’s very late in Ireland! | 23:29 |
| Kiall | Running the tests, expecting explosions. | 23:32 |
| Kiall | 99 fails - But - I'm pretty sure they all failed in the same spot for the same reason.. progress :) | 23:33 |
| betsy | Only 99 is actually pretty good. :) | 23:33 |
| Kiall | I actually think it's because of the test updates too | 23:34 |
| Kiall | text fixture* | 23:34 |
| Kiall | test* | 23:34 |
| betsy | Ah. Yes. I changed those to include a record for recordset | 23:34 |
| Kiall | the queue is small, so I'll upload | 23:34 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 23:35 |
| Kiall | test output @ https://jenkins06.openstack.org/job/gate-designate-python27/115/consoleFull | 23:36 |
| Kiall | Some kludges later to change the default fixtures back and, FAILED (id=280, failures=18 (-81)) | 23:41 |
| Kiall | and down to 13 fails :) | 23:43 |
| betsy | Nice! | 23:47 |
| Kiall | Most of those were fixed by breaking your tests though by changing the recordset fixtures back - because of the objects change, that would need to be-reworked.. I think I can sort it our without changing the fixtures though... I think. | 23:49 |
| Kiall | Anyway - 99% sure all the remaining breakage is in the tests rather than code now | 23:50 |
| betsy | Yeah!!! | 23:50 |
| *** vinod1 has joined #openstack-dns | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!