| *** nosnos has joined #openstack-dns | 01:49 | |
| *** nosnos has quit IRC | 02:09 | |
| *** vinod1 has joined #openstack-dns | 02:13 | |
| *** vinod1 has quit IRC | 02:19 | |
| *** darshan104 has joined #openstack-dns | 02:59 | |
| *** vinod1 has joined #openstack-dns | 03:06 | |
| *** vinod1 has quit IRC | 03:08 | |
| *** darshan104 has quit IRC | 03:11 | |
| *** darshan104 has joined #openstack-dns | 03:12 | |
| *** darshan104 has quit IRC | 03:16 | |
| openstackgerrit | Vinod Mangalpally proposed a change to openstack/designate: Answer dns record queries https://review.openstack.org/105845 | 03:21 |
|---|---|---|
| *** darshan104 has joined #openstack-dns | 03:31 | |
| *** darshan104 has quit IRC | 03:35 | |
| *** nosnos has joined #openstack-dns | 04:26 | |
| *** darshan104 has joined #openstack-dns | 04:31 | |
| *** k4n0 has joined #openstack-dns | 05:13 | |
| *** nosnos has quit IRC | 06:20 | |
| *** mariusv_ is now known as mariusv | 07:07 | |
| *** JensOfSweden has joined #openstack-dns | 07:11 | |
| *** Dafna has joined #openstack-dns | 08:56 | |
| *** mariusv has quit IRC | 09:49 | |
| *** mariusv has joined #openstack-dns | 09:49 | |
| *** k4n0 has quit IRC | 09:57 | |
| *** k4n0 has joined #openstack-dns | 10:11 | |
| openstackgerrit | A change was merged to openstack/designate: Answer dns record queries https://review.openstack.org/105845 | 10:23 |
| *** k4n0 has quit IRC | 10:35 | |
| *** Dafna is now known as Dafna_away | 11:01 | |
| * mugsie_ is listening to Muse - Knights of Cydonia | 11:26 | |
| mugsie_ | -_- | 11:26 |
| mugsie_ | wrong room | 11:26 |
| *** mugsie_ is now known as mugsie | 11:26 | |
| Kiall | mugsie: LOL | 11:44 |
| Kiall | nobody wants to see that stuff ;) | 11:44 |
| Kiall | Literally - Nobody. | 11:44 |
| mugsie | execpt for the room where we share our play lists | 11:44 |
| mugsie | they do want to see it - its the point of the room ;) | 11:45 |
| * Kiall has zero understanding of that room's appeal | 11:51 | |
| *** darshan104 has quit IRC | 12:06 | |
| *** Dafna_away is now known as Dafna | 12:06 | |
| *** darshan104 has joined #openstack-dns | 12:06 | |
| *** darshan104 has quit IRC | 12:11 | |
| openstackgerrit | Endre Karlson proposed a change to openstack/designate: Updated from global requirements https://review.openstack.org/106568 | 13:13 |
| *** jaycaz has joined #openstack-dns | 13:33 | |
| *** eankutse has joined #openstack-dns | 13:38 | |
| openstackgerrit | Graham Hayes proposed a change to openstack/designate: Fixed issue with roles being added to contexts https://review.openstack.org/106768 | 13:52 |
| openstackgerrit | A change was merged to openstack/designate: Updated from global requirements https://review.openstack.org/106568 | 13:54 |
| *** betsy has joined #openstack-dns | 13:57 | |
| *** betsy has quit IRC | 14:01 | |
| jaycaz | Hey Kiall, I am writing documentation on Collections and I was wondering if there should be a section on Nested Collections. There is a short one in the V2 wiki (https://wiki.openstack.org/wiki/Designate/APIv2#Nested_Collections) but Vinod was curious as to whether this needs to be in the docs as well. | 14:03 |
| Kiall | Heya - The more (accurate stuff) we can migrate from the wiki, the better :) In this case, Nested Collections aren't used in the current API (but will be once betsy's change lands_) | 14:06 |
| *** timsim has joined #openstack-dns | 14:07 | |
| jaycaz | Kiall: So, should they not be added until betsy's changes have been merged in then? | 14:12 |
| Kiall | I think it's probably OK, since we're 100% going to be merging it... | 14:18 |
| jaycaz | All right then, good to know! | 14:22 |
| jaycaz | I mean, if you're still unsure, I could just make a patch and apply it once betsy's changes are in. | 14:23 |
| *** msisk has joined #openstack-dns | 14:28 | |
| openstackgerrit | Jordan Cazamias proposed a change to openstack/designate-specs: Add spec for Zone and Record TotalCount https://review.openstack.org/106098 | 14:48 |
| *** richm has joined #openstack-dns | 14:55 | |
| *** jaycaz has quit IRC | 14:58 | |
| *** eankutse1 has joined #openstack-dns | 15:01 | |
| *** eankutse has quit IRC | 15:01 | |
| *** jaycaz has joined #openstack-dns | 15:19 | |
| *** betsy_ has joined #openstack-dns | 15:29 | |
| *** vinod1 has joined #openstack-dns | 15:30 | |
| *** eankutse1 has quit IRC | 15:35 | |
| *** eankutse has joined #openstack-dns | 15:35 | |
| *** bandarji has joined #openstack-dns | 15:36 | |
| openstackgerrit | A change was merged to openstack/designate: Iterator methods should be on DictObjectMixin https://review.openstack.org/105020 | 15:36 |
| *** eankutse1 has joined #openstack-dns | 15:38 | |
| *** eankutse has quit IRC | 15:39 | |
| *** rmoe has joined #openstack-dns | 15:53 | |
| *** jaycaz has quit IRC | 15:56 | |
| *** betsy_ has quit IRC | 15:57 | |
| *** jaycaz has joined #openstack-dns | 16:00 | |
| *** vinod1 has quit IRC | 16:01 | |
| *** richm has quit IRC | 16:02 | |
| *** timsim has quit IRC | 16:02 | |
| *** msisk_ has joined #openstack-dns | 16:03 | |
| *** vinod1 has joined #openstack-dns | 16:03 | |
| *** betsy has joined #openstack-dns | 16:04 | |
| *** jaycaz1 has joined #openstack-dns | 16:04 | |
| *** jaycaz has quit IRC | 16:05 | |
| *** msisk has quit IRC | 16:05 | |
| *** eankutse1 has quit IRC | 16:05 | |
| *** eankutse has joined #openstack-dns | 16:05 | |
| *** richm has joined #openstack-dns | 16:15 | |
| *** richm has quit IRC | 16:26 | |
| *** sballe has quit IRC | 16:39 | |
| *** richm has joined #openstack-dns | 16:40 | |
| *** sballe has joined #openstack-dns | 16:40 | |
| *** richm has quit IRC | 16:49 | |
| *** richm has joined #openstack-dns | 17:07 | |
| *** jaycaz1 has quit IRC | 17:08 | |
| *** vinod1 has quit IRC | 17:08 | |
| *** jaycaz has joined #openstack-dns | 17:09 | |
| *** jaycaz has quit IRC | 17:17 | |
| *** vinod1 has joined #openstack-dns | 17:17 | |
| *** yidclare has joined #openstack-dns | 17:19 | |
| *** jaycaz has joined #openstack-dns | 17:21 | |
| *** eankutse1 has joined #openstack-dns | 17:26 | |
| *** eankutse has quit IRC | 17:26 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 17:34 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Implement a ListObjectMixin class https://review.openstack.org/105021 | 17:42 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Attach records to RecordSet objects https://review.openstack.org/105887 | 17:50 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 17:53 |
| *** jaycaz has quit IRC | 17:53 | |
| openstackgerrit | Graham Hayes proposed a change to openstack/designate: Fixed D701 Hacking check https://review.openstack.org/106768 | 17:54 |
| *** betsy has quit IRC | 18:03 | |
| *** betsy has joined #openstack-dns | 18:04 | |
| *** darshan104 has joined #openstack-dns | 18:05 | |
| *** vinod1 has quit IRC | 18:18 | |
| *** shakamunyi has joined #openstack-dns | 18:21 | |
| *** betsy has quit IRC | 18:23 | |
| *** vinod1 has joined #openstack-dns | 18:29 | |
| *** tylerdurden has joined #openstack-dns | 18:32 | |
| *** tylerdurden is now known as shakamunyi_otp | 18:32 | |
| *** betsy_ has joined #openstack-dns | 18:32 | |
| *** betsy has joined #openstack-dns | 18:34 | |
| *** betsy has left #openstack-dns | 18:35 | |
| *** betsy has joined #openstack-dns | 18:35 | |
| vinod1 | kiall: #link https://review.openstack.org/#/c/106094/2/designate/central/service.py | 18:38 |
| vinod1 | This adds a new method count_report - for the report extensions | 18:39 |
| Kiall | Heya | 18:39 |
| vinod1 | should the rpc version be bumped up or can it stay the same? | 18:39 |
| Kiall | It should be bumped by a minor version, but with all the activity we have right know, I was thinking we ignore that for the minute and wait for things to settle | 18:40 |
| vinod1 | i am fine with that | 18:40 |
| *** betsy_ has left #openstack-dns | 18:41 | |
| *** darshan104 has quit IRC | 18:42 | |
| *** eankutse1 has quit IRC | 18:44 | |
| *** betsy has quit IRC | 18:44 | |
| openstackgerrit | A change was merged to openstack/designate: Implement equality methods on DesignateObject https://review.openstack.org/105036 | 18:44 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 18:48 |
| Kiall | betsy: So - All the tests should pass on ^ now.. I'm 100% sure I've broken some stuff which isn't being tested though - But at least it passes ;) | 18:49 |
| *** darshan104 has joined #openstack-dns | 18:52 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 18:53 |
| *** betsy has joined #openstack-dns | 19:07 | |
| *** jaycaz has joined #openstack-dns | 19:13 | |
| *** eankutse has joined #openstack-dns | 19:16 | |
| vinod1 | kiall: Re: your ListObjectMixin - what is the primary motivation to have this change? | 19:17 |
| Kiall | vinod1: for the recordset.record list | 19:18 |
| Kiall | recordset.records* | 19:18 |
| Kiall | additionally, gives us something to keep more advanced stuff to do with our lists as we go - e.g. total records on a paginated list, or restrictions upon the type of objects that can placed in a list (e.g. you can't put a objects.Domain() into a record's list) | 19:19 |
| vinod1 | that makes sense - just had a few comments/questions on this - i just added it to the code review. | 19:20 |
| openstackgerrit | Graham Hayes proposed a change to openstack/designate: Added proper handling for 405 errors https://review.openstack.org/106847 | 19:23 |
| *** vinod1 has quit IRC | 19:29 | |
| *** darshan104 has quit IRC | 19:31 | |
| *** vinod1 has joined #openstack-dns | 19:34 | |
| vinod1 | kiall: wanted to get your thoughts on report extenstions on v2 | 19:38 |
| vinod1 | #link https://review.openstack.org/#/c/106094/2 | 19:38 |
| vinod1 | if you try to get reports on a non-existent tenant you get a response with a 0 count | 19:38 |
| vinod1 | should it trhow an exception instead of returning a count of 0? | 19:39 |
| Kiall | So, non-existent tenant is something OpenStack in general sucks at. We have no way to know if the tenant id is valid or not, only how many of our resources it consumes. | 19:40 |
| vinod1 | ahh | 19:40 |
| vinod1 | so which is why we return 0? | 19:40 |
| Kiall | I'm not sure it would be right to raise an exception instead of a 0 when the tenant_id is valid, but just hasn't created any domains etc on us | 19:40 |
| Kiall | Yea.. Pretty much | 19:40 |
| vinod1 | Thanks for the clarification. | 19:41 |
| *** betsy has quit IRC | 19:41 | |
| Kiall | In theory, we could call out to keystone and find out if it's valid, but none of the services do that AFAIK, and I know we would have to remove that code for HP Cloud anyway, as we don't give the services admin access to keystone | 19:41 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 19:42 |
| *** betsy has joined #openstack-dns | 19:46 | |
| *** nkinder has joined #openstack-dns | 19:55 | |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 19:57 |
| Kiall | betsy: Rebase complete.. PHEW. | 19:57 |
| openstackgerrit | A change was merged to openstack/designate: Added proper handling for 405 errors https://review.openstack.org/106847 | 19:57 |
| Kiall | betsy: please have a look and make sure I didn't miss anything :) | 20:00 |
| vinod1 | mugsie: re https://review.openstack.org/#/c/106768/1..2/designate/objects/base.py | 20:02 |
| vinod1 | Is the change in DictObjectMixin related to the other changes that you are making? | 20:03 |
| vinod1 | The reason that I ask - one of Kiall's patchsets makes the same change - https://review.openstack.org/#/c/105021/12/designate/objects/base.py | 20:03 |
| vinod1 | actually i was comparing the wrong patchsets - so forget about my question | 20:04 |
| mugsie | :D | 20:07 |
| Kiall | vinod1: you spotted the extra case where the mutable default argument value was being allowed, and then we remembered we had added a test for that.. and fixed the test to actually work ;) | 20:07 |
| Kiall | It caught a bunch more | 20:07 |
| Kiall | pep8 clean this time -_- | 20:09 |
| openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Modify Recordset API https://review.openstack.org/102892 | 20:09 |
| Kiall | vinod1: you reviewed patchset #2 of betsy's RecordSet API change - I've rebased it etc etc - but not addressed any comments, at least, not unless they needed to happen in order to make it work after the rebase.. It should be safe to review again | 20:10 |
| vinod1 | betsy plans to make the changes to address my comments now that everything is merged | 20:12 |
| vinod1 | her machine is down - so she is not on IRC now | 20:13 |
| Kiall | always fun :) | 20:13 |
| Kiall | vinod1: I've left some comments on PS2 where you last commented, agreeing, but suggesting we make most of them followup patchsets. | 20:17 |
| vinod1 | kiall: Re the comment that I made in ListObjectMixin's __init__ method - what I meant was that it makes an assumption that an object would inherit from DesignateObject and ListObjectMixin for this to work | 20:25 |
| vinod1 | My comment was to see if we could make this to work without that assumption | 20:25 |
| vinod1 | But as you mentioned we could revisit this in a later change if needed | 20:26 |
| Kiall | Ohh, I see what you mean now.. The Dict/ListObjectMixins are only intended to be used in combination with a DesignateObject. But, we can't have them directly inherit from DesignateObject without causing issues | 20:26 |
| Kiall | e.g. in theory, there is nothing stopping you from having another mixin class which can coexist with say - DictObjectMixin - at that point, you would have 2 paths to DesignateObject through the MRO tree - which will be.. painful. | 20:28 |
| Kiall | (MRO tree = Method Resolution Order tree, or, the objects inheritance tree) | 20:28 |
| vinod1 | the problems of multiple inheritance | 20:30 |
| Kiall | Yep - The joys and pain of multiple inheritance :) | 20:30 |
| openstackgerrit | A change was merged to openstack/designate: Fixed D701 Hacking check https://review.openstack.org/106768 | 20:40 |
| *** vinod1 has quit IRC | 20:51 | |
| *** yidclare has left #openstack-dns | 20:53 | |
| *** eankutse has quit IRC | 20:58 | |
| *** betsy_ has joined #openstack-dns | 21:02 | |
| *** betsy has quit IRC | 21:02 | |
| *** betsy_ is now known as betsy | 21:02 | |
| *** betsy has quit IRC | 21:07 | |
| *** msisk_ has quit IRC | 21:11 | |
| *** betsy has joined #openstack-dns | 21:15 | |
| *** openstackgerrit has quit IRC | 21:31 | |
| *** openstackgerrit has joined #openstack-dns | 21:32 | |
| *** ChanServ sets mode: +v openstackgerrit | 21:32 | |
| *** shakamunyi has quit IRC | 21:40 | |
| *** msisk has joined #openstack-dns | 22:01 | |
| *** msisk has quit IRC | 22:02 | |
| openstackgerrit | Betsy Luzader proposed a change to openstack/designate: Port Report Extensions from v1 to v2 https://review.openstack.org/106094 | 22:13 |
| *** vinod1 has joined #openstack-dns | 22:31 | |
| *** bandarji has quit IRC | 22:33 | |
| *** crc32 has joined #openstack-dns | 22:46 | |
| *** betsy has quit IRC | 23:13 | |
| *** jaycaz has quit IRC | 23:29 | |
| *** jaycaz has joined #openstack-dns | 23:30 | |
| *** jaycaz has quit IRC | 23:30 | |
| *** richm has left #openstack-dns | 23:37 | |
| *** vinod1 has quit IRC | 23:38 | |
| *** nosnos has joined #openstack-dns | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!