| *** richm has joined #openstack-dns | 00:00 | |
| *** jmcbride has joined #openstack-dns | 00:12 | |
| *** EricGonczer_ has joined #openstack-dns | 00:15 | |
| *** EricGonczer_ has quit IRC | 00:16 | |
| *** dtalton has quit IRC | 00:19 | |
| *** jmcbride has quit IRC | 00:25 | |
| rjrjr | betsy: i'm here. | 00:43 |
|---|---|---|
| *** dtx00ff has quit IRC | 00:58 | |
| *** dtx00ff has joined #openstack-dns | 00:58 | |
| *** dtx00ff has quit IRC | 01:01 | |
| *** amcrn has quit IRC | 01:16 | |
| *** EricGonczer_ has joined #openstack-dns | 01:36 | |
| *** jmcbride has joined #openstack-dns | 02:07 | |
| *** jmcbride has quit IRC | 02:12 | |
| *** EricGonczer_ has quit IRC | 02:25 | |
| *** vinod1 has joined #openstack-dns | 02:39 | |
| *** vinod1 has quit IRC | 02:40 | |
| *** richm has quit IRC | 03:00 | |
| *** msisk has joined #openstack-dns | 03:15 | |
| *** msisk has quit IRC | 03:17 | |
| *** jordanP has joined #openstack-dns | 07:31 | |
| *** jordanP has quit IRC | 07:36 | |
| *** jordanP has joined #openstack-dns | 07:48 | |
| *** jordanP has quit IRC | 08:12 | |
| *** jordanP has joined #openstack-dns | 08:19 | |
| *** jordanP has quit IRC | 08:24 | |
| *** jordanP has joined #openstack-dns | 08:36 | |
| jordanP | hi | 09:12 |
| jordanP | is Vinod Mangalpallyarround ? | 09:12 |
| openstackgerrit | Jordan Pittier proposed a change to openstack/designate: Bind9 zone file should end with a new line https://review.openstack.org/121792 | 09:50 |
| *** alokj has joined #openstack-dns | 09:55 | |
| openstackgerrit | Jordan Pittier proposed a change to openstack/designate: Bind9 zone file should end with a new line https://review.openstack.org/121792 | 09:59 |
| *** Guest2046 is now known as puck | 10:46 | |
| *** mwagner_lap has quit IRC | 11:03 | |
| *** EricGonczer_ has joined #openstack-dns | 11:22 | |
| *** EricGonczer_ has quit IRC | 11:36 | |
| jordanP | Kiall, regarding https://review.openstack.org/#/c/121792/ I unit test is missing | 12:13 |
| Kiall | Oh, which one? | 12:13 |
| jordanP | it would test that the bind9-zone.jinja2 indeed ends with a empty line | 12:13 |
| jordanP | otherwise someone could in the future silenty remove this empty line a added in the patch | 12:13 |
| jordanP | *I | 12:13 |
| Kiall | Ah, So, you could have a test use utils.resource_string() to load the template up as a string, then validate it ends with \n | 12:14 |
| jordanP | exactly | 12:14 |
| jordanP | i am currently writting this test | 12:14 |
| Kiall | Removed my +2, in case someone get's to thge +A before you submit again :) | 12:15 |
| Kiall | the* | 12:15 |
| jordanP | yeah, I should have marked this as a WIP | 12:16 |
| Kiall | I find the Gerrit WIP implementation a pain to be honest - it's too easy to accidentally "remove" the WIP.. | 12:17 |
| jordanP | Kiall, for the last test, I thought of putting it in a different place, it would go as : designate.tests.test_resources.test_templates.test_bind9.Bind9Test.test_bind9_zone_ends_with_empty_line | 12:17 |
| jordanP | what di you think ? | 12:17 |
| Kiall | Sure, bind9 is sorely lacking in any real test at the moment anyway, so that's as good a place as any | 12:18 |
| jordanP | ok cool | 12:19 |
| *** richm has joined #openstack-dns | 12:21 | |
| *** mwagner_lap has joined #openstack-dns | 12:38 | |
| openstackgerrit | Jordan Pittier proposed a change to openstack/designate: Bind9 zone file should end with a new line https://review.openstack.org/121792 | 12:43 |
| *** nkinder has quit IRC | 13:16 | |
| *** msisk has joined #openstack-dns | 13:16 | |
| *** msisk has quit IRC | 13:49 | |
| *** nkinder has joined #openstack-dns | 14:01 | |
| openstackgerrit | A change was merged to openstack/designate: Bind9 zone file should end with a new line https://review.openstack.org/121792 | 14:20 |
| *** paul_glass has joined #openstack-dns | 14:47 | |
| *** timsim has joined #openstack-dns | 14:50 | |
| *** EricGonczer_ has joined #openstack-dns | 14:52 | |
| *** paul_glass has quit IRC | 15:00 | |
| *** EricGonczer_ has quit IRC | 15:05 | |
| *** betsy has joined #openstack-dns | 15:05 | |
| *** jmcbride has joined #openstack-dns | 15:05 | |
| *** alokj has quit IRC | 15:27 | |
| *** zain has joined #openstack-dns | 15:51 | |
| *** RaginBajin has quit IRC | 16:03 | |
| *** EricGonczer_ has joined #openstack-dns | 16:14 | |
| *** jmcbride has quit IRC | 16:18 | |
| *** jordanP has quit IRC | 16:20 | |
| *** alokj has joined #openstack-dns | 16:27 | |
| *** alokj is now known as Guest662 | 16:27 | |
| *** timsim has quit IRC | 16:32 | |
| *** jmcbride has joined #openstack-dns | 16:35 | |
| *** timsim has joined #openstack-dns | 16:36 | |
| *** jmcbride has quit IRC | 16:36 | |
| *** betsy has quit IRC | 16:38 | |
| *** jmcbride has joined #openstack-dns | 16:38 | |
| *** betsy has joined #openstack-dns | 17:00 | |
| *** dtx00ff has joined #openstack-dns | 17:02 | |
| *** Guest662 has quit IRC | 17:17 | |
| *** richm has quit IRC | 17:28 | |
| *** simonmcc has quit IRC | 17:28 | |
| *** simonmcc has joined #openstack-dns | 17:29 | |
| *** richm has joined #openstack-dns | 17:33 | |
| *** dtx00ff has quit IRC | 17:38 | |
| *** dtx00ff has joined #openstack-dns | 17:39 | |
| *** jmcbride has quit IRC | 17:43 | |
| *** dtx00ff has quit IRC | 17:43 | |
| *** jmcbride has joined #openstack-dns | 17:44 | |
| *** jmcbride has quit IRC | 17:50 | |
| *** jmcbride has joined #openstack-dns | 18:31 | |
| *** dtx00ff has joined #openstack-dns | 18:59 | |
| harmw | lol, I was planning to add a bugreport about that :p | 19:41 |
| harmw | plus fix | 19:41 |
| *** jmcbride has quit IRC | 19:41 | |
| *** jmcbride has joined #openstack-dns | 19:43 | |
| *** mwagner_lap has quit IRC | 20:56 | |
| *** betsy has quit IRC | 21:14 | |
| *** betsy has joined #openstack-dns | 21:15 | |
| *** betsy has quit IRC | 21:50 | |
| *** jmcbride1 has joined #openstack-dns | 21:51 | |
| *** jmcbride has quit IRC | 21:54 | |
| *** jmcbride1 has quit IRC | 21:54 | |
| *** jmcbride has joined #openstack-dns | 21:55 | |
| *** timsim has quit IRC | 21:55 | |
| *** jmcbride has quit IRC | 22:01 | |
| *** EricGonczer_ has quit IRC | 22:08 | |
| *** nkinder has quit IRC | 22:09 | |
| *** dtx00ff has quit IRC | 22:26 | |
| *** timsim has joined #openstack-dns | 22:41 | |
| *** dtx00ff has joined #openstack-dns | 22:41 | |
| *** dtx00ff has quit IRC | 22:45 | |
| *** dtx00ff has joined #openstack-dns | 22:45 | |
| *** dtx00ff has quit IRC | 22:45 | |
| *** dtx00ff has joined #openstack-dns | 22:46 | |
| *** mwagner_lap has joined #openstack-dns | 22:53 | |
| *** nkinder has joined #openstack-dns | 23:01 | |
| *** betsy has joined #openstack-dns | 23:07 | |
| *** richm has quit IRC | 23:13 | |
| *** timsim has quit IRC | 23:22 | |
| *** Guest72739 is now known as mgagne | 23:42 | |
| *** mgagne has joined #openstack-dns | 23:42 | |
| *** ekarlso has quit IRC | 23:48 | |
| *** ekarlso has joined #openstack-dns | 23:48 | |
| *** zain has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!