*** rmoe has quit IRC | 00:19 | |
*** rmoe has joined #openstack-dns | 00:35 | |
*** shakayumi has quit IRC | 00:45 | |
*** amcrn has quit IRC | 01:00 | |
*** richm has quit IRC | 01:01 | |
*** EricGonczer_ has joined #openstack-dns | 01:24 | |
*** EricGonczer_ has quit IRC | 01:32 | |
*** EricGonczer_ has joined #openstack-dns | 01:32 | |
*** jmcbride has joined #openstack-dns | 01:32 | |
*** EricGonczer_ has quit IRC | 01:34 | |
*** openstack has joined #openstack-dns | 01:42 | |
*** ChanServ sets mode: +v openstack | 01:42 | |
*** openstackgerrit has joined #openstack-dns | 01:52 | |
*** ChanServ sets mode: +v openstackgerrit | 01:52 | |
*** nosnos has joined #openstack-dns | 01:52 | |
*** shakamunyi has joined #openstack-dns | 01:58 | |
*** jmcbride has quit IRC | 02:10 | |
*** shakayumi has joined #openstack-dns | 02:24 | |
*** shakamunyi has quit IRC | 02:27 | |
*** vinod1 has joined #openstack-dns | 02:30 | |
*** vinod1 has quit IRC | 02:31 | |
*** slawqo has quit IRC | 02:43 | |
*** amcrn has joined #openstack-dns | 02:47 | |
*** mwagner_lap has joined #openstack-dns | 02:57 | |
*** amcrn has quit IRC | 03:50 | |
*** nosnos has quit IRC | 03:50 | |
*** nosnos has joined #openstack-dns | 03:51 | |
*** nosnos has quit IRC | 03:55 | |
*** nosnos has joined #openstack-dns | 04:30 | |
*** ttrumm has joined #openstack-dns | 06:00 | |
*** zigo has joined #openstack-dns | 06:08 | |
*** jordanP has joined #openstack-dns | 07:44 | |
openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Enforce all Object attributes are private or well defined https://review.openstack.org/128282 | 11:48 |
---|---|---|
openstackgerrit | Kiall Mac Innes proposed a change to openstack/designate: Correct int datatypes during zone import https://review.openstack.org/128280 | 11:51 |
*** jmcbride has joined #openstack-dns | 11:58 | |
*** EricGonczer_ has joined #openstack-dns | 12:10 | |
*** EricGonczer_ has quit IRC | 12:14 | |
*** jmcbride has quit IRC | 12:17 | |
*** jmcbride has joined #openstack-dns | 12:49 | |
*** jmcbride has quit IRC | 12:51 | |
*** richm has joined #openstack-dns | 13:17 | |
openstackgerrit | A change was merged to openstack/designate: Convert Object FIELDS from list to dict https://review.openstack.org/127845 | 13:18 |
*** EricGonczer_ has joined #openstack-dns | 13:19 | |
*** EricGonczer_ has quit IRC | 13:33 | |
*** timsim has joined #openstack-dns | 13:35 | |
*** paul_glass has joined #openstack-dns | 13:43 | |
*** jmcbride has joined #openstack-dns | 13:45 | |
*** paul_glass has quit IRC | 13:46 | |
*** EricGonczer_ has joined #openstack-dns | 14:02 | |
*** vinod1 has joined #openstack-dns | 14:03 | |
*** ttrumm has quit IRC | 14:11 | |
*** shakayumi has quit IRC | 14:12 | |
*** betsy has quit IRC | 14:14 | |
openstackgerrit | A change was merged to openstack/designate: Add a UUID Schema format checker https://review.openstack.org/128291 | 14:28 |
openstackgerrit | A change was merged to openstack/designate: Correct int datatypes during zone import https://review.openstack.org/128280 | 14:38 |
*** paul_glass has joined #openstack-dns | 14:40 | |
*** jmcbride has quit IRC | 14:59 | |
*** jmcbride has joined #openstack-dns | 15:00 | |
*** betsy has joined #openstack-dns | 15:00 | |
*** paul_glass has quit IRC | 15:00 | |
*** timsim has quit IRC | 15:00 | |
*** vinod1 has quit IRC | 15:01 | |
*** vinod1 has joined #openstack-dns | 15:03 | |
*** vinod1 has quit IRC | 15:03 | |
*** timsim has joined #openstack-dns | 15:08 | |
*** jmcbride has quit IRC | 15:11 | |
*** vinod1 has joined #openstack-dns | 15:11 | |
*** jmcbride has joined #openstack-dns | 15:11 | |
*** paul_glass has joined #openstack-dns | 15:12 | |
*** nosnos has quit IRC | 15:27 | |
*** rmoe has quit IRC | 15:52 | |
*** rmoe has joined #openstack-dns | 16:16 | |
*** paul_glass has quit IRC | 16:29 | |
*** paul_glass has joined #openstack-dns | 16:31 | |
*** paul_glass has quit IRC | 16:34 | |
*** rjrjr has joined #openstack-dns | 16:39 | |
*** paul_glass has joined #openstack-dns | 16:47 | |
*** paul_glass has quit IRC | 16:53 | |
*** jmcbride has quit IRC | 16:54 | |
*** paul_glass has joined #openstack-dns | 16:54 | |
*** mugsie has joined #openstack-dns | 16:57 | |
*** jmcbride has joined #openstack-dns | 17:24 | |
*** jmcbride has quit IRC | 17:29 | |
*** jordanP has quit IRC | 17:39 | |
*** jmcbride has joined #openstack-dns | 17:54 | |
*** jmcbride has quit IRC | 17:58 | |
vinod1 | continuing discussion here | 18:00 |
mugsie | vinod1, yeah - they should be taken out of the API | 18:01 |
betsy | What should be taken out? | 18:01 |
rjrjr | ? | 18:01 |
vinod1 | since we already are doing the api - why not have it in the api, instead of in the config file? | 18:01 |
mugsie | pool servers | 18:01 |
Kiall | brb.. | 18:01 |
betsy | I thought only the default server name went in the config file | 18:01 |
vinod1 | i mean in the api and database | 18:01 |
mugsie | because we decided against storing any data about servers in the db | 18:01 |
rjrjr | we discussed this in seattle. | 18:01 |
vinod1 | i remember now - sensitive data about servers in the config | 18:02 |
betsy | I guess since I wasn’t there I missed that | 18:02 |
mugsie | yeah | 18:02 |
betsy | Ah. makes sense | 18:02 |
timsim | I think we agreed we could cascade if needed, check config->database | 18:02 |
timsim | So for the initial bit, just the config is fine. | 18:03 |
rjrjr | no, we agreed just in the config file. | 18:03 |
Kiall | ^ yes, we agreed just config for 1.0 of poolsd | 18:03 |
rjrjr | we did discuss cascade, but we decided it was not a good idea. | 18:03 |
mugsie | there was too much complexity doing the cascade | 18:03 |
Kiall | (So many iterations, it's hard to remember) | 18:03 |
timsim | Ah. Makes sense | 18:03 |
rjrjr | the code for this will be day later today or tomorrow in either case. | 18:04 |
betsy | rjrjr: the code for the server pool service? | 18:05 |
rjrjr | read the server configuration fro the file along with the backend configuration. | 18:05 |
vinod1 | so when we want to add a new pool - we add the pool with the api and then update the config to add the pool servers for the pool and then start the pool manager service? | 18:07 |
betsy | That doesn’t really make sense | 18:07 |
rjrjr | the pool name goes into the config too. | 18:07 |
rjrjr | you can add that info to the config for the pool first. | 18:08 |
timsim | I think this is the way it works for 1.0, yes? | 18:08 |
rjrjr | correct. | 18:08 |
vinod1 | How about later? | 18:09 |
rjrjr | you don't need to wait to add a server. remember, the servers in the config file are for the pool managed by that instance of designate-pool-manager. | 18:09 |
timsim | The pool still gets created in the DB though. | 18:09 |
rjrjr | add a server - add the servers | 18:09 |
Kiall | Yea - "pool" exists in the DB, as does pool nameservers (since we need to add/remove NS records based on those) - Everything else is "hidden" behind the poolmanager service, and not in the API for v1 | 18:10 |
Kiall | for v1 of pools | 18:10 |
vinod1 | we would still need to go through the api to create a pool and add the name servers for that pool and specify other attributes of the pool | 18:10 |
Kiall | vinod1: Yep - I think we're saying the same thing.. But details of the physical nameservers, and the backend options like credentials etc, are not in the pools v1 API | 18:11 |
vinod1 | okay that makes sense - i will get working on the pools api then | 18:12 |
vinod1 | coordinating all the various work items in the pools now looks tricky | 18:13 |
vinod1 | we would probably have to do multiple rebases every time a change is merged | 18:13 |
Kiall | vinod1: I think we need to try ensure we can merge each piece one at a time.. e.g. merging the pool manager service should break nothing | 18:14 |
rjrjr | kiall: not true. becky and are both doing storage work. | 18:14 |
Kiall | rjrjr: in theory, the 2 migrations can just stack unless your both modifying the same columns of existing tables etc.. | 18:15 |
rjrjr | i am okay with getting becky's in first. i'll treat my commits as WIP in the meantime. | 18:15 |
rjrjr | well, i saw we both have the same db migration number. that needs to be reconciled. | 18:15 |
rjrjr | 41 i believe. | 18:16 |
Kiall | Okay.. Before I head off till Monday.. I put up a WIP review for moving validation into the Objects, https://review.openstack.org/#/c/127846/, some thoughts on the changes inside the objects folder, and thoughts on the open questions in the commit message would be nice.. It's apparently becoming a bigger change than I thought, so I'll write up a spec etc once I have a better understanding of the open questions.. | 18:16 |
*** jmcbride has joined #openstack-dns | 18:16 | |
Kiall | rjrjr: yep, whoever merges first get's 41.. other person has to bump to 42 :) | 18:16 |
rjrjr | i'll just keep updating mine until betsy's is in. | 18:17 |
*** jmcbride has quit IRC | 18:17 | |
betsy | Mine should be in today | 18:17 |
rjrjr | (betsy, i cannot believe i called you becky again. sorry.) | 18:17 |
betsy | no problem. :) | 18:17 |
betsy | I respond to anything | 18:17 |
vinod1 | When would I want this one to go in - https://review.openstack.org/#/c/125868/? | 18:17 |
vinod1 | s/I/you | 18:17 |
Kiall | rjrjr: I also have 2 comments pending on that review (1 re the migration ;)) - It's not a complete review, but I've gotta run till Monday so I'll just post them | 18:17 |
rjrjr | sure. i'll just update that (treat it as WIP) until next week. | 18:18 |
Kiall | vinod1: ideally, we'd avoid breaking the NOTIFY's (we can send duplicate NOTIFY's for the moment, no harm), then whenever really | 18:18 |
vinod1 | okay I will update the change to still continue to send the NOTIFY's from central | 18:19 |
Kiall | vinod1: other than that, I don't remember any reasons why it's not okay to megre (bear in mind, I've not looked at it in a week ;) | 18:19 |
vinod1 | Once we have the pool manager sending the notifies, then we can remove the central sending the notifies | 18:20 |
Kiall | vinod1: exactly :) | 18:20 |
vinod1 | How long will you be around Kiall? | 18:21 |
*** jmcbride has joined #openstack-dns | 18:21 | |
rjrjr | kiall, one question. i had problems creating a foreign key on the pool_manager_status table for the domains.id. | 18:21 |
Kiall | About 45 seconds? I put my chances of an internet connection about 50/50 tomorrow + the day after ;) | 18:21 |
Kiall | I'll be around again tonight - if your wanting a review once you upload the next PS? | 18:21 |
rjrjr | if i create a separate database, no foreign key required, correct? | 18:22 |
vinod1 | ok mugsie and betsy can review the mdns change then | 18:22 |
mugsie | I am gone from this time tomorrow ;) | 18:22 |
Kiall | rjrjr: yea, but if there was an issue creating it (e.g. mysql complaining it's an incompatible type), then we should probably fix that either way | 18:22 |
Kiall | (My Sisters wedding, and it wouldn't be a Mac Innes wedding without mugsie ;)) | 18:23 |
rjrjr | i'll look again. i believe the complaint was no domains table to be found. this was while running unit tests. | 18:23 |
rjrjr | yet all the tests passed. | 18:23 |
rjrjr | (when i took out the foreign key.) | 18:24 |
rjrjr | we can discuss more next week if i don't figure it out. | 18:24 |
Kiall | Sounds good | 18:24 |
*** mugsie has quit IRC | 18:25 | |
Kiall | Okay - Cyas :) | 18:25 |
vinod1 | Have a great time | 18:26 |
*** jmcbride has quit IRC | 18:29 | |
*** jmcbride has joined #openstack-dns | 18:40 | |
*** jmcbride has quit IRC | 18:40 | |
*** jmcbride has joined #openstack-dns | 18:40 | |
*** jmcbride1 has joined #openstack-dns | 18:43 | |
*** jmcbride1 has quit IRC | 18:43 | |
*** jmcbride has quit IRC | 18:43 | |
*** jmcbride1 has joined #openstack-dns | 18:44 | |
*** Kiall has quit IRC | 18:56 | |
*** Kiall has joined #openstack-dns | 19:01 | |
*** amcrn has joined #openstack-dns | 19:03 | |
*** jmcbride1 has quit IRC | 19:22 | |
*** jmcbride has joined #openstack-dns | 19:25 | |
*** EricGonczer_ has quit IRC | 19:29 | |
*** EricGonczer_ has joined #openstack-dns | 19:49 | |
*** EricGonczer_ has quit IRC | 19:51 | |
*** EricGonczer_ has joined #openstack-dns | 20:12 | |
*** vinod1 has quit IRC | 20:26 | |
*** paul_glass has quit IRC | 20:29 | |
*** EricGonczer_ has quit IRC | 20:30 | |
*** paul_glass1 has joined #openstack-dns | 20:32 | |
*** EricGonczer_ has joined #openstack-dns | 20:38 | |
*** vinod1 has joined #openstack-dns | 20:39 | |
*** EricGonczer_ has quit IRC | 20:49 | |
*** vinod1 has quit IRC | 21:03 | |
*** jmcbride has quit IRC | 21:11 | |
openstackgerrit | Betsy Luzader proposed a change to openstack/designate: Server Pools Storage https://review.openstack.org/127355 | 21:14 |
*** jmcbride has joined #openstack-dns | 21:16 | |
*** amcrn has quit IRC | 21:28 | |
*** EricGonczer_ has joined #openstack-dns | 21:35 | |
*** EricGonczer_ has quit IRC | 21:45 | |
*** timsim has quit IRC | 21:48 | |
*** paul_glass1 has quit IRC | 21:56 | |
*** jmcbride has quit IRC | 21:58 | |
*** rjrjr_ has joined #openstack-dns | 22:04 | |
rjrjr_ | betsy, you on? | 22:06 |
betsy | Yep | 22:06 |
betsy | What’s up? | 22:06 |
rjrjr_ | did your changes get merged? | 22:06 |
betsy | For Server Pools Storage? | 22:06 |
rjrjr_ | yes. | 22:06 |
betsy | Nope. I just submitted the final version of it | 22:06 |
betsy | It should be good to go, though. | 22:07 |
rjrjr_ | okay. i think i'd rather not wait until next week. 8^) | 22:07 |
betsy | Problem is mugsie and kiall are out the rest of the week, I think | 22:07 |
rjrjr_ | ahhh... | 22:07 |
betsy | Wait for what? | 22:07 |
rjrjr_ | i was going to keep updating what I submitted. but i'd like my code merged. | 22:07 |
rjrjr_ | we cannot merge without kiall or mugsie? | 22:07 |
betsy | Oh, have you submitted the server pool service? | 22:08 |
rjrjr_ | part of it, yes. | 22:08 |
betsy | vinod and I can both +2 things, if we have to | 22:08 |
rjrjr_ | i have some small changes to make to it and then i'd like it merged if possible. | 22:08 |
betsy | Oh, I didn’t realize that could be merged by itself. | 22:08 |
betsy | Ok. Keep vinod and me posted. | 22:08 |
betsy | mugsie might be around part of the time. I know kiall is out until monday | 22:09 |
rjrjr_ | well, we have the problem of the DB revision file. | 22:09 |
betsy | db revision file? | 22:09 |
rjrjr_ | the python code that tracks the database changes by version. | 22:09 |
betsy | Oh, is there a bug against that? | 22:10 |
rjrjr_ | your python file was 041_XXX.py | 22:10 |
betsy | Oh, right | 22:10 |
betsy | I know. when I did the blacklist code, I started out with version 030 and ended up with 033 | 22:10 |
betsy | Lots of fun redoing that | 22:10 |
rjrjr_ | so, if your code is merged, i'll get that code and submit a patch with that file changes and changes asked for by vinod and kiall. | 22:10 |
rjrjr_ | i have a 041_XXX.py as well. 8^( | 22:11 |
betsy | well, hopefully mugsie’s around and can give mine a +2 | 22:11 |
rjrjr_ | so, you and vinod don't have +2 permissions? | 22:11 |
betsy | If your’s goes first, I’ll just bump up my version number | 22:11 |
betsy | Yeah, we do, but I can’t give a +2 on my own code | 22:12 |
betsy | Nobody is supposed to +2 their own | 22:12 |
rjrjr_ | i know. i meant, vinod can't +2 your change? | 22:12 |
betsy | yeah. he can | 22:12 |
betsy | and hopefully mugsie’s around some tomorrow | 22:12 |
betsy | i’ll look for him in the morning and let him know i think the storage code is good to go | 22:13 |
rjrjr_ | okay. i guess i'll keep patching the code (adding more and more functionality) until then. | 22:14 |
rjrjr_ | or i can logical separate what i'm working on and submit them as separate changes. | 22:15 |
rjrjr_ | that is a pain however. | 22:15 |
betsy | Yeah. It’s got pros and cons | 22:16 |
betsy | I’m doing that with the storage piece | 22:16 |
rjrjr_ | logically separating what you work on? | 22:16 |
betsy | For instance, I haven’t migrated the servers from the servers table into the pool_attributes table | 22:16 |
betsy | But it’s easier to do with the storage piece | 22:17 |
betsy | It’s got a large piece and then smaller pieces like that | 22:17 |
betsy | I’ve also got to modify the domains table to include the pool_id | 22:17 |
*** ryanpetrello has quit IRC | 22:34 | |
*** betsy has quit IRC | 22:34 | |
*** ryanpetrello has joined #openstack-dns | 22:35 | |
rjrjr_ | were all the backend drivers converted for mdns? | 22:35 |
openstackgerrit | Ron Rickard proposed a change to openstack/designate: Pool Manager Service Changes https://review.openstack.org/128300 | 22:37 |
mgagne | I wish to unregister a step in a workflow, how can I do it? There is a bunch of examples in the docs with horizon.get_dashboard and get_panel but none with workflow. Can someone assist? | 22:59 |
mgagne | oops, wrong channel | 22:59 |
*** jmcbride has joined #openstack-dns | 23:04 | |
*** jmcbride has quit IRC | 23:23 | |
*** jmcbride has joined #openstack-dns | 23:27 | |
*** jmcbride has quit IRC | 23:29 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!