*** EricGonczer_ has joined #openstack-dns | 00:02 | |
*** EricGonczer_ has quit IRC | 00:05 | |
*** ryanpetrello has joined #openstack-dns | 00:31 | |
*** ryanpetrello has quit IRC | 00:47 | |
*** nosnos has joined #openstack-dns | 01:01 | |
*** ryanpetrello has joined #openstack-dns | 01:03 | |
*** ryanpetrello has quit IRC | 01:25 | |
*** ryanpetrello has joined #openstack-dns | 01:26 | |
*** ryanpetrello has quit IRC | 01:38 | |
*** richm has joined #openstack-dns | 01:46 | |
*** richm has quit IRC | 02:43 | |
*** boris-42 has quit IRC | 03:07 | |
*** nosnos has quit IRC | 03:49 | |
*** EricGonczer_ has joined #openstack-dns | 04:00 | |
*** EricGonczer_ has quit IRC | 04:06 | |
*** nosnos has joined #openstack-dns | 04:46 | |
*** nosnos_ has joined #openstack-dns | 05:50 | |
*** nosnos has quit IRC | 05:51 | |
*** nosnos_ has quit IRC | 05:57 | |
*** nosnos has joined #openstack-dns | 05:59 | |
*** ryanpetrello has joined #openstack-dns | 06:23 | |
*** nosnos_ has joined #openstack-dns | 06:23 | |
*** nosnos has quit IRC | 06:23 | |
*** EricGonczer_ has joined #openstack-dns | 06:59 | |
*** EricGonczer_ has quit IRC | 07:00 | |
*** ryanpetrello has quit IRC | 07:02 | |
*** jordanP has joined #openstack-dns | 08:33 | |
*** jordanP has quit IRC | 08:33 | |
*** jordanP has joined #openstack-dns | 08:33 | |
*** ToMiles has quit IRC | 09:30 | |
*** rediskin has joined #openstack-dns | 09:41 | |
*** rediskin has left #openstack-dns | 09:42 | |
*** rediskin has joined #openstack-dns | 09:42 | |
*** GonZo2K has joined #openstack-dns | 10:30 | |
*** boris-42 has joined #openstack-dns | 10:33 | |
Kiall | boris-42: feature request for osprofiler - allow the middleware to use oslo.config for it's settings, like the keystone middleware, most projects including designate have moved settings we expect users to modify outside of the api-paste.ini, to help ensure upgrades are easy | 11:14 |
---|---|---|
Kiall | And.. Ideally, hmac_keys would default to None, which would in turn disable the profiler, rather than defaulting to "SECRET_KEY" ;) | 11:15 |
boris-42 | Kiall: no | 11:17 |
Kiall | lol | 11:17 |
boris-42 | Kiall: it will make my life about 10 harder | 11:17 |
boris-42 | 10 times* | 11:17 |
boris-42 | =) | 11:17 |
boris-42 | Kiall: it will be turned off by defualt via CONF file | 11:17 |
Kiall | At the cost of making `apt-get upgrade` require human interaction to resolve the conflict in api-paste.ini, which was a BIG issue for all OpenStack projects thanks to keystone up until they fixed it ;) | 11:18 |
Kiall | (I won't be the only one who says api-paste.ini is not a config file users should need to edit unless their adding custom middleware!) | 11:19 |
Kiall | api-paste's syntax is something $end_user's simply don't understand, resolving the conflicts was a big issue for upgrades "back in the day" | 11:20 |
boris-42 | Kiall: so the thing is that this stuff is already merged in cinder/glance | 11:24 |
Kiall | Wait till the distro guys notice :) | 11:25 |
boris-42 | Kiall: I can try to make all this stuff via configs * | 11:25 |
boris-42 | Kiall: I already faced one guy+) | 11:25 |
boris-42 | Kiall: but he was agaisnt adding new lib* | 11:25 |
boris-42 | lol | 11:25 |
Kiall | lol.. the KS middleware supports both api-paste, OR oslo.config setup.. It doesn't look that hard to make it work ;) | 11:25 |
Kiall | Anyway, left some comments on the review .. All trivial/questions bar ^ :) | 11:26 |
boris-42 | Kiall: okay=) | 11:27 |
*** simon-AS559 has joined #openstack-dns | 11:29 | |
*** rediskin has left #openstack-dns | 11:31 | |
*** rediskin has joined #openstack-dns | 11:34 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Return the correct RRSet object in Central.create_recordset https://review.openstack.org/134909 | 11:34 |
Kiall | boris-42: BTW.. I managed to get a run of the gate's rally settings with 0% fail, still trying to figure out how to fix without loosing functionality though :( | 11:44 |
*** openstackgerrit has quit IRC | 11:48 | |
boris-42 | Kiall: hm | 11:49 |
*** openstackgerrit has joined #openstack-dns | 11:49 | |
*** ChanServ sets mode: +v openstackgerrit | 11:49 | |
boris-42 | Kiall: you can run without concurency | 11:49 |
Kiall | Yea, I know.. But! We need to fix the concurrency fail ;) | 11:49 |
*** GonZo2K has quit IRC | 12:01 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add Rally to Vagrant VM https://review.openstack.org/134711 | 12:04 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Move Central notifications to a decorator https://review.openstack.org/134707 | 12:04 |
openstackgerrit | Merged openstack/designate: Updated from global requirements https://review.openstack.org/134766 | 12:38 |
openstackgerrit | Merged openstack/designate: Detect CPU on OSX as well https://review.openstack.org/134704 | 12:39 |
openstackgerrit | Graham Hayes proposed openstack/designate: Added functionality to allow for zone ownership transfers https://review.openstack.org/107822 | 12:39 |
*** nosnos_ has quit IRC | 12:39 | |
*** EricGonczer_ has joined #openstack-dns | 12:41 | |
*** ryanpetrello has joined #openstack-dns | 12:41 | |
*** EricGonczer_ has quit IRC | 12:44 | |
*** ryanpetrello has quit IRC | 12:54 | |
*** ryanpetrello_ has joined #openstack-dns | 12:54 | |
*** ryanpetrello_ is now known as ryanpetrello | 12:54 | |
*** simon-AS5591 has joined #openstack-dns | 13:02 | |
*** simon-AS559 has quit IRC | 13:02 | |
*** simon-AS559 has joined #openstack-dns | 13:04 | |
*** simon-AS5591 has quit IRC | 13:07 | |
boris-42 | Kiall: =) | 13:10 |
boris-42 | Kiall: ya that will be nice | 13:11 |
boris-42 | Kiall: so I need to work a bit on Rally now, and I'll make corresponding patch to osprofiler | 13:11 |
boris-42 | Kiall: to allow it set key via CONF | 13:11 |
boris-42 | Kiall: and make optional api-paste.ini pass + enable | 13:11 |
boris-42 | Kiall: then I'll chnage cinder/glance | 13:12 |
boris-42 | Kiall: make one more version of osprofiler that removes fully this variables from api-paste.ini | 13:12 |
boris-42 | Kiall: and update designate patches lol=) | 13:12 |
Kiall | lol - sorry for causing so much work :P | 13:13 |
*** ChanServ changes topic to "Openstack DNS / Designate - Weekly meet on Wednesdays @ 1700 UTC https://launchpad.net/designate - Help us choose a new meeting time - https://www.surveymonkey.com/r/FJRBSVF - https://github.com/openstack/designate - http://docs.openstack.org/developer/designate/ - This room is logged (http://eavesdrop.openstack.org/irclogs/)" | 13:18 | |
*** mugsie_ is now known as mugsie | 13:18 | |
mugsie | hey all - just a heads up - survey for new meeting time - https://www.surveymonkey.com/r/FJRBSVF | 13:25 |
mugsie | sent an email out as well | 13:25 |
Kiall | mugsie: has the US switched it's DST yet? Otherwise question 3 will be all over the place :P | 13:27 |
mugsie | Kiall: yup, everywhere in the northern hemisphere is switched now afaik | 13:29 |
mugsie | and, most US based people still identify with the "normal" tz (pacific, mountain, etc) | 13:30 |
boris-42 | Kiall: lol as you see you are not causing the second release of osprofiler | 13:35 |
boris-42 | Kiall: https://github.com/stackforge/osprofiler/releases | 13:35 |
boris-42 | =) | 13:35 |
boris-42 | Kiall: but I really think that removing conf options from api-paste ini makes sense | 13:36 |
*** k4n0_ has quit IRC | 13:39 | |
*** ryanpetrello has quit IRC | 13:53 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add synchronized_domain decorator https://review.openstack.org/134942 | 13:54 |
Kiall | eandersson: .. with ^ + the notifications change, your test script is passing again. | 13:55 |
Kiall | Rally still gave me a fail though :'( | 13:56 |
*** ryanpetrello has joined #openstack-dns | 13:59 | |
*** nkinder has quit IRC | 14:05 | |
*** richm1 has joined #openstack-dns | 14:15 | |
*** ryanpetrello has quit IRC | 14:19 | |
Kiall | boris-42: Question, is it possible to run just 1 of the benchmarks without hacking up the input task? (e.g. just run DesignateBasic.create_and_delete_records from http://logs.openstack.org/42/134942/1/check/gate-rally-dsvm-designate-designate/3897073/rally-plot/sla.txt ) | 14:23 |
boris-42 | Kiall: nope | 14:24 |
boris-42 | Kiall: only if I add experimental job | 14:24 |
boris-42 | Kiall: with separated file | 14:24 |
boris-42 | Kiall: that you can trigger =) | 14:24 |
Kiall | boris-42: ah, I meant locally :) | 14:24 |
Kiall | Not in the gate | 14:24 |
boris-42 | Kiall: just copy paste it* | 14:24 |
boris-42 | Kiall: to another task.. | 14:24 |
Kiall | boris-42: K thanks.. Another Q.. Do each of the benchmarks run in parallel or serially? | 14:27 |
Kiall | Running just that benchmark passes, running them all fails -_- | 14:28 |
Kiall | Ah.. passed the first time on it's own, failed the second :( | 14:29 |
*** ryanpetrello has joined #openstack-dns | 14:36 | |
*** simon-AS559 has quit IRC | 14:36 | |
*** timsim has joined #openstack-dns | 14:41 | |
*** simon-AS559 has joined #openstack-dns | 14:49 | |
*** simon-AS5591 has joined #openstack-dns | 14:50 | |
*** EricGonczer_ has joined #openstack-dns | 14:51 | |
*** paul_glass has joined #openstack-dns | 14:53 | |
*** simon-AS559 has quit IRC | 14:53 | |
*** EricGonczer_ has quit IRC | 14:55 | |
*** nkinder has joined #openstack-dns | 14:57 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add synchronized_domain decorator https://review.openstack.org/134942 | 14:59 |
*** simon-AS5591 has quit IRC | 14:59 | |
Kiall | Ok.. That Patch + Notifications Patch + timsim's DB indexing patch == Golden :) | 15:06 |
timsim | \o/ | 15:09 |
Kiall | timsim: do you have any more changes you want on the DB index patch? Otherwise, we'll try and merge today :) | 15:10 |
Kiall | (e.g. is the migration number still sane? | 15:11 |
*** simon-AS559 has joined #openstack-dns | 15:11 | |
*** simon-AS5591 has joined #openstack-dns | 15:16 | |
*** simon-AS559 has quit IRC | 15:19 | |
timsim | Kiall: Migration # still works. I think I'm happy with it. Index usage suggested those stay. Seems good :) | 15:41 |
Kiall | timsim: K | 15:44 |
*** paul_glass has quit IRC | 15:52 | |
*** paul_glass has joined #openstack-dns | 15:58 | |
*** EricGonczer_ has joined #openstack-dns | 15:59 | |
Kiall | timsim: when's vinod back in the office BTW? | 16:08 |
Kiall | and.. has anyone seen rjrjr since the last meeting? | 16:08 |
boris-42 | Kiall: serial | 16:18 |
Kiall | boris-42: K.. | 16:18 |
timsim | Kiall: He just got in :) | 16:19 |
timsim | And I haven't seen Ron. | 16:19 |
mugsie | timsim: just had a few comments on your patch - feel free to tell me I am wrong | 16:20 |
mugsie | seen as the days thats in it, brain is not the working | 16:20 |
timsim | mugsie: I'll change them. You don't even have to put names, MySQL will come up with them for you, but might as well make them make sense :) | 16:20 |
mugsie | :) | 16:20 |
*** paul_glass has quit IRC | 16:21 | |
openstackgerrit | Tim Simmons proposed openstack/designate: Add some helpful SQL indices https://review.openstack.org/129675 | 16:22 |
timsim | mugsie: ;) ^ | 16:22 |
*** paul_glass has joined #openstack-dns | 16:22 | |
mugsie | timsim: +2 | 16:24 |
*** jmcbride has joined #openstack-dns | 16:28 | |
*** vinod has joined #openstack-dns | 16:29 | |
Kiall | timsim: .. removed +A after reading your comment ;) | 16:29 |
Kiall | We want to name the indexes ourselves, if we allow MySQL to do it, then, we have all sorts of pain when trying to deal with postgres and sqlite choosing different names! | 16:29 |
*** vinod has quit IRC | 16:30 | |
*** vinod has joined #openstack-dns | 16:30 | |
timsim | Yeah that sounds gross. I've named them there, and now they make sense. So it should be good to go. | 16:30 |
*** vinod has quit IRC | 16:32 | |
Kiall | Ah, so you have :) | 16:32 |
*** vinod has joined #openstack-dns | 16:32 | |
Kiall | +A again ;) | 16:32 |
timsim | Cool :) | 16:33 |
mugsie | timsim: your reverse name patch - thats just adding the columns for the time being right? | 17:10 |
timsim | Nope, it makes use of them for searches. The superdomain check, and filtering checks on ?name=*blah.com use them. | 17:11 |
*** rmoe_ has quit IRC | 17:13 | |
boris-42 | Kiall: oh finallly back | 17:15 |
*** betsy has joined #openstack-dns | 17:15 | |
*** f1ller is now known as filler | 17:17 | |
openstackgerrit | Merged openstack/designate: Add some helpful SQL indices https://review.openstack.org/129675 | 17:18 |
mugsie | timsim: ah.... | 17:19 |
* mugsie haz the dumb today | 17:19 | |
timsim | mugsie: It's alright. I'm *pretty* sure it works. I'm working on testing it at scale at the moment. | 17:19 |
*** simon-AS5591 has quit IRC | 17:20 | |
openstackgerrit | Endre Karlson proposed openstack/python-designateclient: Move some useful code outside v1 https://review.openstack.org/134186 | 17:22 |
eandersson | Looking good, thanks Kiall! | 17:25 |
*** shakamunyi has joined #openstack-dns | 17:32 | |
*** shakamunyi has quit IRC | 17:32 | |
*** rmoe has joined #openstack-dns | 17:35 | |
timsim | Wow running these migrations against a large dataset is painful. | 17:36 |
openstackgerrit | Merged openstack/designate: Return the correct RRSet object in Central.create_recordset https://review.openstack.org/134909 | 17:36 |
*** simon-AS559 has joined #openstack-dns | 17:46 | |
*** simon-AS5591 has joined #openstack-dns | 17:48 | |
*** simon-AS559 has quit IRC | 17:50 | |
*** vinod has quit IRC | 17:52 | |
*** jordanP has quit IRC | 17:54 | |
boris-42 | Kiall: btw fyi | 17:55 |
openstackgerrit | Endre Karlson proposed openstack/python-designateclient: V2 Bindings https://review.openstack.org/133675 | 17:55 |
boris-42 | Kiall: to get full traces you'll need something like "rally task results" | 17:55 |
Kiall | boris-42: heya | 17:55 |
boris-42 | Kiall: that returns full results of rally task | 17:56 |
*** arborism has joined #openstack-dns | 18:03 | |
*** arborism is now known as amcrn | 18:03 | |
*** eandersson has quit IRC | 18:10 | |
*** eandersson has joined #openstack-dns | 18:14 | |
*** eandersson has quit IRC | 18:20 | |
*** eandersson has joined #openstack-dns | 18:23 | |
openstackgerrit | Endre Karlson proposed openstack/python-designateclient: V2 CLI https://review.openstack.org/133676 | 18:24 |
openstackgerrit | Endre Karlson proposed openstack/python-designateclient: V2 Bindings https://review.openstack.org/133675 | 18:24 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add synchronized_domain decorator https://review.openstack.org/134942 | 18:28 |
*** EricGonczer_ has quit IRC | 18:35 | |
*** ToMiles has joined #openstack-dns | 18:36 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Add synchronized_domain decorator https://review.openstack.org/134942 | 19:03 |
*** jmcbride1 has joined #openstack-dns | 19:08 | |
*** jmcbride has quit IRC | 19:10 | |
Kiall | vinod / betsy - https://review.openstack.org/#/c/134942/ seems to be the piece needed to A) get rally working, and B) fixup the deadlocks eandersson found (https://bugs.launchpad.net/designate/+bug/1392762).. Could you two give it a review today? :) | 19:11 |
uvirtbot | Launchpad bug 1392762 in designate "Concurrent requests can cause designate-central to lock up" [High,In progress] | 19:11 |
betsy | Kiall: just started looking at it | 19:12 |
Kiall | :) | 19:12 |
timsim | Might need to figure out a better way to do this migration: https://review.openstack.org/#/c/134387/4/designate/storage/impl_sqlalchemy/migrate_repo/versions/046_add_reverse_name.py It's been an hour and half, and still going on my large dataset :x | 19:15 |
*** GonZo2K has joined #openstack-dns | 19:16 | |
*** jmcbride1 has quit IRC | 19:16 | |
*** jmcbride has joined #openstack-dns | 19:16 | |
*** GonZo2K has quit IRC | 19:18 | |
Kiall | timsim: yea, did you see my message the other day? I can't believe SQLA doesn't offer a way to use the reverse sql function -_- | 19:20 |
Kiall | timsim: just asked zzzeek - the SQLAlchemy author - if SQL has a method for it.. | 19:22 |
timsim | It lost connection, had to finish it manually. Took like 3 minutes. | 19:22 |
timsim | I couldn't find one for that. Would be majorly helpful. | 19:22 |
*** GonZo2K has joined #openstack-dns | 19:23 | |
Kiall | Lol.. I'll write one if it doesn't exist ;) | 19:23 |
openstackgerrit | Endre Karlson proposed openstack/designate: MDNS part of Secondary zones https://review.openstack.org/133683 | 19:30 |
ekarlso- | wtf | 19:30 |
*** jmcbride has quit IRC | 19:35 | |
*** vinod has joined #openstack-dns | 19:35 | |
Kiall | timsim: I think I know why SQLA doesn't have it.. SQLite doesn't have a reverse function -_- | 19:36 |
* timsim sighs | 19:36 | |
timsim | I mean.... | 19:36 |
timsim | Could it just throw an exception for SQLite or something? Rargh. | 19:36 |
*** MasterPiece has joined #openstack-dns | 19:37 | |
Kiall | timsim: I think I have a solution :) .. Just checking | 19:39 |
openstackgerrit | Merged openstack/designate: Add synchronized_domain decorator https://review.openstack.org/134942 | 19:52 |
Kiall | timsim: http://paste.openstack.org/show/134169/ | 19:57 |
Kiall | on mysql etc, we use the real REVERSE() method.. On SQLite, we fallback to python based | 19:58 |
timsim | Brilliant! | 19:59 |
Kiall | also found out - func.<anything>() will produce <anything>() .. e.g func.foobarbaz(table.c.domain_id) will produce FOOBARBAZ(`table`.`domain_id`) in SQL | 19:59 |
timsim | That's useful. | 19:59 |
Kiall | Yea.. I suppose ;) | 20:00 |
Kiall | Would have prefered if it was in the docs :P | 20:00 |
Kiall | my first attempt was a tad more complicated, before zzzek responded ;) http://paste.openstack.org/show/134165/ | 20:01 |
timsim | Oh my. | 20:02 |
timsim | I mean, shouldn't you just be able to go ask the creator of any software project when you've got a question, who needs docs :P | 20:02 |
Kiall | :D | 20:03 |
Kiall | He works for RedHat now, on OpenStack ;) | 20:03 |
boris-42 | Kiall: btw | 20:03 |
Kiall | well.. on SQLAlchemy, OpenStack and others | 20:03 |
boris-42 | Kiall: I wasn't able to install designate =(( | 20:03 |
timsim | Nice to have people like that around. | 20:03 |
Kiall | boris-42: boo! What failed? | 20:03 |
boris-42 | Kiall: like no module "oslo.concurency" | 20:03 |
boris-42 | Kiall: some oslocrap=) | 20:04 |
Kiall | lol, it exists! https://pypi.python.org/pypi/oslo.concurrency | 20:04 |
boris-42 | Kiall: with this line it deosn't work #ENABLED_SERVICES+=,designate,designate-api,designate-central | 20:04 |
Kiall | and it's in our requirements.txt :) | 20:04 |
boris-42 | Kiall: if I remove # | 20:04 |
boris-42 | Kiall: I belive that it exist lol | 20:04 |
eandersson | haha I just had that problem testing the patch out :P | 20:04 |
Kiall | eandersson: lol :) | 20:05 |
boris-42 | lol | 20:05 |
Kiall | oslo.concurrency is new | 20:05 |
Kiall | if you installed dependencies from master maybe a week ago, you wouldn't have it.. | 20:05 |
boris-42 | Kiall: hm | 20:06 |
boris-42 | Kiall: but devstack! | 20:06 |
boris-42 | Kiall: it should install it! | 20:06 |
Kiall | It does for me? | 20:06 |
eandersson | I am still seeing the DBError on start-up. It seems to cause a few defunk processes, but recover by itself. | 20:06 |
Kiall | (and - it does in the gate too!) | 20:06 |
boris-42 | Kiall: u asking me?) | 20:06 |
Kiall | eandersson: is this with workers > 1, that's still a TODO item ? | 20:07 |
eandersson | yep | 20:07 |
Kiall | boris-42: more confused as to why it isn't installing for you! | 20:07 |
eandersson | I mean I can lower the worker number now. Assuming that this works. | 20:07 |
eandersson | So not super important. | 20:07 |
Kiall | eandersson: ah, well, workers = 2+ is next on my list | 20:07 |
eandersson | perfect | 20:07 |
boris-42 | Kiall: hehe=) | 20:07 |
boris-42 | Kiall: it's openstack | 20:08 |
boris-42 | =) | 20:08 |
Kiall | boris-42: :D | 20:08 |
boris-42 | Kiall: hmhmhm I don't see oslo.concurency in requirements of designate | 20:08 |
boris-42 | Kiall: wtf?) | 20:08 |
Kiall | https://github.com/openstack/designate/blob/master/requirements.txt Line 18? | 20:08 |
Kiall | boris-42: I tend to use the vagrant stuff in our contrib folder.. throwaway VMs == Much nicer ;) | 20:09 |
eandersson | Vagrant is a lifesaver. | 20:09 |
eandersson | I have custom scripts to set up a single environment with the click of a button. | 20:09 |
Kiall | Rally support in our vagrant stuff == https://review.openstack.org/#/c/134711 (vinod or betsy will need to +2 that to merge it ;)) | 20:09 |
eandersson | You can also do it remotly. | 20:09 |
eandersson | (host it on an actual server, instead of locally) | 20:10 |
boris-42 | Kiall: =) | 20:10 |
boris-42 | Kiall: adoption of rally lol | 20:10 |
Kiall | boris-42: I wanted to use it to help reproduce eandersson's issue since it seemed to trigger it too ;) | 20:10 |
Kiall | hence adding it :P | 20:10 |
boris-42 | Kiall: =) | 20:11 |
boris-42 | Kiall: so I have some local issue for some reason requreiemnt.txt is differnet from what I see on github | 20:11 |
Kiall | But.. It's still failing in the gate :( | 20:11 |
eandersson | I could probably write a book on all the feedback I have! :P | 20:11 |
Kiall | (rally that is..) | 20:11 |
eandersson | I'll get busy contributing back once I am back in Europe. | 20:11 |
boris-42 | Kiall: i am not sure that Rally is the reason of failing that gate=) | 20:12 |
boris-42 | Kiall: or you mean vagrant stuff? | 20:12 |
Kiall | boris-42: it's not rallys fault.. I meant "the rally gate" | 20:12 |
boris-42 | OH | 20:12 |
boris-42 | I got fixed requriments | 20:12 |
boris-42 | woot | 20:12 |
boris-42 | seems like my cat deleted them | 20:12 |
boris-42 | ! | 20:12 |
boris-42 | when I was sleeping! | 20:12 |
boris-42 | or I was drunk | 20:12 |
boris-42 | =) | 20:12 |
Kiall | lol | 20:13 |
Kiall | eandersson: excellent, feedback (especially when you find issues like the one you did!) is always appricated :) | 20:13 |
*** EricGonczer_ has joined #openstack-dns | 20:14 | |
boris-42 | Kiall: oh | 20:15 |
boris-42 | Kiall: I am really affraid of cutting new released for osprofiler | 20:15 |
boris-42 | Kiall: I can break everything | 20:15 |
boris-42 | =) | 20:15 |
* boris-42 *so much power* | 20:15 | |
Kiall | In theory, you shouldn't be able to break the gate ;) | 20:15 |
boris-42 | Kiall: lol *in theory* lol | 20:16 |
boris-42 | Kiall: * in theory osprofiler should be somewhere under openstack/* | 20:16 |
Kiall | yea.. oh well! | 20:16 |
boris-42 | Kiall: like oslo, so I'll be able to setup job | 20:16 |
boris-42 | Kiall: for functional testing | 20:16 |
boris-42 | =) | 20:16 |
eandersson | It will be nice once I have got all the major issues out of the way. So I can start concentrating on the Sink, as it is really the major feature for me as a developer. | 20:16 |
Kiall | Well, you can add the gate jobs to stackforge/osprofiler.. | 20:16 |
Kiall | then.. You'll know if your about to break other people etc | 20:17 |
eandersson | You guys should support hybrid cloud integration with the HP cloud for Designate (if you don't already). :P | 20:17 |
boris-42 | Kiall: no I can't | 20:17 |
Kiall | ekarlso-'s secondary domain support get's us to the point we can do that from the HP Cloud side ;) | 20:17 |
boris-42 | Kiall: there is special mechanism for that | 20:17 |
eandersson | I don't think I have found any good tools to support hybrid cloud dns. | 20:18 |
Kiall | Oh.. oh well :( | 20:18 |
boris-42 | Kiall: and only oslo/* stuff supports it | 20:18 |
boris-42 | Kiall: cause of politics | 20:18 |
boris-42 | Kiall: and other crap | 20:18 |
Kiall | Simple solution to that, perform a totally broken release on Friday afternoon ;) | 20:18 |
Kiall | the "world is broke" rage will change the politics pretty quickly :P | 20:19 |
*** EricGonczer_ has quit IRC | 20:21 | |
openstackgerrit | Tim Simmons proposed openstack/designate: Add a reverse name columns to domains/recordsets https://review.openstack.org/134387 | 20:23 |
*** jmcbride has joined #openstack-dns | 20:23 | |
timsim | Thanks Kiall ^ | 20:23 |
boris-42 | Kiall: yep =) | 20:25 |
boris-42 | Kiall: wait for next friday =) | 20:25 |
Kiall | timsim: Cool, 1 last thing on that review, rather than doing this kinda thing: obj.FIELDS['reverse_name'] = {} | 20:27 |
Kiall | can we instead add a more generic "extra_values" which would look like "skip_values" does? e.g. https://github.com/openstack/designate/blob/master/designate/sqlalchemy/base.py#L238 | 20:27 |
Kiall | "obj.FIELDS['reverse_name'] = {}" will "leak" back out of the storage layer when the object get's returned etc | 20:27 |
timsim | Sure. That makes sense. | 20:28 |
Kiall | another comment on the review too | 20:30 |
timsim | Ah yeah, for sure. | 20:31 |
timsim | You don't have a problem with having that column default to ''? | 20:34 |
Kiall | I missed that.. lol | 20:42 |
Kiall | if default is left out, what happens? | 20:42 |
timsim | You can't create the column, non-nullable column without a default doesn't work (non-null column with null in it). I could create the column as nullable, do the migration, and then make it non-nullable? | 20:43 |
*** openstackgerrit has quit IRC | 20:49 | |
*** openstackgerrit has joined #openstack-dns | 20:49 | |
*** ChanServ sets mode: +v openstackgerrit | 20:49 | |
Kiall | Oh, well, in the migration, we should fix it up after I reckon | 20:51 |
Kiall | In the tables.py.. will it let you leave out default='' ? | 20:51 |
Kiall | Back in an hour or so, rain stopped, home time! | 20:51 |
*** timsim_ has joined #openstack-dns | 20:59 | |
*** jmcbride has quit IRC | 21:01 | |
*** timsim has quit IRC | 21:02 | |
*** jmcbride has joined #openstack-dns | 21:12 | |
*** jmcbride has quit IRC | 21:18 | |
*** jmcbride has joined #openstack-dns | 21:27 | |
*** jmcbride has quit IRC | 21:35 | |
*** jmcbride has joined #openstack-dns | 21:39 | |
*** jmcbride has quit IRC | 21:45 | |
*** jmcbride has joined #openstack-dns | 21:46 | |
*** jmcbride has quit IRC | 22:01 | |
*** betsy_ has joined #openstack-dns | 22:02 | |
*** jmcbride has joined #openstack-dns | 22:02 | |
*** betsy has quit IRC | 22:02 | |
*** betsy_ is now known as betsy | 22:02 | |
*** vinod has quit IRC | 22:02 | |
*** jmcbride has quit IRC | 22:03 | |
*** jmcbride has joined #openstack-dns | 22:08 | |
*** jmcbride has quit IRC | 22:14 | |
*** jmcbride has joined #openstack-dns | 22:26 | |
openstackgerrit | Tim Simmons proposed openstack/designate: Add a reverse name columns to domains/recordsets https://review.openstack.org/134387 | 22:29 |
*** paul_glass has quit IRC | 22:34 | |
*** timsim_ has quit IRC | 22:36 | |
*** betsy has quit IRC | 22:42 | |
*** ryanpetrello has quit IRC | 23:00 | |
*** EricGonczer_ has joined #openstack-dns | 23:02 | |
*** EricGonczer_ has quit IRC | 23:18 | |
*** GonZoPT has joined #openstack-dns | 23:19 | |
*** nkinder has quit IRC | 23:20 | |
*** GonZo2K has quit IRC | 23:21 | |
*** nkinder has joined #openstack-dns | 23:33 | |
*** jmcbride has quit IRC | 23:33 | |
*** soren has quit IRC | 23:44 | |
*** nkinder has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!