| *** chlong has joined #openstack-dns | 00:20 | |
| *** EricGonczer_ has quit IRC | 00:24 | |
| *** nkinder has quit IRC | 00:32 | |
| *** nkinder has joined #openstack-dns | 00:35 | |
| *** rudrajit has joined #openstack-dns | 00:54 | |
| *** pglass has quit IRC | 00:58 | |
| *** linkedinyou has quit IRC | 01:03 | |
| *** stanzgy has joined #openstack-dns | 01:34 | |
| *** EricGonczer_ has joined #openstack-dns | 02:16 | |
| *** EricGonczer_ has quit IRC | 02:40 | |
| *** rudrajit has quit IRC | 03:12 | |
| *** rudrajit has joined #openstack-dns | 03:13 | |
| *** rudrajit_ has joined #openstack-dns | 03:23 | |
| *** rudrajit has quit IRC | 03:26 | |
| *** rudrajit_ has quit IRC | 04:16 | |
| *** rudrajit has joined #openstack-dns | 04:27 | |
| *** stanzgy has quit IRC | 04:47 | |
| *** stanzgy has joined #openstack-dns | 04:48 | |
| *** stanzgy has quit IRC | 04:52 | |
| *** stanzgy has joined #openstack-dns | 04:53 | |
| *** rudrajit has quit IRC | 05:00 | |
| *** rudrajit has joined #openstack-dns | 05:02 | |
| *** rudrajit_ has joined #openstack-dns | 05:07 | |
| *** rudrajit has quit IRC | 05:10 | |
| *** rudrajit_ has quit IRC | 05:13 | |
| *** chlong has quit IRC | 05:27 | |
| *** CaptTofu_ has quit IRC | 05:35 | |
| *** pfreund has quit IRC | 05:35 | |
| *** serverascode has quit IRC | 05:35 | |
| *** chlong has joined #openstack-dns | 05:40 | |
| *** serverascode has joined #openstack-dns | 05:40 | |
| *** CaptTofu_ has joined #openstack-dns | 05:41 | |
| *** pfreund has joined #openstack-dns | 05:45 | |
| *** chlong has quit IRC | 06:20 | |
| *** hetii has joined #openstack-dns | 06:32 | |
| *** chlong has joined #openstack-dns | 06:36 | |
| *** boris-42 has joined #openstack-dns | 06:38 | |
| *** timfreund has quit IRC | 07:20 | |
| *** timfreund has joined #openstack-dns | 07:20 | |
| *** CaptTofu_ has quit IRC | 07:31 | |
| *** pfreund has quit IRC | 07:31 | |
| *** rackertom has quit IRC | 07:31 | |
| *** simonmcc has quit IRC | 07:31 | |
| *** serverascode has quit IRC | 07:31 | |
| *** chlong has quit IRC | 07:34 | |
| *** simonmcc has joined #openstack-dns | 07:51 | |
| *** rackertom has joined #openstack-dns | 07:55 | |
| *** pfreund has joined #openstack-dns | 07:56 | |
| *** serverascode has joined #openstack-dns | 07:58 | |
| *** CaptTofu_ has joined #openstack-dns | 08:06 | |
| *** jordanP has joined #openstack-dns | 08:26 | |
| openstackgerrit | Federico Ceratto proposed openstack/designate: Create unit tests dir, move objects tests there https://review.openstack.org/202957 | 08:30 |
|---|---|---|
| *** jordanP has quit IRC | 08:31 | |
| *** jordanP has joined #openstack-dns | 08:45 | |
| openstackgerrit | sonu proposed openstack/python-designateclient: Replacing print with print() to provide py 2/3 compatibility https://review.openstack.org/203539 | 09:31 |
| *** pksingh has joined #openstack-dns | 10:32 | |
| *** stanzgy has quit IRC | 10:49 | |
| openstackgerrit | Federico Ceratto proposed openstack/designate: Create unit tests dir, move objects tests there https://review.openstack.org/202957 | 10:49 |
| *** l6unchpad has joined #openstack-dns | 11:00 | |
| *** mwagner_lap has quit IRC | 11:02 | |
| *** l6unchpad has quit IRC | 11:05 | |
| *** ig0r_ has joined #openstack-dns | 11:08 | |
| *** l6unchpad has joined #openstack-dns | 11:11 | |
| *** l6unchpa_ has joined #openstack-dns | 11:11 | |
| *** l6unchpad has quit IRC | 11:15 | |
| *** boris-42 has quit IRC | 11:22 | |
| *** ducttape_ has joined #openstack-dns | 11:38 | |
| *** ducttape_ has quit IRC | 11:43 | |
| *** ducttape_ has joined #openstack-dns | 11:48 | |
| *** ducttape_ has joined #openstack-dns | 11:48 | |
| *** ducttape_ has quit IRC | 12:00 | |
| *** ig0r_ has quit IRC | 12:05 | |
| pksingh | Hi Kiall | 12:24 |
| *** chlong has joined #openstack-dns | 12:35 | |
| *** mwagner_lap has joined #openstack-dns | 12:35 | |
| openstackgerrit | sonu proposed openstack/designate: Replaced print with print() to provide py 2/3 compatibility https://review.openstack.org/203448 | 12:40 |
| *** l6unchpa_ has quit IRC | 12:43 | |
| openstackgerrit | sonu proposed openstack/designate: Replacing dict.iteritems() with dict.items() https://review.openstack.org/203446 | 12:55 |
| *** EricGonczer_ has joined #openstack-dns | 12:57 | |
| *** EricGonczer_ has quit IRC | 13:09 | |
| openstackgerrit | Federico Ceratto proposed openstack/designate: Create unit tests dir, move objects tests there https://review.openstack.org/202957 | 13:16 |
| *** hetii has quit IRC | 13:20 | |
| *** boris-42 has joined #openstack-dns | 13:28 | |
| *** ducttape_ has joined #openstack-dns | 13:31 | |
| *** ducttape_ has quit IRC | 13:34 | |
| *** pksingh has quit IRC | 13:34 | |
| *** ducttape_ has joined #openstack-dns | 13:34 | |
| *** rbak has joined #openstack-dns | 13:50 | |
| *** richm has joined #openstack-dns | 13:53 | |
| ducttape_ | Kiall - thoughts on https://review.openstack.org/#/c/189894/ ? | 13:54 |
| ducttape_ | and last week there was a question on the designate dashbaord, and I could not answer it / got pulled away. forget where the question came from. ready to help with that too | 13:54 |
| *** l6unchpad has joined #openstack-dns | 13:59 | |
| *** mwagner_lap has quit IRC | 14:01 | |
| *** mwagner_lap has joined #openstack-dns | 14:02 | |
| *** pglass has joined #openstack-dns | 14:07 | |
| *** timsim has joined #openstack-dns | 14:09 | |
| *** l6unchpa_ has joined #openstack-dns | 14:14 | |
| *** l6unchpad has quit IRC | 14:17 | |
| Kiall | ducttape_: I looked at it over the weekend, but haven't got a good answer :( We absolutly want different error conditions to give different errors out of the API! | 14:21 |
| ducttape_ | cool ok, thanks. so long as it is consuming some of your brain cycles then I feel good :p | 14:23 |
| Kiall | So long as we can have different errors come out for the different error conditions, I'm happy to megre! But having two ways to get duplicate_domain is what's got me! | 14:23 |
| Kiall | What may work is: | 14:24 |
| Kiall | Use "forbidden_domain" as the exception type, and ensure the exception message contains the right detail to show the user... | 14:24 |
| ducttape_ | I'd like to avoid using the exception message, as it may change. I thought there was a exception_type field or something like that??? | 14:25 |
| Kiall | _type is the forbidden_domain etc | 14:25 |
| Kiall | actually | 14:25 |
| Kiall | just looked at the review again and saw you comment on the exceptions.py file | 14:26 |
| ducttape_ | I just don't feel super great about having the message (which is a string) contain something that will drive some other action | 14:26 |
| Kiall | I missed that comment -_- | 14:26 |
| Kiall | Would it drive another action? | 14:26 |
| ducttape_ | it drives the ui to say "nice try, someone else already picked your domain" etc. i.e. what message we show to the user | 14:26 |
| Kiall | e.g. would Horizon treat "Forbidden, because the name matches a blacklist" any different to "Forbidden, becasue another tenants owns it" | 14:26 |
| ducttape_ | it's not a huge business logic decision, but it helps the user experience - providing them with more insightful messages | 14:27 |
| Kiall | If we don't use the e.message, they don't we have to account for every exception type in Horizon? vs just the high level types? | 14:27 |
| Kiall | then* | 14:27 |
| Kiall | Anyway - as I said, I missed your comment where you suggested: | 14:28 |
| Kiall | class IllegalChildDomain(Forbidden): | 14:28 |
| Kiall | error_type = 'illegal_child' | 14:28 |
| Kiall | That seems reasonable, and a illegal_parent for when the zone is a sub-domain of another tenants zone | 14:28 |
| ducttape_ | there are certain types that we can generally place stuff into buckets, like forbidden. However, when you are picking a domain name it helps to know if a) I am just forbidden, due to policy or something else b) I am choosing a domain that already exists | 14:28 |
| Kiall | But - In general, I'd expect the error message returned from the API to be passed through to the user, it's either empty or has the real reason for the failure etc | 14:29 |
| ducttape_ | I don't imagine horizon handling every possible exception branch, but having a unique name seems like a good specific error message to provide | 14:29 |
| Kiall | Anyway - Let's proceed with illegal_child / illegal_parent (the opposite case, pointed out in one of my review comments) | 14:31 |
| Kiall | We can discuss the finer points of passing messages to Horizon at a later date ;') | 14:31 |
| Kiall | And.. 13 changes in the gate queue. lol, must be merge monday | 14:34 |
| *** jordan_ has joined #openstack-dns | 14:38 | |
| *** kfox1111_ has joined #openstack-dns | 14:39 | |
| *** arn_ has joined #openstack-dns | 14:39 | |
| *** ryanpetrello has quit IRC | 14:42 | |
| *** pfreund has quit IRC | 14:42 | |
| *** briancline has quit IRC | 14:42 | |
| *** pglass has quit IRC | 14:42 | |
| *** jordanP has quit IRC | 14:42 | |
| *** arn has quit IRC | 14:42 | |
| *** kfox1111 has quit IRC | 14:42 | |
| *** puck has quit IRC | 14:42 | |
| *** bauruine has quit IRC | 14:42 | |
| *** briancline has joined #openstack-dns | 14:42 | |
| *** ryanpetrello has joined #openstack-dns | 14:42 | |
| *** puck has joined #openstack-dns | 14:42 | |
| *** pglass has joined #openstack-dns | 14:43 | |
| *** EricGonczer_ has joined #openstack-dns | 14:43 | |
| openstackgerrit | Merged openstack/designate: Replaced print with print() to provide py 2/3 compatibility https://review.openstack.org/203448 | 14:46 |
| openstackgerrit | Merged openstack/designate: Replacing dict.iteritems() with dict.items() https://review.openstack.org/203446 | 14:46 |
| openstackgerrit | Merged openstack/designate: Add some UTs to test_tsigkeys.py https://review.openstack.org/202378 | 14:47 |
| *** bauruine has joined #openstack-dns | 14:47 | |
| *** pfreund has joined #openstack-dns | 14:51 | |
| openstackgerrit | Merged openstack/designate: Add some UTs to test_recordsets.py https://review.openstack.org/202356 | 14:52 |
| openstackgerrit | Merged openstack/python-designateclient: Replacing print with print() to provide py 2/3 compatibility https://review.openstack.org/203539 | 15:06 |
| openstackgerrit | Merged openstack/designate: Add some UTs to test_pools.py https://review.openstack.org/202857 | 15:06 |
| openstackgerrit | Merged openstack/designate: Add some UTs to test_zones.py https://review.openstack.org/201446 | 15:06 |
| openstackgerrit | Merged openstack/designate: Updated from global requirements https://review.openstack.org/200663 | 15:07 |
| openstackgerrit | Merged openstack/python-designateclient: Updated from global requirements https://review.openstack.org/203135 | 15:11 |
| openstackgerrit | Merged openstack/designate: Modify UT in test_limits.py https://review.openstack.org/202916 | 15:11 |
| openstackgerrit | Merged openstack/designate: DevStack: Support installing client at released versions https://review.openstack.org/201111 | 15:11 |
| openstackgerrit | Merged openstack/designate: Fix the displayed error message in V2 API https://review.openstack.org/201250 | 15:17 |
| Kiall | Looks like the merge party is over ;) | 15:23 |
| openstackgerrit | Graham Hayes proposed openstack/designate: Only print flake8 table if there is results https://review.openstack.org/201550 | 15:25 |
| openstackgerrit | Graham Hayes proposed openstack/designate: Only print flake8 table if there is results https://review.openstack.org/201550 | 15:26 |
| mugsie | Kiall: ^ | 15:27 |
| Kiall | done... | 15:29 |
| mugsie | ty | 15:30 |
| mugsie | timsim: ^ | 15:30 |
| timsim | done :) | 15:31 |
| Kiall | federico3: has one too ;) https://review.openstack.org/#/c/202957/ | 15:31 |
| Kiall | Starting to rework unit tests so stuff like database and central and etc don't need to be booted for them to work ;) | 15:31 |
| openstackgerrit | Merged openstack/designate: Update ubuntu-dev guide https://review.openstack.org/200745 | 15:33 |
| * timsim has 4 more reviews to do to be caught up (I think) | 15:33 | |
| *** marzif has joined #openstack-dns | 15:35 | |
| *** mlavalle has joined #openstack-dns | 15:38 | |
| *** rudrajit has joined #openstack-dns | 15:39 | |
| *** rudrajit has quit IRC | 15:43 | |
| *** rudrajit has joined #openstack-dns | 15:43 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate: [zm] Periodic Secondary zone refresh task https://review.openstack.org/201330 | 15:51 |
| *** ducttape_ has quit IRC | 15:57 | |
| *** rudrajit has quit IRC | 16:00 | |
| *** johnbelamaric has joined #openstack-dns | 16:01 | |
| *** l6unchpa_ has quit IRC | 16:11 | |
| *** ducttape_ has joined #openstack-dns | 16:19 | |
| *** jordan_ has quit IRC | 16:32 | |
| *** rudrajit has joined #openstack-dns | 16:34 | |
| openstackgerrit | Merged openstack/designate: Create unit tests dir, move objects tests there https://review.openstack.org/202957 | 16:34 |
| *** jasonsb has quit IRC | 16:47 | |
| *** jmcbride has joined #openstack-dns | 17:03 | |
| *** pglbutt has joined #openstack-dns | 17:04 | |
| *** pglass has quit IRC | 17:05 | |
| *** jmcbride has quit IRC | 17:08 | |
| *** jmcbride has joined #openstack-dns | 17:10 | |
| *** jordanP has joined #openstack-dns | 17:12 | |
| *** openstackgerrit has quit IRC | 17:16 | |
| *** openstackgerrit has joined #openstack-dns | 17:17 | |
| *** ChanServ sets mode: +v openstackgerrit | 17:17 | |
| openstackgerrit | Graham Hayes proposed openstack/designate: Fixup v2 API Validation https://review.openstack.org/201535 | 17:19 |
| openstackgerrit | Merged openstack/designate: Only print flake8 table if there is results https://review.openstack.org/201550 | 17:29 |
| *** rudrajit_ has joined #openstack-dns | 17:44 | |
| *** rudrajit has quit IRC | 17:47 | |
| *** pglbutt has quit IRC | 17:57 | |
| *** jmcbride has quit IRC | 17:57 | |
| *** jmcbride has joined #openstack-dns | 18:01 | |
| *** pglbutt has joined #openstack-dns | 18:03 | |
| *** jmcbride1 has joined #openstack-dns | 18:05 | |
| *** jmcbride has quit IRC | 18:06 | |
| *** jmcbride1 has quit IRC | 18:07 | |
| *** jmcbride has joined #openstack-dns | 18:08 | |
| *** pglbutt has quit IRC | 18:24 | |
| *** jasonsb has joined #openstack-dns | 18:30 | |
| *** pglass has joined #openstack-dns | 18:57 | |
| openstackgerrit | Kiall Mac Innes proposed openstack/designate-dashboard: Fixup tox.ini Horizon tgz URL https://review.openstack.org/203787 | 19:28 |
| openstackgerrit | Ryan Bak proposed openstack/designate: Fix duplicate domain error handling https://review.openstack.org/189894 | 19:31 |
| *** rudrajit has joined #openstack-dns | 19:34 | |
| *** rudrajit_ has quit IRC | 19:38 | |
| openstackgerrit | Merged openstack/designate: DevStack: Keystone V3 Service/Endpoint Creation https://review.openstack.org/197502 | 19:46 |
| openstackgerrit | Federico Ceratto proposed openstack/designate: Increase unit tests coverage. Work In Progress https://review.openstack.org/203815 | 20:52 |
| *** mwagner_lap has quit IRC | 20:58 | |
| *** EricGonczer_ has quit IRC | 21:20 | |
| *** rudrajit_ has joined #openstack-dns | 21:30 | |
| *** rudrajit has quit IRC | 21:33 | |
| *** jordanP has quit IRC | 21:39 | |
| *** jmcbride has quit IRC | 21:53 | |
| *** johnbelamaric has quit IRC | 21:55 | |
| *** rbak_ has joined #openstack-dns | 22:00 | |
| *** rbak has quit IRC | 22:02 | |
| *** pglass has quit IRC | 22:04 | |
| *** mwagner_lap has joined #openstack-dns | 22:09 | |
| openstackgerrit | Mimi Lee proposed openstack/designate: Reject invalid filters https://review.openstack.org/200651 | 22:12 |
| *** km has joined #openstack-dns | 22:51 | |
| *** rbak_ has quit IRC | 22:54 | |
| *** chlong has quit IRC | 22:54 | |
| *** ducttape_ has quit IRC | 22:56 | |
| *** bitblt has joined #openstack-dns | 23:20 | |
| *** kei_yama has joined #openstack-dns | 23:22 | |
| *** ducttape_ has joined #openstack-dns | 23:38 | |
| *** ducttape_ has quit IRC | 23:39 | |
| *** mlavalle has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!