*** EricGonczer_ has joined #openstack-dns | 00:49 | |
*** EricGonczer_ has quit IRC | 01:37 | |
*** ducttape_ has joined #openstack-dns | 01:54 | |
*** ducttape_ has quit IRC | 01:55 | |
*** ducttape_ has joined #openstack-dns | 01:55 | |
*** ducttape_ has quit IRC | 02:33 | |
*** ducttape_ has joined #openstack-dns | 02:34 | |
*** ducttape_ has quit IRC | 02:34 | |
*** ducttape_ has joined #openstack-dns | 02:34 | |
*** ducttape_ has quit IRC | 02:57 | |
*** ducttape_ has joined #openstack-dns | 02:58 | |
*** ducttape_ has quit IRC | 02:58 | |
*** puck has quit IRC | 04:07 | |
openstackgerrit | Tin Lam proposed openstack/designate-dashboard: Update requirement for Horizon in stable/mitaka https://review.openstack.org/300930 | 04:11 |
---|---|---|
*** puck has joined #openstack-dns | 04:15 | |
*** Alex_Stef has joined #openstack-dns | 04:26 | |
*** jasonsb has joined #openstack-dns | 04:36 | |
*** Alex_Stef has quit IRC | 04:53 | |
*** Alex_Stef has joined #openstack-dns | 04:53 | |
*** jasonsb has quit IRC | 05:09 | |
*** jasonsb has joined #openstack-dns | 05:13 | |
*** jasonsb has quit IRC | 05:24 | |
*** jasonsb has joined #openstack-dns | 05:27 | |
*** Alex_Stef has quit IRC | 06:33 | |
*** nyechiel_ has joined #openstack-dns | 07:02 | |
*** rudrajit has quit IRC | 07:04 | |
-openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance | 07:13 | |
*** jschwarz has joined #openstack-dns | 07:13 | |
*** adreznec has quit IRC | 07:39 | |
*** adreznec has joined #openstack-dns | 07:41 | |
*** fawadkhaliq has joined #openstack-dns | 07:54 | |
*** fawadkhaliq has quit IRC | 08:10 | |
*** _shaps_ has joined #openstack-dns | 08:14 | |
*** Alex_Stef has joined #openstack-dns | 08:17 | |
*** mdavidson has quit IRC | 08:39 | |
*** rudrajit has joined #openstack-dns | 08:45 | |
*** rudrajit has quit IRC | 08:49 | |
*** jordanP has joined #openstack-dns | 09:20 | |
*** kei_yama has quit IRC | 09:25 | |
*** mdavidson has joined #openstack-dns | 09:35 | |
*** GonZo2K has joined #openstack-dns | 10:00 | |
*** GonZo2K has quit IRC | 10:30 | |
*** openstackgerrit has quit IRC | 10:48 | |
*** openstackgerrit has joined #openstack-dns | 10:48 | |
*** ChanServ sets mode: +v openstackgerrit | 10:48 | |
*** krotscheck_vaca is now known as krotscheck | 11:13 | |
*** jordanP has quit IRC | 12:00 | |
*** EricGonczer_ has joined #openstack-dns | 12:07 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 12:22 |
*** EricGonczer_ has quit IRC | 12:26 | |
openstackgerrit | Federico Ceratto proposed openstack/designate: Fix rrset serialization, improve mdns tests https://review.openstack.org/286552 | 12:29 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 13:13 |
*** GonZo2K has joined #openstack-dns | 13:14 | |
*** GonZo2K has quit IRC | 13:16 | |
*** GonZo2K has joined #openstack-dns | 13:16 | |
*** GonZo2K has quit IRC | 13:16 | |
*** GonZo2K has joined #openstack-dns | 13:16 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 13:20 |
*** rsyed_away is now known as rsyed | 13:37 | |
openstackgerrit | Graham Hayes proposed openstack/designate: Add Enhanced Logging to APIs https://review.openstack.org/167351 | 13:44 |
*** GonZo2K has quit IRC | 13:46 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 13:48 |
Kiall | pglass / timsim / elarson / mugsie: I *think* ^ is good to go as a base framework.. reviews appreciated before I start converting existing tests! :) | 13:52 |
*** mlavalle has joined #openstack-dns | 13:58 | |
*** GonZo2K has joined #openstack-dns | 14:01 | |
*** GonZo2K has joined #openstack-dns | 14:01 | |
*** venkat has joined #openstack-dns | 14:08 | |
*** GonZo2K has quit IRC | 14:14 | |
openstackgerrit | Graham Hayes proposed openstack/designate: Add Enhanced Logging to APIs https://review.openstack.org/167351 | 14:16 |
*** pglass has joined #openstack-dns | 14:23 | |
*** jasonsb has quit IRC | 14:25 | |
*** jasonsb has joined #openstack-dns | 14:26 | |
elarson | mugsie: are we creating a new branch for the workshop repo? | 14:37 |
mugsie | yeah | 14:38 |
mugsie | I am trying to get neutron installed atm | 14:38 |
elarson | so you haven't pushed the branch just yet then? | 14:38 |
mugsie | not yet | 14:39 |
*** ducttape_ has joined #openstack-dns | 14:41 | |
openstackgerrit | Merged openstack/designate: Update config samples to show Identity v3 params https://review.openstack.org/297299 | 14:45 |
openstackgerrit | Merged openstack/designate: Updated from global requirements https://review.openstack.org/300760 | 14:47 |
openstackgerrit | Merged openstack/designate-dashboard: Update requirement for Horizon in stable/mitaka https://review.openstack.org/300930 | 14:47 |
*** james_li has joined #openstack-dns | 14:49 | |
elarson | mugsie: :coolio: | 14:50 |
*** rsyed is now known as rsyed_away | 14:57 | |
*** mlavalle has quit IRC | 15:00 | |
*** Alex_Stef has quit IRC | 15:00 | |
*** mlavalle has joined #openstack-dns | 15:03 | |
*** EricGonczer_ has joined #openstack-dns | 15:04 | |
mugsie | elarson: timsim pglass - can you read http://lists.openstack.org/pipermail/openstack-dev/2016-April/091295.html and let me know what you think? | 15:05 |
mugsie | + Kiall | 15:05 |
pglass | mugsie: do any other projects keep tests in a separate repo? | 15:09 |
mugsie | not yet | 15:09 |
mugsie | but, I dont like the idea of keeping it in repo because no one else did | 15:10 |
mugsie | tempest explisitly supports out of repo tests | 15:11 |
elarson | mugsie: I think it is a resonable way forward, especially if it means you can point the tests at any install without having to download / configure a designate env. | 15:12 |
elarson | given, that isn't a huge deal, but it does simplify things | 15:12 |
mugsie | cool. | 15:12 |
elarson | assuming I'm understanding correclty | 15:12 |
mugsie | elarson: want to reply to list ? :P | 15:12 |
elarson | correctly* | 15:12 |
elarson | sure! | 15:12 |
pglass | the only thing there is that the gate depends on the tests. so then you need to manually coordinate changes to tests and code. | 15:12 |
mugsie | elarson: you are | 15:12 |
Kiall | So, out of tree has some nicities for us @ HP when it comes to easy of integrating into tooling.. BUT - It also means we can start doing "branchless tempest". Zones API v2 should have the same stuff in L as it does in M | 15:12 |
mugsie | pglass: which is a good thing, to make sure we do not break APIs :) | 15:13 |
Kiall | But that in turn forces us to expose via the API that $new shiny feature is supported or not | 15:13 |
mugsie | does it 404? then it is not supported | 15:14 |
mugsie | (I joke) | 15:14 |
elarson | Kiall: you could run the tests with filters to exclude tests you expect to fail | 15:14 |
Kiall | lol | 15:14 |
mugsie | kinda | 15:14 |
Kiall | You can, but that wouldn't be in the spirit of it ;) | 15:14 |
Kiall | http://docs.openstack.org/developer/tempest/HACKING.html#branchless-tempest-considerations explains it better than I | 15:14 |
* elarson reads up | 15:14 | |
* elarson has mainly used some pglass magic with tempest to test envs, so might be skewed as to the use cases | 15:15 | |
Kiall | lol | 15:15 |
pglass | well i'm just thinking about like... oslo something pbr breaks the world - then you need changes to both repos. or you merge tests before a bug is fixed and then everything is broken. | 15:15 |
elarson | pglass: that is a good point | 15:16 |
Kiall | the test repo would be gated on the tests passing, so you can't land a broken testy | 15:16 |
pglass | that's true | 15:16 |
Kiall | re requirements like pbr etc, those would break us either way.. in-tree or separate repo, same explosions | 15:16 |
elarson | this is also true, pbr breaks everything™ | 15:17 |
Kiall | The core services like nova/neutron/cinder etc have been keeping their tests in the tempest repo itself for years, so it's certainly managable. | 15:17 |
pglass | i mean, i'm fine with it | 15:18 |
Kiall | While all the new services keeping stuff in tree are in for 1 hell of a suprise IMO | 15:18 |
elarson | it seems like you'd want to publish a "here is the baseline tempest tests" that you run from a separate repo while still having some tempest tests that are release specific for new features, etc. | 15:18 |
Kiall | i.e. when tempest (master) requires PBR > 2.0 and there stable/mitaka requires PBR < 2.0 | 15:18 |
elarson | rather than breaking things up by technology (ie tempest) you break them up via function | 15:18 |
Kiall | Well, tempest's way of doing that is to decorate tests with: | 15:19 |
Kiall | @test.requires_ext(extension='ext-gw-mode', service='network') | 15:20 |
Kiall | and your service is expected to advertise the "things" it supports, or tempest.conf can be set to say which extensions are enabled. | 15:20 |
*** venkat has quit IRC | 15:20 | |
pglass | yeah, tempest has test attributes you can filter on... but it does make "which tests are supposed to pass for mitaka?" a bit more fuzzy | 15:21 |
*** rsyed_away is now known as rsyed | 15:21 | |
Kiall | pglass: yea - it does, but which tests should pass for a release should == every test executed ;) | 15:22 |
Kiall | Anyway - I honestly can't see how in-tree works long term as a tempest plugin, thanks to requirements.txt. | 15:23 |
pglass | right. when you release, all tests should pass. but a year later, when there are new tests for new features it's less clear. | 15:23 |
pglass | but maybe nobody cares about that. | 15:24 |
pglass | i don't. | 15:24 |
pglass | i'm +1 on a separate repo | 15:24 |
mugsie | timsim: last call to -2 the idea? | 15:26 |
pglass | timsim is pto, baseball | 15:26 |
Kiall | Ideally, those new tests for new features should ideally be keyed off something we expose in our API - e.g. say we added "status" to the output of a zone list API call, we'd want to expose a method for saying "status-on-zones" is supported. | 15:26 |
Kiall | i.e. being really explicit about API changes | 15:26 |
Kiall | (which, by itself is a Good Thing to be explicit about) | 15:27 |
*** nkinder has joined #openstack-dns | 15:27 | |
pglass | normally, a version would work for that. | 15:28 |
pglass | but we just have "v2" that never changes | 15:29 |
mugsie | pglass: we could do microversions :P | 15:33 |
Kiall | -10 | 15:33 |
mugsie | (for the record i am -1000 on that) | 15:33 |
pglass | it would be fine if the version wasn't in the url | 15:34 |
Kiall | but.. we could have a v2/extensions that lists out the "extra adde stuff" | 15:34 |
Kiall | added* | 15:34 |
mugsie | thats the only place you should have a microversion URL | 15:34 |
Kiall | (as nothing should ever be removed) | 15:34 |
mugsie | Kiall: we could add it at the root of /v2/ | 15:34 |
pglass | i mean, we're effectively releasing new microversions of v2 anyway. it wouldn't be horrible if we started including a "v2.0.9" in the versions list on a GET / | 15:36 |
pglass | but that's probably not openstack's way | 15:36 |
Kiall | pglass: openstack in general started down this microversions idea, and its... awkward and klunky at best | 15:36 |
pglass | it's what like all other software does | 15:37 |
mugsie | pglass: what you *should* do in microversions is v2/ always points to the latest. You then have /v2.0.9 versions availible, for people who need to pin to a partiuclar release | 15:43 |
pglass | yes | 15:43 |
pglass | i would be fine with that | 15:44 |
mugsie | openstack has decided to go with a header and (for nova for example) /v2.1 | 15:44 |
*** ccneill has joined #openstack-dns | 15:45 | |
mugsie | so you GET /v2.1 with a header of X-OpenStack-Nova-API-Version: 2.114 | 15:46 |
*** bpokorny has joined #openstack-dns | 15:46 | |
*** jschwarz has quit IRC | 16:01 | |
*** EricGonczer_ has quit IRC | 16:14 | |
*** ccneill_ has joined #openstack-dns | 16:27 | |
*** EricGonczer_ has joined #openstack-dns | 16:28 | |
*** rudrajit has joined #openstack-dns | 16:28 | |
*** ccneill has quit IRC | 16:29 | |
*** barra204 has quit IRC | 16:32 | |
*** rudrajit has quit IRC | 16:41 | |
*** EricGonczer_ has quit IRC | 16:42 | |
*** EricGonczer_ has joined #openstack-dns | 16:43 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 16:44 |
*** _shaps_ has quit IRC | 16:50 | |
*** rsyed is now known as rsyed_away | 16:53 | |
*** jasonsb has quit IRC | 17:04 | |
*** EricGonczer_ has quit IRC | 17:07 | |
*** gord0 has joined #openstack-dns | 17:15 | |
mlavalle | mugsie: ping | 17:17 |
*** ccneill_ has quit IRC | 17:22 | |
*** pglass has quit IRC | 17:31 | |
*** pglass has joined #openstack-dns | 17:32 | |
*** rudrajit has joined #openstack-dns | 17:34 | |
*** rudrajit_ has joined #openstack-dns | 17:43 | |
*** ccneill_ has joined #openstack-dns | 17:45 | |
*** rudrajit has quit IRC | 17:46 | |
*** bpokorny has quit IRC | 17:59 | |
*** james_li has quit IRC | 18:00 | |
*** james_li has joined #openstack-dns | 18:11 | |
*** rsyed_away is now known as rsyed | 18:14 | |
*** pglass has quit IRC | 18:16 | |
*** pglass has joined #openstack-dns | 18:17 | |
*** ccneill__ has joined #openstack-dns | 18:18 | |
*** ccneill__ is now known as ccneill | 18:19 | |
*** ccneill_ has quit IRC | 18:21 | |
*** EricGonczer_ has joined #openstack-dns | 18:27 | |
*** bpokorny has joined #openstack-dns | 18:30 | |
*** nyechiel_ has quit IRC | 18:36 | |
*** rudrajit has joined #openstack-dns | 18:39 | |
*** rudrajit_ has quit IRC | 18:43 | |
*** darkxploit has joined #openstack-dns | 18:46 | |
*** EricGonczer_ has quit IRC | 18:48 | |
*** EricGonczer_ has joined #openstack-dns | 18:48 | |
*** james_li has quit IRC | 18:56 | |
*** EricGonczer_ has quit IRC | 19:18 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 19:29 |
Kiall | pglass: I've made a bunch of changes to the tempest plugin, including some onion unpeeling, but the unpeeling resulted in manual .addCleanups vs magic tracking :( But overall, I'm personally liking where it's at, care to have another look? | 19:29 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 19:30 |
Kiall | derp - forgot to fix mugsie's review comment ;) | 19:30 |
Kiall | mlavalle: he's elbow deep in popcorn watching Batman v Superman | 19:31 |
pglass | `from oslo_serialization import jsonutils as json` | 19:32 |
Kiall | what about it? :) | 19:34 |
pglass | i shouldn't be surprised | 19:34 |
pglass | at what oslo will wrap or rewrite | 19:34 |
Kiall | lol, yea. | 19:34 |
mlavalle | Kiall: LOL, thanks | 19:34 |
Kiall | it's mostly for handling things native json.loads/dumps barfs on.. like dattimes. | 19:35 |
Kiall | datetimes* | 19:35 |
pglass | and it looks like it just forwards along to json (or anyjson, if it finds it) | 19:35 |
Kiall | jsonutils.loads passes through to https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L27 | 19:36 |
Kiall | I'm not entirely sure what value it provides ;) habbit to use the oslo versions because there's always something that barfs if you don't these days :) | 19:37 |
Kiall | Anyway, If I don't get any objections to what's there now, I'm going to start looking at padding out pieces I've glossed over (testing updates needs some base methods etc defined..) then port over all the existing zone tests and start down the path of moving all the things over. | 19:40 |
pglass | Kiall: those `credentials = ['primary', 'admin']` bits are compatible with all this? http://docs.openstack.org/developer/tempest/configuration.html#credential-provider-mechanisms | 19:42 |
Kiall | Yep, they are. | 19:43 |
*** EricGonczer_ has joined #openstack-dns | 19:48 | |
*** shakamunyi has joined #openstack-dns | 19:51 | |
*** ccneill has left #openstack-dns | 19:52 | |
*** shakamunyi has quit IRC | 19:57 | |
*** rsyed is now known as rsyed_away | 20:07 | |
Kiall | pglass: Q - What exactly do you guys return from your service catalog for Designate? | 20:19 |
Kiall | (refreshing my memory on https://github.com/openstack/designate/commit/9bdcb63904c3fb2f7964def9dcdd74eb20fd470b ) | 20:19 |
pglass | Kiall: https://global.dns.api.rackspacecloud.com/v2/983174 | 20:21 |
pglass | the number at the end is our tenant id | 20:21 |
Kiall | where the 983.. is a tenant id? | 20:21 |
Kiall | And for nova etc? Same pattern? | 20:21 |
pglass | yes. that's every service | 20:21 |
pglass | so i imagine someone has already figured out that bit | 20:21 |
Kiall | That's what I'm thinking. But don't want to write it off and have you redo again. | 20:22 |
Kiall | I'm also thinking the request hooks you added should be easy to port, if you use it and if tempest doesn't offer something built in that provides the same functionality. | 20:23 |
pglass | well, that was really just a quick hack to support some kind of rate limiting against our envs | 20:25 |
pglass | the right solution for that was to rate limit the client by respecting the retry-after header. | 20:26 |
Kiall | The hooks? As in, not used/needed anymore? | 20:26 |
pglass | well, we still use them | 20:26 |
pglass | but there's a better solution which was to get tempest-lib to retry on 413s, based on the retry-after header | 20:27 |
pglass | which tempest-lib does, but it only handles one kind of time format | 20:27 |
Kiall | Ah, and if that use case is solved in tempest, there's no longer a use of hooks? | 20:28 |
pglass | that's right. | 20:28 |
Kiall | (I'm trying not to copy things for the sake of coping them, if there's a use for them, they come, if not, no need.) | 20:28 |
Kiall | Any idea if there's traction in tempest to fix that? a patch etc? | 20:28 |
pglass | that makes sense | 20:28 |
pglass | i haven't checked. we were in a bit of a deadline rush at the time. | 20:29 |
Kiall | If there's a patch, there's a good chance we can get it merged by pinging the right people :) | 20:29 |
pglass | well, you can leave out the rackspace-specific bits for now, and I'll get around to worrying about them and handling things in better ways at some point | 20:30 |
Kiall | Okay, So.. I'm going to leave both of those patches for the moment. For the URI tenent_id thing, we will need to do something, as we build the v2/zones - where the tenant id needs to land in the middle, but we have a good and easy place to put that code. | 20:31 |
Kiall | For the hooks retry after use case, it'd be awesome to see a bug +patch to tempest, and I can nag the tempest folks to merge it! Less code for us + a win. | 20:32 |
Kiall | = a win* | 20:32 |
pglass | it was this bit here: https://github.com/openstack/tempest/blob/master/tempest/lib/common/rest_client.py#L631-L640 | 20:32 |
pglass | `delay = int(resp['retry-after'])` | 20:33 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 20:33 |
Kiall | ^ just changes adm -> admin | 20:33 |
*** rsyed_away is now known as rsyed | 20:33 | |
pglass | but our retry-after headers are in another format. i'll get around to fixing that at some point, assuming everything still uses that tempest.lib client | 20:34 |
Kiall | Retry-After: Fri, 31 Dec 1999 23:59:59 GMT | 20:34 |
Kiall | Retry-After: 120 | 20:34 |
Kiall | yours is the first format I guess? | 20:34 |
pglass | yep | 20:34 |
Kiall | yea, it does use it. | 20:34 |
Kiall | BTW - Have you read AND understood http://docs.openstack.org/developer/tempest/HACKING.html#negative-tests ? | 20:37 |
Kiall | I see there's some sort of specific way to do negative tests, but I haven't found any examples of it used in real life ;) | 20:38 |
Kiall | e.g. "The class decorator SimpleNegativeAutoTest will automatically generate test cases out of the given schema in the attribute _schema." | 20:38 |
Kiall | ^'s that bit I've never seen. | 20:38 |
*** nyechiel_ has joined #openstack-dns | 20:52 | |
*** rsyed is now known as rsyed_away | 20:59 | |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: Initial layout of designate tempest plugin https://review.openstack.org/283511 | 21:10 |
openstackgerrit | Kiall Mac Innes proposed openstack/designate: WIP: Broken attempt at using Tempest NegativeAutoTest https://review.openstack.org/301352 | 21:10 |
pglass | just because it exists, doesn't mean we have to use it... | 21:13 |
pglass | https://github.com/openstack/tempest/blob/master/tempest/tests/negative/test_negative_generators.py#L29-L41 | 21:19 |
pglass | there's a compute example as well: https://github.com/openstack/tempest/blob/8843f0f0768019c76be72b4be2f6a156cdbe3d78/tempest/api_schema/request/compute/v2/flavors.py | 21:21 |
pglass | https://github.com/openstack/tempest/blob/8843f0f0768019c76be72b4be2f6a156cdbe3d78/tempest/api/compute/flavors/test_flavors_negative.py#L27 | 21:21 |
*** rsyed_away is now known as rsyed | 21:30 | |
*** bpokorny has quit IRC | 21:35 | |
*** richm has joined #openstack-dns | 21:38 | |
*** gord0 has quit IRC | 21:56 | |
*** nyechiel_ has quit IRC | 21:57 | |
*** ducttape_ has quit IRC | 22:12 | |
*** pglass has quit IRC | 22:32 | |
*** EricGonczer_ has quit IRC | 22:35 | |
*** km has joined #openstack-dns | 23:00 | |
*** mlavalle has quit IRC | 23:00 | |
*** chlong has joined #openstack-dns | 23:18 | |
*** ducttape_ has joined #openstack-dns | 23:26 | |
*** ducttape_ has quit IRC | 23:28 | |
*** kei_yama has joined #openstack-dns | 23:31 | |
*** kei_yama has quit IRC | 23:51 | |
*** kei_yama has joined #openstack-dns | 23:52 | |
*** rsyed is now known as rsyed_away | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!