| *** vlad_ has quit IRC | 00:30 | |
| *** cuongnv has joined #openstack-dns | 01:02 | |
| *** n0isyn0i1e has joined #openstack-dns | 01:12 | |
| *** n0isyn0ise has quit IRC | 01:14 | |
| *** zhurong has joined #openstack-dns | 02:05 | |
| *** sonuk has joined #openstack-dns | 02:57 | |
| *** zhurong has quit IRC | 04:08 | |
| *** zhurong has joined #openstack-dns | 04:16 | |
| *** sonuk has quit IRC | 04:49 | |
| *** sonuk has joined #openstack-dns | 04:50 | |
| *** mikal_ is now known as mikal | 05:06 | |
| *** pcaruana has joined #openstack-dns | 06:20 | |
| *** openstackgerrit has joined #openstack-dns | 06:31 | |
| *** ChanServ sets mode: +v openstackgerrit | 06:31 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/designate master: Add '.' into zone format in _build_zones method https://review.openstack.org/467649 | 06:31 |
|---|---|---|
| openstackgerrit | Dai Dang Van proposed openstack/designate master: Improve testcase https://review.openstack.org/467906 | 06:31 |
| *** zhurong has quit IRC | 07:30 | |
| *** sonuk has quit IRC | 07:44 | |
| *** egonzalez has joined #openstack-dns | 07:44 | |
| *** sonuk has joined #openstack-dns | 07:45 | |
| *** renmak__ has joined #openstack-dns | 07:45 | |
| *** zhurong has joined #openstack-dns | 07:45 | |
| *** renmak__ has quit IRC | 07:46 | |
| *** amoralej|off is now known as amoralej | 07:56 | |
| *** zhurong has quit IRC | 08:54 | |
| *** zhurong has joined #openstack-dns | 09:04 | |
| *** tg90nor has quit IRC | 09:05 | |
| *** zhurong has quit IRC | 09:35 | |
| *** cuongnv has quit IRC | 10:17 | |
| *** n0isyn0i1e is now known as n0isyn0ise | 11:28 | |
| *** amoralej is now known as amoralej|lunch | 11:28 | |
| openstackgerrit | Merged openstack/designate-dashboard master: Updated from global requirements https://review.openstack.org/464368 | 11:43 |
| openstackgerrit | Merged openstack/designate-dashboard master: Imported Translations from Zanata https://review.openstack.org/466664 | 11:44 |
| *** sonuk has quit IRC | 12:10 | |
| *** KeithMnemonic1 has joined #openstack-dns | 12:38 | |
| *** KeithMnemonic has quit IRC | 12:41 | |
| daidv | greghaynes, afternoon, can I confirm with u at just one point related to https://review.openstack.org/#/c/467906/ | 12:45 |
| mugsie|alt | daidv: I assume that was for me? | 12:51 |
| mugsie|alt | (i am graham hayes) :) | 12:52 |
| daidv | ^^ Aha. | 12:52 |
| daidv | I just thought that should we allow for both of Integer and UUID as a UUID field format? | 12:53 |
| mugsie|alt | not for recordsets | 12:53 |
| mugsie|alt | we force them to be UUIDs | 12:53 |
| mugsie|alt | the only IDs that should be free form is tenant / projects and user ids | 12:54 |
| daidv | how about some others: Zone ID or something like it? | 12:54 |
| *** amoralej|lunch is now known as amoralej | 12:54 | |
| mugsie|alt | zone is UUID - the best place to look is at the objects | 12:54 |
| daidv | My question came from when I got your review and started to fix them. | 12:55 |
| mugsie|alt | anything that inherits from https://github.com/openstack/designate/blob/master/designate/objects/base.py#L655 should have the ID as a UUID | 12:55 |
| daidv | But I see to many other ID still integer in testcase | 12:55 |
| mugsie|alt | yeah - the unit tests do not validate objects | 12:56 |
| mugsie|alt | it is a bug | 12:56 |
| daidv | Humm. this was made me confused. So we should convert all of integer ID in testcase to right UUID format. right? | 12:57 |
| daidv | ofc, without tenant_id | 12:59 |
| mugsie|alt | sure, if you have the time, that would be great :) | 13:05 |
| *** chlong has quit IRC | 13:06 | |
| daidv | yep, we will bump it. | 13:07 |
| daidv | btw, sorry about my missing in yesterday meeting. | 13:07 |
| daidv | But I have read IRC meeting log and I saw that we should have some ways to validate() object when we convert from database item? | 13:08 |
| daidv | right? | 13:08 |
| mugsie|alt | we should | 13:10 |
| mugsie|alt | but that will take time | 13:10 |
| mugsie|alt | we need to fix all the unit tests first | 13:10 |
| daidv | Surely. | 13:11 |
| daidv | I still have a question "why don't we migrate to OVO objects in near future?." This will help us to auto validate | 13:12 |
| daidv | for all of action | 13:13 |
| daidv | convert data from database item -> it will validate | 13:13 |
| daidv | Set value for any field --> it also validate. | 13:13 |
| daidv | So, it ensure for any object keep a right format. | 13:13 |
| daidv | Just a question in my mind, I knew that we should fix above unit test bug before. | 13:14 |
| mugsie|alt | OVO and Designate objects are completely different | 13:18 |
| mugsie|alt | we wrote them before OVO was a thing | 13:18 |
| mugsie|alt | and now we rely on them (and their behaviour) in a lot of places - OVO will not be able to do all the things we have in our objects | 13:18 |
| daidv | Humm, thanks! I knew that you don't have more time for explain this, so I think I will investigate Designate more to get for myself detail answer. | 13:23 |
| daidv | Anyway, thank you again, hope us to have a good time contributing together in Desginate project. :) | 13:24 |
| *** renmak__ has joined #openstack-dns | 14:06 | |
| *** KeithMnemonic1 has quit IRC | 14:09 | |
| *** MarkBaker has quit IRC | 14:09 | |
| *** renmak__ has quit IRC | 14:11 | |
| *** daidv has quit IRC | 14:12 | |
| *** daidv has joined #openstack-dns | 14:18 | |
| *** MarkBaker has joined #openstack-dns | 14:21 | |
| *** daidv has quit IRC | 14:22 | |
| *** renmak__ has joined #openstack-dns | 14:27 | |
| *** chlong has joined #openstack-dns | 14:27 | |
| *** daidv has joined #openstack-dns | 14:39 | |
| *** renmak__ has quit IRC | 14:41 | |
| *** renmak__ has joined #openstack-dns | 15:01 | |
| *** renmak__ has quit IRC | 15:11 | |
| *** renmak__ has joined #openstack-dns | 15:26 | |
| *** renmak__ has quit IRC | 15:31 | |
| *** pcaruana has quit IRC | 15:38 | |
| *** pcaruana has joined #openstack-dns | 15:39 | |
| *** renmak__ has joined #openstack-dns | 15:40 | |
| *** daidv has quit IRC | 15:44 | |
| *** renmak__ has quit IRC | 15:48 | |
| *** egonzalez has quit IRC | 16:05 | |
| *** MarkBaker has quit IRC | 16:18 | |
| openstackgerrit | Nguyen Van Trung proposed openstack/designate master: Add 'DELETED' for record object. https://review.openstack.org/468088 | 16:22 |
| *** pcaruana has quit IRC | 16:30 | |
| *** pcaruana has joined #openstack-dns | 16:30 | |
| *** MarkBaker has joined #openstack-dns | 16:31 | |
| *** renmak__ has joined #openstack-dns | 17:08 | |
| *** renmak__ has quit IRC | 17:13 | |
| *** renmak__ has joined #openstack-dns | 17:30 | |
| *** renmak__ has quit IRC | 17:35 | |
| *** renmak__ has joined #openstack-dns | 17:48 | |
| *** amoralej is now known as amoralej|off | 17:52 | |
| *** renmak__ has quit IRC | 17:55 | |
| *** egonzalez has joined #openstack-dns | 17:55 | |
| *** renmak__ has joined #openstack-dns | 18:02 | |
| *** renmak__ has quit IRC | 18:14 | |
| *** renmak__ has joined #openstack-dns | 18:19 | |
| *** renmak__ has quit IRC | 18:24 | |
| *** pcaruana has quit IRC | 19:09 | |
| *** renmak__ has joined #openstack-dns | 19:54 | |
| *** renmak__ has quit IRC | 20:00 | |
| *** renmak__ has joined #openstack-dns | 20:08 | |
| *** chlong has quit IRC | 20:15 | |
| *** renmak__ has quit IRC | 20:28 | |
| *** chlong has joined #openstack-dns | 20:33 | |
| *** chlong has quit IRC | 20:37 | |
| *** kbyrne has quit IRC | 20:38 | |
| *** chlong has joined #openstack-dns | 20:38 | |
| *** chlong has quit IRC | 21:11 | |
| *** renmak__ has joined #openstack-dns | 21:16 | |
| *** renmak__ has quit IRC | 21:21 | |
| *** renmak__ has joined #openstack-dns | 21:27 | |
| *** renmak__ has quit IRC | 21:45 | |
| *** renmak__ has joined #openstack-dns | 21:54 | |
| *** renmak__ has quit IRC | 22:10 | |
| *** egonzalez has quit IRC | 23:06 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!