| *** altlogbot_1 has quit IRC | 02:56 | |
| *** altlogbot_2 has joined #openstack-dns | 02:57 | |
| openstackgerrit | Merged openstack/designate master: Ensure pdns4 driver is consistent with other drivers https://review.opendev.org/643591 | 03:18 |
|---|---|---|
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Added basic synchronized_zone tests https://review.opendev.org/659945 | 07:44 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Added basic synchronized_zone tests https://review.opendev.org/659945 | 07:45 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix metrics code always opening sockets https://review.opendev.org/659946 | 08:43 |
| eandersson | rm_work, I am wonder if you were hitting that one ^ | 08:45 |
| eandersson | Not sure if I even understand what is fully going on with the metrics implementation. | 08:46 |
| rm_work | Ah is it to monasca? | 08:46 |
| rm_work | Yes | 08:46 |
| rm_work | That test was failing on me always | 08:46 |
| rm_work | Because I have no monasca... | 08:46 |
| rm_work | On my MacBook... Lol | 08:47 |
| eandersson | We could probably just remove that code, or like implement V2 or something :p | 08:47 |
| eandersson | doubt anyone is using that code path | 08:47 |
| eandersson | the monasca client in general is weird, like not enough for it to open a socket, if you don't call open_buffer it fails with an undefined variable | 08:48 |
| eandersson | makes no sense | 08:48 |
| eandersson | https://opendev.org/openstack/monasca-statsd/src/branch/master/monascastatsd/connection.py#L84 | 08:48 |
| rm_work | But I think there were more causing all those weird popups | 08:49 |
| rm_work | Dunno | 08:49 |
| rm_work | That one is definitely an issue though | 08:49 |
| rm_work | But I don't know anything about monasca :( | 08:49 |
| eandersson | I found at least one piece of code actually opening sockets | 08:52 |
| eandersson | but this was the first one that pop'd up for me | 08:52 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix metrics code always opening sockets https://review.opendev.org/659946 | 08:53 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix metrics code always opening sockets https://review.opendev.org/659946 | 08:58 |
| rm_work | Well, appreciate you looking ;) | 09:18 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Reduce the number of sockets needed for unit tests https://review.opendev.org/659950 | 09:25 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Don't bind to tcp/udp when running unit-tests https://review.opendev.org/659950 | 09:38 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Added basic synchronized_zone tests https://review.opendev.org/659945 | 09:48 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Simplified metrics implementation https://review.opendev.org/659946 | 09:57 |
| eandersson | Maybe I should sleep.. it's 3AM on a Saturday :p | 09:57 |
| *** ircuser-1 has quit IRC | 15:17 | |
| *** altlogbot_2 has quit IRC | 18:19 | |
| *** altlogbot_3 has joined #openstack-dns | 18:19 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Simplified metrics implementation https://review.opendev.org/659946 | 18:55 |
| *** zigo has quit IRC | 19:08 | |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Simplified metrics implementation https://review.opendev.org/659946 | 21:24 |
| openstackgerrit | Erik Olof Gunnar Andersson proposed openstack/designate master: Added basic synchronized_zone tests https://review.opendev.org/659945 | 21:31 |
| eandersson | mugsie, merging some of the low risk changes you have +2'd | 21:35 |
| eandersson | rm_work, if you have time can you test to see if the tcp popups goes away with this https://review.opendev.org/#/c/659950/ ? | 21:36 |
| rm_work | eandersson: designate.tests.unit.test_metrics.test_metrics.TestMonascaMetrics.test_monasca_metrics_enabled still failing | 22:03 |
| rm_work | i have to try to pay close attention to the popups tho | 22:03 |
| rm_work | hmm ran it AGAIN and didn't fail that test? weird | 22:05 |
| rm_work | also didn't see any popups | 22:05 |
| rm_work | so maybe? | 22:05 |
| rm_work | gonna try doing a run-loop | 22:05 |
| rm_work | huh, yeah.... failing intermittently | 22:08 |
| rm_work | http://paste.openstack.org/show/751651/ | 22:09 |
| openstackgerrit | Merged openstack/designate master: Remove unused debug code https://review.opendev.org/657312 | 22:23 |
| openstackgerrit | Merged openstack/designate master: Added missing service_statuses metadata https://review.opendev.org/648313 | 22:33 |
| openstackgerrit | Merged openstack/designate master: Fixing stevedore warning when running devstack https://review.opendev.org/645457 | 22:34 |
| eandersson | rm_work, that should be fixed in this commit instead https://review.opendev.org/#/c/659946/ | 23:38 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!