*** hamalq has quit IRC | 00:57 | |
openstackgerrit | Jens Harbott (frickler) proposed openstack/designate master: Fix designate-sink shutdown issue https://review.opendev.org/725948 | 06:35 |
---|---|---|
frickler | eandersson: lgtm, testing whether we can get a passing run on master with a depends-on ^^ | 06:35 |
frickler | also, there used to be a devstack-updown job that verifies that we can also stop the openstack installation successfully, maybe we should revive this | 06:40 |
frickler | actually this issue may have been present in master for the whole cycle, if we never test shutdown, we would only notice it when we do the stable branch | 06:42 |
*** Anticimex has quit IRC | 07:56 | |
*** Anticimex has joined #openstack-dns | 08:01 | |
*** salmankhan has joined #openstack-dns | 08:34 | |
eandersson | Honestly this issue probably goes back 5 years :D | 08:41 |
eandersson | But wasn't really noticable until I enabled graceful shutdown | 08:41 |
*** livelace has joined #openstack-dns | 08:53 | |
frickler | actually there were issues for me that running unstack.sh took a long time, for all designate processes, but I didn't ever look deeper | 09:01 |
frickler | mugsie: nicolasbock: ^^ I'd think that eandersson's fix should be merged and make it into a rc2 if we can still have that, otherwise we'd need to release a .0.1 immediately after the release | 09:05 |
*** salmankhan1 has joined #openstack-dns | 09:11 | |
*** salmankhan has quit IRC | 09:12 | |
*** salmankhan1 is now known as salmankhan | 09:12 | |
*** livelace has quit IRC | 09:16 | |
*** irclogbot_0 has quit IRC | 09:41 | |
*** irclogbot_1 has joined #openstack-dns | 09:41 | |
*** bersace has joined #openstack-dns | 10:31 | |
*** livelace has joined #openstack-dns | 11:38 | |
nicolasbock | frickler: The change looks ok to me and should have a very low regression potential. I am ok with adding it to an rc2. | 11:42 |
openstackgerrit | Merged openstack/designate stable/ussuri: Fix designate-sink shutdown issue https://review.opendev.org/725977 | 13:45 |
openstackgerrit | Merged openstack/designate master: Fix designate-sink shutdown issue https://review.opendev.org/725948 | 13:45 |
*** livelace has quit IRC | 15:26 | |
*** nicolasbock has quit IRC | 15:32 | |
*** nicolasbock has joined #openstack-dns | 15:32 | |
*** livelace has joined #openstack-dns | 15:34 | |
*** hamalq has joined #openstack-dns | 16:40 | |
*** hamalq_ has joined #openstack-dns | 16:47 | |
*** hamalq has quit IRC | 16:51 | |
*** salmankhan1 has joined #openstack-dns | 17:13 | |
*** salmankhan has quit IRC | 17:17 | |
*** salmankhan1 has quit IRC | 17:18 | |
*** gmann is now known as gmann_afk | 17:25 | |
openstackgerrit | hamza proposed openstack/designate master: Adding the option to set the zone quota to unlimited, by assigning negative value for the resource https://review.opendev.org/726214 | 17:31 |
openstackgerrit | hamza proposed openstack/designate master: Adding the option to set the zone quota to unlimited https://review.opendev.org/726214 | 17:34 |
eandersson | frickler I think we might need this in train as well | 18:59 |
eandersson | It's really an issue in all versions, but before Train we weren't doing graceful shutdowns, so oslo would just forcefully kill it. | 18:59 |
*** gmann_afk is now known as gmann | 19:06 | |
*** livelace has quit IRC | 19:48 | |
*** AJaeger has joined #openstack-dns | 20:19 | |
AJaeger | could I get a review for this designate-dashboard cleanup, please? https://review.opendev.org/#/c/720750/ | 20:19 |
*** livelace has joined #openstack-dns | 20:39 | |
openstackgerrit | Merged openstack/designate-dashboard master: Cleanup py27 support https://review.opendev.org/720750 | 21:14 |
*** livelace has quit IRC | 21:14 | |
*** hamalq_ has quit IRC | 23:33 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!