eandersson | frickler ^ | 01:04 |
---|---|---|
*** hamalq has quit IRC | 01:15 | |
*** ircuser-1 has joined #openstack-dns | 04:44 | |
frickler | eandersson: a) that's a stack of 3 patches, doesn't make sense to review just the middle one. b) I don't have the capacity to review changes that large in the foreseeable future. c) I still don't think that that is a reasonable feature, but I won't block it if others want to go forward with it | 07:44 |
*** lbragstad has quit IRC | 15:29 | |
*** lbragstad has joined #openstack-dns | 15:34 | |
*** lbragstad has quit IRC | 15:35 | |
*** lbragstad has joined #openstack-dns | 15:35 | |
*** hamalq has joined #openstack-dns | 17:58 | |
*** ianychoi_ has quit IRC | 18:46 | |
*** lbragstad has quit IRC | 21:35 | |
*** lbragstad has joined #openstack-dns | 21:38 | |
*** andrewbogott has left #openstack-dns | 21:38 | |
eandersson | No worries frickler | 22:05 |
eandersson | I am in the same boat | 22:05 |
johnsom | yeah, I raised some concerns on this patch set myself on first patch. | 22:17 |
johnsom | It seems like regex's that require the operator to define is a big limitation. | 22:19 |
eandersson | johnsom I think the regex was fixed right | 22:20 |
eandersson | I mean it is no longer using a regex | 22:20 |
eandersson | based on your super valid feedback | 22:21 |
johnsom | It's been a while since I have reviewed that patch again (lots of vacation time), so maybe that was changed. | 22:21 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!