| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix dns.query.tcp/udp not always handling ipv6 properly https://review.opendev.org/c/openstack/designate/+/813722 | 03:55 |
|---|---|---|
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix dns.query.tcp/udp not always handling ipv6 properly https://review.opendev.org/c/openstack/designate/+/813722 | 07:53 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix dns.query.tcp/udp not always handling ipv6 properly https://review.opendev.org/c/openstack/designate/+/813722 | 19:47 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix dns.query.tcp/udp not always handling ipv6 properly https://review.opendev.org/c/openstack/designate/+/813722 | 19:49 |
| eandersson | johnsom ^ I didn't want to change the behavior of that call in this patch, but didn't notice that it just breaks after the first successful attempt. | 19:49 |
| eandersson | So I think it's fine and made the change you requested. | 19:49 |
| johnsom | Ok, cool. Yeah, just worried that on hosts with no IPv6 access picking the first address resolved may bomb | 19:50 |
| eandersson | Yea - that is why I initially went with the simple work around of just always picking an IPv4 address, if available | 19:51 |
| eandersson | but this is better | 19:51 |
| johnsom | eandersson If you are bored in the next few days, there are a few +2 reviews in the client repo that could use a pass over | 19:52 |
| eandersson | oh wow that is a lot | 19:52 |
| eandersson | I wonder if I have disabled python-designateclient notifications | 19:52 |
| johnsom | Well, I have been busy trying to get things cleaned up and get the stable branches happy again | 19:53 |
| johnsom | Still more work to do, but progress | 19:54 |
| opendevreview | Michael Johnson proposed openstack/python-designateclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-designateclient/+/781261 | 20:00 |
| opendevreview | Merged openstack/python-designateclient stable/wallaby: Update .gitreview for stable/wallaby https://review.opendev.org/c/openstack/python-designateclient/+/781255 | 20:05 |
| eandersson | The API logs are very spammy. I wonder if that is due to the new LOG.exception in the api middleware? | 20:48 |
| eandersson | https://zuul.opendev.org/t/openstack/build/d9f800254d7f425e931df4b64b127797/log/controller/logs/screen-designate-api.txt | 20:48 |
| johnsom | You are just not used to having *any* api logs... Grin let me see | 20:50 |
| eandersson | lol | 20:51 |
| johnsom | Oh, the oslo policy stuff. Yeah, there have been many discussions about that. | 20:51 |
| eandersson | It could be all the added functional tests as well, but pretty sure some of those error logs were historically being supressed | 20:51 |
| johnsom | There is this proposal: https://review.opendev.org/c/openstack/oslo.policy/+/799539 | 20:52 |
| eandersson | Actually referring to the errors, but that too | 20:52 |
| johnsom | Yeah, the forbidden errors are probably fallout from merging those broken patches in wallaby. I would really like to see my patch merge soon-ish: https://review.opendev.org/c/openstack/designate/+/800727 | 20:53 |
| eandersson | e.g. https://paste.openstack.org/show/bktSs1eAfbgInqq0DJDg/ | 20:53 |
| eandersson | We only need to log designate.objects.adapters.bas | 20:54 |
| eandersson | but we are showing that twice, plus a bunch of unnecessary stuff under ERROR designate.api.middleware | 20:54 |
| johnsom | Yeah, interesting. Amplifying the negative test case error logging | 20:54 |
| eandersson | I am guessing that adding LOG.exception(...) probably shows the traceback twice | 20:55 |
| johnsom | exception will log the traceback | 20:55 |
| eandersson | https://paste.openstack.org/show/811262/ | 20:55 |
| eandersson | This is what I expect to see | 20:55 |
| opendevreview | Merged openstack/python-designateclient master: Stop to use the __future__ module. https://review.opendev.org/c/openstack/python-designateclient/+/732919 | 20:56 |
| opendevreview | Merged openstack/python-designateclient master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/python-designateclient/+/790891 | 20:56 |
| opendevreview | Merged openstack/python-designateclient stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/c/openstack/python-designateclient/+/752525 | 20:56 |
| johnsom | That is basically the only difference between LOG.exception and LOG.error, exception will log a traceback | 20:56 |
| eandersson | Yea - but we have a ton of code designed to provide you with the intended traceback | 20:56 |
| eandersson | It | 20:57 |
| eandersson | It's why we have this stupid thing https://github.com/openstack/designate/blob/master/designate/rpc.py#L225 | 20:57 |
| johnsom | lol | 20:57 |
| johnsom | I can't dig into this now, but yeah, something to look at for sure | 20:58 |
| eandersson | Yea - not the end of the world | 20:58 |
| eandersson | especially in real usecases :p | 20:58 |
| johnsom | Yeah | 20:58 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add shared zone commands https://review.opendev.org/c/openstack/python-designateclient/+/726335 | 20:59 |
| opendevreview | Merged openstack/python-designateclient stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/c/openstack/python-designateclient/+/752526 | 21:06 |
| opendevreview | Merged openstack/python-designateclient master: Cap jsonschema 3.2.0 as the minimal version https://review.opendev.org/c/openstack/python-designateclient/+/730967 | 21:06 |
| opendevreview | Merged openstack/python-designateclient master: Remove H402 hacking as it is deprecated https://review.opendev.org/c/openstack/python-designateclient/+/419742 | 21:48 |
| opendevreview | Merged openstack/python-designateclient master: Clarify that name or ID can be used on TLDs https://review.opendev.org/c/openstack/python-designateclient/+/814819 | 21:48 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Use py3 as the default runtime for tox https://review.opendev.org/c/openstack/python-designateclient/+/787155 | 21:57 |
| johnsom | I figured we would have a few rebases in our future with that backlog. | 22:06 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Remove LOG.exceptions from __call__ https://review.opendev.org/c/openstack/designate/+/819168 | 22:12 |
| eandersson | The logging is already handled here | 22:12 |
| eandersson | https://github.com/openstack/designate/blob/master/designate/api/middleware.py#L280 | 22:12 |
| eandersson | If we want to keep the current behavior we could just remove the if statement here | 22:13 |
| johnsom | Cool | 22:14 |
| eandersson | expected basically means that the exception is intended e.g. 404 throws a DB Not Found error | 22:14 |
| eandersson | We could add a else statement and do something like LOG.debug(e, exc_info=True) as well | 22:15 |
| eandersson | https://paste.openstack.org/show/811265/ | 22:17 |
| eandersson | Let me know if you want me to change it to this instead ^ | 22:18 |
| johnsom | Personally, if it is expected I don’t know that we really need to log it. | 22:41 |
| opendevreview | Merged openstack/python-designateclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby https://review.opendev.org/c/openstack/python-designateclient/+/781261 | 23:09 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!