| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add basic osc unit tests https://review.opendev.org/c/openstack/python-designateclient/+/819761 | 00:32 |
|---|---|---|
| eandersson | frickler johnsom can you let me know what you think about the above ^ | 00:33 |
| eandersson | My goal is just to add some really basic tests that we can later build upon | 00:33 |
| eandersson | Hoping it would be perfect for an intern or similar to finish at some point ;) | 00:37 |
| eandersson | but would at least provide some very basic coverage for now, testing some previously completely uncovered (and critical) code paths | 00:37 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add basic osc unit tests https://review.opendev.org/c/openstack/python-designateclient/+/819761 | 00:39 |
| johnsom | eandersson In general I am fully in favor. I haven’t commented yet as I wanted to understand the existing tests. I just didn’t get to it last week. | 01:03 |
| johnsom | I did get some stable branch releases out and the Ussuri EM tag. | 01:04 |
| eandersson | All good no hurry. | 01:32 |
| eandersson | The general change is that nothing was previously covering anything in the cli folder | 01:32 |
| eandersson | https://github.com/openstack/python-designateclient/tree/master/designateclient/v2/cli | 01:33 |
| eandersson | The above patch increases unit test coverage by 10% :p | 01:36 |
| eandersson | *overall | 01:36 |
| *** dkehn__ is now known as dkehn | 14:37 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!