johnsom | frickler I saw you were doing some tests on the jsonschema change but haven't voted. Do you still have open concerns or can we land that? | 15:29 |
---|---|---|
johnsom | https://review.opendev.org/c/openstack/designate/+/846014 | 15:29 |
frickler | johnsom: the centos 9 jobs failed on the test patch, I wasn't sure if that might be related | 15:32 |
johnsom | frickler It was a timeout during a pip install and hadn't started the tests. Probably worth a recheck | 15:34 |
frickler | ah, right, now I remember. seemes the requirements were not actually installable. but not clear why that only happens for centos | 15:34 |
johnsom | no comment | 15:35 |
johnsom | I put a recheck in so we can see if it was transient | 15:35 |
frickler | but actually the patch itself is fine, so +2 on that. I was more wondering whether some other issue might be found by my test | 15:38 |
johnsom | Yeah, it seems to be the season for new issues to pop up. | 15:38 |
johnsom | Whelp, there is a bug in the show pool test. It's expecting an ordered list. | 21:14 |
eandersson | Ah yea I have seen that once or twice before | 23:55 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!