johnsom | Kind of curious on that, I thought the upper constraint restriction saved us on that issue. I will have to go look again. | 00:33 |
---|---|---|
eandersson | I don’t think that code is really used | 08:48 |
eandersson | it’s primarily used by the secondary stuff, but could be wrong. | 08:49 |
opendevreview | mitya-eremeev-2 proposed openstack/designate stable/victoria: Specify AXFR transfer timeout for dnspython v1. https://review.opendev.org/c/openstack/designate/+/864058 | 12:13 |
opendevreview | mitya-eremeev-2 proposed openstack/designate stable/victoria: Specify AXFR transfer timeout for dnspython v1. https://review.opendev.org/c/openstack/designate/+/864058 | 12:14 |
johnsom | JayF I took a look at https://review.opendev.org/c/openstack/designate/+/744013 and I think it looks fine. The coverage is not great, but it does at least run the meat of the change. Overall coverage isn't great in that driver, it would be nice if someone took an afternoon and worked to improve it. (59%, 81%, 46%) But I don't think that should block this patch. | 15:43 |
JayF | I'm not going to feed you a line about how I'll come back around to it; I'm happy to add it to my list but that's not a guarantee it gets done with how quickly that list is growing | 15:44 |
JayF | but if we could get that change in, it'd be a big help -- it basically is the last patch to "unfork" the downstream | 15:45 |
johnsom | Understood. A PTL can wish though right? Maybe you will get an intern | 15:45 |
opendevreview | mitya-eremeev-2 proposed openstack/designate master: Secondary zone loops AXFR transfer during zone creation https://review.opendev.org/c/openstack/designate/+/864131 | 17:09 |
opendevreview | mitya-eremeev-2 proposed openstack/designate master: Secondary zone loops AXFR transfer during zone creation https://review.opendev.org/c/openstack/designate/+/864131 | 17:15 |
ozzzo_work | I'm trying to figure out the python API for Designate. Reading here: https://docs.openstack.org/python-designateclient/latest/user/bindings.html# | 17:28 |
ozzzo_work | It says "To view examples of usage please checkout the doc/examples folder" | 17:28 |
ozzzo_work | but after installing python-designateclient I can't locate that folder | 17:29 |
johnsom | ozzzo_work Hi | 17:29 |
johnsom | FYI, most of OpenStack services are moving towards deprecating the python client bindings, and instead recommending you use the OpenStackSDK: https://docs.openstack.org/openstacksdk/latest/user/index.html | 17:30 |
johnsom | For new development, I would encourage you to consider using the OpenStack SDK. | 17:31 |
johnsom | That said, the examples are here in GIT: https://opendev.org/openstack/python-designateclient/src/branch/master/doc/examples | 17:31 |
johnsom | Let me look if they are included in the pip module. | 17:32 |
johnsom | Nope, it doesn't look like they were packaged in the pip module. | 17:33 |
ozzzo_work | I'm adding to existing code so I think I'll use python for now but I'll bring up the change with my team and start looking at the SDK. When can we expect the python bindings to stop working? | 17:33 |
johnsom | I have not announced a deprecation cycle for it yet (It's just been discussed), so it will be at least a year after that announcement. | 17:34 |
johnsom | So, not super soon | 17:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!