opendevreview | Merged openstack/designate-tempest-plugin master: Pin stable branch jobs nodeset to Ubuntu Focal (20.04) https://review.opendev.org/c/openstack/designate-tempest-plugin/+/861512 | 06:50 |
---|---|---|
zigo | zigo: Designate autopkgtest fails with dnspython 2.3.0~rc1: https://ci.debian.net/data/autopkgtest/unstable/amd64/d/designate/30272328/log.gz | 10:02 |
zigo | It's also the only thing that failed. | 10:02 |
zigo | https://qa.debian.org/excuses.php?experimental=1&package=dnspython | 10:02 |
zigo | Could someone look into it? | 10:02 |
frickler | seems to be the same as our own testing failures in https://zuul.opendev.org/t/openstack/builds?job_name=designate-tox-dnspython-latest&project=openstack/designate which I mentioned 2 weeks ago. probably you just want to exclude the failing tests for now | 11:01 |
johnsom | zigo I missed that over the break, I will have a look today to see if it's a dnspython bug or something we are doing wrong. | 16:04 |
johnsom | Yeah, this is likely a poorly written test, 14 is not a valid opcode: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-5 | 17:21 |
johnsom | Ok, joy, so Designate is using an unassigned opcode 14 for "command and control": https://github.com/openstack/designate/blob/master/designate/backend/private_codes.py#L26 | 18:17 |
johnsom | Which dnspython is now validating the opcodes and rejecting 14 | 18:17 |
johnsom | So, I think we have a few options for a path forward: | 19:17 |
johnsom | 1. Try to convince dnspython to include "unassigned" opcodes | 19:18 |
johnsom | 2. Monkey patch dnspython to include the opcode 14 designate is using | 19:18 |
johnsom | 3. rewrite the agent communication protocol to us the UPDATE protocol properly and switch to opcode 5 | 19:20 |
johnsom | (I have tested option 2 and it resolves the issue) | 19:21 |
johnsom | frickler eandersson Would like your input and any community feedback | 19:21 |
johnsom | Obviously #3 is a lot more work and will take more time | 19:21 |
*** dkehn_ is now known as dkehn | 23:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!