| opendevreview | Merged openstack/designate master: Secondary zone loops AXFR transfer during zone creation https://review.opendev.org/c/openstack/designate/+/864131 | 00:17 |
|---|---|---|
| ozzzo_work | eandersson: I can test /879832 but not 879833 because we don't have the FIP stuff in Train. | 17:19 |
| ozzzo_work | delete_ptr_record doesn't appear in our service.py | 17:19 |
| eandersson | Yep that is why I made two separate patches | 17:45 |
| eandersson | The FIP code is unrelated to your issue, but suffers from the same bug | 17:45 |
| eandersson | In future versions I am going to unify those two code paths | 17:48 |
| opendevreview | Merged openstack/designate stable/2023.1: Fix sharing a zone with the zone owner https://review.opendev.org/c/openstack/designate/+/879474 | 18:25 |
| johnsom | Ah, nice. The tempest patch I am reviewing now had skips due to that issue. I will update my comnments. | 18:26 |
| opendevreview | Greg Rakauskas proposed openstack/designate master: Admin and User Guide updates for multi-pools https://review.opendev.org/c/openstack/designate/+/880245 | 21:41 |
| opendevreview | Greg Rakauskas proposed openstack/designate master: Corrected Pep8 errors https://review.opendev.org/c/openstack/designate/+/880245 | 23:04 |
| ozzzo_work | eandersson: I had to change one thing. You have this at line 261: context, zone_id, record['recordset_id'], record['id'] | 23:49 |
| ozzzo_work | I had to change it to: context, record['zone_id'], record['recordset_id'], record['id'] | 23:50 |
| ozzzo_work | but that's because my criterion is different. At https://github.com/openstack/designate/blob/60edc59ff765b406e4b936deb4d200a2d9b411ce/designate/notification_handler/base.py#L243 I see this: https://paste.openstack.org/show/bPHgEIGbxsVuVP1OEtCi/ | 23:52 |
| ozzzo_work | But the code I'm running has this: https://paste.openstack.org/show/bItxugbaKdLPRcopwy9T/ | 23:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!