| gboutry | Hi, I have an issue when creating designate database, about shared_zones FK zones_id not being compatible with zones.id. While looking at the code, I noticed that this table was the only one not defining a charset. And my issue is that the default charset of my db is different from the set on other tables, making these two keys incompatibles with each other. Is ok if I go ahead and submit a patch adding the options | 09:31 |
|---|---|---|
| gboutry | mysql_engine='InnoDB', mysql_charset='utf8', which are present on all other tables ? Or is there a bug process before being able to contribute ? | 09:31 |
| opendevreview | Guillaume Boutry proposed openstack/designate master: Add mysql_engine and mysql_charset options to shared_zones table https://review.opendev.org/c/openstack/designate/+/893344 | 09:43 |
| frickler | gboutry: thanks for the fix, could you maybe also create a bug report for this on launchpad? I'm not sure whether we can fix it this way or need to do a migration, will need to wait for some other core reviewers to take a look | 09:53 |
| gboutry | Ah yes you're right, here's the bug https://bugs.launchpad.net/designate/+bug/2033635 | 10:01 |
| eandersson | frickler can you merge this in https://review.opendev.org/c/openstack/kolla-ansible/+/892427 ? | 18:02 |
| eandersson | gboutry. Can you add this to the commit message of your PR? | 18:03 |
| eandersson | > Closes-Bug: #2033635 | 18:03 |
| frickler | eandersson: done, thx for the reminder | 20:15 |
| eandersson | Thank you good sir! | 22:03 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!