| eandersson | frickler: If you have some time can you look at the above patch today? ^ | 10:20 |
|---|---|---|
| eandersson | Also gratz on the TC position frickler! | 10:20 |
| frickler | eandersson: thx for both, checking | 10:24 |
| frickler | eandersson: commented. also I'm not sure if this is a regression or was always broken? | 10:37 |
| eandersson | It’s a regression, but was in theory always broken, but for some reason not in practice | 11:18 |
| eandersson | https://github.com/openstack/designate/commit/2f86440507a05fab7bebefac2c17999c3f78b945 | 11:20 |
| eandersson | This is the commit that caused the issue | 11:20 |
| eandersson | But it’s unrelated to the issue itself as the issue is that we try to afxr when not using a secondary zone | 11:20 |
| eandersson | which is disastrous as it overwrites all record data | 11:20 |
| eandersson | as an example frickler this is before and after running pool update | 11:22 |
| eandersson | https://paste.openstack.org/show/bOpgJ9m6Hd2u5nL9F7BW/ | 11:22 |
| eandersson | It's basically wiping all information | 11:22 |
| eandersson | Which makes sense, since the code basically does an AXFR and uses the result to rebuild the zone | 11:26 |
| eandersson | https://github.com/openstack/designate/blob/master/designate/dnsutils.py#L113 | 11:26 |
| eandersson | https://github.com/openstack/designate/blob/master/designate/worker/tasks/zone.py#L180 | 11:27 |
| eandersson | All other calls to this is protected in some shape or form. | 11:29 |
| eandersson | https://github.com/openstack/designate/blob/d6de3cf4f0560fb84677442ecb824899160ca9ee/designate/mdns/handler.py#L129 | 11:29 |
| eandersson | https://github.com/openstack/designate/blob/d6de3cf4f0560fb84677442ecb824899160ca9ee/designate/central/service.py#L821 | 11:29 |
| eandersson | https://github.com/openstack/designate/blob/d6de3cf4f0560fb84677442ecb824899160ca9ee/designate/central/service.py#L1131 | 11:29 |
| eandersson | Once this is merged I'll probably purpose a second patch with more protection against this and some tests if I can come up with some reasonable ones. | 11:30 |
| eandersson | (but for the sake of keeping this simple to backport I just fixed the bug itself) | 11:30 |
| eandersson | Actually I can throw a basic test in | 11:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/894898 | 11:41 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/894898 | 11:43 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Prevent XFR from being used on PRIMARY zones https://review.opendev.org/c/openstack/designate/+/896061 | 12:05 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix AXFR loop when updating secondary zone https://review.opendev.org/c/openstack/designate/+/896062 | 12:30 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix AXFR loop when updating secondary zone https://review.opendev.org/c/openstack/designate/+/896062 | 12:32 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Prevent XFR from being used on PRIMARY zones https://review.opendev.org/c/openstack/designate/+/896061 | 12:37 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix AXFR loop when updating secondary zone https://review.opendev.org/c/openstack/designate/+/896062 | 12:37 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix AXFR loop when updating secondary zone https://review.opendev.org/c/openstack/designate/+/896062 | 12:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/2023.2: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/895920 | 12:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/2023.1: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896063 | 12:49 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/zed: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896101 | 12:50 |
| opendevreview | kiran pawar proposed openstack/designate master: Add new API for zone move https://review.opendev.org/c/openstack/designate/+/796633 | 12:50 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/yoga: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896064 | 12:55 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/xena: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896065 | 12:57 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/wallaby: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896102 | 12:57 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/wallaby: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896102 | 12:58 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/victoria: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896103 | 12:58 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/ussuri: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896104 | 12:58 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/yoga: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896064 | 14:01 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/xena: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896065 | 14:11 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/wallaby: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896102 | 14:12 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/victoria: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896103 | 14:13 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/ussuri: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896104 | 14:13 |
| opendevreview | Merged openstack/designate master: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/894898 | 15:09 |
| -opendevstatus- NOTICE: The lists.openinfra.dev and lists.starlingx.io sites will be offline briefly for migration to a new server | 15:30 | |
| opendevreview | Merged openstack/designate stable/2023.2: Update .gitreview for stable/2023.2 https://review.opendev.org/c/openstack/designate/+/895422 | 16:21 |
| opendevreview | Merged openstack/designate stable/2023.2: Update TOX_CONSTRAINTS_FILE for stable/2023.2 https://review.opendev.org/c/openstack/designate/+/895424 | 16:22 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/yoga: [CI] Reduce workers and disable cinder to save on memory https://review.opendev.org/c/openstack/designate/+/896118 | 22:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!