| frickler | johnsom: eandersson: should this latest fix also go into bobcat rc2? | 09:12 |
|---|---|---|
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate stable/2023.2: Prevent XFR from being used on PRIMARY zones https://review.opendev.org/c/openstack/designate/+/896528 | 09:43 |
| eandersson | Would need two PRs merged as I made these a chain | 09:46 |
| eandersson | I didn’t understand the issue when I started that third patch | 09:46 |
| eandersson | *fully | 09:48 |
| frickler | eandersson: that was kind of implicitly part of my question: do we (you) understand the issue well enough now so that we can assume that it is completely fixed now, or is there more work needed? | 09:49 |
| frickler | and https://review.opendev.org/c/openstack/designate/+/896062 is merged, so should be fine to get backported, too, isn't it? | 09:50 |
| eandersson | Yea we understand the issue fine now | 10:04 |
| eandersson | The second patch just patches the issue in a way that was more difficult to backport. | 10:07 |
| eandersson | And the third patch fixes an issue where a create/update secondary zone would trigger an AXFR, and that AXFR then calls update secondary zone. The problem is if the master of a secondary zone was updated (e.g. pool update) it would get stuck in an infinit loop. We fixed this by making sure that the update_zone call from the AXFR function never has | 10:09 |
| eandersson | masters set. | 10:09 |
| eandersson | It was previously fixed, but only for create_zone, so we moved the fix to the central AXFR code. | 10:10 |
| frickler | eandersson: so IMO should go into 2023.2, where there is no delta to master so far? we can skip backports to older stable branches if they're too complicated | 11:52 |
| frickler | s/IMO/IMO all/ | 11:53 |
| eandersson | Yea no delta | 11:56 |
| eandersson | and the remaning patches aren't critical enough to need backports to older stable branches | 11:57 |
| eandersson | Well no delta, but there are 3 patches in the chain | 11:58 |
| eandersson | https://review.opendev.org/c/openstack/designate/+/896061 | 11:58 |
| eandersson | https://review.opendev.org/c/openstack/designate/+/896062 | 11:58 |
| eandersson | So they would need to be backported in order | 11:58 |
| frickler | doesn't gerrit stack those automatically? let me test this, if it doesn't work, I'll stack'em manually | 12:00 |
| frickler | hmm, gives a merge conflict, so manual it is | 12:01 |
| eandersson | Thanks! | 12:04 |
| opendevreview | Dr. Jens Harbott proposed openstack/designate stable/2023.2: Fix AXFR loop when updating secondary zone https://review.opendev.org/c/openstack/designate/+/896648 | 12:18 |
| frickler | johnsom: eandersson: ^^ I'll -1 the release patches and update once these are in | 12:21 |
| frickler | meh, too late, https://review.opendev.org/c/openstack/releases/+/896596 just merged. so it'll be rc3 | 12:23 |
| johnsom | Yeah, to me they are not super high priority as they are for secondary zones and it wasn't clear we could make the RC cut off on Thursday, so I pushed RC2 for the critical patch we knew we had. | 15:31 |
| johnsom | Sadly there is no tempest scenario coverage for the secondary zones. | 15:47 |
| eandersson | Yea - def not critical patches, but I am not against a third rc, but also not going to push for it. | 15:59 |
| opendevreview | Merged openstack/designate stable/wallaby: Fix bug with designate-manage pool update losing existing record data https://review.opendev.org/c/openstack/designate/+/896102 | 17:18 |
| opendevreview | Merged openstack/designate master: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/894895 | 19:07 |
| opendevreview | Michael Johnson proposed openstack/designate stable/2023.2: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896702 | 20:33 |
| opendevreview | Michael Johnson proposed openstack/designate stable/2023.1: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896703 | 20:33 |
| opendevreview | Michael Johnson proposed openstack/designate stable/zed: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896704 | 20:33 |
| opendevreview | Michael Johnson proposed openstack/designate stable/yoga: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896705 | 20:33 |
| opendevreview | Michael Johnson proposed openstack/designate stable/xena: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896727 | 20:51 |
| opendevreview | Michael Johnson proposed openstack/designate stable/wallaby: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896706 | 20:51 |
| opendevreview | Michael Johnson proposed openstack/designate stable/victoria: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896707 | 20:52 |
| opendevreview | Michael Johnson proposed openstack/designate stable/ussuri: Add middleware to limit request body size to api-paste https://review.opendev.org/c/openstack/designate/+/896708 | 20:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!