| frickler | eandersson: do you have a reference to how this "lambda:" things works? I see it is already being used in some other locations, so it can't be too wrong, but I'm unsure whether changing old migration files is correct | 13:52 |
|---|---|---|
| eandersson | frickler: the old migration files is just returning it to how it worked before the bug was introduced | 14:57 |
| eandersson | As for lanbda just means that the config value now gets evaluated each time the object gets instantiated | 14:58 |
| eandersson | btw there is a better description of the bug in my comments | 15:06 |
| eandersson | https://bugs.launchpad.net/designate/+bug/2042944/comments/3 | 15:06 |
| eandersson | The reason lamdba (or a fucntion) works is because sqlalchemy checks if the value is callable | 15:24 |
| eandersson | https://github.com/sqlalchemy/sqlalchemy/blob/447cafd12df4811e4701c8b39f48a927e5414f90/lib/sqlalchemy/sql/schema.py#L3449 | 15:24 |
| eandersson | https://github.com/sqlalchemy/sqlalchemy/blob/447cafd12df4811e4701c8b39f48a927e5414f90/lib/sqlalchemy/sql/schema.py#L3434 | 15:25 |
| frickler | eandersson: ah, o.k., thx, +2 | 15:48 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add support for catalog zones https://review.opendev.org/c/openstack/designate/+/885594 | 16:51 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add catalog zone support to devstack plugin https://review.opendev.org/c/openstack/designate/+/892814 | 16:53 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add support for catalog zones https://review.opendev.org/c/openstack/designate/+/885594 | 18:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!