| opendevreview | Takashi Kajinami proposed openstack/designate master: Make edgegrid-python optional https://review.opendev.org/c/openstack/designate/+/906248 | 07:58 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/designate master: Make edgegrid-python optional https://review.opendev.org/c/openstack/designate/+/906248 | 08:01 |
| tkajinam | wondering if akamai v2 backend is actually used. I've not seen any update since it was initially added in 2019 | 08:03 |
| * frickler would just dump all non-free backends. ymmv. was already wondering whether eandersson has some vested interest in infoblox or is just cleaning up a bit | 08:17 | |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Updated Infoblox backend https://review.opendev.org/c/openstack/designate/+/904978 | 10:19 |
| eandersson | I am just cleaning up old code | 10:28 |
| opendevreview | Takashi Kajinami proposed openstack/designate master: Make edgegrid-python optional https://review.opendev.org/c/openstack/designate/+/906248 | 10:29 |
| opendevreview | Takashi Kajinami proposed openstack/designate master: Make edgegrid-python optional https://review.opendev.org/c/openstack/designate/+/906248 | 10:46 |
| eandersson | frickler: It's still failing the req check | 10:54 |
| eandersson | Not sure if it is worth making the infoblox client optional in that case | 10:55 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Updated Infoblox backend https://review.opendev.org/c/openstack/designate/+/904978 | 10:58 |
| frickler | eandersson: commented in the review, though that seems to have overlapped with your latest ps | 11:00 |
| eandersson | Oh yea but that isn’t an acceptable solution to not have them in requirements | 11:01 |
| eandersson | Then we make them plugins | 11:01 |
| eandersson | Or remove the driver all together | 11:01 |
| eandersson | I won't support code that we cannot test in the main test suit. | 11:05 |
| frickler | well you can only do unit tests anyway, or do you have an infoblox backend somewhere? | 11:08 |
| eandersson | Does not seem acceptable to me. | 11:09 |
| eandersson | If we want to make it more difficult to maintain the project we might as well just either drop the code completely, or make the backend a plugin. | 11:13 |
| eandersson | I am fine making in an extra like the edgegrid PR above, but the key difference there is that we are still testing it as part of the regular test suite by having it in test-requirements.txt | 11:25 |
| opendevreview | Takashi Kajinami proposed openstack/designate master: Make edgegrid-python optional https://review.opendev.org/c/openstack/designate/+/906248 | 12:47 |
| eandersson | Another path is just to not use the library and go back to the original implementation. | 12:59 |
| eandersson | That seems like a crazy option to me, but maybe less complicated. | 13:00 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Updated Infoblox backend https://review.opendev.org/c/openstack/designate/+/904978 | 13:53 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Updated Infoblox backend https://review.opendev.org/c/openstack/designate/+/904978 | 13:54 |
| eandersson | I am gonna leave the PR as-is. Feel free to either carry it, or drop it. | 13:54 |
| eandersson | But don't merge it if you decide to go the non requirements route. | 13:54 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add support for catalog zones https://review.opendev.org/c/openstack/designate/+/885594 | 14:23 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add catalog zone support to devstack plugin https://review.opendev.org/c/openstack/designate/+/892814 | 14:25 |
| tobias-urdin | johnsom: could you check https://review.opendev.org/c/openstack/designate-dashboard/+/903880 when you have some time available? thanks! | 16:19 |
| johnsom | Sure, NP | 16:20 |
| tobias-urdin | \o/ thanks | 16:21 |
| opendevreview | Merged openstack/designate-dashboard master: Migrate passthrough to openstacksdk https://review.opendev.org/c/openstack/designate-dashboard/+/903880 | 23:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!