| stephenfin | johnsom: oschwart: just a reminder that https://review.opendev.org/c/openstack/designate/+/948799/ and https://review.opendev.org/c/openstack/designate/+/950569/ are ready for review. They should be a better long-term fix that the scripts (which is breaking in some environments) | 09:59 |
|---|---|---|
| oschwart | stephenfin thanks for the reminder. I would prefer johnsom to review it as I have very little experience with mod_wsgi and uwsgi | 10:13 |
| oschwart | with that being said, I see here https://review.opendev.org/c/openstack/designate/+/950569/3/setup.cfg#64 | 10:13 |
| oschwart | designate-api-wsgi = designate.wsgi.api:application | 10:14 |
| oschwart | while in the bind job I still see wsgi-file = /opt/stack/data/venv/bin/designate-api-wsgi | 10:14 |
| oschwart | https://47a624755bd42692a936-ba34e4226dca04b61ca2c662e5f6bd64.ssl.cf2.rackcdn.com/openstack/b1a7121a9f9a47a6b801e4f4454b64db/controller/logs/etc/designate/designate-api-uwsgi.ini | 10:14 |
| stephenfin | oschwart: I will reply to johnsom but the answer is yes. You will note that this is a stable-only change and I have explicitly *not* migrated the devstack plugin from script-based configuration (wsgi-file) to module path-based configuration (module) | 10:17 |
| stephenfin | so the fact that jobs are passing despite the removal of wsgi_scripts is proof that this approach is sufficient | 10:17 |
| stephenfin | (I have a follow-up to do the migration to a module path-based configuration, but as I've noted on the change I don't think we should do that on stable branches. As such, it's really a DNM to prove both approaches will now work https://review.opendev.org/c/openstack/designate/+/950633/) | 10:18 |
| oschwart | stephenfin ack, thanks | 10:43 |
| opendevreview | Elod Illes proposed openstack/python-designateclient master: DNM: gate health test https://review.opendev.org/c/openstack/python-designateclient/+/952920 | 16:25 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!