| opendevreview | Omer Schwartz proposed openstack/designate master: Add a Neutron client using openstacksdk https://review.opendev.org/c/openstack/designate/+/947206 | 11:22 |
|---|---|---|
| opendevreview | Omer Schwartz proposed openstack/designate master: Add a producer task that removes stale ptr records https://review.opendev.org/c/openstack/designate/+/946752 | 11:22 |
| opendevreview | Omer Schwartz proposed openstack/designate master: Add a producer task that removes stale ptr records https://review.opendev.org/c/openstack/designate/+/946752 | 12:01 |
| tkajinam | oschwart, I've left one more comment in https://review.opendev.org/c/openstack/designate/+/947206 . | 14:52 |
| tkajinam | which is more correct. checking what was done in octavia might be helpful but what was done there is a bit different from what you are trying to achieve | 14:53 |
| tkajinam | their main aim was to replace existing implementation to call neutron using credential in octavia.conf, but you are adding it from scratch here | 14:54 |
| tkajinam | but still I think sticking with the new neutron section instead of adding fallback for existing sections for different purpose is the better approach, I believe | 14:54 |
| oschwart | tkajinam, I think I should add a neutron section either way, so I guess I could move those keystone_authtoken config options to neutron and then we see how to continue | 14:58 |
| oschwart | all of that keystone & neutron authentication is pretty new to me, I don't think I did something similar before | 15:00 |
| tkajinam | ideally we may want a fallback logic which may work without any credential set (or if the logic can be skipped then we can just skip it if neutron section is not configured properly, with warning logged) | 15:00 |
| tkajinam | a tricky part is that there are two groups of options in these auth sections. some of these(like username, auth_url) are used for initial authentication to get token and catalog, and the others are used for further interaction with the services(eg. neutron) you actually want to use (like region_name, interface) | 15:02 |
| tkajinam | so if you use keystone section then you are forced to use the same access pattern for keystone api as well as neutron api | 15:02 |
| tkajinam | this is just fyi. just ignore it if that's too complicated (I think so) | 15:02 |
| tkajinam | so yeah we can start with adding the new neutron section and then consider how we may add/need fallback | 15:03 |
| oschwart | sounds good to me. thanks! | 15:04 |
| tkajinam | oschwart, :-) | 15:06 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!