| efried | what little link bars? | 00:01 |
|---|---|---|
| johnsom | The CSS does make the check marks larger, which my last patch adjusts | 00:01 |
| efried | So I've got the old and new right next to each other in two browser tabs, and flipping back and forth I can't see any difference | 00:01 |
| johnsom | In the table, the check marks have little under bars indicating links. | 00:01 |
| efried | man, if there's a difference, it's too subtle for me to see it. | 00:02 |
| johnsom | Did the browser cache the CSS from the first run? maybe try a control-Refresh? | 00:02 |
| johnsom | It is a big difference for me | 00:02 |
| johnsom | Also, you can check in the cinder directory, docs/build/html/_static/ should have support-matrix.css file which it did not before | 00:03 |
| johnsom | If it's not there, it is likely tox pulled the version from pypi | 00:04 |
| efried | johnsom: Argh, I caught PS3 instead of PS2 :) | 00:05 |
| johnsom | That would do it, I just started the split | 00:05 |
| efried | Sorry to grind you like this. I look at this repository like once a year. And I am far from a docs expert. | 00:08 |
| johnsom | Yeah, no worries. I'm just happy that you *did* look at my patches. | 00:08 |
| johnsom | I fully expected to have to bug people in the oslo meeting Monday. | 00:09 |
| johnsom | Ok, split is done | 00:10 |
| johnsom | We are going to be using this heavily in the Octavia docs. Thus why I am fixing things as I see them. | 00:11 |
| efried | yup, I just created https://review.openstack.org/652176 | 00:11 |
| efried | hoping depends-on works from a to b there... | 00:11 |
| efried | which was my original question. | 00:11 |
| efried | And now I'm seeing a difference locally. | 00:11 |
| efried | the bigger ✔/X and the colors on complete/missing | 00:12 |
| johnsom | Yep, cool. So the CSS is now being applied. | 00:12 |
| *** jungleboyj has quit IRC | 00:13 | |
| efried | whoops, I messed up that cinder patch | 00:13 |
| johnsom | I think the ✔/X is too big IMO, so I proposed making it "normal" size in https://review.openstack.org/#/c/652171/ | 00:13 |
| efried | ack | 00:16 |
| johnsom | With the current patch chain (all four of them) I get this for the Octavia page I am working on now: | 00:16 |
| johnsom | https://usercontent.irccloud-cdn.com/file/CN1gWYOC/image.png | 00:17 |
| efried | oo | 00:17 |
| efried | Hoping I can get this cinder tester working; if so I can depends-on all of your patches and have something to link in your changes when I +2 them :) | 00:17 |
| efried | btw, any idea where thingee disappeared to? | 00:18 |
| *** diablo_rojo_phon has quit IRC | 00:18 | |
| johnsom | No, sorry. | 00:20 |
| *** jungleboyj has joined #openstack-doc | 00:20 | |
| *** mnaser has quit IRC | 00:20 | |
| *** jungleboyj has quit IRC | 00:27 | |
| johnsom | efried It doesn't look like it picked it up. I think you need required-projects in the zuul definition to have it pick up depends-on changes. | 00:35 |
| johnsom | I can probably add that to you patch if you would like | 00:36 |
| *** eumel8 has quit IRC | 00:37 | |
| efried | johnsom: Let me try. I'm trying to larn this zuul thing. | 00:39 |
| johnsom | +1 | 00:40 |
| efried | johnsom: This look right? https://review.openstack.org/652176 | 00:41 |
| efried | f, cancel | 00:42 |
| *** jungleboyj has joined #openstack-doc | 00:42 | |
| efried | johnsom: reload, PS4 if you please... | 00:42 |
| efried | nope | 00:43 |
| johnsom | efried I think publish-openstack-docs-pti is a template and not a job that can be a parent. | 00:43 |
| efried | oh | 00:43 |
| johnsom | Try "openstack-tox-docs" as the parent | 00:44 |
| efried | ... | 00:44 |
| johnsom | Otherwise that is what I would have done too | 00:44 |
| efried | done. That makes sense... sorta. | 00:44 |
| *** mnaser has joined #openstack-doc | 00:44 | |
| * efried doesn't know the difference between a template and a job | 00:45 | |
| efried | a template contains multiple jobs? | 00:45 |
| johnsom | A template has both check and gate jobs defined in it | 00:45 |
| johnsom | Right | 00:45 |
| efried | ah | 00:45 |
| efried | and can it be multiple jobs in each? | 00:45 |
| johnsom | Yes | 00:45 |
| efried | remind me where the template and base job thingies are defined? | 00:45 |
| johnsom | Well, easier said then done as the are spread over a few repos. I usually codesearch for the tempate name and dig. | 00:46 |
| efried | mm, okay. | 00:46 |
| johnsom | http://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/zuul.d/project-templates.yaml#n78 | 00:47 |
| efried | johnsom: Well, it's not acknowledging sphinx-feature-classification as a project that exists. Did I spell it wrong? | 00:47 |
| efried | oh | 00:48 |
| efried | I need openstack/ | 00:48 |
| johnsom | Ah, yes, openstack/ | 00:48 |
| efried | I'll get there eventually. | 00:48 |
| efried | johnsom: You said https://review.openstack.org/#/c/652165/ was going to be n/a for cinder? | 00:58 |
| efried | because it doesn't use `link` in the driver defs? | 00:59 |
| johnsom | Sadly yes, there are no links defined for any of the drivers. You could add one however. | 00:59 |
| johnsom | Correct | 00:59 |
| efried | yeah, I'll do that in my test patch (once I've seen it actually working) | 01:00 |
| efried | woot http://logs.openstack.org/76/652176/6/check/my-docs/10ca382/html/reference/support-matrix.html | 01:03 |
| johnsom | That looks like it worked, it picked up the CSS | 01:03 |
| efried | yup | 01:03 |
| efried | johnsom: PS7 is up, with a link and deps to all of your changes. | 01:05 |
| efried | easter egg in there for ya | 01:05 |
| johnsom | +1 I'm posting an update to the main openstack-tox-docs job to add the required-project. Since at least two projects will be using it. | 01:06 |
| efried | ah, cool. | 01:07 |
| johnsom | efried FYI: https://review.openstack.org/652180 | 01:08 |
| efried | johnsom: Hm, that's weird, the line above your change? | 01:09 |
| efried | has a name: key | 01:09 |
| johnsom | Yeah, I know, I don't know why. It's not necessary. | 01:09 |
| efried | does it work at all? | 01:09 |
| johnsom | It must, we are all running that docs job.... It's just odd. There are other spots in the same file that don't use the name tag either. | 01:10 |
| johnsom | Pentatonix fan eh? | 01:10 |
| efried | for sure | 01:10 |
| efried | I'm a harmony nerd | 01:11 |
| johnsom | Nice | 01:11 |
| efried | Though I'm not loving their new bass | 01:11 |
| efried | guess I just haven't heard anything where he's showcased. | 01:12 |
| johnsom | After we get the results from this run and I give you a minute to take a look at them, I am going to sign off for the evening and go make dinner. | 01:15 |
| efried | Thanks for the work here, johnsom. I'm buying the drinks if you cut nova over to use s-f-c | 01:17 |
| johnsom | Ha! well, not sure I can commit to that at this point. I'm pretty busy with my Octavia work. | 01:17 |
| johnsom | Hmm, ok, so there must be something wrong with the https://review.openstack.org/#/c/652171/ patch as the cells didn't render their borders. | 01:19 |
| johnsom | Ah, I bet I know what I did wrong there. | 01:20 |
| *** jamesmcarthur has joined #openstack-doc | 01:21 | |
| *** jamesmcarthur has quit IRC | 01:26 | |
| *** jamesmcarthur has joined #openstack-doc | 01:27 | |
| johnsom | Ok, I am going to have to work on https://review.openstack.org/#/c/652171/ I didn't realize I had my intermediate fix still in place when I tested that. The cells are not getting their border. | 01:31 |
| johnsom | The others look good though | 01:31 |
| efried | johnsom: ayup, okay, that all gels with what I saw. Reviewed all, You're totaling +5 from me at the moment :) | 01:35 |
| johnsom | lol, thanks! | 01:36 |
| johnsom | Testing out a fix for the cells now | 01:36 |
| johnsom | efried https://review.openstack.org/#/c/652171/2 Fixes it local if you want to re-check | 01:39 |
| efried | done | 01:40 |
| *** rmstar has quit IRC | 01:42 | |
| *** jamesmcarthur has quit IRC | 02:18 | |
| *** jamesmcarthur has joined #openstack-doc | 03:59 | |
| *** jamesmcarthur has quit IRC | 04:03 | |
| *** factor has quit IRC | 04:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/contributor-guide master: Imported Translations from Zanata https://review.openstack.org/652192 | 07:28 |
| *** jungleboyj has quit IRC | 07:45 | |
| *** preece has quit IRC | 07:45 | |
| *** csatari has quit IRC | 07:45 | |
| *** hogepodge has quit IRC | 07:45 | |
| *** jungleboyj has joined #openstack-doc | 07:47 | |
| *** preece has joined #openstack-doc | 07:47 | |
| *** csatari has joined #openstack-doc | 07:47 | |
| *** hogepodge has joined #openstack-doc | 07:47 | |
| openstackgerrit | Merged openstack/contributor-guide master: Imported Translations from Zanata https://review.openstack.org/652192 | 09:32 |
| *** tosky has joined #openstack-doc | 13:02 | |
| *** efried1 has joined #openstack-doc | 15:07 | |
| *** efried has quit IRC | 15:08 | |
| *** efried1 is now known as efried | 15:08 | |
| *** tosky has quit IRC | 15:33 | |
| *** jamesmcarthur has joined #openstack-doc | 15:46 | |
| *** spotz has quit IRC | 16:48 | |
| *** mtreinish has quit IRC | 16:48 | |
| *** niceplace has quit IRC | 16:48 | |
| *** tonyb has quit IRC | 16:48 | |
| *** jamesmcarthur has quit IRC | 16:52 | |
| *** jamesmcarthur has joined #openstack-doc | 16:55 | |
| *** niceplace has joined #openstack-doc | 17:06 | |
| *** mtreinish has joined #openstack-doc | 17:06 | |
| *** jamesmcarthur has quit IRC | 17:11 | |
| *** jamesmcarthur has joined #openstack-doc | 17:29 | |
| *** jamesmcarthur_ has joined #openstack-doc | 17:33 | |
| *** jamesmcarthur has quit IRC | 17:34 | |
| *** jamesmcarthur_ has quit IRC | 20:05 | |
| *** jamesmcarthur has joined #openstack-doc | 20:35 | |
| *** jamesmcarthur has quit IRC | 20:43 | |
| *** jamesmcarthur has joined #openstack-doc | 20:47 | |
| *** jamesmcarthur has quit IRC | 20:56 | |
| *** jamesmcarthur has joined #openstack-doc | 20:57 | |
| *** jamesmcarthur has quit IRC | 21:00 | |
| *** jamesmcarthur has joined #openstack-doc | 21:01 | |
| *** jamesmcarthur has quit IRC | 22:18 | |
| *** jamesmcarthur has joined #openstack-doc | 22:46 | |
| *** jamesmcarthur has quit IRC | 23:07 | |
| *** jamesmcarthur has joined #openstack-doc | 23:37 | |
| *** jamesmcarthur has quit IRC | 23:42 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
