| *** dmacpher has joined #openstack-doc | 00:21 | |
| *** dmacpher_ has quit IRC | 00:22 | |
| *** efried has quit IRC | 00:37 | |
| *** efried has joined #openstack-doc | 00:45 | |
| openstackgerrit | Merged openstack/training-labs master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/654675 | 02:41 |
|---|---|---|
| *** threestrands has joined #openstack-doc | 03:31 | |
| *** altlogbot_3 has quit IRC | 03:44 | |
| *** altlogbot_2 has joined #openstack-doc | 03:45 | |
| *** altlogbot_2 has quit IRC | 04:38 | |
| *** altlogbot_3 has joined #openstack-doc | 04:39 | |
| *** altlogbot_3 has quit IRC | 04:40 | |
| *** altlogbot_1 has joined #openstack-doc | 04:41 | |
| *** pcaruana has joined #openstack-doc | 05:15 | |
| *** rcernin has quit IRC | 06:01 | |
| *** rcernin has joined #openstack-doc | 06:01 | |
| *** rcernin has quit IRC | 06:52 | |
| *** tesseract has joined #openstack-doc | 07:05 | |
| *** tosky has joined #openstack-doc | 07:11 | |
| *** tosky has quit IRC | 07:40 | |
| *** tosky has joined #openstack-doc | 07:42 | |
| *** Emine has joined #openstack-doc | 07:43 | |
| openstackgerrit | Merged openstack/training-labs stable/pike: Fix disk multiattach with VirtualBox 6 https://review.opendev.org/661433 | 07:55 |
| openstackgerrit | Merged openstack/training-labs stable/rocky: Fix disk multiattach with VirtualBox 6 https://review.opendev.org/661430 | 08:00 |
| openstackgerrit | Merged openstack/training-labs stable/ocata: Fix disk multiattach with VirtualBox 6 https://review.opendev.org/661432 | 08:07 |
| *** kopecmartin|off is now known as kopecmartin | 08:09 | |
| openstackgerrit | Merged openstack/training-labs stable/queens: Fix disk multiattach with VirtualBox 6 https://review.opendev.org/661431 | 08:10 |
| frickler | the links for the reno tool are broken e.g. in nova, IIUC because there are only latest docs and no stable branches for reno. can someone help with fixing this? https://docs.openstack.org/nova/rocky/contributor/releasenotes.html | 08:44 |
| AJaeger | frickler: looks like a bug in reno-doc, dhellmann wrote that, maybe he can help ^ | 08:49 |
| * AJaeger wonders where reno-doc is defined, can't find it directly ;( | 08:50 | |
| *** strigazi has joined #openstack-doc | 09:04 | |
| openstackgerrit | Merged openstack/openstack-manuals master: Set a note to Ubuntu network interface names https://review.opendev.org/657315 | 09:19 |
| *** threestrands has quit IRC | 09:54 | |
| *** redrobot has quit IRC | 11:39 | |
| *** tesseract has quit IRC | 11:53 | |
| *** tesseract has joined #openstack-doc | 11:53 | |
| stephenfin | frickler: I don't understand the issue. Do you mean specific links are broken or all links? | 11:59 |
| *** redrobot has joined #openstack-doc | 12:23 | |
| AJaeger | stephenfin: the links to reno are broken, go to the page, it links to ... | 12:32 |
| AJaeger | "reno documentation" -> https://docs.openstack.org/reno/rocky/user/index.html | 12:32 |
| AJaeger | "nova uses reno" -> https://docs.openstack.org/reno/rocky/ | 12:32 |
| AJaeger | that should not be reno/rocky but always reno/latest | 12:33 |
| chason | stephenfin We need update opendocstheme. For example, the reno project. Reno didn't have the rocky branch. but reno-doc still render https://docs.openstack.org/reno/rocky/ | 12:33 |
| dhellmann | There are no stable branches of reno. It doesn't need to be co-installable and fixes are just released from master. So just link to /reno/latest/whatever.html | 12:33 |
| dhellmann | I don't know what "reno-doc" is | 12:33 |
| AJaeger | so, where does it come from? Now I'm confused ;( | 12:33 |
| dhellmann | I guess that's a directive of some sort to compute the right link? We shouldn't use that for reno. | 12:34 |
| stephenfin | dhellmann: I guess you're referring to https://opendev.org/openstack/nova/blame/branch/master/doc/source/contributor/releasenotes.rst#L23 | 12:35 |
| stephenfin | That's mu mistake | 12:35 |
| AJaeger | ah, found it | 12:35 |
| stephenfin | *my | 12:35 |
| AJaeger | doc/source/conf.py:openstack_projects = [ | 12:35 |
| stephenfin | *we're | 12:35 |
| AJaeger | in nova is the setting | 12:35 |
| AJaeger | and openstackdocstheme/ext.py uses it... | 12:35 |
| AJaeger | stephenfin: yeah, you need to remove reno from that list... | 12:35 |
| chason | If there is only master brach, _setup_link_roles should always use "latest" instead of series from "_get_series_name()". | 12:35 |
| dhellmann | oh, fun | 12:35 |
| AJaeger | dhellmann: indeed, false alarm ;/ | 12:35 |
| dhellmann | yeah, the theme shouldn't have to figure out which repos have branches and which don't. | 12:36 |
| *** mtreinish has quit IRC | 12:36 | |
| *** mtreinish has joined #openstack-doc | 12:36 | |
| tosky | uh, I thought too that there is a fallback; would it be possible to have a parameter or another macro which always points to master? | 12:37 |
| chason | We should check whether the "series" from "_get_series_name()" is really exists in the project. | 12:38 |
| AJaeger | chason: that would be a link to a *remote* project, not sure we want that... | 12:39 |
| chason | If no, use "latest" as the "series". | 12:39 |
| stephenfin | frickler, AJaeger, dhellmann: https://review.opendev.org/661967 | 12:40 |
| * stephenfin goes back to removing a metric tonne of CSS from openstackdocstheme | 12:41 | |
| AJaeger | stephenfin: thanks. frickler, see 661967 ^ | 12:41 |
| AJaeger | stephenfin: the change needs backporting, the report was for rocky | 12:41 |
| chason | stephenfin I think fixing it in opendocstheme is better. | 12:42 |
| AJaeger | chason: no, the macro is for using it across projects that have stable branches as well.. | 12:42 |
| chason | Some project maybe just like reno | 12:43 |
| AJaeger | should we update the language in https://docs.openstack.org/openstackdocstheme/latest/#external-link-helper ? | 12:43 |
| AJaeger | chason: then they don't need the link-helper | 12:43 |
| chason | OK | 12:44 |
| openstackgerrit | Chason Chan proposed openstack/openstackdocstheme master: Note External Link Helper is not compatible with project only master brach https://review.opendev.org/661970 | 12:49 |
| openstackgerrit | Chason Chan proposed openstack/openstackdocstheme master: Note External Link Helper is not compatible with project only master brach https://review.opendev.org/661970 | 12:50 |
| *** gmann has quit IRC | 12:53 | |
| AJaeger | chason: thanks. stephenfin want to check my proposed update for this? I need a native speaker to review ^ | 12:54 |
| chason | AJaeger Can you please check why this patch failed? https://review.opendev.org/#/c/661879/ | 13:02 |
| chason | AJaeger I just follow what stephenfin do in this patch: https://review.opendev.org/#/c/540888/4 | 13:04 |
| AJaeger | chason: I really suggest to abandon your change and go with https://review.opendev.org/#/c/661691/ instead... | 13:04 |
| chason | AJaeger stephenfin also checked this patch as you see. | 13:04 |
| AJaeger | sorry, need to step out... | 13:05 |
| chason | AJaeger I prefer to this way: https://review.opendev.org/#/c/660965/4/doc/source/user/quickstart.rst | 13:06 |
| chason | There are many URL enforcing "latest" in quickstart.rst. Why just fix this link and include another file? | 13:09 |
| AJaeger | chason: I let the ansible-kolla team decide on this. | 13:11 |
| *** gmann has joined #openstack-doc | 14:10 | |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: css: Don't use bold text in titles (StarlingX) https://review.opendev.org/662001 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: css: Use https links (StarlingX) https://review.opendev.org/662002 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: css: Use ellipsis for long titles in sidebar (StarlingX) https://review.opendev.org/662003 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: css: Move bootstrap modifications to 'combined.css' (StarlingX) https://review.opendev.org/662004 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: css: Add symlinks for openstack logos https://review.opendev.org/662005 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: Removed 'combined.css' for 'starlingxdocs' theme https://review.opendev.org/662006 | 14:47 |
| openstackgerrit | Stephen Finucane proposed openstack/openstackdocstheme master: Remove a heap of dead CSS rules https://review.opendev.org/662007 | 14:47 |
| stephenfin | AJaeger, asettle: I've no idea how to simplify the last of those commits ^ Open to suggestions. It was a whole lot of grepping (or ag'ing) | 14:48 |
| asettle | Ah I see | 14:49 |
| asettle | This is fine | 14:49 |
| stephenfin | asettle: Blindly approve? ;) | 14:51 |
| asettle | Kind of my MO lately | 14:51 |
| * asettle wildly approves | 14:52 | |
| AJaeger | ;) | 15:13 |
| *** altlogbot_1 has quit IRC | 15:35 | |
| *** altlogbot_0 has joined #openstack-doc | 15:35 | |
| *** irclogbot_0 has quit IRC | 15:36 | |
| *** irclogbot_0 has joined #openstack-doc | 15:37 | |
| *** tesseract has quit IRC | 15:44 | |
| *** Emine has quit IRC | 16:31 | |
| *** kopecmartin is now known as kopecmartin|off | 17:47 | |
| *** tosky__ has joined #openstack-doc | 17:59 | |
| *** tosky has quit IRC | 18:00 | |
| *** tosky__ is now known as tosky | 18:00 | |
| *** pcaruana has quit IRC | 21:23 | |
| *** efried has quit IRC | 21:49 | |
| *** tosky has quit IRC | 21:49 | |
| *** ianychoi has quit IRC | 22:32 | |
| *** ianychoi has joined #openstack-doc | 22:33 | |
| *** rcernin has joined #openstack-doc | 23:06 | |
| *** rcernin has quit IRC | 23:07 | |
| *** rcernin has joined #openstack-doc | 23:07 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!