| *** jamesmcarthur has quit IRC | 00:08 | |
| *** mfuller has joined #openstack-doc | 00:11 | |
| *** donghao has joined #openstack-doc | 00:13 | |
| *** goldyfruit_ has joined #openstack-doc | 00:14 | |
| *** jamesmcarthur has joined #openstack-doc | 00:17 | |
| *** donghao has quit IRC | 00:17 | |
| *** mfuller has quit IRC | 00:19 | |
| *** jamesmcarthur has quit IRC | 00:31 | |
| *** jamesmcarthur has joined #openstack-doc | 00:32 | |
| *** jamesmcarthur has quit IRC | 01:14 | |
| *** jamesmcarthur has joined #openstack-doc | 01:17 | |
| *** ianychoi has quit IRC | 01:17 | |
| *** ianychoi has joined #openstack-doc | 01:18 | |
| *** jamesmcarthur has quit IRC | 01:22 | |
| *** jamesmcarthur has joined #openstack-doc | 01:40 | |
| *** jamesmcarthur has quit IRC | 02:06 | |
| *** jamesmcarthur has joined #openstack-doc | 02:07 | |
| *** donghao has joined #openstack-doc | 02:15 | |
| *** brinzhang has joined #openstack-doc | 02:19 | |
| *** donghao has quit IRC | 02:19 | |
| *** brinzhang_ has joined #openstack-doc | 02:24 | |
| *** brinzhang has quit IRC | 02:27 | |
| *** gmann_afk is now known as gmann | 03:33 | |
| *** ianychoi has quit IRC | 03:59 | |
| *** ianychoi has joined #openstack-doc | 04:00 | |
| *** donghao has joined #openstack-doc | 04:16 | |
| *** donghao has quit IRC | 04:22 | |
| *** jamesmcarthur has quit IRC | 04:31 | |
| *** jamesmcarthur has joined #openstack-doc | 04:33 | |
| *** pcaruana has joined #openstack-doc | 05:01 | |
| *** ianychoi has quit IRC | 05:03 | |
| *** ianychoi has joined #openstack-doc | 05:05 | |
| *** jamesmcarthur has quit IRC | 05:17 | |
| *** ianychoi has quit IRC | 05:27 | |
| *** ianychoi has joined #openstack-doc | 05:29 | |
| *** jamesmcarthur has joined #openstack-doc | 05:47 | |
| *** ianychoi has quit IRC | 06:00 | |
| *** ianychoi has joined #openstack-doc | 06:01 | |
| *** donghao has joined #openstack-doc | 06:19 | |
| *** jamesmcarthur has quit IRC | 06:20 | |
| *** donghao has quit IRC | 06:23 | |
| *** jamesmcarthur has joined #openstack-doc | 06:28 | |
| *** ianychoi has quit IRC | 06:40 | |
| *** ianychoi has joined #openstack-doc | 06:42 | |
| *** jamesmcarthur has quit IRC | 07:04 | |
| *** tesseract has joined #openstack-doc | 07:16 | |
| *** tosky has joined #openstack-doc | 07:16 | |
| *** kopecmartin|off is now known as kopecmartin | 07:24 | |
| *** rcernin has quit IRC | 08:02 | |
| *** rcernin has joined #openstack-doc | 08:03 | |
| *** brinzhang has joined #openstack-doc | 08:05 | |
| *** brinzhang_ has quit IRC | 08:08 | |
| *** alexmcleod has joined #openstack-doc | 08:16 | |
| *** brinzhang_ has joined #openstack-doc | 08:37 | |
| *** brinzhang_ has quit IRC | 08:38 | |
| *** brinzhang_ has joined #openstack-doc | 08:39 | |
| *** brinzhang has quit IRC | 08:40 | |
| *** jamesmcarthur has joined #openstack-doc | 09:01 | |
| *** jamesmcarthur has quit IRC | 09:06 | |
| *** donghao has joined #openstack-doc | 09:21 | |
| *** donghao has quit IRC | 09:26 | |
| *** brinzhang has joined #openstack-doc | 10:08 | |
| *** brinzhang_ has quit IRC | 10:12 | |
| *** donghao has joined #openstack-doc | 11:24 | |
| *** donghao has quit IRC | 11:28 | |
| asettle | amotoki, I got your response to the castellan patch. Thanks for your response. I actually had done exactly that, but still failed on requirements. Let me update again, and hopefully I can replicate! | 12:10 |
|---|---|---|
| *** ianychoi has quit IRC | 12:10 | |
| tosky | how do we move forward when there are issues with no known workarounds? I understand that for the sake of the goal the output does not need to be totally perfect, but still | 12:12 |
| tosky | right now, when doc/index contains some text followed by the TOC, the generated tex file swaps the order, as it puts the TOC on one page, and then the text in the next page | 12:13 |
| *** ianychoi has joined #openstack-doc | 12:13 | |
| tosky | yes, we could go for a separate index and it looks more related to the default sphinx theme, but still | 12:13 |
| asettle | tosky, hhmm | 12:15 |
| asettle | Good question | 12:15 |
| asettle | I mean, as you say, not being part of the goal that's entirely up to you/the project to asses how you'd like to do that best. | 12:15 |
| tosky | but I'm pretty sure we can't be the only one with the same issue :) | 12:15 |
| asettle | From a goal-perspective, provided it's building, we consider that a success | 12:16 |
| asettle | tosky, unlikely. Have you emailed to -discuss? | 12:16 |
| asettle | Tends to be more traction that way than through here. | 12:16 |
| asettle | If anything, amotoki might have seen something on his review rounds | 12:16 |
| tosky | I added it to the etherpad | 12:17 |
| *** brinzhang_ has joined #openstack-doc | 12:21 | |
| *** brinzhang has quit IRC | 12:24 | |
| asettle | amotoki, I rebased: https://review.opendev.org/#/c/684776/ But I was a little confused by your comment on the python minimums | 12:29 |
| asettle | tosky, I'll send out an email to the list now asking if anyone has issues with no known workarounds to come forward. We can compile then, and collaborate. | 12:29 |
| asettle | But as far as the goal is concerned, the "management" is complete once the pdf is building :) | 12:30 |
| tosky | ack! | 12:31 |
| tosky | I guess we need to backport the patches to train, right? I have a couple of floating patches does to those workarounds | 12:31 |
| amotoki | asettle: hi, which point is unclear to you? | 12:32 |
| asettle | amotoki, I wasn't too sure what you meant exactly about the python versions: https://review.opendev.org/#/c/684776/10/doc/requirements.txt | 12:32 |
| asettle | I rebased to a previous version where I *had* created the doc/requirements file | 12:33 |
| asettle | So this is old news | 12:33 |
| asettle | Butttt, these python versions reflect exactly what's in the barbican setup: https://review.opendev.org/683969 | 12:33 |
| asettle | So I wasn't too sure what you were saying was wrong | 12:33 |
| amotoki | asettle: when I looked at https://review.opendev.org/#/c/684776/10/doc/requirements.txt, the minimum versions are 1.6.2 for py27 and 1.8.0 for py3. Is it intended? If so, it is better to explain why. | 12:35 |
| *** brinzhang has joined #openstack-doc | 12:35 | |
| asettle | amotoki, umm... not really, no | 12:38 |
| asettle | I don't know the repo particularly well, so this was fumbling at a guess | 12:38 |
| asettle | Bad, I know | 12:39 |
| *** brinzhang_ has quit IRC | 12:39 | |
| amotoki | asettle: perhaps it was not detected during the review. it is a good chance to correct it. I think we can use sphinx>=1.8.0. | 12:40 |
| asettle | Is that not what I have here? :) https://review.opendev.org/#/c/684776/10/doc/requirements.txt | 12:41 |
| asettle | Line 2 | 12:41 |
| AJaeger | asettle: let'S remove those from test-requirements.txt, I left a comment | 12:45 |
| asettle | Got it :) | 12:45 |
| asettle | Submitted | 12:46 |
| amotoki | asettle: I found some missing points in the patch set you just submitted. Let me update it. | 12:47 |
| asettle | amotoki, please do | 12:47 |
| *** rcernin has quit IRC | 12:58 | |
| amotoki | asettle: just pushed | 13:00 |
| asettle | Looking | 13:00 |
| amotoki | asettle: one open issue is remaining. if you look at TOC of the generated PDF, it looks a bit odd as the team tag is a separate top section. | 13:01 |
| AJaeger | amotoki: one small issue found, I'll push now as well ;) | 13:06 |
| asettle | \o/ pile on! | 13:07 |
| asettle | amotoki, that's something that should be left to the team, I think | 13:07 |
| AJaeger | ;) | 13:07 |
| asettle | Not that I don't want to help, but I don't want to alter the way they do things past ensuring it's building | 13:08 |
| asettle | Which, it was, except for the 'requirements' failure | 13:08 |
| asettle | This is the one I'm really struggling with: https://review.opendev.org/#/c/685031/ | 13:09 |
| asettle | It should be rebased on top of: https://review.opendev.org/685708 | 13:09 |
| asettle | But even then, still failing | 13:09 |
| AJaeger | "sphinx-build: error: argument -b: expected one argument" | 13:11 |
| asettle | Which one are we looking at now? | 13:11 |
| asettle | Ah, the python one | 13:11 |
| AJaeger | "sphinx-build -W -b -d html " is wrong | 13:12 |
| asettle | Sure, I'll fix that | 13:12 |
| asettle | But that's not the issue | 13:12 |
| AJaeger | -W -b html -d doc/build/dirtrees | 13:12 |
| asettle | Yep, adjusted, that's a typo from my part (I copied from the castellan one) but if you pull it down, you'll see it's failing on a completely different issue | 13:12 |
| asettle | And I'm pretty stuck :/ | 13:13 |
| AJaeger | asettle: still wrong, see my comment | 13:13 |
| asettle | okau | 13:14 |
| AJaeger | asettle: looking at logs, it fails at exactly that line. There might be something else but that is needed first | 13:14 |
| *** jawad_axd has joined #openstack-doc | 13:14 | |
| asettle | AJaeger, building locally, it's always this error: "Warning, treated as error: | 13:15 |
| asettle | error while formatting arguments for barbicanclient.client.Client: 'function' object has no attribute '__mro__' | 13:15 |
| asettle | " | 13:15 |
| asettle | I think stephenfin was able to replicate | 13:15 |
| asettle | Which is why he pushed up: https://review.opendev.org/#/c/685708/ | 13:15 |
| AJaeger | asettle: ah ;( | 13:16 |
| asettle | But rebasing on top of his patch still fails | 13:16 |
| *** donghao has joined #openstack-doc | 13:26 | |
| *** donghao has quit IRC | 13:31 | |
| amotoki | asettle: scrolling back the irc log, I found tosky's mention "when doc/index contains some text followed by the TOC, the generated tex file swaps the order, as it puts the TOC on one page, and then the text in the next page" | 13:47 |
| asettle | Ahuh | 13:47 |
| amotoki | asettle: tosky: I haven't understood what "TOC" actually means. Do you mean "toctree" by "TOC"? | 13:47 |
| tosky | sorry - table of content | 13:47 |
| amotoki | In my understanding, TOC from latex is different from toctree in sphinx | 13:48 |
| tosky | toctree is the implementation of a TOC | 13:48 |
| amotoki | I have no idea on how to control the place of TOC of PDF file via sphinx | 13:48 |
| tosky | but it's the sphinx theme which seems to define how the TOC is placed | 13:48 |
| amotoki | we can have multiple toctree in a single RST file. | 13:48 |
| amotoki | so I think toctree is the way to declare which RST files are under a specific file. | 13:49 |
| tosky | yes, I noticed it at least in the main toctree | 13:49 |
| amotoki | so I think toctree does not control where TOC should be placed. It just specifies the tree of documentation in case of latex..... I guess this is one reason that sphinx provides toctree_only option in latex_documents. | 13:51 |
| AJaeger | asettle: did you rebase your change on 685708? | 13:51 |
| AJaeger | asettle: https://review.opendev.org/#/c/685031/ right now is not based on it | 13:52 |
| tosky | amotoki: that's where the theme plays a role; see https://review.opendev.org/#/c/679290/ | 13:52 |
| asettle | AJaeger, uh, I did. But I forgot to push it up again. Hang on, let me do that again | 13:53 |
| tosky | in the preview site, there is a blurb of text "This is a client for OpenStack Sahara API. [...]" and the TOC ("Reference guide" etc) | 13:53 |
| tosky | thehttps://99ad16ec33ecbdfdd033-11a2e186f8f6505f790122d590a395c2.ssl.cf5.rackcdn.com/679290/3/check/openstack-tox-docs/f9c8089/docs/ | 13:53 |
| tosky | umpf | 13:53 |
| tosky | https://99ad16ec33ecbdfdd033-11a2e186f8f6505f790122d590a395c2.ssl.cf5.rackcdn.com/679290/3/check/openstack-tox-docs/f9c8089/docs/ | 13:53 |
| tosky | the PDF doc is different (https://99ad16ec33ecbdfdd033-11a2e186f8f6505f790122d590a395c2.ssl.cf5.rackcdn.com/679290/3/check/openstack-tox-docs/f9c8089/pdf/doc-python-saharaclient.pdf) | 13:53 |
| tosky | that TOC is on page 3; the blurb of text is on page 5 | 13:53 |
| asettle | AJaeger, should be good now | 13:54 |
| *** jawad_axd has quit IRC | 13:54 | |
| amotoki | tosky: The main contents in the top page will be converted into a cover text (just after TOC) in PDF... | 13:54 |
| asettle | Unless I did it backwards again | 13:54 |
| asettle | I did that last time :p | 13:54 |
| asettle | Nope that's right | 13:55 |
| AJaeger | asettle: you did not base it on the other one as far as I see | 13:55 |
| AJaeger | asettle: shall I help? | 13:56 |
| asettle | AJaeger, uh, yeah, please | 13:56 |
| asettle | I don't remember having trouble rebasing before but here we are | 13:56 |
| amotoki | tosky: I have no good idea to swap the order of them. I sometimes adjust the files a bit and | 13:56 |
| amotoki | sometimes make some trick like https://review.opendev.org/#/c/679969/ | 13:57 |
| AJaeger | asettle: done | 13:57 |
| tosky | amotoki: if this required a change in the sphinx theme/whatever drives the format of the generated tex file, would it be acceptable? Where should such change be added, inside openstackdocstheme? | 13:58 |
| asettle | AJaeger, what on earth did I do wrong? Very confused | 13:58 |
| amotoki | tosky: in the last example, it has reasonable volume of contents in the top page. I created a overview page for PDF so that the page will appear in the TOC> | 13:58 |
| AJaeger | asettle: no idea | 13:58 |
| asettle | Hmm confused. I'll look at it after my meeting. Sorry, and thanks AJaeger | 13:58 |
| amotoki | tosky: if you need a change in the theme, I think openstackdocstheme would be a good place. | 13:58 |
| amotoki | tosky: perhaps asettle, AJaeger and stephenfin know more about such policy. | 13:59 |
| * asettle catches up | 13:59 | |
| -amotoki- wonders ianychoi knows more as he was an active contributor on PDF support | 14:00 | |
| AJaeger | asettle: https://99b859c8323de3b165e8-5bc324e44eaaf1e289f167f2af496d5e.ssl.cf2.rackcdn.com/685031/7/check/openstack-tox-docs/4546930/pdf/doc-python-barbicanclient.pdf | 14:09 |
| AJaeger | so, works now... | 14:09 |
| asettle | Oh awesome! thank you AJaeger :D | 14:09 |
| asettle | I must have botched the rebase the first time too | 14:09 |
| * asettle facepalms | 14:09 | |
| AJaeger | asettle: git review -d first-change;git review -x second-change ; git review | 14:10 |
| *** mfuller has joined #openstack-doc | 14:16 | |
| asettle | Yep, that was it | 14:17 |
| asettle | I'm baffled now | 14:17 |
| *** jamesmcarthur has joined #openstack-doc | 14:55 | |
| *** ianychoi has quit IRC | 15:20 | |
| *** ianychoi has joined #openstack-doc | 15:23 | |
| *** donghao has joined #openstack-doc | 15:28 | |
| *** tesseract has quit IRC | 15:33 | |
| *** donghao has quit IRC | 15:33 | |
| *** alexmcleod has quit IRC | 16:12 | |
| *** donghao has joined #openstack-doc | 17:29 | |
| *** donghao has quit IRC | 17:34 | |
| *** jamesmcarthur has quit IRC | 17:38 | |
| *** jamesmcarthur has joined #openstack-doc | 17:48 | |
| *** jamesmcarthur has quit IRC | 17:59 | |
| *** jamesmcarthur has joined #openstack-doc | 17:59 | |
| *** jamesmcarthur has quit IRC | 18:04 | |
| *** jamesmcarthur has joined #openstack-doc | 18:19 | |
| *** jamesmcarthur has quit IRC | 18:23 | |
| *** jamesmcarthur has joined #openstack-doc | 18:47 | |
| *** brinzhang_ has joined #openstack-doc | 18:51 | |
| *** brinzhang_ has quit IRC | 18:51 | |
| *** brinzhang_ has joined #openstack-doc | 18:51 | |
| *** brinzhang_ has quit IRC | 18:52 | |
| *** brinzhang_ has joined #openstack-doc | 18:52 | |
| *** brinzhang has quit IRC | 18:54 | |
| *** donghao has joined #openstack-doc | 19:32 | |
| *** donghao has quit IRC | 19:36 | |
| *** brinzhang has joined #openstack-doc | 19:54 | |
| *** brinzhang_ has quit IRC | 19:57 | |
| *** brinzhang_ has joined #openstack-doc | 20:02 | |
| *** brinzhang has quit IRC | 20:05 | |
| *** jamesmcarthur has quit IRC | 20:07 | |
| *** kopecmartin is now known as kopecmartin|off | 20:11 | |
| *** jamesmcarthur has joined #openstack-doc | 20:16 | |
| *** pcaruana has quit IRC | 20:33 | |
| *** openstackstatus has quit IRC | 21:32 | |
| *** donghao has joined #openstack-doc | 21:34 | |
| *** openstackstatus has joined #openstack-doc | 21:34 | |
| *** ChanServ sets mode: +v openstackstatus | 21:34 | |
| *** donghao has quit IRC | 21:38 | |
| *** jamesmcarthur has quit IRC | 22:48 | |
| *** tosky has quit IRC | 23:02 | |
| *** jamesmcarthur has joined #openstack-doc | 23:32 | |
| *** rcernin has joined #openstack-doc | 23:33 | |
| *** donghao has joined #openstack-doc | 23:36 | |
| *** donghao has quit IRC | 23:41 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!