| *** kberger_ has quit IRC | 01:51 | |
| *** KeithMnemonic has joined #openstack-doc | 02:10 | |
| *** pmatulis has quit IRC | 04:17 | |
| *** pmatulis has joined #openstack-doc | 04:18 | |
| *** evrardjp has quit IRC | 04:35 | |
| *** evrardjp has joined #openstack-doc | 04:36 | |
| *** dmacpher has quit IRC | 05:56 | |
| *** dmacpher has joined #openstack-doc | 06:00 | |
| *** dmacpher_ has joined #openstack-doc | 06:06 | |
| *** dmacpher has quit IRC | 06:10 | |
| *** dmacpher has joined #openstack-doc | 06:28 | |
| *** dmacpher_ has quit IRC | 06:30 | |
| *** rcernin has quit IRC | 07:32 | |
| *** dmacpher_ has joined #openstack-doc | 07:50 | |
| *** dmacpher has quit IRC | 07:51 | |
| *** dmacpher_ has quit IRC | 07:55 | |
| *** dmacpher has joined #openstack-doc | 07:57 | |
| *** pcaruana has quit IRC | 08:09 | |
| *** pcaruana has joined #openstack-doc | 08:26 | |
| *** pcaruana has quit IRC | 08:44 | |
| *** pcaruana has joined #openstack-doc | 08:44 | |
| *** dmacpher has quit IRC | 09:29 | |
| *** tosky has joined #openstack-doc | 09:30 | |
| *** dmacpher has joined #openstack-doc | 09:33 | |
| *** dmacpher has quit IRC | 09:40 | |
| *** dmacpher has joined #openstack-doc | 12:06 | |
| *** dmacpher has quit IRC | 13:05 | |
| *** diablo_rojo has quit IRC | 13:13 | |
| johnsom | Is it just me, or did the openstackdocstheme change the docstrings to a light grey font color? https://docs.openstack.org/oslo.config/latest/reference/api/oslo_config.html#oslo_config.types.List | 16:00 |
|---|---|---|
| johnsom | Super hard to read for me. I'm using chrome. | 16:01 |
| AJaeger | johnsom: please use #openstack-oslo for the theme now, we transferred ownership | 16:01 |
| johnsom | Ah, I missed that. Thanks. | 16:01 |
| AJaeger | johnsom: I just checked the last merges and don't see any indentional change - but please check history | 16:02 |
| johnsom | Yeah, I don't know when it happened. I don't look at those very often. Just wasn't sure if it was my version of chrome causing the issue. | 16:03 |
| AJaeger | johnsom: I have light grey on firefox as well, let me compare with others... | 16:04 |
| johnsom | Ok, so it likely is something in the theme. I will see if I can dig with the css explorer | 16:05 |
| AJaeger | johnsom: could also be a change from sphinx 3 | 16:05 |
| AJaeger | johnsom: you might want to discuss wit stephenfin next week | 16:07 |
| stephenfin | very strange. I see the same | 16:07 |
| AJaeger | johnsom: want to build with sphinx 2 and 3 and compare? Sorry, I cannot help further | 16:08 |
| johnsom | It's getting this property: https://github.com/openstack/openstackdocstheme/blob/master/openstackdocstheme/theme/openstackdocs/static/css/native.css#L45 | 16:10 |
| johnsom | dl.py.class | 16:10 |
| stephenfin | That smells like a sphinx autodoc change | 16:11 |
| johnsom | Yeah, looks like they added that CSS class in 3.x | 16:18 |
| johnsom | https://github.com/sphinx-doc/sphinx/commit/333596dc10ba87bd5d6d3a83f70b3b414e9e7d84 | 16:19 |
| stephenfin | johnsom: you want to file the bug with Sphinx or will I? | 16:24 |
| johnsom | I'm not convinced it is a sphinx bug. It's our CSS that is setting that to grey. | 16:25 |
| stephenfin | that CSS if from pygments | 16:25 |
| stephenfin | if you have pygments installed, you can see the classes locally | 16:25 |
| stephenfin | from pygments.formatters import HtmlFormatter | 16:26 |
| stephenfin | print(HtmlFormatter().get_style_defs('.py')) | 16:26 |
| stephenfin | (from https://pygments.org/docs/quickstart/) | 16:26 |
| johnsom | I will fully admit this is an area I have not poked in before, so you probably understand the problem better. Feel free to open the bug. | 16:26 |
| johnsom | stephenfin Thanks! | 16:34 |
| *** evrardjp has quit IRC | 16:35 | |
| *** evrardjp has joined #openstack-doc | 16:36 | |
| stephenfin | johnsom: okay, looks like pygments have fixed things be prefixing all their styles now but we're using old stuff which is why we're seeing this | 16:49 |
| *** alexmcleod has quit IRC | 18:45 | |
| *** KeithMnemonic has quit IRC | 19:39 | |
| *** kopecmartin has quit IRC | 22:07 | |
| *** factor has quit IRC | 22:07 | |
| *** evrardjp has quit IRC | 22:07 | |
| *** irclogbot_0 has quit IRC | 22:07 | |
| *** stephenfin has quit IRC | 22:07 | |
| *** ildikov has quit IRC | 22:07 | |
| *** pots has quit IRC | 22:07 | |
| *** kopecmartin has joined #openstack-doc | 22:08 | |
| *** evrardjp has joined #openstack-doc | 22:10 | |
| *** pots has joined #openstack-doc | 22:10 | |
| *** stephenfin has joined #openstack-doc | 22:11 | |
| *** irclogbot_1 has joined #openstack-doc | 22:11 | |
| *** tosky has quit IRC | 23:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!