| *** tosky has quit IRC | 00:01 | |
| *** jamesmcarthur has quit IRC | 00:01 | |
| *** jamesmcarthur has joined #openstack-doc | 00:13 | |
| *** jamesmcarthur has quit IRC | 00:16 | |
| *** threestrands has joined #openstack-doc | 00:19 | |
| openstackgerrit | gugug proposed openstack/openstack-manuals master: Fix pygments style https://review.opendev.org/729441 | 00:24 |
|---|---|---|
| *** jamesmcarthur has joined #openstack-doc | 00:29 | |
| *** jamesmcarthur has quit IRC | 00:30 | |
| *** dmacpher_ has quit IRC | 01:27 | |
| *** dmacpher has joined #openstack-doc | 01:27 | |
| *** jamesmcarthur has joined #openstack-doc | 01:59 | |
| *** jamesmcarthur has quit IRC | 02:10 | |
| *** jamesmcarthur has joined #openstack-doc | 02:51 | |
| *** jamesmcarthur has quit IRC | 03:54 | |
| *** jamesmcarthur has joined #openstack-doc | 03:55 | |
| *** jamesmcarthur has quit IRC | 04:12 | |
| *** jamesmcarthur has joined #openstack-doc | 04:12 | |
| *** jamesmcarthur has quit IRC | 04:16 | |
| *** jamesmcarthur has joined #openstack-doc | 04:16 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #openstack-doc | 04:33 | |
| *** brinzhang_ has joined #openstack-doc | 05:13 | |
| *** brinzhang has quit IRC | 05:14 | |
| *** jamesmcarthur has quit IRC | 05:32 | |
| *** jamesmcarthur has joined #openstack-doc | 05:33 | |
| *** jamesmcarthur has quit IRC | 05:38 | |
| *** brinzhang has joined #openstack-doc | 05:56 | |
| *** brinzhang_ has quit IRC | 05:59 | |
| *** brinzhang_ has joined #openstack-doc | 06:00 | |
| *** brinzhang_ has quit IRC | 06:02 | |
| *** brinzhang_ has joined #openstack-doc | 06:02 | |
| *** brinzhang has quit IRC | 06:03 | |
| *** jamesmcarthur has joined #openstack-doc | 06:09 | |
| *** jamesmcarthur has quit IRC | 06:19 | |
| *** jawad_axd has joined #openstack-doc | 06:31 | |
| *** brinzhang has joined #openstack-doc | 06:40 | |
| *** brinzhang_ has quit IRC | 06:43 | |
| *** jamesmcarthur has joined #openstack-doc | 06:54 | |
| *** tesseract has joined #openstack-doc | 07:02 | |
| *** jamesmcarthur has quit IRC | 07:05 | |
| openstackgerrit | Andreas Jaeger proposed openstack/security-doc master: Switch to newer openstackdocstheme version https://review.opendev.org/728265 | 07:19 |
| AJaeger | stephenfin, asettle, I have some changes up for docs, please review: https://review.opendev.org/728265 https://review.opendev.org/727860 https://review.opendev.org/728386 | 07:19 |
| *** tosky has joined #openstack-doc | 07:30 | |
| *** alexmcleod has joined #openstack-doc | 07:49 | |
| *** jamesmcarthur has joined #openstack-doc | 09:02 | |
| *** jamesmcarthur has quit IRC | 09:06 | |
| *** brinzhang has quit IRC | 09:35 | |
| *** brinzhang has joined #openstack-doc | 09:35 | |
| openstackgerrit | Andreas Jaeger proposed openstack/security-doc master: Switch to newer openstackdocstheme version https://review.opendev.org/728265 | 10:05 |
| asettle | AJaeger, all the good stuff hey | 10:07 |
| AJaeger | always ;) | 10:09 |
| openstackgerrit | Merged openstack/openstack-manuals master: www: Regenerate sitemap https://review.opendev.org/728386 | 10:22 |
| openstackgerrit | Merged openstack/openstack-manuals master: Update openstackdocstheme version https://review.opendev.org/727860 | 10:22 |
| *** jamesmcarthur has joined #openstack-doc | 11:03 | |
| *** brinzhang_ has joined #openstack-doc | 11:14 | |
| *** brinzhang has quit IRC | 11:17 | |
| *** brinzhang_ has quit IRC | 11:20 | |
| *** brinzhang_ has joined #openstack-doc | 11:20 | |
| *** jamesmcarthur has quit IRC | 11:22 | |
| *** brinzhang has joined #openstack-doc | 11:55 | |
| *** brinzhang_ has quit IRC | 11:58 | |
| openstackgerrit | Merged openstack/security-doc master: Switch to newer openstackdocstheme version https://review.opendev.org/728265 | 12:43 |
| amotoki | I see a lot of changes with a title "Fix pygments style" are proposed. their commit messages do not provide enough information, so I cannot evaluate its value. | 13:01 |
| amotoki | does anyone have any more information or pointer on this? | 13:01 |
| stephenfin | amotoki: Previously we were ignoring the Sphinx-configured pygments stylesheet | 13:02 |
| stephenfin | Instead, we were using a bundled 'native' theme | 13:02 |
| stephenfin | Since 3.0.0 (or 3.0.1 - I don't recall) we no longer do that | 13:02 |
| stephenfin | and some projects had the 'sphinx' theme configured instead of 'native' | 13:03 |
| stephenfin | However | 13:03 |
| stephenfin | unless they're seeing actual issues, the 'sphinx' theme should be fine | 13:03 |
| stephenfin | so you can either accept them as essentially noops, or reject them because there isn't a clear reason to switch | 13:04 |
| stephenfin | *as they are | 13:04 |
| stephenfin | amotoki: Does that make sense? AJaeger is going to send out an email about it later today, if he hasn't done so already | 13:04 |
| AJaeger | amotoki: see https://etherpad.opendev.org/p/u9_gQDpUGtwRMpBJhfSe (will sent as email in a bit) and my explanation in https://review.opendev.org/729528 | 13:06 |
| AJaeger | stephenfin: waiting with the email on +A on 729554 so that I know we move forward... | 13:07 |
| stephenfin | AJaeger: ack. I've got meetings for the next while (:-() but I'll get to it before EOD | 13:08 |
| AJaeger | stephenfin: thanks! | 13:10 |
| *** jamesmcarthur has joined #openstack-doc | 13:19 | |
| amotoki | stephenfin: AJaeger: thanks for the information. your explanation is really clear to me. | 13:19 |
| amotoki | stephenfin: AJaeger: when I read the commit message from inspur folks like https://review.opendev.org/#/c/729489/, I did not understand the context and what the commit is fixing..... | 13:20 |
| AJaeger | amotoki: I agree completely, people did not get it ;( | 13:22 |
| AJaeger | amotoki: just copy & paste an easy fix... | 13:22 |
| amotoki | AJaeger: my understanding is that this kind of change is not required as long as code snippets are rendered as expected, right? | 13:24 |
| *** jamesmcarthur has quit IRC | 13:26 | |
| AJaeger | amotoki: correct! | 13:28 |
| AJaeger | I'll still do it in 729489 as part of the longer change... | 13:28 |
| amotoki | AJaeger: thanks. My detail check turns out that 'native' theme is a bit easier to read than 'sphinx' from POV of the color contrast. | 13:30 |
| *** jamesmcarthur has joined #openstack-doc | 13:35 | |
| *** brinzhang_ has joined #openstack-doc | 14:18 | |
| *** KeithMnemonic has joined #openstack-doc | 14:19 | |
| *** brinzhang has quit IRC | 14:21 | |
| *** brinzhang_ has quit IRC | 14:22 | |
| *** brinzhang_ has joined #openstack-doc | 14:22 | |
| *** threestrands has quit IRC | 14:34 | |
| *** brinzhang_ has quit IRC | 14:45 | |
| *** jamesmcarthur has quit IRC | 15:11 | |
| *** jamesmcarthur has joined #openstack-doc | 15:12 | |
| *** rcernin has quit IRC | 16:04 | |
| pmatulis | hi, is this no longer legal? --> code-block:: console | 16:26 |
| *** tesseract has quit IRC | 16:27 | |
| pmatulis | i use this for command output but now i get a black box with the text hidden | 16:27 |
| pmatulis | (all i get is one big black square on the page) | 16:27 |
| AJaeger | pmatulis: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html | 16:28 |
| pmatulis | AJaeger, i'm sorry, i don't see anything about my question | 16:30 |
| AJaeger | pmatulis: the comment about pygments_style = "native"' | 16:31 |
| AJaeger | pmatulis: which repo? | 16:31 |
| AJaeger | happy to push a change quickly... | 16:32 |
| pmatulis | AJaeger, i just published this but i imagine all my pages are affected: | 16:33 |
| pmatulis | https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/app-series-upgrade.html#generic-series-upgrade | 16:33 |
| pmatulis | source: https://opendev.org/openstack/charm-deployment-guide/raw/branch/master/deploy-guide/source/app-series-upgrade.rst | 16:33 |
| AJaeger | pmatulis: https://review.opendev.org/729658 | 16:34 |
| AJaeger | pmatulis: check whether that fixes it - will work with ussuri openstackdocstheme version and victoria... | 16:34 |
| *** jamesmcarthur has quit IRC | 16:36 | |
| pmatulis | AJaeger, ok, waiting | 16:37 |
| amotoki | AJaeger: thanks for your mail to openstack-discuss. ins't the best place to ask #openstack-docs here instead of #openstack-oslo? the mail says #openstack-oslo. | 16:37 |
| AJaeger | amotoki: openstackdocstsheme is a deliverable of oslo team now... | 16:38 |
| amotoki | AJaeger: ah, I see. | 16:38 |
| *** jamesmcarthur has joined #openstack-doc | 16:39 | |
| amotoki | so, I wonder which channel I should use when I have a question on openstackdocstheme..... | 16:40 |
| AJaeger | amotoki: better #openstack-oslo - but you will get answers probably here as well... | 16:40 |
| amotoki | okay, openstackdocstheme is usually only related to docs, but openstack-oslo would be the place to ask.... I now know it, but probably others do not :( | 16:42 |
| AJaeger | amotoki: that's why I put it in - but no harm if asking here... | 16:46 |
| amotoki | :) | 16:46 |
| pmatulis | AJaeger, ok, my issue is resolved. thank you | 17:03 |
| pmatulis | i guess i should update the other guide i maintain | 17:03 |
| openstackgerrit | Merged openstack/openstack-manuals master: Fix pygments style https://review.opendev.org/729441 | 17:10 |
| *** jamesmcarthur has quit IRC | 17:24 | |
| *** jamesmcarthur has joined #openstack-doc | 17:45 | |
| *** jamesmcarthur has quit IRC | 17:51 | |
| *** jamesmcarthur has joined #openstack-doc | 18:00 | |
| *** jamesmcarthur has quit IRC | 18:40 | |
| *** jamesmcarthur has joined #openstack-doc | 18:41 | |
| melwitt | AJaeger: is that pygments_style the reason for this weird rendering here too? does it mean I need to propose a change to nova? https://docs.openstack.org/nova/latest/user/quotas.html#project-quotas I noticed you proposed a bunch of changes but I don't see for nova | 19:54 |
| AJaeger | melwitt: I'll update pygments_style now in my changes - we weren't aware of the impact ;( | 19:55 |
| AJaeger | melwitt: I can push one for nova quickly... | 19:56 |
| melwitt | ok, I'll check the doc preview on it to make sure. for us, it looks like we set = 'sphinx' in our conf.py but it looks weird when it's actually used | 19:57 |
| AJaeger | melwitt: it was set ages ago, perhaps at oslosphinx times - and openstackdocstheme just override the setting... | 19:57 |
| melwitt | yeah, I saw 10 years ago heh | 19:58 |
| AJaeger | melwitt: now we stephenfin cleaned that up - and that fallout was not expected | 19:58 |
| AJaeger | nova change pushed, novaclient does not need one | 19:59 |
| melwitt | perfect thank you | 19:59 |
| *** jamesmcarthur has quit IRC | 20:19 | |
| *** jamesmcarthur has joined #openstack-doc | 20:19 | |
| *** jamesmcarthur has quit IRC | 21:12 | |
| *** jamesmcarthur has joined #openstack-doc | 21:12 | |
| *** jamesmcarthur has quit IRC | 21:15 | |
| *** jamesmcarthur has joined #openstack-doc | 21:15 | |
| *** jamesmcarthur has quit IRC | 21:32 | |
| *** jamesmcarthur has joined #openstack-doc | 21:33 | |
| *** jamesmcarthur has quit IRC | 21:35 | |
| *** jamesmcarthur has joined #openstack-doc | 21:42 | |
| *** jamesmcarthur has quit IRC | 22:29 | |
| *** jamesmcarthur has joined #openstack-doc | 22:30 | |
| *** jamesmcarthur has quit IRC | 22:52 | |
| *** jamesmcarthur has joined #openstack-doc | 22:53 | |
| *** jamesmcarthur has quit IRC | 22:56 | |
| *** jamesmcarthur has joined #openstack-doc | 22:56 | |
| *** jamesmcarthur has quit IRC | 23:07 | |
| *** rcernin has joined #openstack-doc | 23:08 | |
| *** jamesmcarthur has joined #openstack-doc | 23:14 | |
| *** jamesmcarthur has quit IRC | 23:20 | |
| *** jamesmcarthur has joined #openstack-doc | 23:20 | |
| *** jamesmcarthur has quit IRC | 23:25 | |
| *** tosky has quit IRC | 23:48 | |
| *** threestrands has joined #openstack-doc | 23:49 | |
| *** jamesmcarthur has joined #openstack-doc | 23:59 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!