| *** yamamoto has quit IRC | 01:33 | |
| *** yamamoto has joined #openstack-dragonflow | 01:52 | |
| *** xiaohhui has quit IRC | 02:44 | |
| *** xiaohhui has joined #openstack-dragonflow | 02:44 | |
| *** rajivk has joined #openstack-dragonflow | 02:44 | |
| openstackgerrit | hujie proposed openstack/dragonflow: refactor db consistent and object refresher(step1) https://review.openstack.org/408591 | 03:11 |
|---|---|---|
| *** gongysh has joined #openstack-dragonflow | 03:19 | |
| *** xiaohhui has quit IRC | 03:22 | |
| *** xiaohhui has joined #openstack-dragonflow | 03:24 | |
| openstackgerrit | hujie proposed openstack/dragonflow: refactor db consistent and object refresher(step1) https://review.openstack.org/408591 | 03:27 |
| *** xiaohhui has quit IRC | 05:59 | |
| *** xiaohhui has joined #openstack-dragonflow | 05:59 | |
| openstackgerrit | jeck proposed openstack/dragonflow: [TrivialFix] Fix function document comment typo error https://review.openstack.org/410541 | 06:00 |
| *** xiaohhui has quit IRC | 06:51 | |
| oanson | dimak, hujie, nick-ma_, would be happy to hear your opinion on https://review.openstack.org/#/c/410298 | 06:54 |
| *** xiaohhui has joined #openstack-dragonflow | 07:12 | |
| xiaohhui | oanson nick-ma_ ping | 07:14 |
| oanson | pong | 07:14 |
| oanson | xiaohhui, ^^^ | 07:14 |
| xiaohhui | hi, I want to discuss this patch here https://review.openstack.org/#/c/401210 | 07:14 |
| oanson | Yes | 07:15 |
| xiaohhui | What do you mean by migration script ? | 07:15 |
| xiaohhui | Is that a script file for a version? | 07:15 |
| xiaohhui | or a script file for all versions | 07:15 |
| oanson | One sec, let me review the patch again | 07:15 |
| xiaohhui | OK | 07:16 |
| oanson | My meaning was that I like the direction you took | 07:17 |
| oanson | I didn't give it a complete review | 07:17 |
| oanson | I was waiting for the merge conflict to be resolved | 07:17 |
| *** yamamoto has quit IRC | 07:18 | |
| oanson | But in general I think dimak and hujie approve of the direction as well | 07:19 |
| xiaohhui | I see nick-ma_ said a migration script is enough, then I thought I might over-do the work | 07:19 |
| xiaohhui | I see, let me resolve the conflict first, maybe we can carry on discussion on the version after rebase. | 07:20 |
| oanson | It looks like the work is already done (by you) | 07:20 |
| oanson | I think now it's just small review comments | 07:20 |
| oanson | Let me rephrase. A script would have been enough, but I think this is better. This is more flexible, extendible, and readable in the long run | 07:21 |
| xiaohhui | OK, thanks. since you are here, maybe you can take another look at this patch https://review.openstack.org/#/c/393773/ :) | 07:21 |
| oanson | I see | 07:22 |
| oanson | I think I misunderstood what you meant by atomic | 07:22 |
| oanson | Any chance you could add this information on the bug? i.e. which patches add back the features and their order? | 07:24 |
| xiaohhui | I want to make the UT be one testcase for one feature. | 07:24 |
| oanson | That makes sense | 07:24 |
| oanson | I thought you wanted a single assert call, so that you'll detect all errors and not just the first one. But this solution does that too, and is better | 07:24 |
| xiaohhui | There are recorded in https://review.openstack.org/#/q/topic:bug/1633078 | 07:24 |
| oanson | (your solution, that is) | 07:24 |
| xiaohhui | Yeah, that is what I mean atomic. | 07:25 |
| oanson | Yes. I was hoping for an overview of the changes, like a cover-mail for a patchset. | 07:26 |
| oanson | It gets difficult to follow all these changes :) | 07:26 |
| oanson | Let me see if I can auto-generate it | 07:27 |
| xiaohhui | what do you mean by cover-mail? | 07:27 |
| oanson | An overview of the change, and how it is split into the patches | 07:28 |
| oanson | So if something is removed in one patch and re-added in another patch, I can go and see the two changes | 07:28 |
| xiaohhui | I can add some words in the commit msg. | 07:29 |
| xiaohhui | But I don't know how to use tool to generate it | 07:30 |
| oanson | That would definitely help. Thanks | 07:30 |
| xiaohhui | will respin the patch soon | 07:30 |
| xiaohhui | Thank you for your help, oanson | 07:31 |
| oanson | Great. Thanks! Sorry for the nit-picking | 07:31 |
| xiaohhui | not a problem | 07:31 |
| oanson | I'm just having trouble getting all the reviews done, so any little bit helps :) | 07:31 |
| xiaohhui | :) | 07:34 |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Refactor test case for ml2 mech driver(port) https://review.openstack.org/393773 | 07:40 |
| *** zenoway has joined #openstack-dragonflow | 07:41 | |
| *** gongysh has quit IRC | 07:47 | |
| *** zenoway has quit IRC | 07:49 | |
| *** yamamoto has joined #openstack-dragonflow | 07:56 | |
| *** yuval has joined #openstack-dragonflow | 07:57 | |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Add nb db migration mechanism and apply to lswitch unique_key https://review.openstack.org/401210 | 08:09 |
| *** zenoway has joined #openstack-dragonflow | 08:11 | |
| openstackgerrit | hujie proposed openstack/dragonflow: refactor db consistent and object refresher(step1) https://review.openstack.org/408591 | 08:12 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow: Do not use multiproc publishers in fullstack tests https://review.openstack.org/407542 | 08:16 |
| *** lihi has joined #openstack-dragonflow | 08:18 | |
| *** saggi has joined #openstack-dragonflow | 08:40 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-dragonflow | 09:45 | |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Dynamic register nb db models https://review.openstack.org/410645 | 09:45 |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Dynamic register nb db models https://review.openstack.org/410645 | 09:48 |
| *** gongysh has joined #openstack-dragonflow | 10:04 | |
| *** gongysh has quit IRC | 10:43 | |
| *** dimak has joined #openstack-dragonflow | 10:49 | |
| *** yamamoto has quit IRC | 11:12 | |
| *** gongysh has joined #openstack-dragonflow | 11:24 | |
| *** yamamoto has joined #openstack-dragonflow | 11:26 | |
| openstackgerrit | WangJian proposed openstack/dragonflow: Refactor port-status-update NB API https://review.openstack.org/396915 | 11:39 |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Fix the broken gate of fullstack https://review.openstack.org/410710 | 11:40 |
| openstackgerrit | Hong Hui Xiao proposed openstack/dragonflow: Fix the broken gate of fullstack https://review.openstack.org/410710 | 11:48 |
| *** zenoway has quit IRC | 12:07 | |
| *** gongysh has quit IRC | 12:19 | |
| openstackgerrit | Merged openstack/dragonflow: Correction in df-db dump command https://review.openstack.org/409537 | 13:33 |
| oanson | dimak, yo | 13:36 |
| dimak | oanson, key | 13:36 |
| dimak | hey | 13:36 |
| oanson | Re - rethinkdb | 13:37 |
| oanson | How much work is there? | 13:37 |
| dimak | Not much at all, a few days I think to get it stable | 13:38 |
| dimak | but is it developed? | 13:38 |
| dimak | fc25 packages? | 13:38 |
| oanson | Dunno. I don't follow it | 13:39 |
| oanson | But if it's not a lot of effort, it would be good PR | 13:39 |
| irenab | oanson: do you have a min? | 13:47 |
| oanson | Sure | 13:47 |
| irenab | can you please let me know if ovs-vif supports DF ovs plug: https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py | 13:48 |
| irenab | https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L148 | 13:49 |
| oanson | What am I looking at? | 13:50 |
| irenab | this is openstack vif library, supposed to be used instead of vurrent nova vif driver | 13:50 |
| oanson | We're supposed to follow the OVS plug-vif mechanism | 13:51 |
| oanson | AFAIK, we haven't made any changes to the plug-vif mechanism for Dragonflow | 13:52 |
| irenab | as I can see it does not look as supported here | 13:52 |
| oanson | I'm guessing we should be with objects.vif.VIFOpenVSwitch | 13:53 |
| irenab | it seems to be taking care of windows case only | 13:53 |
| oanson | But I am not sure I understand where the actual plug operation is done | 13:53 |
| irenab | with os_vif, this should be done here: https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L148 | 13:54 |
| oanson | _plug_vif_windows is amusing. It calls linux_net :) | 13:54 |
| irenab | oanson: so am I correct in saying that native linux ovs plug support is missing? | 13:55 |
| oanson | Looks like it | 13:55 |
| irenab | oanson: thanks, needed another pair of eyes :-) | 13:56 |
| oanson | It looks like it only creates the bridge. Maybe the actual plug is done elsewhere? | 13:56 |
| irenab | which will be stange comparing to other options. Will check | 13:56 |
| oanson | Yes, that's true | 13:59 |
| openstackgerrit | Itamar Ofek proposed openstack/dragonflow: add lport accessors for exteral_dic values https://review.openstack.org/410772 | 14:12 |
| *** dimak has quit IRC | 15:14 | |
| *** saggi has quit IRC | 15:16 | |
| *** lihi has quit IRC | 15:37 | |
| *** skipp1 has joined #openstack-dragonflow | 15:50 | |
| *** skipp1 is now known as sk1pp | 15:50 | |
| *** yuval has quit IRC | 16:04 | |
| *** yamamoto has quit IRC | 16:55 | |
| *** yamamoto has joined #openstack-dragonflow | 16:57 | |
| *** yamamoto has quit IRC | 17:02 | |
| *** yamamoto has joined #openstack-dragonflow | 17:56 | |
| *** yamamoto has quit IRC | 18:01 | |
| *** yamamoto has joined #openstack-dragonflow | 18:26 | |
| *** yamamoto has quit IRC | 18:27 | |
| *** yamamoto has joined #openstack-dragonflow | 18:27 | |
| *** yamamoto has quit IRC | 18:27 | |
| *** rajivk has quit IRC | 18:50 | |
| *** hujie has quit IRC | 18:57 | |
| *** hujie has joined #openstack-dragonflow | 19:01 | |
| *** rajivk has joined #openstack-dragonflow | 19:02 | |
| *** sk1pp has quit IRC | 19:11 | |
| openstackgerrit | Steve Kipp proposed openstack/dragonflow: Add unit tests to dhcp_app https://review.openstack.org/409844 | 19:13 |
| *** yamamoto has joined #openstack-dragonflow | 19:28 | |
| *** yamamoto has quit IRC | 19:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!