| *** deep-book-gk_ has joined #openstack-dragonflow | 00:22 | |
| *** deep-book-gk_ has left #openstack-dragonflow | 00:24 | |
| *** yamamoto has joined #openstack-dragonflow | 01:37 | |
| *** yamamoto has quit IRC | 01:41 | |
| *** yamamoto has joined #openstack-dragonflow | 05:06 | |
| *** yamamoto has quit IRC | 05:09 | |
| oanson | Morning | 05:55 |
|---|---|---|
| oanson | irenab, re bug 1705397 - Is it blocking Kuryr integration? The question is this bug High or Medium? | 05:56 |
| openstack | bug 1705397 in DragonFlow "Sub port of Trunk port is not updated to Active status" [Undecided,New] https://launchpad.net/bugs/1705397 | 05:56 |
| *** NatanBro has joined #openstack-dragonflow | 06:57 | |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Classifier to use OvsPort events https://review.openstack.org/480197 | 08:56 |
| openstackgerrit | Merged openstack/dragonflow master: Updated from global requirements https://review.openstack.org/486312 | 08:57 |
| oanson | dimak, I've posted a question on https://review.openstack.org/#/c/485103 | 10:43 |
| oanson | In case you thought the +1 was random :) | 10:43 |
| dimak | Sure, will take a look | 10:44 |
| dimak | oanson, posted a reply | 10:44 |
| oanson | dimak, I'm still not sure I understand | 10:45 |
| oanson | We already have a __deepcopy__ | 10:45 |
| dimak | PortBinding is not a child of model base we defined | 10:45 |
| oanson | Never mind. Wrong base class. | 10:46 |
| oanson | Yeah. Noticed a minute too late :) | 10:46 |
| openstackgerrit | Merged openstack/dragonflow master: Remove unused tunnel_key attribute in tests https://review.openstack.org/485040 | 10:51 |
| oanson | dimak, a question regarding https://review.openstack.org/#/c/485690/ | 11:11 |
| oanson | (Not blocking the review, but interested) | 11:11 |
| oanson | Why add another table? Why not resubmit to table 0 for re-classification, again and again, until no more classifications available? | 11:11 |
| oanson | This way trunk within trunk within trunk within mpls within trunk would work out of the box. | 11:11 |
| oanson | (I think this is also what we discussed last week, but I'm not sure) | 11:12 |
| dimak | Hmm | 11:17 |
| dimak | oanson, I'll change that, it's a better idea | 11:18 |
| oanson | Sure | 11:18 |
| oanson | I already +2ed that patch, so you can also put a patch on top of it | 11:18 |
| oanson | (Whatever you're more comfortable with) | 11:18 |
| dimak | I'll change this one. | 11:19 |
| oanson | Sure | 11:19 |
| dimak | No reason to gate it if we're not happy with it and have a better solution | 11:19 |
| oanson | True. | 11:22 |
| oanson | But there are other things to take into account. e.g. review cycle | 11:22 |
| oanson | Urgency | 11:22 |
| oanson | Neither of which may be relevant here, but they should be taken into account. | 11:23 |
| oanson | dimak, ^^^ | 11:23 |
| dimak | I'll still have to add some testing for https://review.openstack.org/#/c/485604/3 | 11:23 |
| dimak | So it's not like its going in right now | 11:23 |
| oanson | I thought we already had testing for that. I recall having fullstack tests for ARP responder at least | 11:25 |
| dimak | oanson, ARP is not affected that much, the RegLoad just moved elsewhere | 11:26 |
| oanson | Yes. But it's the same kind of change for all the responders. | 11:27 |
| oanson | I'm not saying we shouldn't need tests, I just thought we already had them | 11:27 |
| dimak | If you're fine with the change as it is it, its between you and irenab :P | 11:27 |
| irenab | dimak, I just wanted an answer :-) | 11:28 |
| dimak | I would have posted an answer the moment I checked :) | 11:29 |
| oanson | irenab, are you satisfied with what we said? We have fullstack tests for at least ARP responder, and I'm sure ICMP and ND have them as well. | 11:30 |
| dimak | But I didn't dig in depth yet | 11:30 |
| dimak | ICMP responders should be installed on router interfaces | 11:30 |
| dimak | Maybe fullstack tests ping them | 11:30 |
| oanson | ARP responder: https://github.com/openstack/dragonflow/blob/master/dragonflow/tests/fullstack/test_apps.py#L76 | 11:30 |
| dimak | Will check in a few | 11:30 |
| oanson | ND responder: https://github.com/openstack/dragonflow/blob/master/dragonflow/tests/fullstack/test_apps.py#L177 | 11:31 |
| oanson | I think this one is ICMP responder, it pings a router interface address: https://github.com/openstack/dragonflow/blob/master/dragonflow/tests/fullstack/test_apps.py#L861 | 11:32 |
| irenab | fullstack tests are f9ine, we just either need to make sure we have them or add bug to add later | 11:34 |
| dimak | lihi, leyal , take a look at https://review.openstack.org/#/c/480197/ when you have a moment | 11:54 |
| leyal | sure | 11:55 |
| lihi | 👍 | 12:07 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Trunk: use reg6 for classfication instead of ofport https://review.openstack.org/485690 | 12:39 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Classifier: reset in_port before dispatch https://review.openstack.org/485604 | 12:39 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Trunk: use classifier app to dispatch packets https://review.openstack.org/485691 | 12:39 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Classifier: resubmit to table 0 to allow reclassification https://review.openstack.org/486389 | 12:39 |
| dimak | oanson, I uploaded resubmit on classify fix | 12:40 |
| dimak | also, the top 2 patches deal with the same issue, I can squash them if you prefer (both are tiny) | 12:41 |
| oanson | No. I don't mind 2 small patches. They are atomic, in a sense | 12:41 |
| dimak | oanson, sure. | 12:47 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/dragonflow master: Updated from global requirements https://review.openstack.org/486394 | 13:41 |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Move add-option part when receiving DHCP-packet to function https://review.openstack.org/475167 | 13:50 |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Move add-option part when receiving DHCP-packet to function https://review.openstack.org/475167 | 14:10 |
| openstackgerrit | Merged openstack/dragonflow master: Classifier to use OvsPort events https://review.openstack.org/480197 | 14:14 |
| openstackgerrit | Merged openstack/dragonflow master: Remove unnecessary constant https://review.openstack.org/485735 | 14:15 |
| openstackgerrit | Merged openstack/dragonflow master: Trunk driver: consume callbacks from neutron-lib https://review.openstack.org/486296 | 14:17 |
| *** NatanBro has quit IRC | 14:28 | |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Remove is_local attribute from LogicalPort https://review.openstack.org/485581 | 14:30 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Remove special handling of lport in controller code https://review.openstack.org/485582 | 14:30 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Replace chassis and remote_vtep with port binding https://review.openstack.org/485103 | 14:30 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [WIP] Change DNAT to rely on Provider app for bridge access https://review.openstack.org/475362 | 14:30 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Remove ofport attribute from LogicalPort https://review.openstack.org/485526 | 14:30 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Cache all ports in local controller https://review.openstack.org/486411 | 14:30 |
| openstackgerrit | Eyal Leshem proposed openstack/dragonflow master: Answer to "Parameter Request List" option in DHCP app https://review.openstack.org/475718 | 14:31 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Add fullstack test for snat https://review.openstack.org/465524 | 14:35 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: Add fullstack test for snat https://review.openstack.org/465524 | 16:12 |
| openstackgerrit | Merged openstack/dragonflow master: Replace chassis and remote_vtep with port binding https://review.openstack.org/485103 | 17:54 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Trunk: use reg6 for classfication instead of ofport https://review.openstack.org/485690 | 18:32 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Classifier: reset in_port before dispatch https://review.openstack.org/485604 | 18:32 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Trunk: use classifier app to dispatch packets https://review.openstack.org/485691 | 18:32 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Classifier: resubmit to table 0 to allow reclassification https://review.openstack.org/486389 | 18:32 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/dragonflow master: Updated from global requirements https://review.openstack.org/486394 | 18:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!