| *** yamamoto has quit IRC | 00:01 | |
| *** yamamoto has joined #openstack-dragonflow | 00:01 | |
| *** yamamoto has quit IRC | 00:52 | |
| *** yamamoto has joined #openstack-dragonflow | 00:55 | |
| *** yamamoto has quit IRC | 01:26 | |
| *** yamamoto has joined #openstack-dragonflow | 01:48 | |
| *** yamamoto has quit IRC | 01:58 | |
| *** yamamoto has joined #openstack-dragonflow | 01:59 | |
| *** yamamoto has quit IRC | 02:10 | |
| *** yamamoto has joined #openstack-dragonflow | 02:13 | |
| oanson | Morning | 05:38 |
|---|---|---|
| dimak | oanson, morning | 05:42 |
| irenab | morning | 05:59 |
| irenab | oanson: welcome back from the “PTO” | 06:00 |
| oanson | irenab, thanks. Welcome back from holiday. | 06:00 |
| irenab | thanks | 06:00 |
| *** kkxue has joined #openstack-dragonflow | 06:09 | |
| *** yamamoto has quit IRC | 06:21 | |
| openstackgerrit | Merged openstack/dragonflow master: BGP service: Construct function name with format https://review.openstack.org/492428 | 06:50 |
| oanson | dimak, you in? | 07:11 |
| oanson | Did we ever discuss inheritance/polymorphism in our NB models? | 07:12 |
| dimak | oanson, I don't think we should, why? | 07:12 |
| oanson | It would be helpful. Both for LBaaS and unified classification | 07:13 |
| dimak | Elaborate? | 07:13 |
| oanson | Gimme a sec to come up with a coherent example | 07:16 |
| oanson | All right. In LBaaS, I have a 'Listener' - it says on what to listen (Protocl, port, etc.) | 07:16 |
| oanson | Now there can be several types: TCP, UDP, raw, http. | 07:16 |
| oanson | Each of these has different parameters: TCP and UDP have ports. raw has address, length, and data. http has e.g. the request URL, or a header value. | 07:17 |
| oanson | And maybe later we'll want to also add others: http2, sip, etc. | 07:17 |
| oanson | So Listener (or maybe a child object) should be an 'abstract class' (in OOP terminology), and each of these should inherit from it | 07:18 |
| oanson | dimak, ? | 07:20 |
| dimak | I'd rather avoid this kind of complexity | 07:20 |
| oanson | So what would you suggest? | 07:20 |
| dimak | For starters, using a union type | 07:21 |
| oanson | It will grow whenever we add more types. | 07:21 |
| oanson | It will probably lead to some strange re-uses for fields that are almost, but not exactly, the same. | 07:21 |
| dimak | Otherwise, you'll have to maintain a factory | 07:22 |
| dimak | to know what object to instantiate | 07:22 |
| dimak | you can do that by tagging all instances with their type.. | 07:22 |
| dimak | and using dynamic registration | 07:22 |
| dimak | but I don't really like it tbh | 07:23 |
| oanson | Not sure I understood the last bit. | 07:23 |
| oanson | What's wrong with a factory? | 07:23 |
| oanson | We can overload the from_* functions to call the factory. Dynamic registration isn't too bad. We have it in other places. | 07:24 |
| dimak | Nothing wrong, I think that a simpler approach might be a better way to start | 07:24 |
| oanson | If the infrastructure will hide most of the implementation details, we can come up with a clean API. | 07:24 |
| oanson | All right. I'll put both options in the spec, and we'll vote for it. | 07:25 |
| dimak | Before the spec, maybe implement some half baked example? | 07:25 |
| dimak | So we can toy with it | 07:25 |
| oanson | I can try. But I want to make progress with the spec a bit. | 07:26 |
| dimak | Sure | 07:26 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Move FIP status updates to L3 plugin https://review.openstack.org/493359 | 07:36 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Move FIP status updates to L3 plugin https://review.openstack.org/493359 | 07:47 |
| dimak | oanson, lihi, irenab take a look at ^ when you get a moment | 07:51 |
| lihi | 👍 | 07:52 |
| oanson | Will do | 07:52 |
| dimak | lihi, if you have more spare moments, also take a look at https://review.openstack.org/#/c/489994/ :) | 07:52 |
| lihi | sure | 07:52 |
| *** yamamoto has joined #openstack-dragonflow | 07:54 | |
| *** dmellado has quit IRC | 08:06 | |
| *** yamamoto has quit IRC | 08:12 | |
| *** yamamoto has joined #openstack-dragonflow | 08:14 | |
| *** yamamoto has quit IRC | 08:23 | |
| *** yamamoto has joined #openstack-dragonflow | 08:43 | |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** kkxue has quit IRC | 09:45 | |
| *** yamamoto has quit IRC | 10:37 | |
| *** yamamoto has joined #openstack-dragonflow | 10:40 | |
| *** yamamoto has quit IRC | 10:40 | |
| *** openstackgerrit has joined #openstack-dragonflow | 10:56 | |
| openstackgerrit | Merged openstack/dragonflow master: [01/xx] Introduce bind/unbind port events https://review.openstack.org/489994 | 10:56 |
| *** yamamoto has joined #openstack-dragonflow | 10:59 | |
| *** yamamoto has quit IRC | 11:04 | |
| *** kkxue has joined #openstack-dragonflow | 11:18 | |
| *** yamamoto has joined #openstack-dragonflow | 11:30 | |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: LBaaS spec https://review.openstack.org/477463 | 11:59 |
| *** kkxue has quit IRC | 12:35 | |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Move FIP status updates to L3 plugin https://review.openstack.org/493359 | 12:55 |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: [WIP] Replace usage of tenant_id with project_id https://review.openstack.org/493537 | 12:59 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [03/xx] Remove update_lport and cache all ports https://review.openstack.org/486411 | 14:17 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [02/xx] Introduce port locator https://review.openstack.org/493079 | 14:17 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [06/xx] Remove binding on trunk subports https://review.openstack.org/493282 | 14:17 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [04/xx] Dispatcher to hold apps by name https://review.openstack.org/493559 | 14:17 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: [05/xx] Move port events handling into standalone app https://review.openstack.org/493560 | 14:17 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Change DNAT to rely on Provider app for bridge access https://review.openstack.org/475362 | 14:19 |
| *** mlavalle has joined #openstack-dragonflow | 15:04 | |
| *** yamamoto has quit IRC | 16:21 | |
| *** yamamoto has joined #openstack-dragonflow | 17:22 | |
| *** yamamoto has quit IRC | 17:29 | |
| oanson | Dragonflow weekly meeting starting now | 19:01 |
| oanson | #openstack-meeting-4 | 19:01 |
| dimak | Cool | 19:01 |
| oanson | leyal, irenab, lihi, dimak, mlavalle, and anyone else who wants to join | 19:01 |
| leyal | Hi | 19:02 |
| openstackgerrit | Dima Kuznetsov proposed openstack/dragonflow master: Change DNAT to rely on Provider app for bridge access https://review.openstack.org/475362 | 19:03 |
| *** lewo has quit IRC | 20:23 | |
| *** lewo has joined #openstack-dragonflow | 20:24 | |
| openstackgerrit | Omer Anson proposed openstack/dragonflow master: [WIP] Replace usage of tenant_id with project_id https://review.openstack.org/493537 | 20:30 |
| *** yamamoto has joined #openstack-dragonflow | 21:08 | |
| *** yamamoto has quit IRC | 21:20 | |
| *** yamamoto has joined #openstack-dragonflow | 21:57 | |
| *** mlavalle has quit IRC | 22:20 | |
| *** lewo has quit IRC | 23:51 | |
| *** saggi has quit IRC | 23:51 | |
| *** dims has quit IRC | 23:51 | |
| *** zigo has quit IRC | 23:51 | |
| *** openstackgerrit has quit IRC | 23:51 | |
| *** oanson has quit IRC | 23:51 | |
| *** irenab has quit IRC | 23:51 | |
| *** afranc has quit IRC | 23:51 | |
| *** yamamoto has quit IRC | 23:51 | |
| *** serverascode has quit IRC | 23:51 | |
| *** evrardjp has quit IRC | 23:51 | |
| *** igordc has quit IRC | 23:51 | |
| *** yuval has quit IRC | 23:51 | |
| *** ChanServ has quit IRC | 23:51 | |
| *** lihi has quit IRC | 23:51 | |
| *** leyal has quit IRC | 23:51 | |
| *** yamamoto has joined #openstack-dragonflow | 23:55 | |
| *** lewo has joined #openstack-dragonflow | 23:55 | |
| *** lihi has joined #openstack-dragonflow | 23:55 | |
| *** oanson has joined #openstack-dragonflow | 23:55 | |
| *** irenab has joined #openstack-dragonflow | 23:55 | |
| *** leyal has joined #openstack-dragonflow | 23:55 | |
| *** saggi has joined #openstack-dragonflow | 23:55 | |
| *** afranc has joined #openstack-dragonflow | 23:55 | |
| *** serverascode has joined #openstack-dragonflow | 23:55 | |
| *** dims has joined #openstack-dragonflow | 23:55 | |
| *** zigo has joined #openstack-dragonflow | 23:55 | |
| *** evrardjp has joined #openstack-dragonflow | 23:55 | |
| *** ChanServ has joined #openstack-dragonflow | 23:56 | |
| *** tepper.freenode.net sets mode: +o ChanServ | 23:56 | |
| *** openstackgerrit has joined #openstack-dragonflow | 23:56 | |
| *** igordc has joined #openstack-dragonflow | 23:56 | |
| *** yuval has joined #openstack-dragonflow | 23:56 | |
| *** ChanServ has quit IRC | 23:56 | |
| *** igordc has quit IRC | 23:57 | |
| *** yuval has quit IRC | 23:57 | |
| *** openstackgerrit has quit IRC | 23:57 | |
| *** lewo has quit IRC | 23:57 | |
| *** saggi has quit IRC | 23:57 | |
| *** dims has quit IRC | 23:57 | |
| *** zigo has quit IRC | 23:57 | |
| *** oanson has quit IRC | 23:57 | |
| *** irenab has quit IRC | 23:57 | |
| *** afranc has quit IRC | 23:57 | |
| *** yamamoto has quit IRC | 23:57 | |
| *** serverascode has quit IRC | 23:57 | |
| *** evrardjp has quit IRC | 23:57 | |
| *** lihi has quit IRC | 23:57 | |
| *** leyal has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!