| opendevreview | Cyril Roelandt proposed openstack/election master: Add Cyril Roelandt for Glance 2027.1 PTL https://review.opendev.org/c/openstack/election/+/1002042 | 10:41 |
|---|---|---|
| gouthamr | ^ sigh, slaweq ianychoi: so please do follow up and post results. I plan to discuss appointments at the TC meeting tomorrow (25th Aug, 1700 UTC) | 16:06 |
| opendevreview | Ian Y. Choi proposed openstack/election master: Close 2027.1 Election Results (PTL) https://review.opendev.org/c/openstack/election/+/1002175 | 17:14 |
| ianychoi | gouthamr: plz see ^ and https://review.opendev.org/c/openstack/governance/+/1002177 | 17:16 |
| gouthamr | w00t | 17:16 |
| gouthamr | ty ianychoi! | 17:16 |
| ianychoi | slaweq: Plz share SHA from "tox -e venv -- generate-rolls". My result is 81af5979219ac3032f0e01eff3ca3ad55fb11486c7adc7585942f3ee6eedd354 | 17:16 |
| fungi | ianychoi: did you use https://review.opendev.org/1001560 when doing it? | 17:20 |
| fungi | the tc is expecting that to be used, i was hoping it would get merged before election officials start generating rolls | 17:21 |
| ianychoi | fungi: Ah, not yet. I just used master version of git repo. Thank you for letting me know | 17:22 |
| opendevreview | Ian Y. Choi proposed openstack/election master: Update governance tag 0.23.0 to configuration https://review.opendev.org/c/openstack/election/+/1002178 | 17:24 |
| ianychoi | fungi: Does 1001560 need additional dependency? It returns like "no attribute 'no_core_reviewers'" error - pasting log via https://paste.opendev.org/show/bjFJmiCMEjyjfUug5FXB/ | 17:28 |
| fungi | ianychoi: there are several child changes it depends on, yes | 17:28 |
| fungi | you need the whole stack of changes there, 1001560 is merely the last in the series | 17:29 |
| fungi | some of the earlier changes in that series already merged but there are still a few that are waiting review | 17:29 |
| ianychoi | Should "git review -d 1001560" get all the dependencies? | 17:29 |
| fungi | yes | 17:31 |
| ianychoi | Yep I was pasting the error from like "git review -d 1001560 && tox -e venv -- generate-rolls" | 17:32 |
| fungi | though i wonder if the generate-rolls entrypoint is in need of changes similar to the owners entrypoint | 17:34 |
| fungi | just a sec, i didn't test by running generate-rolls i was running owners directly to generate the files | 17:34 |
| fungi | generate-rolls is a wrapper around it, i'll get a quick fix for that pushed | 17:35 |
| ianychoi | Thank you - Seems that no_core_reviewers option needs to be processed on generate_rolls.py file due to https://paste.opendev.org/show/bjFJmiCMEjyjfUug5FXB/ | 17:38 |
| fungi | yes, i'm about done, implementing it similarly to how `no_extra_acs` is done there | 17:40 |
| fungi | just testing locally to make sure nothing else is missing | 17:40 |
| opendevreview | Jeremy Stanley proposed openstack/election master: Active core reviewers are also Active Contributors https://review.opendev.org/c/openstack/election/+/1001560 | 17:43 |
| fungi | good thing i did, caught a typo from my initial attempt | 17:43 |
| fungi | that new version ^ only adds to the generate-rolls script, doesn't alter anything else from the prior revision | 17:45 |
| fungi | i'm not having any luck actually testing generate-rolls directly on my machine because (even on the current master branch state) it seems to be passing `old_projects` in incorrectly | 17:48 |
| ianychoi | Thank you - now on local execution to see the result | 17:49 |
| fungi | i'm rolling back my local checkout to late july, before any of this stuff or the election-related changes merged, and am getting the same error, so it may be something weird on my system | 17:50 |
| fungi | ianychoi: you may also need to rebase the change series locally onto the current master branch state in order to pick up 1002178 which adjusted the election configuration | 17:54 |
| fungi | or, no, i guess that hasn't even merged yet either | 17:55 |
| fungi | you could just make that edit locally to your `configuration.yaml` file | 17:55 |
| fungi | confirmed, that's what was breaking my attempts to run it locally, the governance tag placeholder wasn't a real tag and somehow that doesn't get caught early by the script to cascades to a problem parsing files from that repo instead | 17:59 |
| ianychoi | fungi: THank you for the confirmation - it works on my local environment well so I gave +2 | 18:06 |
| ianychoi | slaweq: Sharing two SHAs via https://etherpad.opendev.org/p/TC_PTL_Elections2027.1_Indri#L87 - your double-check with 1001560 review would be highly appreciated. | 18:07 |
| ianychoi | For reference, without 1001560, there are 248 electorates. With 1001560, there are 258 electorates. | 18:08 |
| ianychoi | Once the other election official / one more liaison person validates above, then I can move forward, hopefully. | 18:09 |
| fungi | thanks, yes it's running for me too but still in progress here so i don't know for sure whether it will complete successfully, but expect if it got this far then it will | 18:10 |
| fungi | ianychoi: good to know that we had 10 active core reviewers who didn't own any merged changes during the qualifying timeframe, that's ~4% of the electorate, so not trivial | 18:11 |
| fungi | gouthamr: ^ useful statistic about the impact of the tc's charter adjustment | 18:13 |
| fungi | and the script did eventually complete successfully for me as well, `rolls/0.23.0/_electorate.txt` contains 258 addresses matching your outcome | 18:14 |
| ianychoi | Is SHA the same, fungi ? 55aed6f5fd91a5b3a002b77adaabb6d057a46a1752334be5f1db25838019ffe0 ./0.23.0/_electorate.txt ( | 18:14 |
| fungi | `55aed6f5fd91a5b3a002b77adaabb6d057a46a1752334be5f1db25838019ffe0 ./0.23.0/_electorate.txt` | 18:22 |
| fungi | ianychoi: confirmed | 18:22 |
| fungi | after the election has concluded, if someone wants an easy improvement to make, the runtime of the generate-rolls script could be halved by turning off the extra stable branch electorate generation, that's been unused for roughly a decade ever since stable branch management ceased to be an official project team | 18:28 |
| gouthamr | wow that’s great! | 18:34 |
| fungi | gouthamr: to be precise, that's active core reviewers on merged changes during the qualifying window who have an e-mail address in their gerrit account matching a foundation individual member profile | 18:56 |
| fungi | who also didn't own any changes merging during that timeframe | 18:56 |
| fungi | (so a lot of caveats) | 18:57 |
| gouthamr | yeah, i didn't expect that bump :D it was a lot of "if's" - we'll recap this to teh TC tomorrow during their meeting - interesting stuff! ty fungi | 20:12 |
| spotz[m] | ianychoi: what do you need me to look at? I've been trying to keep up with the patches | 20:17 |
| fungi | spotz[m]: 1002178 and the unmerged remainder of the series ending in 1001560 at least, for electoral rolls | 20:20 |
| spotz[m] | looking | 20:21 |
| fungi | spotz[m]: and then separately, there's 1002175 to close the ptl election results (with corresponding governance change 1002177) | 20:23 |
| spotz[m] | i think on 1002177 so far others look good still working though | 20:31 |
| spotz[m] | Ok I think I got everything, if not let me know | 20:32 |
| *** Uggla is now known as Guest16245 | 21:34 | |
| *** Uggla7 is now known as Uggla | 21:34 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!