| frickler | there's still warnings about RLocks and monkey_patching when running nova unit tests with latest oslo.log and eventlet, this may warrant another look, see e.g. https://14e68174e345e9e87efc-7aaaa43d127e6b333bd4b0d6411a2943.ssl.cf2.rackcdn.com/933257/10/check/cross-nova-py312/19a8006/job-output.txt | 09:50 |
|---|---|---|
| frickler | but eventlet u-c bump is now merging | 09:50 |
| hberaud[m] | ack | 12:49 |
| hberaud[m] | thanks for the heads up | 12:49 |
| itamarst | now that new eventlet is merged, should continue on https://review.opendev.org/c/openstack/oslo.log/+/937729 | 14:39 |
| itamarst | do I just post a comment saying "recheck" to trigger Zuul? | 14:39 |
| JayF | I think it's fine, because it already depends-on the merged change | 15:03 |
| JayF | so I think the action there is ... no action | 15:03 |
| JayF | well, except other people reviewing :D | 15:04 |
| itamarst | I guess once it's merged I'm back to doing hard things :( | 15:05 |
| hberaud[m] | I made my review, +2ed with a tiny suggestion about adding a release note | 15:07 |
| JayF | yeah, good point, it probably should have one | 15:08 |
| hberaud[m] | it could be added with a follow up patch if you want | 15:08 |
| JayF | itamarst: ^ have you done release notes here before? I can do the follow up for you if you want | 15:10 |
| itamarst | I have not done release notes, no | 15:42 |
| JayF | basically tox -evenv; . .tox/venv/bin/activate; reno new short-change-description | 16:09 |
| JayF | it'll create a file like releasenotes/notes/short-change-description-sdglkjhfdhkgjdsfh.yaml which is a template you edit | 16:09 |
| JayF | (really you just need `reno` installed and working somewhere; I use the venv that tox installs) | 16:10 |
| JayF | or the alternative way to do it is to say "screw that, please do it for me Jay" :P | 16:11 |
| JayF | since I've done those a thousand times | 16:11 |
| JayF | and I'm always happy to run paperwork so you can do hard stuff instead LOL | 16:11 |
| itamarst | I like option B 😁 thank you! | 16:29 |
| JayF | itamarst: https://review.opendev.org/c/openstack/oslo.log/+/937729/5/releasenotes/notes/pipemutex-for-asyncio-hub-1292d9253e9aff68.yaml | 16:36 |
| JayF | hberaud[m]: ^ added release note per your request, if you wanna restore your core review it'd be awesome o/ | 16:36 |
| itamarst | thank you! | 16:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!