itamarst | for https://github.com/eventlet/eventlet/issues/1020 suggestion from zzzeek is that Nova needs to us SQLAlchemy API in a different, more correct way by explicitly closing database connections | 13:18 |
---|---|---|
itamarst | so someone on Nova is gonna have to take this on | 13:18 |
itamarst | if SeanMooney doesn't follow up someone here should file an issue whereever it is issues get filed | 13:19 |
hberaud[m] | dansmith gibi : FYI ^ | 17:12 |
dansmith | hberaud[m]: I see the assertion that nova is doing something wrong, but not a pointer to where | 17:15 |
dansmith | AFAIK zzzeek did a lot of the work to convert nova to enginefacade early on and I don't know of anywhere we're actually explicitly closing connections | 17:15 |
dansmith | (off the top of my head) | 17:16 |
hberaud[m] | Indeed, lets ask to Mike if he own more details | 17:17 |
itamarst | if I understood correctly it's not so much doing something wrong as lack of doing the right thing? so might not be a specific line of code that's wrong so much as a line of code that's missing | 18:41 |
itamarst | (and in practice it might e.g. only be an issue on shutdown, where it's not impactful... and tests) | 18:41 |
-opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline momentarily while we reboot for a patch version upgrade of the software, but should return again within a few minutes | 22:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!