| ralonsoh | damani[m], hello! qq: what about the cotyledon dependency? | 11:07 |
|---|---|---|
| ralonsoh | I still need to import it to run a service using the threading backend | 11:08 |
| ralonsoh | I see that is included in test-requirements: https://review.opendev.org/c/openstack/oslo.service/+/945720 | 11:08 |
| ralonsoh | why not in requirements? | 11:08 |
| damani[m] | ralonsoh, it's not in the requirements because it's an optional dependency | 11:39 |
| damani[m] | however it's in the setup.cfg | 11:41 |
| damani[m] | for example you can install it like that: | 11:43 |
| damani[m] | `pip install .[threading]` | 11:43 |
| damani[m] | or in the requirements.txt you can put: | 11:44 |
| damani[m] | `oslo.service[threading]` | 11:44 |
| ralonsoh | damani[m], does it mean we need to change the devstack installation tools to have these libraries? | 12:24 |
| damani[m] | yes since cotyledon and futurist are optional dependencies under the [threading] extra, they won’t be installed by default | 12:59 |
| ralonsoh | damani[m], so is there a devstack patch proposed? just to know | 12:59 |
| ralonsoh | if this is not the case, I'll check how to do it | 12:59 |
| ralonsoh | btw | 12:59 |
| damani[m] | so if you want to use the threading backend with devstack, you’ll need to explicitly add it | 12:59 |
| damani[m] | i have not made it | 13:00 |
| damani[m] | but i can take a look today and proposed a patch | 13:00 |
| ralonsoh | how is it possible to set the 'threading' backend via config? | 13:00 |
| ralonsoh | or is always needed to call this hook method | 13:00 |
| damani[m] | ralonsoh, i'm not sure to understand what you mean sorry? | 13:37 |
| ralonsoh | damani[m], one sec, in my 1:1 now | 13:38 |
| ralonsoh | damani[m], so right now I'm doing this: https://review.opendev.org/c/openstack/neutron/+/938404/18/neutron/cmd/agents/l3.py | 14:02 |
| ralonsoh | because, if I'm not wrong, this method should be called before anything | 14:03 |
| ralonsoh | actually this is different from https://review.opendev.org/c/openstack/oslo.service/+/945720/31/releasenotes/notes/add-threading-backend-9b0e601e5c1282e1.yaml#34 | 14:04 |
| damani[m] | ralonsoh, yes, you still need to either call init_backend() or register a default hook but there’s no support for configuration, so it must still be done in code | 14:18 |
| ralonsoh | ok | 14:19 |
| damani[m] | sorry i'm in a meeting at the same i can take time to answer | 14:19 |
| ralonsoh | me too, hehhee | 14:19 |
| damani[m] | but so that is the good way https://review.opendev.org/c/openstack/neutron/+/938404/18/neutron/cmd/agents/l3.py | 14:19 |
| damani[m] | i will check for devstack later today or tomorrow | 14:20 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!