| ralonsoh | damani[m], hello! just a heads-up: the class ProcessLauncher does not have the same signature | 08:56 |
|---|---|---|
| ralonsoh | wait_interval is missing in threading (I know it makes no sense) | 08:56 |
| ralonsoh | maybe there could be a kwargs input in the "threading" implementation, just to accept it (and maybe logging a deprecation warning) | 08:57 |
| ralonsoh | just a suggestion, I'm actually removing this input parameter here: https://review.opendev.org/c/openstack/neutron/+/950854 | 08:58 |
| damani[m] | yes good catch | 10:43 |
| damani[m] | i can added in the signature, just to not break the api | 10:43 |
| damani[m] | i will create a jira issue about it | 10:43 |
| hberaud[m] | Thanks, and I agree with ralonsoh , we could emit deprecation warning to prepare its removal and the next steps with oslo.service | 12:05 |
| gibi | JayF: I think the issue is https://tox.wiki/en/latest/config.html#constrain_package_deps in your tox.ini. I don't see it in nova's tox.ini and the definition suggests that normal deps are forced to be constraints and then tox fails as contraints cannot have optional extras | 15:13 |
| JayF | 👀 | 15:13 |
| gibi | https://github.com/openstack/networking-baremetal/blob/master/tox.ini#L7 | 15:13 |
| JayF | I was looking for something like that, but never checked tox.ini | 15:13 |
| JayF | compared the pyproject.toml, setup.*, etc | 15:13 |
| JayF | thanks, I'll update the patches for ngs/nbm | 15:14 |
| gibi | yeah it helped that you ruled out those files | 15:14 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is temporarily unreachable due to an ongoing issue in the hosting provider where it resides | 22:07 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!