| ralonsoh | hi folks, let see if we can push https://review.opendev.org/c/openstack/oslo.service/+/951505 and release it | 09:23 |
|---|---|---|
| ralonsoh | thanks in advance! | 09:23 |
| hberaud[m] | OMW | 09:34 |
| hberaud[m] | but if you think that's not necessary I won't block the merge for that. | 09:48 |
| tkajinam | hberaud[m], a problem with debtcollector.removed_kwargs is that it does not detect a usage in case args is used instead of kwargs | 14:07 |
| tkajinam | because the function has a few arguments I'm not too sure if we can assume that users are always using kwargs | 14:07 |
| hberaud[m] | ack | 14:08 |
| tkajinam | that's why I did suggest using that method. | 14:08 |
| hberaud[m] | then, let's follow your suggestion. | 14:08 |
| hberaud[m] | thanks for your heads up | 14:08 |
| tkajinam | maybe we can use warnings.warn with category=DeprecationWarning if that can show more explicit warning | 14:10 |
| tkajinam | (this is what is internally used in debtcollector | 14:10 |
| hberaud[m] | as you prefer | 14:11 |
| hberaud[m] | I just +2ed (without +W), so feel free to +W if you feel that we are good | 14:12 |
| tkajinam | hberaud[m], I've made a slight modification. could you review https://review.opendev.org/c/openstack/oslo.service/+/951505 again ? | 14:13 |
| hberaud[m] | sure | 14:13 |
| hberaud[m] | thanks | 14:13 |
| tkajinam | if that looks ok to you then I'll vote +2+A by my side | 14:13 |
| hberaud[m] | LGTM | 14:18 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!