| amorin | hey team, I did not follow the recent updates on eventlet removal, but I have the feeling that I will need to get rid of starting mistral api as wsgi from code and rely on uwsgi on any wsgi server, am I wrong? | 08:33 |
|---|---|---|
| amorin | I have this patch ongoing: https://review.opendev.org/c/openstack/mistral/+/952624 | 08:33 |
| amorin | which failed, I believe due to this | 08:33 |
| gibi | amorin: from deployment perspective yes, the api shoud be started by a wsgi server like uwsgi or apache with mod_wsgi. | 08:41 |
| gibi | amorin: from testing perspective if you want to run the api from the test code then you can look at https://review.opendev.org/c/openstack/nova/+/947245/4/nova/tests/fixtures/nova.py what nova does to do it without relying on eventlet | 08:41 |
| amorin | thanks gibi! I think from deployment I am already good, I will take a look at what you did on nova side | 08:44 |
| amorin | for units | 08:44 |
| hberaud[m] | amorin: o/ FYI, if that can help you, here is another approach used by ironic, using cheroot https://review.opendev.org/c/openstack/ironic/+/951054 in place of eventlet.wsgi. Also, IIRC mistral still use the oslo.service eventlet backend, you may be interested by shitfing the backend as the next step (I precise because you said that missed the recent updates) | 09:08 |
| hberaud[m] | In all the case you have to replace the wsgi part before shifting oslo.service's backend | 09:09 |
| amorin | I saw the cheroot stuff, mistral is relying on pecan to build the wsgi app, I have the feeling that this would be a big change, am I wrong? | 09:17 |
| amorin | and yes, mistral is still using the eventlet service, I am trying to shift to threading backend in this change: https://review.opendev.org/c/openstack/mistral/+/952624 | 09:18 |
| amorin | but that also break my unit tests, due to api on eventlet wsgi I believe | 09:18 |
| amorin | should I start switching the wsgi off eventlet first? | 09:19 |
| hberaud[m] | Probably, in all the case I'd encourage to avoid of using 36 differents kind of wsgi libs, uwsgi looks a good choice | 09:19 |
| hberaud[m] | yes, I think your priority is the wsgi part, first | 09:19 |
| amorin | ack, thanks | 09:19 |
| hberaud[m] | as the oslo.service threading backend do not implement wsgi support, you have to migrate that part firstly | 09:21 |
| amorin | mistral is already able to deliver a wsgi app without eventlet, but I need to figure that out for unit tests | 09:21 |
| amorin | gibi exemple is a good starting point I believe | 09:21 |
| hberaud[m] | perfect | 09:22 |
| hberaud[m] | yes | 09:22 |
| amorin | I saw that heat also removed their wsgi stuff, I dont know how they achieve the change in unit tests | 09:22 |
| hberaud[m] | I'm far to be a heat expert, but it seems that they already had a wsgi alternative available handy, so they simply removed the eventlet one | 09:25 |
| amorin | ack | 09:25 |
| hberaud[m] | and so they simply removed the unit tests related to eventlet | 09:25 |
| -opendevstatus- NOTICE: Gerrit is being restarted to pick up a configuration change. You may notice a short outage. | 17:36 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!