*** dschroeder has quit IRC | 00:23 | |
*** memogarcia has quit IRC | 00:25 | |
*** reldan has quit IRC | 00:29 | |
*** jonaspf has joined #openstack-freezer | 02:58 | |
*** jonaspf has quit IRC | 03:13 | |
*** frescof__ has quit IRC | 03:18 | |
*** frescof__ has joined #openstack-freezer | 03:18 | |
*** jonaspf has joined #openstack-freezer | 03:24 | |
*** jonaspf has quit IRC | 03:39 | |
*** DuncanT has quit IRC | 05:25 | |
*** emildi has quit IRC | 05:25 | |
*** nullvariable has quit IRC | 05:25 | |
*** DuncanT has joined #openstack-freezer | 05:26 | |
*** emildi has joined #openstack-freezer | 05:26 | |
*** nullvariable has joined #openstack-freezer | 05:31 | |
*** jonaspf has joined #openstack-freezer | 07:25 | |
*** jonaspf has quit IRC | 07:40 | |
*** fabriziof has joined #openstack-freezer | 08:16 | |
*** reldan has joined #openstack-freezer | 08:48 | |
*** memogarcia has joined #openstack-freezer | 08:54 | |
*** memogarcia has quit IRC | 09:08 | |
*** reldan has quit IRC | 09:11 | |
*** openstackgerrit has quit IRC | 09:31 | |
*** openstackgerrit has joined #openstack-freezer | 09:32 | |
*** reldan has joined #openstack-freezer | 10:05 | |
*** daemontool has joined #openstack-freezer | 10:12 | |
*** daemontool has quit IRC | 10:14 | |
*** daemontool has joined #openstack-freezer | 10:15 | |
openstackgerrit | Fausto Marzi proposed openstack/freezer: Windows Scheduler https://review.openstack.org/245793 | 10:21 |
---|---|---|
daemontool | all: any reason why the pbr requirements version in kilo is not aligned with kilo requirements? https://github.com/openstack/freezer-web-ui/blob/stable/kilo/setup.py | 10:23 |
daemontool | that needs to be fixed... | 10:28 |
m3m0 | I'll do that now | 10:29 |
*** jonaspf has joined #openstack-freezer | 10:29 | |
daemontool | in stable/kilo | 10:29 |
daemontool | thank a lot! | 10:30 |
daemontool | :) | 10:30 |
m3m0 | daemontool, is this the correct one? setup_requires='pbr>=1.6', | 10:31 |
*** openstackgerrit has quit IRC | 10:31 | |
*** openstackgerrit has joined #openstack-freezer | 10:32 | |
m3m0 | or this one? setup_requires='pbr>=0.6,!=0.7,<1.0', | 10:33 |
daemontool | yep | 10:34 |
daemontool | check if it works | 10:35 |
daemontool | after the changes :) | 10:35 |
daemontool | lol | 10:35 |
daemontool | sorry | 10:35 |
daemontool | 1.6 is Liberty | 10:35 |
daemontool | while pbr>=0.6,!=0.7,<1.0 is for kilo | 10:35 |
daemontool | you can see them from here | 10:35 |
daemontool | https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt | 10:36 |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Pbr to comply against kilo requirements https://review.openstack.org/246311 | 10:39 |
m3m0 | daemontool, this is the commit but I think is not pointing to stable/kilo | 10:40 |
daemontool | ok | 10:42 |
daemontool | so after cloned the repo | 10:42 |
daemontool | go on master | 10:42 |
daemontool | sorry go on kilo | 10:42 |
daemontool | git checkout stable/kilo | 10:42 |
daemontool | after the patch | 10:42 |
m3m0 | i did that, git checkout origin/stable/kilo | 10:42 |
daemontool | ok | 10:43 |
daemontool | then | 10:43 |
daemontool | git review stable/kilo | 10:43 |
daemontool | rather just git review | 10:43 |
daemontool | otherwise the chance will be sent to master | 10:43 |
m3m0 | k, I miss that step | 10:43 |
m3m0 | done daemontool https://review.openstack.org/#/c/246313/ | 10:46 |
daemontool | :) | 10:47 |
openstackgerrit | Fausto Marzi proposed openstack/freezer: Windows Scheduler https://review.openstack.org/245793 | 10:58 |
daemontool | all: would be good to understand what needs to be done to support containers backup with freezer | 11:02 |
Jokke_ | m3m0: openstack/requirements has global-requirements.txt ... checkout correct branch and use that as reference | 11:06 |
*** reldan has quit IRC | 11:08 | |
*** reldan has joined #openstack-freezer | 11:10 | |
*** daemontool has quit IRC | 11:11 | |
*** daemontool has joined #openstack-freezer | 11:11 | |
*** jonaspf has quit IRC | 11:13 | |
openstackgerrit | Pierre-Arthur MATHIEU proposed openstack/freezer: Updated requirements to match Liberty's one https://review.openstack.org/246331 | 11:15 |
daemontool | Slashme, thanks ++ | 11:16 |
daemontool | fabriziof, ping | 11:17 |
Jokke_ | daemontool: you might want to merge these https://review.openstack.org/#/q/Ib588cf5f7c166088061f0e3ec86addb45a8973b0,n,z | 11:18 |
*** daemontool has quit IRC | 11:23 | |
*** daemontool has joined #openstack-freezer | 11:24 | |
daemontool | yes Jokke_ thanks | 11:25 |
*** daemontool has quit IRC | 11:25 | |
*** daemontool has joined #openstack-freezer | 11:26 | |
Jokke_ | m3m0: were you planning to set the version to 1.1.3 or bump it from that? | 11:26 |
Jokke_ | it's set already to 1.1.3 in stable/kilo | 11:26 |
openstackgerrit | Pierre-Arthur MATHIEU proposed openstack/freezer-api: Updated requirements to match Liberty's one https://review.openstack.org/246341 | 11:32 |
*** jonaspf has joined #openstack-freezer | 11:35 | |
m3m0 | I don;t know why was done automatically, I didn't understood that | 11:35 |
m3m0 | Jokke_ | 11:36 |
Jokke_ | so your plan was not to set it to 1.1.4? | 11:37 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix tests https://review.openstack.org/245796 | 11:38 |
Jokke_ | m3m0: fixed it for you then ;) | 11:40 |
m3m0 | thanks Jokke_, quick question, is there a typo on the requirements.txt? or the ui is not displaying it correctly? | 11:41 |
m3m0 | vape? | 11:42 |
Jokke_ | in about 5min ... we have on-call handoff | 11:46 |
Jokke_ | aargh | 11:46 |
Jokke_ | that fucked up | 11:46 |
Jokke_ | need to fix after the meeting | 11:47 |
*** reldan has quit IRC | 11:48 | |
*** reldan has joined #openstack-freezer | 11:51 | |
*** reldan has quit IRC | 11:57 | |
*** federico2 is now known as federico3 | 12:10 | |
*** reldan has joined #openstack-freezer | 12:10 | |
Jokke_ | m3m0: I dunno why the feck it did that for me :( | 12:11 |
Jokke_ | but fixed now | 12:11 |
m3m0 | thanks Jokke_ :) you should stop using notepad | 12:12 |
m3m0 | :) | 12:12 |
m3m0 | daemontool, we need to bump freezer 1.1.3 from stable/kilo in pypy | 12:15 |
m3m0 | soon | 12:15 |
m3m0 | do you want to create as well one for freezer-web-ui in pypy? | 12:18 |
Jokke_ | daemontool: we need to merge all those version bumps | 12:59 |
Jokke_ | on stable/kilo | 12:59 |
Jokke_ | pbr will prevent anything else merging as 1.1.3 has been released already | 12:59 |
m3m0 | Jokke_ is there a policy if I want to send a bug fix for a stable/branch ? | 13:18 |
m3m0 | vannif, is there a way we can set elasticsearch>=1.7.0 by default in the api? | 13:33 |
*** szaher_ has joined #openstack-freezer | 14:02 | |
*** memogarcia has joined #openstack-freezer | 14:26 | |
vannif | in requirements.txt use : elasticsearch>=1.3.0,<=1.7.0 | 14:32 |
vannif | but then the elasticsearch python library would not support the latest elastisearch db. I need to remove the method that is boing deprecated since elasticsearch 1.7 | 14:33 |
*** reldan has quit IRC | 14:42 | |
*** reldan has joined #openstack-freezer | 14:43 | |
m3m0 | reldan... 2015-11-17 14:53:31,532 root CRITICAL [*] Critical Error: <freezer.storage.local.LocalStorage object at 0x7fa21873c210> is not JSON serializable | 14:55 |
openstackgerrit | Pierre-Arthur MATHIEU proposed openstack/freezer: Fixed installation of platform-specific requirements https://review.openstack.org/246434 | 14:56 |
reldan | m3m0: could you please show stack trace, I actually have no idea why we want to serialize localstorage | 14:56 |
m3m0 | is the only thing that the logs shows | 14:57 |
reldan | Could you please comment line 193 and 204 - 209 in freezer/main.py and retry | 14:58 |
openstackgerrit | Pierre-Arthur MATHIEU proposed openstack/freezer: Updated requirements to match Liberty's one https://review.openstack.org/246331 | 14:59 |
m3m0 | reldan, doesn't show anything :( | 15:02 |
m3m0 | the backup finish but I think the problem is the metadata is not being send it | 15:02 |
reldan | Very very strange | 15:06 |
reldan | We can add additional logging to get_metadata | 15:07 |
reldan | But now I don’t see how storage can be placed to metadata | 15:07 |
reldan | Guys, do you know how to fix pbr problem? https://review.openstack.org/#/c/245793/ | 15:10 |
reldan | It seems that we are blocked now | 15:10 |
reldan | pbr.version.SemanticVersion(1.1.4), but target version is pbr.version.SemanticVersion(1.1.3) | 15:10 |
m3m0 | I have the same issue | 15:17 |
*** samuelBartel has joined #openstack-freezer | 15:18 | |
m3m0 | am I the only one having this problem? http://paste.openstack.org/show/479130/ | 15:21 |
reldan | m3m0: Can you add logging in job.py 111 line | 15:23 |
reldan | or just print | 15:23 |
reldan | print metadata | 15:23 |
Jokke_ | m3m0: https://wiki.openstack.org/wiki/StableBranch | 15:24 |
Jokke_ | I'll fix the repos in a sec | 15:25 |
m3m0 | k I'll do that | 15:26 |
reldan | m3m0: it seems that instead of timestamp or mode or etc we have storage, seems that we invoke somewhere function with wrong sequence of arguments | 15:27 |
openstackgerrit | Erno Kuvaja proposed openstack/freezer: Fix versions for Liberty https://review.openstack.org/246446 | 15:27 |
openstackgerrit | Erno Kuvaja proposed openstack/freezer-api: Fix versions for Liberty https://review.openstack.org/246448 | 15:28 |
reldan | Thank you, hope it will help | 15:28 |
m3m0 | is nto storage an argument ? | 15:28 |
m3m0 | so how can we use storage the argument instead of storage the object? | 15:29 |
reldan | Do you need to have storage in metadata? | 15:30 |
reldan | like a string? | 15:30 |
openstackgerrit | Erno Kuvaja proposed openstack/freezer-web-ui: Fix versions for Liberty https://review.openstack.org/246451 | 15:30 |
m3m0 | yes, at least from the ui is a very good value to have | 15:30 |
Jokke_ | When https://review.openstack.org/#/q/I6bcd9b1d3462ccf9b35119c571ec57d9aa548578,n,z is merged you can start merging stuff again, that will fix the pbr error | 15:31 |
reldan | m3m0: See now. I execute this in main.py line 133 backup_args.__dict__['storage'] = storage | 15:31 |
reldan | and rewrite string to object | 15:31 |
m3m0 | do you want to send the patch? | 15:32 |
reldan | What behaviour do you expect actually? I can do differently. 1 way - just instead of rewriting storage use something like storage_object. 2 - way - add method to storage def name: str | 15:33 |
m3m0 | just the get the string for the storage argument (swift, local, ssh) | 15:34 |
*** daemontool has quit IRC | 15:34 | |
reldan | Ok m3m0: I actually don’t like how we work with this metadata - but it’s different problem. Let me send a patch | 15:35 |
*** samuelBartel has quit IRC | 15:41 | |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix metadata storage https://review.openstack.org/246456 | 15:43 |
m3m0 | reldan, should this be on kilo? | 15:53 |
reldan | commit 01421da3525665d9fce1a2a5adffa5873c01f206 | 15:54 |
reldan | Author: memo <sirmemogarcia@gmail.com> | 15:54 |
reldan | Date: Fri Nov 13 15:39:50 2015 +0000 | 15:54 |
reldan | Add backup metadata fields | 15:54 |
reldan | This is in kilo? | 15:54 |
*** daemontool has joined #openstack-freezer | 15:57 | |
daemontool | Jokke_, re: https://review.openstack.org/#/q/I6bcd9b1d3462ccf9b35119c571ec57d9aa548578,n,z yes thanks a lot! | 15:58 |
daemontool | as soon as the verification pass, I'll approve it | 15:58 |
Jokke_ | :) | 15:58 |
Jokke_ | I used the same change id for all of them so it's easy to track | 15:58 |
*** daemontool has quit IRC | 15:59 | |
*** daemontool has joined #openstack-freezer | 15:59 | |
reldan | https://review.openstack.org/#/c/246460/ | 16:00 |
daemontool | Jokke_, we'd have spend 1 week to fix that, thanks | 16:00 |
daemontool | s/fix/understand and fix/ | 16:00 |
*** dschroeder has joined #openstack-freezer | 16:00 | |
daemontool | :) | 16:00 |
Jokke_ | damn | 16:00 |
Jokke_ | sorry to notice it only now | 16:01 |
daemontool | reldan, one sec, let's merge the version changes | 16:01 |
reldan | Yes, sure it is for m3m0 | 16:01 |
daemontool | then we'll rebase current commits | 16:01 |
daemontool | :) | 16:01 |
daemontool | ok | 16:01 |
Jokke_ | daemontool: the kilo version bump needs to happen as well | 16:01 |
daemontool | yes, that's what I'm referring too | 16:03 |
daemontool | all: please review https://review.openstack.org/#/q/I6bcd9b1d3462ccf9b35119c571ec57d9aa548578,n,z quite critical | 16:05 |
Jokke_ | so just for future reference ... every time after release the setup.cfg version need to be lifted or that pbr check will fail it's safe to bump it up by patch X.Y.+1 and if minor release needed change it again before you tag. After curring stable branch, master needs to have minor bump to leave the patch room for the stable releases even if there is nothing merged that would othervice warrant it | 16:06 |
m3m0 | reldan, your patch works, thanks :) | 16:06 |
Jokke_ | :%s/curring/cutting/ | 16:06 |
reldan | m3m0: thank you for help with branches :) | 16:06 |
daemontool | Jokke_, ++ | 16:07 |
daemontool | reldan, you didn't miss not even 1 second ;) | 16:16 |
*** fabriziof has quit IRC | 16:17 | |
reldan | Yes, I should review more carefully then :) | 16:17 |
daemontool | just kidding :) | 16:18 |
daemontool | all: after the 3 commits here are merged, please rebase your changes https://review.openstack.org/#/q/I6bcd9b1d3462ccf9b35119c571ec57d9aa548578,n,z | 16:19 |
*** fabriziof has joined #openstack-freezer | 16:27 | |
openstackgerrit | Merged openstack/freezer-web-ui: Fix versions for Liberty https://review.openstack.org/246451 | 16:33 |
openstackgerrit | Merged openstack/freezer-api: Fix versions for Liberty https://review.openstack.org/246448 | 16:33 |
daemontool | fabriziof, hi | 16:34 |
openstackgerrit | Merged openstack/freezer: Fix versions for Liberty https://review.openstack.org/246446 | 16:38 |
daemontool | all: now, rebase :) | 16:39 |
openstackgerrit | Fausto Marzi proposed openstack/freezer: Improvements for windows snapshots https://review.openstack.org/245737 | 16:42 |
openstackgerrit | Fausto Marzi proposed openstack/freezer: Windows Scheduler https://review.openstack.org/245793 | 16:43 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix tests https://review.openstack.org/245796 | 16:43 |
daemontool | Jokke_, here https://review.openstack.org/#/c/246313/ the version was already bumped to 1.1.3 | 16:53 |
daemontool | aligned with freezer and freezer-api (1.1.3 in kilo) | 16:54 |
daemontool | I'll take a look at it in a bit | 16:54 |
Jokke_ | oh the pbr requirement is in test-requirements ... will drop it from there | 16:58 |
Jokke_ | that's why it's failing | 16:58 |
daemontool | ah | 16:58 |
daemontool | good catch | 16:58 |
daemontool | is that the right place? | 16:59 |
daemontool | I think it should be in requirements.txt | 16:59 |
Jokke_ | yes, that's why I'm removing the test-requirements line | 16:59 |
Jokke_ | there | 17:01 |
Jokke_ | daemontool: by warehouse.python.org the 1.1.3 is released already | 17:04 |
*** daemontool has quit IRC | 17:04 | |
*** daemontool has joined #openstack-freezer | 17:04 | |
Jokke_ | daemontool: by warehouse.python.org the 1.1.3 is released already | 17:05 |
daemontool | Jokke_, yes | 17:05 |
daemontool | that is 1.1.3 | 17:05 |
daemontool | stable/kilo | 17:05 |
daemontool | that change is in stable/kilo | 17:05 |
Jokke_ | yes | 17:05 |
daemontool | ah ok | 17:05 |
daemontool | you are bumping | 17:05 |
daemontool | because of that very fix? | 17:05 |
Jokke_ | so needs to be bumped up for next release | 17:05 |
Jokke_ | so always after release first commit to merge is the version bump, otherwise pbr will complain | 17:06 |
Jokke_ | the version number in the HEAD is kind of indicator towards which release the development is happening | 17:06 |
*** jonaspf has quit IRC | 17:08 | |
*** jonaspf has joined #openstack-freezer | 17:10 | |
Jokke_ | daemontool: please see https://review.openstack.org/#/q/Iafe8007765190129e9f430139f0e6fffabd8b2f2,n,z ;) | 17:12 |
*** jonaspf has quit IRC | 17:26 | |
*** jonaspf has joined #openstack-freezer | 17:27 | |
daemontool | Jokke_, +2ed | 17:47 |
daemontool | now everything's clear :) | 17:49 |
Jokke_ | :) | 17:51 |
Jokke_ | good | 17:51 |
Jokke_ | back to work then all ye | 17:51 |
Jokke_ | no more excuses! | 17:52 |
Jokke_ | :P | 17:52 |
daemontool | haha | 17:53 |
daemontool | here: anyone can review https://review.openstack.org/#/c/246368/ https://review.openstack.org/#/c/246366/ | 17:56 |
*** emildi has quit IRC | 18:00 | |
*** emildi has joined #openstack-freezer | 18:00 | |
*** reldan has quit IRC | 18:01 | |
*** szaher_ has quit IRC | 18:19 | |
Jokke_ | daemontool: you wanna +A this or should I? https://review.openstack.org/#/c/246366/ the two of us are only ones who can? | 18:27 |
daemontool | I think the others can do it too | 18:29 |
Jokke_ | that's stable | 18:29 |
daemontool | I need to check | 18:30 |
*** jonaspf has quit IRC | 18:30 | |
daemontool | ah, I have to add the others too | 18:31 |
daemontool | frescof__, can also | 18:32 |
daemontool | not sure he's online | 18:33 |
memogarcia | need help?\ | 18:34 |
daemontool | memogarcia, can you give +A here? https://review.openstack.org/#/c/246366/ | 18:35 |
Jokke_ | daemontool: no do not add others yet | 18:35 |
daemontool | why? | 18:36 |
Jokke_ | need to check with ttx if freezer-stable-maint (as in independent release) needs to follow the same rules as the managed release stable teams | 18:36 |
daemontool | ok | 18:36 |
Jokke_ | only people who have been vetted by the stable-maint-core (as in them taking written record that the person has read the stable policy and is willing to follow it) should be added | 18:37 |
*** daemontool_ has quit IRC | 18:37 | |
Jokke_ | normally the *-stable-maint is owned by the stable-maint-core so that only they even can add | 18:38 |
daemontool | ok now is how it was before | 18:38 |
Jokke_ | I'll check that tomorrow when ttx is again online | 18:38 |
Jokke_ | will let you know | 18:38 |
daemontool | I'll give +A to that now as frescof__ is not online | 18:38 |
daemontool | have to go now, laterz :) | 18:39 |
daemontool | +Aed | 18:39 |
Jokke_ | CU | 18:39 |
Jokke_ | the -api one as well? | 18:39 |
Jokke_ | well doesn't really matter unless we have something urgent that needs to go in | 18:40 |
*** daemontool has quit IRC | 18:44 | |
*** reldan has joined #openstack-freezer | 19:12 | |
*** fabriziof has quit IRC | 19:40 | |
*** jonaspf has joined #openstack-freezer | 19:48 | |
*** jonaspf has quit IRC | 20:02 | |
*** jonaspf has joined #openstack-freezer | 20:03 | |
*** jonaspf has quit IRC | 20:18 | |
*** reldan has quit IRC | 20:21 | |
*** reldan has joined #openstack-freezer | 20:33 | |
*** reldan has quit IRC | 20:42 | |
*** reldan has joined #openstack-freezer | 21:04 | |
*** reldan has quit IRC | 21:13 | |
*** reldan has joined #openstack-freezer | 21:15 | |
*** reldan has quit IRC | 21:28 | |
*** memogarcia has quit IRC | 22:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!