*** daemontool has joined #openstack-freezer | 06:24 | |
daemontool | morning | 06:28 |
---|---|---|
*** kelepirci has joined #openstack-freezer | 07:06 | |
*** reldan has joined #openstack-freezer | 07:28 | |
*** reldan has quit IRC | 07:36 | |
*** reldan has joined #openstack-freezer | 08:09 | |
daemontool | reldan, ping | 08:12 |
daemontool | sorry brb | 08:12 |
reldan | daemontool: Hi dude. How are you? | 08:13 |
*** daemontool_ has joined #openstack-freezer | 08:13 | |
daemontool_ | all, so we need to set also --incremental-engine for the restore | 08:14 |
reldan | daemontool_: Hi dude. How are you? | 08:14 |
daemontool_ | all good :) | 08:14 |
daemontool_ | otherwise there's not way to know it | 08:15 |
reldan | Yes, now we need to have such parameter | 08:15 |
daemontool_ | and also | 08:15 |
reldan | You are right | 08:15 |
daemontool_ | prepend rsync or tar | 08:15 |
daemontool_ | at the beginning | 08:15 |
daemontool_ | cause otherwise the agent doesn't know | 08:15 |
daemontool_ | which one to take | 08:15 |
reldan | Yes, you are right | 08:15 |
reldan | And the same for restore | 08:15 |
daemontool_ | reldan, basically what you were saying Fri | 08:16 |
daemontool_ | :) | 08:16 |
daemontool_ | yes | 08:16 |
daemontool_ | I didn't got that when you saw it | 08:16 |
daemontool_ | but when I was doing the implementation I realized | 08:16 |
daemontool_ | slashme, ^^ | 08:16 |
reldan | You know. For restore we can actually add additional feature | 08:16 |
reldan | Like let’s call il file-based restore | 08:16 |
reldan | In this case we can scan all rsync and tar backups | 08:17 |
daemontool_ | yes | 08:17 |
reldan | Then select needed one | 08:17 |
reldan | And after that initialize incremental-engine | 08:17 |
*** daemontool has quit IRC | 08:17 | |
reldan | But let’s say for incremental backup - we should search only the same engne backups | 08:17 |
daemontool_ | yes | 08:18 |
daemontool_ | also in that way we can have reusable | 08:18 |
daemontool_ | code | 08:18 |
daemontool_ | for incrementals read from streams | 08:18 |
daemontool_ | or from file system | 08:18 |
reldan | Yes, yes should be that way | 08:19 |
daemontool_ | but let'd to things in steps | 08:19 |
daemontool_ | as the rsync for local fs is already quite complex | 08:20 |
reldan | You are right. How is your rsync engine? Still have a lot of stuff to complete? | 08:21 |
daemontool_ | https://review.openstack.org/#/c/290461/ | 08:21 |
daemontool_ | the backup is probaly 90% completed, it works | 08:21 |
daemontool_ | the restore doesn't work | 08:22 |
daemontool_ | I'm working on it | 08:22 |
daemontool_ | test it if you want | 08:22 |
daemontool_ | but I have 1 problem with the backup | 08:22 |
daemontool_ | I have to solve | 08:22 |
daemontool_ | the incremental is taken from level 0 and not from previous level | 08:22 |
reldan | Oh, interesting | 08:23 |
daemontool_ | as soon the restore is fixed | 08:24 |
daemontool_ | I'll focus on that issue | 08:25 |
daemontool_ | but if you want to review/test in the meantime | 08:25 |
daemontool_ | yw :) | 08:25 |
reldan | Thank you :) | 08:25 |
reldan | daemontool_: I had really bad weekend :) I sent my passport for re-entry visa and they lost my passport, registration card and money for issuing visa | 08:25 |
reldan | daemontool_: And russians were able to restore my passport in 3 months, I have to pay fine and fee. And then I need to get my registration card for 300 euro, then send again for re-entry visa | 08:27 |
reldan | daemontool_: But I just have received message that they found it. And now I’m very glad :) | 08:27 |
daemontool_ | ah... frack | 08:33 |
daemontool_ | ah fantastic | 08:33 |
daemontool_ | :) | 08:34 |
daemontool_ | those things are pain in the butt | 08:34 |
daemontool_ | please approve this Katarzyna Senczyna | 08:37 |
daemontool_ | ooops | 08:37 |
daemontool_ | sorry | 08:37 |
daemontool_ | https://review.openstack.org/#/c/296034/ | 08:37 |
*** ccesario has quit IRC | 08:57 | |
*** ccesario has joined #openstack-freezer | 08:57 | |
*** EinstCrazy has joined #openstack-freezer | 09:01 | |
*** reldan has quit IRC | 09:09 | |
*** reldan has joined #openstack-freezer | 09:18 | |
openstackgerrit | Saad Zaher proposed openstack/freezer-api: Switch Freezer-api to oslo.config and oslo.log https://review.openstack.org/295220 | 09:43 |
*** vannif has quit IRC | 09:47 | |
slashme | reldan: very good news :) :) | 09:48 |
reldan | slashme: Yes, but last Friday they just said me, we cannot find your envelope, so we can give you a letter that we lost it. And it is all. | 09:48 |
reldan | I regret to inform you that I have had an intensive search carried out for | 09:49 |
reldan | your passport and unfortunately we were unable to locate it. Could you | 09:49 |
reldan | ring me at the telephone number below to make arrangements for the issue of | 09:49 |
reldan | a new passport. We can provide a letter stating it was lost in the | 09:49 |
reldan | Department and refund the fee for the passport. | 09:49 |
daemontool_ | bad week end :) | 09:50 |
slashme | https://review.openstack.org/#/c/299567/ This is waiting for a +A ;0 | 10:00 |
*** vannif has joined #openstack-freezer | 10:00 | |
slashme | ;) | 10:00 |
slashme | daemontool_: If you have any insight on why this one fails: https://review.openstack.org/#/c/298895/ I think it would be good to fix Kilo even if it'll be deprecated soon. This was a pretty bas bug. | 10:01 |
daemontool_ | slashme, yes, give me 30 mins | 10:02 |
reldan | slashme: please check https://review.openstack.org/#/c/300075/ The stupid glance client has no public methods to create a client from username and password. So I have to use private methods, and these methods tend to change with minor version change | 10:04 |
slashme | i'm testing this atm | 10:04 |
slashme | well as soon as my envmt is up | 10:05 |
reldan | slashme Thank you! | 10:06 |
szaher | all: let's merge this please https://review.openstack.org/#/c/295220/ | 10:13 |
daemontool_ | szaher, are the comments from vannif addressed for https://review.openstack.org/#/c/295220/ ? | 10:14 |
szaher | daemontool_: Yes | 10:22 |
jokke_ | reldan: so is there _any_ excuse to not get that token from keystone before using the glanceclient? | 10:25 |
reldan | jokke_: Example on their site dosn’t work. All clients except glance allows to create client without token. Glance allows to but in private methods. | 10:28 |
jokke_ | reldan: you're hacking to use gc internal functions from the shell, to get it do that token fetch for you which is otterly stupid approach for the same resons you mentioned yourself (they tend to change) | 10:29 |
reldan | jokke_: Yes, I just don’t understand why I should write already written code | 10:29 |
jokke_ | reldan: again, is there any excuse not to do it right? | 10:29 |
reldan | Yes, don’t write already written code | 10:30 |
jokke_ | reldan: so why do you then get the new token for every client you create on that block of code instead of pulling the token once and creating all clients with that? | 10:32 |
jokke_ | when the clients needs that token anyways | 10:32 |
reldan | Probably, you are right. What I need, I need a function that gets my credentials and able to produce as many clients as I want | 10:34 |
reldan | Do you know, do OpenStack clients have such factory? | 10:35 |
jokke_ | reldan: the clients have been moving towards keystone sessions to make that management reasonable | 10:36 |
jokke_ | so if you create session in that client manager (and refresh it if needed) you can pass that keystone session to the clients and avoid every client calling to keystone and creating new one for the same user | 10:37 |
slashme | That'd be nice | 10:38 |
jokke_ | http://docs.openstack.org/developer/python-keystoneclient/using-sessions.html | 10:38 |
reldan | Probably you are right, but cinderclient offers me create client by password http://docs.openstack.org/developer/python-cinderclient/ | 10:40 |
reldan | in client they have proxy_token=None, | 10:40 |
reldan | what the hell is proxy_token | 10:40 |
reldan | For glance I need OS_IMAGE_ENDPOINT. http://docs.openstack.org/developer/python-glanceclient/ | 10:43 |
reldan | And probably yes, it is better to have one token and login everywhere. But clients written in a very poor style, each client requires different arguments, they don’t share a common architecture | 10:43 |
jokke_ | reldan: in cinderclient _construct_http_client takes session parameter, but so far I have not found how to pass session to it when crating the client, which is shait | 10:46 |
jokke_ | reldan: moving ot the keystone session object is exactly for that (see my link above) | 10:47 |
jokke_ | reldan: sad but not surprised that it doesn't seem to be merged in cinderclient yet | 10:47 |
*** openstackgerrit has quit IRC | 10:48 | |
*** openstackgerrit has joined #openstack-freezer | 10:48 | |
reldan | jokke_: So yes, you are 100% right. Probably I should rewrite everything to session. But I suppose it is common problem, everyont who uses more than one client need this part of code | 10:49 |
jokke_ | reldan: yes, that's why it's supposed to be done wiith keystoneclient rather than individual clients :P | 10:49 |
openstackgerrit | Merged openstack/freezer-api: Switch Freezer-api to oslo.config and oslo.log https://review.openstack.org/295220 | 10:50 |
jokke_ | uuuh already ^^ :P | 10:51 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix bug with incremental cinderbackup https://review.openstack.org/301031 | 10:53 |
reldan | jokke_: Ok, let’s me try to use sessions instead | 10:54 |
reldan | jokke_: session.Session(auth=auth) is deprecated now | 10:55 |
jokke_ | humm-m what did I miss | 10:56 |
reldan | 'keystoneclient.session.Session is deprecated as of the 2.1.0 ' | 10:57 |
reldan | 'release in favor of keystoneauth1.session.Session. It will be ' | 10:57 |
reldan | 'removed in future releases.', | 10:57 |
*** reldan has quit IRC | 11:02 | |
jokke_ | http://docs.openstack.org/developer/keystoneauth/using-sessions.html | 11:03 |
jokke_ | seems that they are splitting the lib | 11:03 |
openstackgerrit | Merged openstack/freezer: Adding the freezer logo to the README https://review.openstack.org/299567 | 11:09 |
jokke_ | there is some refactoring done, but the session looks pretty much the same | 11:09 |
*** kelepirci_ has joined #openstack-freezer | 11:10 | |
*** kelepirci has quit IRC | 11:13 | |
*** reldan has joined #openstack-freezer | 11:14 | |
openstackgerrit | Saad Zaher proposed openstack/freezer-api: Adding storage, keystone_authtoken sections to sample config https://review.openstack.org/301053 | 11:20 |
*** frescof has joined #openstack-freezer | 11:29 | |
reldan | jokke_: Just too much to copy-paste from cinderclient | 11:41 |
reldan | it is easier to specify exact version in settings | 11:41 |
openstackgerrit | Saad Zaher proposed openstack/freezer-api: Adding storage, keystone_authtoken sections to sample config https://review.openstack.org/301053 | 11:44 |
*** EinstCrazy has quit IRC | 11:50 | |
openstackgerrit | Saad Zaher proposed openstack/freezer-api: Adding storage, keystone_authtoken sections to sample config https://review.openstack.org/301053 | 12:41 |
*** kelepirci_ has quit IRC | 13:05 | |
*** kelepirci has joined #openstack-freezer | 13:06 | |
kelepirci | hi all | 13:07 |
kelepirci | I am getting following error from jenkins: | 13:07 |
kelepirci | Patch in Merge Conflict | 13:07 |
slashme | Hi kelepirci | 13:07 |
slashme | Witch change ? | 13:07 |
kelepirci | this one: https://review.openstack.org/#/c/296448/ | 13:08 |
* slashme is taking a look | 13:10 | |
openstackgerrit | Pierre Mathieu proposed openstack/freezer: New Better & Well Formatted Docs with Sphinx https://review.openstack.org/296448 | 13:15 |
slashme | It was conflicting with last patch we did on the README (adding the logo). I uploaded a new patchset. It should be okay now. | 13:16 |
slashme | There is two ways of dealing with merge conflict: | 13:16 |
slashme | 1: - from your change : git fetch --all and git rebase master | 13:20 |
slashme | 2: git checkout master and git cherry-pick <your change> | 13:20 |
slashme | In both case, you need to fix the merge-failure manualy (you can use git status to know where it is) and the finish with git add <file you fixed> and either git rebase --continue (if 1) or git cherry-pick --continue (if 2) and finaly git review | 13:20 |
slashme | 13:20 | |
slashme | Hope that helps | 13:20 |
kelepirci | thx slashme it was very helpfull | 13:28 |
kelepirci | so we have a freezer logo | 13:29 |
kelepirci | I was planning to make one | 13:29 |
kelepirci | the logo is nive | 13:30 |
kelepirci | nice | 13:30 |
slashme | Glad you like it | 13:32 |
szaher | https://review.openstack.org/#/c/301053/ plz merge this one to finalize the oslo stuff | 13:40 |
*** ddieterly has joined #openstack-freezer | 13:41 | |
*** ddieterly has quit IRC | 13:42 | |
*** ddieterly has joined #openstack-freezer | 13:45 | |
*** ddieterly has quit IRC | 13:46 | |
*** ddieterly has joined #openstack-freezer | 13:46 | |
*** ddieterly is now known as ddieterly[away] | 13:54 | |
*** ddieterly[away] is now known as ddieterly | 13:57 | |
*** ddieterly is now known as ddieterly[away] | 14:03 | |
*** ddieterly[away] is now known as ddieterly | 14:11 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer-api: Add Freezer API Tempest Tests https://review.openstack.org/297360 | 14:24 |
*** EinstCrazy has joined #openstack-freezer | 14:28 | |
*** ddieterly is now known as ddieterly[away] | 15:10 | |
*** EinstCrazy has quit IRC | 15:10 | |
*** dschroeder has joined #openstack-freezer | 15:13 | |
*** ddieterly[away] is now known as ddieterly | 15:13 | |
*** ddieterly is now known as ddieterly[away] | 15:26 | |
*** ddieterly[away] is now known as ddieterly | 15:28 | |
*** ddieterly is now known as ddieterly[away] | 15:31 | |
*** ddieterly[away] is now known as ddieterly | 15:51 | |
*** ddieterly is now known as ddieterly[away] | 16:05 | |
*** ddieterly[away] is now known as ddieterly | 16:07 | |
*** ddieterly is now known as ddieterly[away] | 16:08 | |
*** ddieterly[away] is now known as ddieterly | 16:08 | |
*** reldan has quit IRC | 16:10 | |
openstackgerrit | Saad Zaher proposed openstack/freezer-api: Adding storage, keystone_authtoken sections to sample config https://review.openstack.org/301053 | 16:18 |
openstackgerrit | Deklan Dieterly proposed openstack/freezer-api: Add Freezer API Tempest Tests https://review.openstack.org/297360 | 16:43 |
*** reldan has joined #openstack-freezer | 16:43 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer-api: Add Freezer API Tempest Tests https://review.openstack.org/297360 | 16:46 |
*** ddieterly is now known as ddieterly[away] | 16:47 | |
*** ddieterly[away] is now known as ddieterly | 16:52 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer-api: Add Freezer API Tempest Tests https://review.openstack.org/297360 | 16:58 |
ddieterly | szaher here are the instructions for developing tempest tests | 17:00 |
ddieterly | https://review.openstack.org/#/c/297360/20/freezer_api/tests/freezer_api_tempest_plugin/README.rst | 17:00 |
ddieterly | you can use those same instructions for running the tests with freezer | 17:01 |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Add Tempest Tests https://review.openstack.org/301250 | 17:10 |
*** ddieterly is now known as ddieterly[away] | 17:17 | |
*** reldan has quit IRC | 17:23 | |
*** dschroeder has left #openstack-freezer | 17:33 | |
*** reldan has joined #openstack-freezer | 17:40 | |
openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fixing Freezer-Agent help https://review.openstack.org/301259 | 17:42 |
*** dschroeder has joined #openstack-freezer | 18:03 | |
*** ddieterly[away] is now known as ddieterly | 18:08 | |
*** daemontool_ has quit IRC | 18:20 | |
*** ddieterly is now known as ddieterly[away] | 18:35 | |
*** ddieterly[away] is now known as ddieterly | 18:56 | |
*** ddieterly is now known as ddieterly[away] | 20:30 | |
*** ddieterly[away] is now known as ddieterly | 20:35 | |
*** daemontool has joined #openstack-freezer | 21:13 | |
ddieterly | szaher this commit broke the README file | 21:16 |
ddieterly | 5fa735409f8c37e80dd546542546ba4fb90de70c | 21:16 |
ddieterly | --file-to-backup is no longer an accepted argument, but the documentation says it is | 21:16 |
*** ddieterly is now known as ddieterly[away] | 21:28 | |
*** ddieterly[away] is now known as ddieterly | 21:30 | |
*** daemontool has quit IRC | 21:45 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Add Tempest Tests https://review.openstack.org/301250 | 22:34 |
*** ddieterly is now known as ddieterly[away] | 22:35 | |
*** ddieterly[away] is now known as ddieterly | 22:59 | |
*** ddieterly has quit IRC | 23:00 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/freezer-api: Updated from global requirements https://review.openstack.org/288699 | 23:16 |
*** dschroeder has quit IRC | 23:18 | |
*** ddieterly has joined #openstack-freezer | 23:33 | |
*** ddieterly is now known as ddieterly[away] | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!